[PATCH v4 0/7] iio: light: vcnl4000: add regulator support

Erikas Bitovtas posted 7 patches 3 weeks ago
There is a newer version of this series
.../bindings/iio/light/vishay,vcnl4000.yaml        |  7 ++
drivers/iio/light/vcnl4000.c                       | 90 ++++++++++++----------
2 files changed, 56 insertions(+), 41 deletions(-)
[PATCH v4 0/7] iio: light: vcnl4000: add regulator support
Posted by Erikas Bitovtas 3 weeks ago
This patch series introduces support for voltage supply, I2C and cathode
regulators. This fixes an issue where if a regulator is shared between
the proximity sensor and some other device, and the other device is
powered off, the proximity sensor would be powered off as well.

One of the commits includes a Reported-by: tag without a Closes: tag -
the report was done outside of LKML.

Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
Changes in v4:
- Reworded device tree bindings commit into imperative mood and
  clarified where do supplies come from.
- Moved data->chip_spec->set_power_state() calls from init functions to
  probe.
- Removed explicit less than 0 checks for ret where unnecessary.
- Moved the patch that adds regulators to the end of the series.
- Added an explanation for removing duplicate prints in probe.
- Fixed indentation for devm_regulator_bulk_get_enable() and i2c_smbus
  writes in vcnl4200_init().
- Removed a redundant check for "proximity-near-level" device property.
- Link to v3: https://lore.kernel.org/r/20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com

Changes in v3:
- Added a more detailed description for supplies in the dt-bindings commit.
- Separated sorting includes into a commit of its own.
- Replaced all occurrences of mutex_init with its device-managed
  counterpart.
- Moved client->dev variable declaration into a commit for adding
  regulators.
- Removed redundant dev_err messages in probe function.
- Replaced all direct usages of client->dev and data->client into usages
  by variable.
- Link to v2: https://lore.kernel.org/r/20260312-vcnl4000-regulators-v2-0-2bdebbcbb58a@gmail.com

Changes in v2:
- Removed double quotes in includes.
- Reordered includes alphabetically.
- Enabled regulators before the mutex is initialized.
- Replaced direct usage of &client->dev with a variable.
- Link to v1: https://lore.kernel.org/r/20260311-vcnl4000-regulators-v1-0-66b6038ce563@gmail.com

---
Erikas Bitovtas (7):
      dt-bindings: iio: light: vcnl4000: add regulators
      iio: light: vcnl4000: sort includes by their name
      iio: light: vcnl4000: move power enablement from init to probe
      iio: light: vcnl4000: replace mutex_init with devm_mutex_init
      iio: light: vcnl4000: remove error messages for trigger and irq
      iio: light: vcnl4000: use variables for I2C client and device instances
      iio: light: vcnl4000: add support for regulators

 .../bindings/iio/light/vishay,vcnl4000.yaml        |  7 ++
 drivers/iio/light/vcnl4000.c                       | 90 ++++++++++++----------
 2 files changed, 56 insertions(+), 41 deletions(-)
---
base-commit: 6e03baeeb160e6cfd72f2c39f26c50bcd925c7a0
change-id: 20260310-vcnl4000-regulators-bcf1b8a01ce6

Best regards,
-- 
Erikas Bitovtas <xerikasxx@gmail.com>
Re: [PATCH v4 0/7] iio: light: vcnl4000: add regulator support
Posted by Andy Shevchenko 3 weeks ago
On Mon, Mar 16, 2026 at 07:19:44PM +0200, Erikas Bitovtas wrote:
> This patch series introduces support for voltage supply, I2C and cathode
> regulators. This fixes an issue where if a regulator is shared between
> the proximity sensor and some other device, and the other device is
> powered off, the proximity sensor would be powered off as well.
> 
> One of the commits includes a Reported-by: tag without a Closes: tag -
> the report was done outside of LKML.

You mean outside of public web access?


-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v4 0/7] iio: light: vcnl4000: add regulator support
Posted by Erikas Bitovtas 3 weeks ago

On 3/16/26 9:59 PM, Andy Shevchenko wrote:
> On Mon, Mar 16, 2026 at 07:19:44PM +0200, Erikas Bitovtas wrote:
>> This patch series introduces support for voltage supply, I2C and cathode
>> regulators. This fixes an issue where if a regulator is shared between
>> the proximity sensor and some other device, and the other device is
>> powered off, the proximity sensor would be powered off as well.
>>
>> One of the commits includes a Reported-by: tag without a Closes: tag -
>> the report was done outside of LKML.
> 
> You mean outside of public web access?
> 

The report was done in a Matrix channel. I could provide the link to the
report for the Closes: tag, but it requires to sign-in to view it.
Re: [PATCH v4 0/7] iio: light: vcnl4000: add regulator support
Posted by Andy Shevchenko 3 weeks ago
On Mon, Mar 16, 2026 at 10:20:54PM +0200, Erikas Bitovtas wrote:
> On 3/16/26 9:59 PM, Andy Shevchenko wrote:
> > On Mon, Mar 16, 2026 at 07:19:44PM +0200, Erikas Bitovtas wrote:

...

> >> One of the commits includes a Reported-by: tag without a Closes: tag -
> >> the report was done outside of LKML.
> > 
> > You mean outside of public web access?
> 
> The report was done in a Matrix channel. I could provide the link to the
> report for the Closes: tag, but it requires to sign-in to view it.

Okay, thanks for elaboration. In case of a new version, please mention this
in the cover letter.

-- 
With Best Regards,
Andy Shevchenko