From nobody Tue Apr 7 02:35:30 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 976643CFF5F for ; Mon, 16 Mar 2026 17:19:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681593; cv=none; b=sZFnIMsoCwxbeu0v5PPtPiL2fU8EJAQQMsgdvqQ1KPTbVHHl1wwb8iXFl5NZUX6VQ4+4EqMz4J+peSHRmNjj9s/nsxUPUB2mI3GMPThxT1uj7c76q7okYLCwKFKBXzhccHpqgPBMq5wMGpa7jnEcsVYilCXY0I83dA6f/EcTb64= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681593; c=relaxed/simple; bh=CZ1jj/eiHUYjGjlvolJhpPQIMl/aN3JFj+jg+nCFVEA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=clOPi6+XTLgz+tluu4OmYc9/gyac+71egllW32bVRS/LKgyk2MfD/usFUOmStX70RGhjGs4CbgL0jOHNQi7TDAJBqb4jLZDbWZoEDO26Llt4sRs9NH7Frk4cc8q/8Qp6RS3oa/0fdt5h8ZjlPgEkXgajq74GZpsXRj/opCG8OdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z5QHY4EM; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z5QHY4EM" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b7cf4a975d2so642663866b.2 for ; Mon, 16 Mar 2026 10:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773681591; x=1774286391; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hrOVP7ftGVSwzsjwgJO9DIOtGTWA2U/htQxTfqCFeYU=; b=Z5QHY4EMw7pa4wLUPbEWBfKlCivNMR+CiRr4ZckwZ53Atfavbyan9qta8SUB99FSTq ORO4a1HiTFiWQKaptg0di8cKeTODsWTTQ28tHa/Nk0pXdznLByXb6UbBw5X78MVINb4S izwnl667pGlIYfnNlEscJMs8oY33uUzH3oDdFCWiXLWcACEUKP7/yebPwyVKbPXIs57e jUauZxsE9EddMUBbSuECgQEu/eEhRMO1qUIFEsGWRXOoQmVROorNGgdvk8f6/QrZckyE IyO0Kv3aRmQhIoN59SlXHjeRHWenX1fRAXNucp4F4g0Pe3CyWXa4Ak3pIKwA1LyXe7Hd xonA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773681591; x=1774286391; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hrOVP7ftGVSwzsjwgJO9DIOtGTWA2U/htQxTfqCFeYU=; b=FNbChr5PvU7PzNMxBERvuqaW9EemaADzqGJg2OyRnlBMhtlcXF3Y68yUZsW59gdZoW 8kTo7KrRDN4kF/F7grV/RVyVmAjQY8SUt84Oy9kLRbpEa0rV/VU74pKbf2oDCH5rDU22 2iOjgEInkX/PYqtaF9kztlIXUSdoXYU/JiVGuUQ91wt6qgZeN3c8yjYchOng3rQz4qf+ am5Jsk/qv5x6Txxgg5oMTWIoOLcxPm6eB/kgkaPvKQJkUhrfLmM3LSRe0qVguWwQmsmb wrflSf2pK++ML8yi8EXqN6ohewK3JP6BP6s3STGqPZC9B/OBdUj18yx9/71xE/PTsOCG zjzg== X-Forwarded-Encrypted: i=1; AJvYcCW0WkuurtmSnohYXpzjhg+a2PEP8mMA2jiftEKKNYdMvP5K0yHU7qnUcPiLceKpBxj37IZ9285+zf4ERRc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywe44mZjh47v3PzwS771ljylSljjdfS2YFfOBBTh0YHWfKFwD4d NqkDJPw/NjpIssld/XGavAiVyo/R+UxJ8q3Akj7Js40gFSvEOjH4hEwA X-Gm-Gg: ATEYQzxQolh/DD9K/7EEHJzEIgVWphjEAo20nVBVT3r+ekOpGC3y/E8KOUSO2QNvcc0 xyQdi+mNpJYai9Erc/YUDNpE8Fd9lChYfHf1xrb2//bwYX0B/5GnlujofXzM1zWICz4tTe/O0zI jRc/n/i534KAnRCdoK8Qh5KBa0Gc8nnkd7NQOZzwMQ6m6PhlZd5JbAKi9N1UiAr++NPUrVV8olS Q+VJGjQV4V5YlR8uJPcOJKqQ9cLQrRFKlodJNJnQ3S+t8TAIw717Vt59TfX0yXjwtRvaudbp8RM IDOpQfL1HSP3PPvvfWxzW4/TqvarRPEUj8j7/Mb8hYYmmnW2dQLV+RA0CZK00sPTFgr3bEgsY0f l7wUcNPUjBk4qlXfU68D1BhjQW7n3yBZPYuxpcFwtpQcVl2gNuwERUjt4xAo7M+XBGZRS0BMsLD luRquHGZOu6g90QtfVm61q0+2q1w== X-Received: by 2002:a17:906:7953:b0:b97:73ae:e1f with SMTP id a640c23a62f3a-b9773ae1114mr769934166b.34.1773681590773; Mon, 16 Mar 2026 10:19:50 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97846174cfsm505940266b.22.2026.03.16.10.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 10:19:50 -0700 (PDT) From: Erikas Bitovtas Date: Mon, 16 Mar 2026 19:19:45 +0200 Subject: [PATCH v4 1/7] dt-bindings: iio: light: vcnl4000: add regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-vcnl4000-regulators-v4-1-854fc2eaf54b@gmail.com> References: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> In-Reply-To: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 These sensors can accept 2 supplies - one for the sensor and one for IR LED [1]. Add supply properties for the sensor - 2 for the sensors and one external, for their I2C bus, to ensure the sensor is powered on before proceeding with setup. [1] https://www.vishay.com/docs/84274/vcnl4040.pdf Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++= ++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.ya= ml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml index 2ba4d5de4ec4..a1b4c02db246 100644 --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml @@ -33,6 +33,10 @@ properties: interrupts: maxItems: 1 =20 + vdd-supply: true + vddio-supply: true + vled-supply: true + reg: maxItems: 1 =20 @@ -54,6 +58,9 @@ examples: compatible =3D "vishay,vcnl4200"; reg =3D <0x51>; proximity-near-level =3D <220>; + vdd-supply =3D <®_vdd>; + vddio-supply =3D <®_vddio>; + vled-supply =3D <®_vled>; }; }; ... --=20 2.53.0 From nobody Tue Apr 7 02:35:30 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FDBC3CF69D for ; Mon, 16 Mar 2026 17:19:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681595; cv=none; b=CXnnORpYU05+YFn76lykHHkACt4lBDZyKS+xDq1nkhjUGyv8/GHvmQMA6Rfv8mUoUbhTwf/8wqz1oFE1Q7xL6RjZygL683ADXL16Pm9Uz1fjUaCCTXuWXHYlHDhXkV4pfaNcYRTSgyMi38w2J/Yk61w4NW3w836OtGGtYRIJD3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681595; c=relaxed/simple; bh=FyYL7KjhfBkhq4Z8eKOH65vilPS2pr7+rN80jiOzQpc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=F/twbpgwzv2i8QxBJM1b/0gB2omFRXIWIz4BU816Yy6g2DiV0GgNuL1OGaX9RNdgAUZ07NDlmWYwZrfY05t6ZUQU2o2NOezq660iZ6XFG3BNIZtdNnLteW8x2xB3dffSXFrmMO/zwvrimbiF/6QW01d/d+6z1d5g+YFkXtmwbMA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N4NhUkx5; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N4NhUkx5" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b979d16dd0cso309173466b.1 for ; Mon, 16 Mar 2026 10:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773681593; x=1774286393; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AGTiQESNTxF+kqg9mPQcr06UPYRyUnWm55j6lAp7RWY=; b=N4NhUkx5yXG1WNgC3quqRNlR4pOqVEOUR6t8Il2JDWvlcGTLYM7CLixNyI8Mnwrl9Z mX/NyoniGiquWWQNCFwgbx4Ly21QuGOEQezjG2b5H1CUm3jMJeeVYxvGzLj78LOC75cZ JSIoF/ppNljUvPY82OOyvk5Uof1QCUD+JbDkP9OqIUemhx4TEa7d954jfmJtq15DuugJ ELnuSMIsBSWxp4OwADccnLXbKBnj+qCfFaStgJRTFK13npZid0HQ3VrwERqTKNxkYCBr 3KSbWHBBR7vKFPLyCOTwlXCZa/EPPsdJfm18rvzUhBJ8SxQ/znsdzPyE/gSHUlyzqbK/ QtIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773681593; x=1774286393; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=AGTiQESNTxF+kqg9mPQcr06UPYRyUnWm55j6lAp7RWY=; b=APnt6P1OPkhSiJBfN5J/7lJTkab6pJamJNLho6u6KWwT5xURrZOn+2gYpANayjhIU9 DR6B4XV9IR/mrMspT76uXnB0RcZ/Ibmk92PS2pdf9XiJHgfx1R1Gl/YiC/SskzmP4E2/ fkPr/aFxs9cTcMeGSug5AXse5XpV2CVrhbuJ34EizVsyKJPfa8xISMv15M74cIXxVEso xf2XaRny7snfJ7MYGdt6XXJ0uTxu/1mU3gvqbZlHPoRPwtkrx7GL0GchxR4Fa/yAfLOl wLgWIh7zaxUqJikd9aeJMJJFehZt9tcKVXbYIUL0GyPnDkoe1IYtjZSrhFKTBE0vovNr NHng== X-Forwarded-Encrypted: i=1; AJvYcCWjKcMoKEVAWcBpuUOsUQ/4kdJAF9/LJSZPfOubPQrq88M8z9owh/5doB0DZo+6KIBDMR93kPatlELiUSw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4t4M23r7CT3BDoulAQiJgTU58XRu1PQ/cEXEnrOeFXtB42RIz ebeo429INRMzNvCkOAj7DKypkS5+oeRecjgZEQYrlfxqGSDSxsp21Mc3 X-Gm-Gg: ATEYQzyETgJdljp0KRpalf9/3ZvGFlN2zxX1eA4JToU+0OCT6LruxqQlPlhA+4l9WgO SELvmMu+utIbah5/MIyYFAXKNbHYfl+1ZEm/ROyBrf6qPTGFi2XLu6sUptEQhNk9/9MXIsLvMbk z4Dtqp5bhy0CdC0HgENrfHR6AiOHbsIpMu8fQhPnEAngQjrfC0jwTgyygSU/c0+l/zTvIRFmKCK FSexg9KvWXHp8/t1X2+Bc8B8o+EBbhzOFhlLZ0Bz0SW2WFCfPNHaEsg8K3wxzYQAlsN1hFWnmtw g7/IFMsa/3ZAG4TQ+gRj4tWOtHmltAXsXb434xQ2N38fSRxFQSAzwBaOU6INYUgfTPBhtEWkYzp RRxN0j1hpHXaXXF7ECxXt6+zP4cHHuDRffquBH1E2IWVIOYmnA3FEVEQguCta80fNqgmQcJLMoX i4QIPsmwrNj+H/ydGlStxE8q4PYA== X-Received: by 2002:a17:907:e2d2:b0:b94:c55:81d2 with SMTP id a640c23a62f3a-b9764f4bdf8mr721875566b.1.1773681592603; Mon, 16 Mar 2026 10:19:52 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97846174cfsm505940266b.22.2026.03.16.10.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 10:19:51 -0700 (PDT) From: Erikas Bitovtas Date: Mon, 16 Mar 2026 19:19:46 +0200 Subject: [PATCH v4 2/7] iio: light: vcnl4000: sort includes by their name Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-vcnl4000-regulators-v4-2-854fc2eaf54b@gmail.com> References: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> In-Reply-To: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Sort include headers by file name for better readability. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 5e03c3d8874b..939ff2d65105 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -18,12 +18,12 @@ */ =20 #include -#include -#include -#include #include -#include +#include +#include #include +#include +#include #include =20 #include --=20 2.53.0 From nobody Tue Apr 7 02:35:30 2026 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C53C83D1CB6 for ; Mon, 16 Mar 2026 17:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681597; cv=none; b=lU2VNP6CIZtBmf80HrpZR6yGnn6XzxVi9MjOPd+rArztkaepF1UxqH1zzFunjB+yC1Hw9PIyQ2qH/lxAxQLBGwrKDjw/LiicLIFXiMgopUyzTsH1kjDse9V6mtBncksK8mqZlVjcxPRncOSN4ZC1JvvAJD+IBg/LGPfZLmV3l8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681597; c=relaxed/simple; bh=fwyYVczkGGhNbbtuDw6wb0iPQK79Hav8hEBxFnyoihs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HWj1WWvzlNZWWSPBNqb1WgLaH9fMYh4sEBJ4OpNLRVYFD0aSv3L0ImKux8DR/cHCNrEMClEoOnecxti/1uOFSLmjuQxinyLBjfdzn52qvFYNaokOnbG9BDfmF1HYliS2ElPZOQKQ+xuoMgStP4do8+ZK3BxAk35fGJsFaVPeR9A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l4jO7IqV; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l4jO7IqV" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b97a0f18a3aso258762166b.1 for ; Mon, 16 Mar 2026 10:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773681594; x=1774286394; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l5lDxPgHMLUWf4KOAgcF/BaGDb9kL4QT6S8GOy/ie+w=; b=l4jO7IqVxgcgLUJJZSXH+fqmT1n1VQSP3xwRcXDBMj0sVhNGdUL6jHWoaUjETIDdaM uGQzxXGnitAcjqy71ublk7gqpi+vbU0KEYBKxcYRD7qkhdcX6MQ1kdqHRsJQLhRLL4Nt Ulo2YYNjFnxDkEcR+BNVnEhQZrhQLpURiaDuITnb4OgDi1/8V0miq814s013JPr3NHPE xlFYb0RpcFbOWyt9lVwfnvkC5pl3lXsAQ+mMlAP9yN7jcQuPaOhxeY55dRwMLNYa1g1b 43pzma+5Wz7FwVVSITsXn2eHqb9Tx/0Vt440c2sHQ7f9AwfASz7Nh7RKLiNv/WGjgsdW IIAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773681594; x=1774286394; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=l5lDxPgHMLUWf4KOAgcF/BaGDb9kL4QT6S8GOy/ie+w=; b=OUL7Xl8z+wcwkaA12FC825LWtPezQzYdbFgUHv2kSlnmvttv3kCmlK4fOO7Tn7UCJK EKlPiJC+B0y7US8BTPTkBJxbvdv8jt20lKa8jQ5eZLAFQSemcqM6Rb//Gso1ftP5yNdi k/DmtPnBzSv3C9RqXuFHzWPF+cy0ZE4OThm1rpXhCQTOOURqmsGGrxcKWqGTOfStIG0+ gjTcrLDq0etGxt+RMlkWN43MmnqfgeSVhgXGIUiZwehI2YRQMud4O6wSOvjsj03huOxg uGvHj3ocgmb8K+TmxBGEUwlnuEx75GLOHftExrYutd9bFjOkAU9PcbEgyq409nBVtuxA wjpA== X-Forwarded-Encrypted: i=1; AJvYcCXCfLQu4ywpBVR+xIWARHvBGqibg/nuxN2R/Bj8L1fEdZcPESZXP0W0XM0vXtiDh8E3xraK02DjdLY1oN4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw09NcCXRl+t5mpJEKm0wK2jyPHkPepCJnjmO785icLH5tYnuWE 47r1oZfz8GgOpPi8iMwzMByIVVMY+8L3yqVb7/oTNNC4Rdb04oSdbee0 X-Gm-Gg: ATEYQzx4DMJN93j0LbfZ4uGc4+Q5gggA3oGEaiHbYHoAn/AGMwMABtBqkgqDsysgrJA vGxhDS733aNaoXz8jpeQQonQNdIchOIzj05puLIHwyH+6Gf937hcNJnLxhenWjacV3Q2en3fj4c XFVbW1hIMlbyq+15Gm43Nvbk51Lk6zbiMNqGO1QWMa+r/KkGh2DjC2X+l1Ea7iMlD8+DsQN8lPC IclpW2rcZaizpiJFy3N7kQrDKM0DRrGZDLoyGJbdFAXQlqwDa6suOydv0nnWV/1JS3mBiXwElJc zt1xt6b7qMA9rHEZ16uTQHy9C2Z+TRhziPfV8Q86ivPOKGDV6/idzPDeLnY1AgTz0c4OnZZy71L ZtWRndVjHxiC4flcGAymYyKVVFuQ+vXV0OmHy/hqxGtrhvpneUF5tdhdNh0+Msnxb1IcZd+1iiA w7mShKr5fT3v7a4PwfSG52KBWYsQ== X-Received: by 2002:a17:906:3396:b0:b97:464:956e with SMTP id a640c23a62f3a-b97651d0b0cmr575179866b.34.1773681594087; Mon, 16 Mar 2026 10:19:54 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97846174cfsm505940266b.22.2026.03.16.10.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 10:19:53 -0700 (PDT) From: Erikas Bitovtas Date: Mon, 16 Mar 2026 19:19:47 +0200 Subject: [PATCH v4 3/7] iio: light: vcnl4000: move power enablement from init to probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-vcnl4000-regulators-v4-3-854fc2eaf54b@gmail.com> References: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> In-Reply-To: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Given both vcnl4000_init and vcnl4200_init end with dev->chip_spec->set_power_state(), they can be called once from the probe to enable the sensors. Move the set_power_state function from init and call it after init function in probe. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 939ff2d65105..287ccd89cfb2 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -280,7 +280,7 @@ static int vcnl4000_init(struct vcnl4000_data *data) data->rev =3D ret & 0xf; data->al_scale =3D 250000; =20 - return data->chip_spec->set_power_state(data, true); + return 0; }; =20 static ssize_t vcnl4000_write_als_enable(struct vcnl4000_data *data, bool = en) @@ -425,10 +425,6 @@ static int vcnl4200_init(struct vcnl4000_data *data) if (ret < 0) return ret; =20 - ret =3D data->chip_spec->set_power_state(data, true); - if (ret < 0) - return ret; - return 0; }; =20 @@ -2003,6 +1999,10 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) return ret; =20 + ret =3D data->chip_spec->set_power_state(data, true); + if (ret) + return ret; + dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 --=20 2.53.0 From nobody Tue Apr 7 02:35:30 2026 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 238A63D333D for ; Mon, 16 Mar 2026 17:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681598; cv=none; b=h5KeqbuCtaaWbaxbFjZAIG0BJG+QfbbHKqS7HKJjRkXw/Mf+0ATMnpbRqhFKEqFJlC+sCriAx2KhgyQW89pxMRxzfi8YT306p2rcEddQCaMZil67lC5iQT9SBN3Mt78j3JiNrovtB9p5g/+f3B+Ji8cSF3QAYeG6QlzGeLn5GNE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681598; c=relaxed/simple; bh=vP7EEpgruq7jb0BDTrxCYCk5LMVt/Xx+6zryX3dg/1Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Csy8JQ10z1oVMS/DNDK5HFL9p3gLJIpigf2oq2leL/P4V0iFqROtV4mRu61ROcdRdZoynJjeZ4V/HRGqVAAlZiT/jEOB67H9Ztpu8QfjUZg2rKTpk5xGzGk0xx22CVGar/DWZn+FZfMHK9mVdbmozkhDqKk5jb5q6tidWthNm24= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SJDnGJXf; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SJDnGJXf" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-6618bc129acso6240667a12.2 for ; Mon, 16 Mar 2026 10:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773681595; x=1774286395; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kmQLMk8d0z4Tj8kbX0Ny9TubbIjksPecuXhm9eaS99k=; b=SJDnGJXfzi8qRYKf3vDwMKvlWKwA8HNL5i9G0uWBdeV1d5SNo2/8qOSQtJYLC4hBdN lEJ76yq3fG0+5Y1WmS4Q0IaS7j7kcWT8yG7KmnRQZClgbhcMSjC+9duNGUPCnheol9hf 3map584Pa1QTQIY8kvBfsyRhCM/9EzCvmho7GRzNVs3oNPAQrWLY17vggqsUc/H5gssh rKEMg8M1gHzWHKvKYRvKiGz8wFX0gVYiL1XYqsDzLEoou64H2L0anIh3DzIRjq/x3hzT w6QjrR32Xm7DH0uZ1Yyrf9KQyenlwPs/Hw9WNx+QWUUdirJkHKaMDYAbS35hP3Lpm9i/ Oxvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773681595; x=1774286395; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kmQLMk8d0z4Tj8kbX0Ny9TubbIjksPecuXhm9eaS99k=; b=bza3J8gG94IyTGG4+puQ5kghhmzNDXQVTSULZZnI9d0YzCNzzYvQnQ9sV0T13F/M0W QRVbkXSTScRFFfuHj+ovq41jTQQkuAXkunlYrxt7QK2JJ9whuDO6x00zS8TIluvPAt3D F7HGY0zz2JBSxquVh3mclWvd7O58pXKDfgOWHjmidVtt+EP6kXahhEP4sAC7LW7yoy1J CxIkdArawlDAwXsTV6MYsPgWIiOgWNYAbnieQo3llKnqbc3jjxvCRUTE+bGQdSIFvj/M Lk/eHSdCvB4s8GQY0Y5G1xHK1FnWB5Iuf2RxDRixY7E8o34YIcJVLrPpbkoh/jj0q62g rAaw== X-Forwarded-Encrypted: i=1; AJvYcCUXuRL7iNgOIU92dD5aA5N52b1XzaTm/7pA8kxBrZgwSTRirFr26QkwgGp6oiCAUxT/bIci/smApkphBvo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz//AvOIGF9SWKiBHJUrItyG+kwPaODKcUUG618xOQzUXzhRCbH SkvvYUDYwCIWtlQ2Phpzq/sNViDuq5BDaPu2Ht9Z+u0UxlKpZK1Q6LkA X-Gm-Gg: ATEYQzylc2q4vZIhlbxkO6VyKBpsJR/7ZWdM18mtiZYAsMnfgo5ryX6H84A0DleUmHE qK2gTMMTi8qivB+3QeS1ngIvFwdWvcVTKaBti6f9R6YEtEKZXzWX8DclNtR3+MCkutSIFIs9YCk Y/0dqgkabLr235JCr+gUJvgFHcYqNSqJntcwnYmjcQo+F8jEAcQ/uEH1Ir6EMcBTTNdqCEsAZeE 8c+/BiNIMtxD4VlIS3MELS/r6biyetuGRM2w/ytdiAPqrRutDXdVjVk3CxBdq6w5xOyKe7RJU2b zZLI+uS3i5IMVIGG82r9Ouf6qz/lsUdSYHPxsYEOAOR54ZEU4qNg/s1p5Wo205csP4r70LJ+Z0D UEW2qYxLfoZXfvNU1CToANApaGIJZ2MUqZEEOVWonH3lDbG3QSYHND35ibLGxbTanhRzMIfOq7h LEEPdWBOV8Ko0HyEAos5QhLFJmSD2EYBAojTpz X-Received: by 2002:a17:906:a14e:b0:b96:ed21:f47e with SMTP id a640c23a62f3a-b976506f1a1mr727876966b.25.1773681595238; Mon, 16 Mar 2026 10:19:55 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97846174cfsm505940266b.22.2026.03.16.10.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 10:19:54 -0700 (PDT) From: Erikas Bitovtas Date: Mon, 16 Mar 2026 19:19:48 +0200 Subject: [PATCH v4 4/7] iio: light: vcnl4000: replace mutex_init with devm_mutex_init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-vcnl4000-regulators-v4-4-854fc2eaf54b@gmail.com> References: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> In-Reply-To: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Replace mutex_init used across driver with its device-managed counterpart, so all assigned mutexes get destroyed. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 287ccd89cfb2..cd7e6ee42cc5 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -356,6 +356,8 @@ static int vcnl4200_set_power_state(struct vcnl4000_dat= a *data, bool on) =20 static int vcnl4200_init(struct vcnl4000_data *data) { + struct i2c_client *client =3D data->client; + struct device *dev =3D &client->dev; int ret, id; u16 regval; =20 @@ -400,8 +402,14 @@ static int vcnl4200_init(struct vcnl4000_data *data) } data->al_scale =3D data->chip_spec->ulux_step; data->ps_scale =3D 16; - mutex_init(&data->vcnl4200_al.lock); - mutex_init(&data->vcnl4200_ps.lock); + + ret =3D devm_mutex_init(dev, &data->vcnl4200_al.lock); + if (ret) + return ret; + + ret =3D devm_mutex_init(dev, &data->vcnl4200_ps.lock); + if (ret) + return ret; =20 /* Use 16 bits proximity sensor readings */ ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1); @@ -1979,6 +1987,7 @@ static int vcnl4010_probe_trigger(struct iio_dev *ind= io_dev) static int vcnl4000_probe(struct i2c_client *client) { const struct i2c_device_id *id =3D i2c_client_get_device_id(client); + struct device *dev =3D &client->dev; struct vcnl4000_data *data; struct iio_dev *indio_dev; int ret; @@ -1993,7 +2002,9 @@ static int vcnl4000_probe(struct i2c_client *client) data->id =3D id->driver_data; data->chip_spec =3D &vcnl4000_chip_spec_cfg[data->id]; =20 - mutex_init(&data->vcnl4000_lock); + ret =3D devm_mutex_init(dev, &data->vcnl4000_lock); + if (ret) + return ret; =20 ret =3D data->chip_spec->init(data); if (ret < 0) --=20 2.53.0 From nobody Tue Apr 7 02:35:30 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6519B3D3CF8 for ; Mon, 16 Mar 2026 17:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681600; cv=none; b=af50TN/H171NK6l5m/m+PX9CUKabwjd5qFFAyvFPGo0CxbFYXSQexBpNpNOOikNnY+YMdgmL0iLMo+ha8e0rbZQp9Iw4izFhzoujZQ7mwTpbEK2a4UMAFCw0G2ai67rBb38Fx3QlWYTunn5XRc0iCD+68Bumt00MqHn3QtIkyLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681600; c=relaxed/simple; bh=F8JhpNRtISwTJCZ0mFH9huui70rVNKoYVUHt0NiS600=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YVRjzCoOQy4ZF3ePEiiAaAFSIKX6h1fKkLBzw+eXFpZkfbG4wlQTcu4fYsHwz8Be0kVzVpCwLrYlfmaDXrRES6NFCmoyZ9EY4KpFhs79/RgDRhJj1y3KYo0DFQdDawVbmth6V22IDqSkJHAvc65sKY07Dl7HLplWEKnw2zWNiIQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P0XfAtwB; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P0XfAtwB" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-660dcafc85aso9285134a12.0 for ; Mon, 16 Mar 2026 10:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773681597; x=1774286397; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NwqEwLydPXTJh37lAhGuKLAvUQ1T9VTG2r0Fov0v/5k=; b=P0XfAtwBdOvGFKYo+PTFs/vZ/4mclwhGJT3I+2/p8DyJeNobGGBFtctWHTCjfGDXMu RzXC6DHveAUq9CYbkXeTE1tY24DoBmq0g2fIpgIQIy/vxk23Z+yKnwMBAxv1KKjld7wI gKh3y6WHEqPEnqz1ua7Azu38LDwElq2AfcNgSuIEwtXUai5FnLwUIdYwJqYWUXPWrNRc v/s+Gwyx1Uq71OCTmcZg71vQMLYcGGRk0fmYaPEc1G7+blAYLiZsoseT3l/dmgvEZH85 u0GKCgT24x4RIYEmLOq8ALc4SyaUkuP/evt+i9GdwkitwPDYL2zIsi9TjU4bUzadbktu hWEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773681597; x=1774286397; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NwqEwLydPXTJh37lAhGuKLAvUQ1T9VTG2r0Fov0v/5k=; b=YWM1Wo4f4C0d+Ud1s4uyvJJCbkt0KLjdMr79l+yM9eYfoZ/lAy6SKOc0uh5uPk1fO6 Hk8hxdQ2DWDWS4329ayaOxPFvQgEU8LtA5NOrD2YPOmANmD1RTDUohhme8AsmENAzaUs X1De+RQwjYmgBrfSqoWE9bo9ojoaDgDdlTYXZFx1wUtR7vONqjIOZGvi+/ez5ZUIi5KN zN5OfIic2VHeD8uOYJT+OMHXwLelf7Azge5Ur/3PgaxToMTlMtIbqGaAumkCWj/RdLKE YCxzB9Pl3+9GWdeFLxTlzZ2Ql7Um8OUb/eynUYq1czIhsohh23333HPe9wFcTYL62sr+ KKlA== X-Forwarded-Encrypted: i=1; AJvYcCVEz80srhyg5o9ok1GGK8kolC5GBzpXWDUbAp0Rp3ku7LslaHLChbPiVptSXCxjDuC1jcHYenWudM+/7is=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9hwVYuIDo2Tv3UuUcIHEFasMilsw7TvKkMs9X2uwutPWQwiKw FNDKcRJLY+GHBs8dxCt1BM2YNWqZEwyJy8N+5yIA//YUpktkjRO71APt X-Gm-Gg: ATEYQzxVbtxTcNWHY08RibLFGEs1RR9wFZesZiYvlrFSyFKsE6m/jqxgglpH5Ikg52g NWhbJVvEETyRgt4Kg8hO7W3AL0nonrmjgdyisGNb0WtpadmqBcphTZGejK3MENEcT8hFEuG/Crb qGMZN2AarU/CyeAwdH37Gk9J29+QenICQ4v8aU9cQQ0NKWJsaAT5hlLUHawzMWySo5eipw5bBL6 m6SkRmjvVR4nvctbaQU9R6VN1+3R+4M8WgeSSQgZkE2vNB1oECIwrMFM0t5vCYehmFHc7DMKaeH dbAqntAxma9km0EmHv7X+Zhzk358Uqely1TBEj4REb66uCjj9VHIaSbq6kTlPshJS5yYCsFTNL0 DwG6iKmX0m+FO1RFAdqbDEQqgO+lKOSTV0epv8nisWd4LV0tdkHMNk4OY9PsWJ9gBBfK/K20Czz /xC6z4Uju4d1qncUjMCyqO1gBruQ== X-Received: by 2002:a17:907:7f8a:b0:b97:c5dd:c661 with SMTP id a640c23a62f3a-b97c5ddc833mr211421066b.45.1773681596530; Mon, 16 Mar 2026 10:19:56 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97846174cfsm505940266b.22.2026.03.16.10.19.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 10:19:56 -0700 (PDT) From: Erikas Bitovtas Date: Mon, 16 Mar 2026 19:19:49 +0200 Subject: [PATCH v4 5/7] iio: light: vcnl4000: remove error messages for trigger and irq Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-vcnl4000-regulators-v4-5-854fc2eaf54b@gmail.com> References: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> In-Reply-To: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 The error code is available in the log after return. In our case, attaching a triggered buffer can only fail if we are out of memory, as no other buffer is being attached. Remove duplicate error messages to reduce noise in dmesg. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index cd7e6ee42cc5..76aee16d479b 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -2033,11 +2033,8 @@ static int vcnl4000_probe(struct i2c_client *client) NULL, data->chip_spec->trig_buffer_func, data->chip_spec->buffer_setup_ops); - if (ret < 0) { - dev_err(&client->dev, - "unable to setup iio triggered buffer\n"); + if (ret < 0) return ret; - } } =20 if (client->irq && data->chip_spec->irq_thread) { @@ -2047,10 +2044,8 @@ static int vcnl4000_probe(struct i2c_client *client) IRQF_ONESHOT, "vcnl4000_irq", indio_dev); - if (ret < 0) { - dev_err(&client->dev, "irq request failed\n"); + if (ret < 0) return ret; - } =20 ret =3D vcnl4010_probe_trigger(indio_dev); if (ret < 0) --=20 2.53.0 From nobody Tue Apr 7 02:35:30 2026 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF9143D4131 for ; Mon, 16 Mar 2026 17:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681601; cv=none; b=uK2t9188N51+Vzv5EhG56asJWfOHWonp/Bmighenp1sNKlEw5B5Ihdu4nfEmbRGIjeKOgBwZABkZqNOBnfcENp8AQtRYYNUo/Ana+WVAzBNDHFH0HnFID+Lz1qP05f14d7xuA87FkMFkHJeomwwBPUt/lvP4/Q4rkZZG9tf7SXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681601; c=relaxed/simple; bh=R6JJNuzHldqhmL0cT6TJNLfm8et18/BjP7zu6n32s78=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hGfY23vTwYDDwUJlNzcUNiN9WBA8DQPqO9OBn3nZajvGdPbHZnVjDqAAYh8+r6WyMlGNFibgdecG7U6rDDqkh/eVE2LB71TCeNMVI7zaTUWvMfkZ46MBEtRa0TzexTQTwKHTAT40Wl3uGiQILHAbOMi6Pdr8awvZuGpEjnqw/EM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HCFq8+hq; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HCFq8+hq" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b976536806cso590611966b.0 for ; Mon, 16 Mar 2026 10:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773681598; x=1774286398; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+Pk3Hh6DzxINjbi6c9eEVbOAYCxG55sTKC9+jA3jbVA=; b=HCFq8+hqMXgzbt/2zeyqCXmplmmZqeBlD49pWb+k3wvkx3lcIKKpQriNVUOmMcN+LZ d5FmLMi+dtzV/MHeCnobJQH4nWSUrKjW6cBdPdlhQ2vB10An89TZ0MQc5wilhXij+iir yi0FaN8nGn+6FbgMDJTdJ8XkuqcBMAleYCJkkvMWU6uKmPTDGSMoFbIew24XMidaMYZA WUOUofNR61BdDonfynlm6grUdFJn/sNecQoIq1JwZMKbfwava54tNQ91GMZx/OFzoCS1 dbW8DxpXoDhtPM7xP7I4YAsHEoN46IMV3EksKOjlNzZxg62jv/mOdIgXyaKAbYc+KHsu uEag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773681598; x=1774286398; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+Pk3Hh6DzxINjbi6c9eEVbOAYCxG55sTKC9+jA3jbVA=; b=O4igEl/+7dSCqhNUrR7vRQkQK6Ub9aCHFEf+35EI7JI9h6R1PP6Ttgb0pycEFzmdWW sUxXTFJYr/a4RBiMFXB/uSnq7qajQ/wKjYKYEPj6Zkb5gKeLzKSBhIY6U27qZUz2lUTS +1G9NtKX4cl2/xabk/APDXKSqPje95sLGAJVEx2Fm9AfQcQw/4irPsbyQLXQmWb2LVfy +x3aYeYWhJJjibDfUU0vLDYlVJyJmJHJWgYvgT5TCw6Sgyzo2YjRAmzBSF/zkTsRw2Fe qzSqs/SwNp+lavLEri+OEinoMsl5MD1pIs7xovE6Zd51qhvbUNZ+rV3r2owvbozdM83G rH0w== X-Forwarded-Encrypted: i=1; AJvYcCVnFlYeE0n5qmf3W4ElwvVjr6K+IoYi6TwWzYzKZ2xZmiu38AniVIuv1idiUJForRpQpO4uE0/GI4Jgv4Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxTglkSJnknrCF8Dv3SwG7jGx+lVlo3IJHicW7+6uceMWBdFOI2 RTblRwZlk7m5vU9pVjyorYs5pXoLjOXJ2CmWcAt5EOGOrMnE7AQYlfPj X-Gm-Gg: ATEYQzw3favjhSZlJpcFgbMTL93IGRIlGtw0EHXGpvDQIF8hHmq7A8yfDFhdeL3ALjm 5mghgxWFRzcdSzVUMD/+SEEzhplkb4LcL+aE3/BFVpWH8Qx41tuyuTMuzuGX2/DS16wyRTVCved 5jcTRG4rK1NPi8Yn2twobze+sKFVefdSNcaYVf+a7bH2V8xVKk2HJzSKP5jkOO7U8CMr8/kpp7C DAivTi6XTVu5Q+YCQxp4z2qPyv9H+CNA8pgLSQHP8fAXjbInooeFB6E14dBQyenQPvtVLh5cpjH yExGSHHiRMB62UJMg4RnsOt4D3HuUUSBiQzEKuMnhpXJmlwApDXX2KOUWsdrk3GflhXqtl6MPIg j0JxR6S/qWQUVE5PnzMU2fHADzo23VwrQFZ8poYk5kqTSZwvmn44u0a+xtgDDMCGoJR9IjREf9R rGA9egsVkTnOx7qqPfCmwHeqUs9w== X-Received: by 2002:a17:906:3e49:b0:b97:5aa2:8337 with SMTP id a640c23a62f3a-b976514e2afmr618393266b.25.1773681598063; Mon, 16 Mar 2026 10:19:58 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97846174cfsm505940266b.22.2026.03.16.10.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 10:19:57 -0700 (PDT) From: Erikas Bitovtas Date: Mon, 16 Mar 2026 19:19:50 +0200 Subject: [PATCH v4 6/7] iio: light: vcnl4000: use variables for I2C client and device instances Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-vcnl4000-regulators-v4-6-854fc2eaf54b@gmail.com> References: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> In-Reply-To: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 After moving data->client and client->dev into variables of their own, replace all instances of data->client and client->dev being used in vcnl4200_init and vcnl4000_probe by the said variables to reduce clutter. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 39 +++++++++++++++++---------------------- 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 76aee16d479b..0a4d82679cfe 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -361,14 +361,14 @@ static int vcnl4200_init(struct vcnl4000_data *data) int ret, id; u16 regval; =20 - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_DEV_ID); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_DEV_ID); if (ret < 0) return ret; =20 id =3D ret & 0xff; =20 if (id !=3D VCNL4200_PROD_ID) { - ret =3D i2c_smbus_read_word_data(data->client, VCNL4040_DEV_ID); + ret =3D i2c_smbus_read_word_data(client, VCNL4040_DEV_ID); if (ret < 0) return ret; =20 @@ -378,7 +378,7 @@ static int vcnl4200_init(struct vcnl4000_data *data) return -ENODEV; } =20 - dev_dbg(&data->client->dev, "device id 0x%x", id); + dev_dbg(dev, "device id 0x%x", id); =20 data->rev =3D (ret >> 8) & 0xf; data->ps_int =3D 0; @@ -412,24 +412,22 @@ static int vcnl4200_init(struct vcnl4000_data *data) return ret; =20 /* Use 16 bits proximity sensor readings */ - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_PS_CONF1); if (ret < 0) return ret; =20 regval =3D ret | VCNL4040_PS_CONF2_PS_HD; - ret =3D i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF1, - regval); + ret =3D i2c_smbus_write_word_data(client, VCNL4200_PS_CONF1, regval); if (ret < 0) return ret; =20 /* Align proximity sensor sample rate to 16 bits data width */ - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF3); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_PS_CONF3); if (ret < 0) return ret; =20 regval =3D ret | VCNL4040_CONF3_PS_SAMPLE_16BITS; - ret =3D i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF3, - regval); + ret =3D i2c_smbus_write_word_data(client, VCNL4200_PS_CONF3, regval); if (ret < 0) return ret; =20 @@ -1992,7 +1990,7 @@ static int vcnl4000_probe(struct i2c_client *client) struct iio_dev *indio_dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; =20 @@ -2014,12 +2012,10 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret) return ret; =20 - dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", + dev_dbg(dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 - if (device_property_read_u32(&client->dev, "proximity-near-level", - &data->near_level)) - data->near_level =3D 0; + device_property_read_u32(dev, "proximity-near-level", &data->near_level); =20 indio_dev->info =3D data->chip_spec->info; indio_dev->channels =3D data->chip_spec->channels; @@ -2029,8 +2025,7 @@ static int vcnl4000_probe(struct i2c_client *client) =20 if (data->chip_spec->trig_buffer_func && data->chip_spec->buffer_setup_ops) { - ret =3D devm_iio_triggered_buffer_setup(&client->dev, indio_dev, - NULL, + ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, data->chip_spec->trig_buffer_func, data->chip_spec->buffer_setup_ops); if (ret < 0) @@ -2038,8 +2033,8 @@ static int vcnl4000_probe(struct i2c_client *client) } =20 if (client->irq && data->chip_spec->irq_thread) { - ret =3D devm_request_threaded_irq(&client->dev, client->irq, - NULL, data->chip_spec->irq_thread, + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, + data->chip_spec->irq_thread, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "vcnl4000_irq", @@ -2052,7 +2047,7 @@ static int vcnl4000_probe(struct i2c_client *client) return ret; } =20 - ret =3D pm_runtime_set_active(&client->dev); + ret =3D pm_runtime_set_active(dev); if (ret < 0) goto fail_poweroff; =20 @@ -2060,9 +2055,9 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) goto fail_poweroff; =20 - pm_runtime_enable(&client->dev); - pm_runtime_set_autosuspend_delay(&client->dev, VCNL4000_SLEEP_DELAY_MS); - pm_runtime_use_autosuspend(&client->dev); + pm_runtime_enable(dev); + pm_runtime_set_autosuspend_delay(dev, VCNL4000_SLEEP_DELAY_MS); + pm_runtime_use_autosuspend(dev); =20 return 0; fail_poweroff: --=20 2.53.0 From nobody Tue Apr 7 02:35:30 2026 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D2453D5223 for ; Mon, 16 Mar 2026 17:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681602; cv=none; b=Wm/B48iF+oYqpRtx4qgb4XKxgQlGh2Ze/c/vr74TT+eWggte03zXgEd5mb/pihVdY03IDNUGJdIhCM9aLd1OvYVC7LTx40hko6kHv5bcgxjG8zFKclgdsMCMgJh86hPkzkXbBtNZotdsC3k689sFmI/W5dQaYuLS+Xv7pOCs5z4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681602; c=relaxed/simple; bh=IU0IBscarTUHstHmwSwIa08PL60ws1VZKbiLKVlW0Jc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lnIs6c2fD/qhImbdoLR5i4fOsWcjK+PK4Yt9166loBBQirQxDEhXTF5eVt0zIaobOyQret4eqCptscLwccjNW2J20h82YCimyOtHQcA/rslsUDHP/sg7RLPDn8qFnjUiiutOe8zWkDf6N8ws/ysSbBIqcxg7ZjpZNR+yJTZqQHU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=goVsI22c; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="goVsI22c" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b97cf8a73d8so85223266b.3 for ; Mon, 16 Mar 2026 10:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773681599; x=1774286399; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LvZUSKnnGPiJWJPl2Ub4VP/4FdncxUtageJMqGG/QlU=; b=goVsI22cRBccBY1QhKM3ZgHopz2avwnvc6FgW70gB9AewxC9933tQbDjq4q/p7JGkV Aku/W6wDs+iJcapBKHozLHDIqFCLneLT+W0sQuf1GhPYEaJbeyX8wy1ZqXVU4pp14v8R vzwSsww5144oJi38W/n0xjg/2J5/nuHsrVw7DLplJdQ+ujCfTBc4mFBc6421iO6elFI/ D7O/1U28rKrit68DA981T1xPM78M/AR228laQcKIoXPqhg2ahSyCWnbQDC3QzBEbc+jJ KEHLadNU2MuHr4XlFN8aF56wQBxvNqhXzX0xkmqGCnHEpB7M9IDN1S3WbvcBStvDlS/b fuAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773681599; x=1774286399; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LvZUSKnnGPiJWJPl2Ub4VP/4FdncxUtageJMqGG/QlU=; b=m8fswFD7arHbgP+KTyIReKhMLHFrYwnE2sZnGZT26BuAf732yFV6BP6CyuzNfRizQe ozycB0I47NqgsgFPVWSeUfHXN63uKic6JvuN6okRbhGR6ayvANvx3sHe8duaYwN0/c/H WbOHdEWJNFpywXM6pXzfLAx3123wJyEPbqprLw7kAQMm0mvMR2IFO/Pco+A1M8nSrwGG T3PJbhMpX+yk8mjzBhao21tPKsjNuRrhmlgdLxmfCHEsIlnvpdAB8x+HjXhZ893pxbUo PFhWoh3qLqzZpSgyto7l81OUhpiyXRC6tE+KFLiw9uNY547L1vngq+YdHfTBTKIR9e3R kURw== X-Forwarded-Encrypted: i=1; AJvYcCVyul7IxdJr6CQw2v7XqI+ViqQRdexjylTUMgvNNhpr/F4hiv7aC6OW/xIB38dAvwaFdIG621zI9vSPhio=@vger.kernel.org X-Gm-Message-State: AOJu0YzkDCh9c2/yymXJKZa0RZlczgR5aG6tV1/AEZbos5dh0xLjocq1 bEe21iWsKnpVO9CyeKiDw9CohK/0PgCRA1ovMhpaHP3G6Cco41xeMinO X-Gm-Gg: ATEYQzzgXTJHCzn0ACrQIzvaj3iBVE11SIvgj6cfT0HD7Aodu7GIjZmTIiZPTCxCp/o zha5dWOAw0YLQqPj6DQy74/38gKfTu+eRmViS1OSkAvf8bO7+coejGj9WHbGnydnboMxUUF7G3N T2SpYpwzjvSQ9mLHT9yTeHYB2F6hpSQ+94G/7eQTjLEtiA4mkW1YzZNhVkM/QwRMm0gGpi04gzc CTo0e7u2KpHcph1JSZwqUne6vgh6a9ia/mLab7lK5OXjyIBDgr/W5mDAIox8KYv/Q0S/R4T5UPt IqUdq2XhY6acCVm4dQb8uAHaJQHh9Wi9K13ZFI6ORuxsosKBtzBLy+ewKbNObGe8+NdZLzrD/bJ heLfOi5McylHjgWK3WH1TukPComP5HCUMyGmGBoXd4v20RwKFRflg9pOrmJtUnLfWwubh/oZ/P4 oPfXXaTCRkoAsZZSyRDL9HF1jxfg== X-Received: by 2002:a17:907:d2e1:b0:b93:56a4:d6bc with SMTP id a640c23a62f3a-b976537e217mr764917466b.49.1773681599374; Mon, 16 Mar 2026 10:19:59 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97846174cfsm505940266b.22.2026.03.16.10.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 10:19:59 -0700 (PDT) From: Erikas Bitovtas Date: Mon, 16 Mar 2026 19:19:51 +0200 Subject: [PATCH v4 7/7] iio: light: vcnl4000: add support for regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-vcnl4000-regulators-v4-7-854fc2eaf54b@gmail.com> References: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> In-Reply-To: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas , Raymond Hackley X-Mailer: b4 0.14.3 Add supply, I2C and cathode voltage regulators to the sensor and enable them. This keeps the sensor powered on even after its only supply shared by another device shuts down. Reported-by: Raymond Hackley Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 0a4d82679cfe..5d1408aca562 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -24,6 +24,7 @@ #include #include #include +#include #include =20 #include @@ -1985,6 +1986,7 @@ static int vcnl4010_probe_trigger(struct iio_dev *ind= io_dev) static int vcnl4000_probe(struct i2c_client *client) { const struct i2c_device_id *id =3D i2c_client_get_device_id(client); + const char * const regulator_names[] =3D { "vdd", "vddio", "vled" }; struct device *dev =3D &client->dev; struct vcnl4000_data *data; struct iio_dev *indio_dev; @@ -2000,6 +2002,11 @@ static int vcnl4000_probe(struct i2c_client *client) data->id =3D id->driver_data; data->chip_spec =3D &vcnl4000_chip_spec_cfg[data->id]; =20 + ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(regulator_names), + regulator_names); + if (ret) + return ret; + ret =3D devm_mutex_init(dev, &data->vcnl4000_lock); if (ret) return ret; --=20 2.53.0