[v4] staging: rtl8723bs: Cleanups for rtw_xmit.c

[PATCH v4 0/2] staging: rtl8723bs: Cleanups for rtw_xmit.c

Posted by Marcos Andrade 3 weeks, 1 day ago

This patch series cleans up rtw_xmit.c by replacing magic numbers with
proper macros and updating the sleep API, as suggested by reviewers.

Patch 1 replaces network magic numbers with EtherType macros.
Patch 2 updates an msleep() call to the new fsleep() API.

Changes in v4:
 - Fixed commit message line wrapping in patch 2/2 to comply with 
   the 75-column limit, as suggested by Ethan Tidmore.
Changes in v3:
 - Grouped the patches into a series because patch 2 depends on the 
   include context of patch 1.
Changes in v2:
 - Changed include from "" to <> for linux/if_ether.h.
 - Sorted includes alphabetically.

Marcos Andrade (2):
  staging: rtl8723bs: Replace network magic numbers with EtherType
    macros
  staging: rtl8723bs: Replace msleep() with fsleep()

 drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

-- 
2.53.0

Re: [PATCH v4 0/2] staging: rtl8723bs: Cleanups for rtw_xmit.c

Posted by Ethan Tidmore 3 weeks, 1 day ago

On Sun Mar 15, 2026 at 4:05 PM CDT, Marcos Andrade wrote:
> This patch series cleans up rtw_xmit.c by replacing magic numbers with
> proper macros and updating the sleep API, as suggested by reviewers.
>
> Patch 1 replaces network magic numbers with EtherType macros.
> Patch 2 updates an msleep() call to the new fsleep() API.
>
> Changes in v4:
>  - Fixed commit message line wrapping in patch 2/2 to comply with 
>    the 75-column limit, as suggested by Ethan Tidmore.
> Changes in v3:
>  - Grouped the patches into a series because patch 2 depends on the 
>    include context of patch 1.
> Changes in v2:
>  - Changed include from "" to <> for linux/if_ether.h.
>  - Sorted includes alphabetically.
>
> Marcos Andrade (2):
>   staging: rtl8723bs: Replace network magic numbers with EtherType
>     macros
>   staging: rtl8723bs: Replace msleep() with fsleep()
>
>  drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET