From nobody Tue Apr 7 06:23:40 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74EE4374191 for ; Sun, 15 Mar 2026 21:06:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773608772; cv=none; b=XlnXM2vm7tNM7qlKkx2JO5i3zEGcmWnunim5fGcc3KQHjC6ulkAy6np3hGdqBirAT875ij3SdbQIhGXN8q3hpzYoaRrHgZf2JJDdRxdFrvHS9mXx0yy/4XyjCxjwIX4aiyhjsZ16uTi7VqJtmm0S4aC8TUOFnxqbLh7WGpnazII= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773608772; c=relaxed/simple; bh=ORJ4rscuuIawNtI4GPO1EVEu5tcsSDq0QVd96Pbwsqk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FRg06Mxe5NKmZzVfpZ1licm4AqnEchwD3ly6N7DrwyIDJet3AqxARNOobFOFGK/ADMeCbYhjNrBFppnjsAEGA36CXjhPcKQPYTfLFUC7P5INTGlG9v0HtgT2dxs9iubqFk1FrKfoNRQzaT0FvrYfOkF8duYTxvYgBNrMxShNTvA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zn8fXbpG; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zn8fXbpG" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82a07738118so2218364b3a.0 for ; Sun, 15 Mar 2026 14:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773608771; x=1774213571; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=akRjWY59n5sMvUNDaGckavPhAPsTROKRG/B6t9OT1vw=; b=Zn8fXbpGlkQ4KrGuyPYedNiYCDM5Zp535D+2r0gHf+lnsjpCEIH7ONSCTQ4G4EfQ4Q pPNu/kUTovh6HvTQaBCjE2H4TKefJ6VcYIOaOD33LzXp0LrOVzPtPgOsIk4HWRPtOjwa aeahDYfNXH/h+8HXmETncBQ4BnqRdLfuG8pqqmYjhzffZea/UkiFLKykJj8vaVUXqMup Tf7B7g/4fA7FyiyosIG31WXGo2E+Cnhf4TQXUF2OkfTp3lY0s0X9Ch+/xrFHntB+2Fj5 9NWzZN2/2xuOzEJB4q6Xs0+mCvyS8L5NEbfJOaIRiwvXvf3xhR4nQ/RSgQqWLj5fXdau 3qug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773608771; x=1774213571; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=akRjWY59n5sMvUNDaGckavPhAPsTROKRG/B6t9OT1vw=; b=QDIL3nJaeBUXUS6n3ckOK4znUWcu9FKjYUIdZ0/GKiUXGdQXkMkhjYLOJCI/Xrk8Gf vpDUUePsnNa8KmiuogJTpbFrt4Wugg+V9kf+ZSPrKb+1o6APty+Hlg+a+rnjF+s9kqhQ inCm1BRDyEzXDqd8r7/PmtUpl2gIYa/4MrsFQYiUqPqKGbHtH0YDEn97ixldLAo7furF pp/4yNFNvdsFThcIzEiipvavNXtguaMmmkmhOyR7RcWwr/lJidRbiLbGg5KMf1zAPLT0 CV56QG3TZJLtbxCd+HLS/0csE1x0/wIacLef5r/BpcBu3cLh8Mz1q9gx9c7t/h0Icbvn VdFA== X-Forwarded-Encrypted: i=1; AJvYcCWw+oEabSuJ8YoSUP7L5LhtgQOmk+6KyTToy4slO9P30vDCcQKPyAc2SOoJaVX6mbmY4OEEqGNyeT9/Dds=@vger.kernel.org X-Gm-Message-State: AOJu0YwysujM+Ul0WMfrQrvbPYI76VTWmAg6BF+q55mP5GW0cF6zCPHC Xyok2EycqF/KkcfBma+VWf000VOgjvlHCpkmHkJx3De+odmc7DOb5gZR X-Gm-Gg: ATEYQzzfBEWZORpnKcmCc4LjCFNKT2YUKobOQZ3gM5MP5NeMWQJNVMo+0PZ+RAoEAu5 SI0CLFl1p2KIQAK/b8rIZqoS9hHVJT6svfXKsmQlDfnQF4DxuFg2VL6vE+9nBbcLn9bwnKrget7 VUYh13vDjdCkmMCkE3czsVsMxhpWF9rduEM2f3FanK+mBUyrd4cbIwhbiW10bIK+rIE8Xi6m2bI 1OwlwAaFJHloiVwPEZ5GGBM0nv6K+censyXhAh17KvRH9Oj0VVBSRe+iUBfF73hM3VaoIEkjBwQ Bss1o5nqW9Z2vi7nhuivFb6+5SBh/376B+KpJBY8o8hhEOqRPxKEQbkeLLpgtWIZ1leIc99yIZ8 nvJKnKDRVTQgy38ILrAfFpgrEtO5z1A2HLhblaL95M8XQC6WgQtC9Yi+1WRh7cixZlMRgDBfawY u1EGNeqTMnprsI8694xnuj+/6OACfkjZ1m4aaK6fDStOxD6Qw= X-Received: by 2002:a05:6a00:1805:b0:81f:3c7c:8591 with SMTP id d2e1a72fcca58-82a198fb744mr9642802b3a.50.1773608770778; Sun, 15 Mar 2026 14:06:10 -0700 (PDT) Received: from mjmachine.localdomain ([131.255.96.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a0725e05esm13675506b3a.18.2026.03.15.14.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 14:06:10 -0700 (PDT) From: Marcos Andrade To: Greg Kroah-Hartman , Ethan Tidmore Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marcos Andrade Subject: [PATCH v4 1/2] staging: rtl8723bs: Replace network magic numbers with EtherType macros Date: Sun, 15 Mar 2026 18:05:49 -0300 Message-ID: <20260315210550.6058-2-marcosandrade95963@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260315210550.6058-1-marcosandrade95963@gmail.com> References: <20260315210550.6058-1-marcosandrade95963@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace hardcoded magic numbers for network protocols (e.g., 0x0806 for ARP, 0x888e for EAPOL) with their standard EtherType macro equivalents (ETH_P_ARP, ETH_P_PAE) defined in . This change improves code readability and aligns the driver with standard Linux networking definitions. Signed-off-by: Marcos Andrade Reviewed-by: Ethan Tidmore --- Changes in v3: - Included in a patch series. Changes in v2: - Changed include from "" to <> for linux/if_ether.h. - Sorted includes alphabetically. drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 7b18be891..4062fe0c1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -5,6 +5,7 @@ * *************************************************************************= *****/ #include +#include =20 static u8 P802_1H_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0xf8 }; static u8 RFC1042_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0x00 }; @@ -2026,8 +2027,8 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *x= mitframe) if (registry->hiq_filter =3D=3D RTW_HIQ_FILTER_ALLOW_SPECIAL) { struct pkt_attrib *attrib =3D &xmitframe->attrib; =20 - if (attrib->ether_type =3D=3D 0x0806 || - attrib->ether_type =3D=3D 0x888e || + if (attrib->ether_type =3D=3D ETH_P_ARP || + attrib->ether_type =3D=3D ETH_P_PAE || attrib->dhcp_pkt ) allow =3D true; --=20 2.53.0 From nobody Tue Apr 7 06:23:40 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC36835DA4D for ; Sun, 15 Mar 2026 21:06:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773608776; cv=none; b=q3U/aqM0uKb6WscldUnZPiBsBnTWJm4W+3x6y7bkdrTQG2NxuA4fxl6J5OGwMSSbiprIgxmI1BxJoP6mlAHN1lsPfuS9Da8rbGlAggDlWhDAMHtayYpD8ZgdGi6ZBqZFuL0XmMfNzfPr0pztFmEXTXF/kq8EaUSZMT4Yxk6te3s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773608776; c=relaxed/simple; bh=Dey168Ui+PXMkuMyHIK+EKJdQwhljjKsBZJUbx6zKZo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I8TNLs49DWdXX2cf9WAoOeuaN7l5vYI3zI4xCYpZOcwtAWIY0ZofT2lG8I88Jrgjbb6JyYcRNo4ENJMDAUvhfAzIOA2YcLdFWbDe3y2iYMhN5aEQwPl1uMfHlMfoadFOHLdcsGDh0a0sdsnrAqPgKwb+YGCXTVwu33dogIW+oqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FhuSTrZI; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FhuSTrZI" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-829b2019b39so1995005b3a.3 for ; Sun, 15 Mar 2026 14:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773608775; x=1774213575; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M1Tvd1tpBTM4CPll1YWLQWGwmWd4M95StOV6rs6r8oI=; b=FhuSTrZIIwSejXDfpWOY59yJSzYXTf9ZdHFUKzQAVBYo0E9EhWZ4WCtSYPSRuGR5Nw 1Br57JEa/ax4XZWt5sFzXi4YJBT/JpFezGtYS1IlyehvNJHKOdXhBD4EvZl29cZOteYQ WDIqkrXmlTkHfljvBhhvgSD4Lw/H8L0q+ILmMPbXDvnveV2qxR5+0KwcxkWdd6yugW/t FiR8CyV8BIngAZvwA2P2kCzAU9Cno2R5YxIoH3skoUDf6Q/KqfaTPt7sEWlnv//Jo0iQ 3JK7iRHmd4ktvjsdnW2xTeDnzpMYi2QEmRpe/nqqAlVRxJz1WRQcX0gL38WhEV6GHcIa XJwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773608775; x=1774213575; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M1Tvd1tpBTM4CPll1YWLQWGwmWd4M95StOV6rs6r8oI=; b=SIzz4KCGfP81+YEQ15gqZx0xVCRQoq0lBR9YVOYTZ901x7+vQiKBLlLX9lF/fW0t89 zXwHCRg1w/5kFrSHla2OHASozBi3DflT2KJK1htAsY+BvnBdVfQ2wFHdszbVSFUay95j o7bp3IStvFqmjulXwC7Zrs65Rk3488zvPykF8abKKf6Rx3B/T2kczNt6JTUDWYynu+xs Dtp9T+mEAZVCa6jsczNGorAq0Aq6QWJ1pJIcdY1kLLhxtz+JZUcRIVs6ox/QaqI81fpW wHqUiGKfGOrAgxU2VD7JoAhW76tPfwAeCm3G4SNr5laxGfI8/eO+l53WyMW+JCu8vN+S FVhA== X-Forwarded-Encrypted: i=1; AJvYcCXyNnLzzzYGIv9JIrFrB8EgfiIThUsdnKbGiTmZTjMZ45Yyehh2FE1NwjypejS6uXqGSdxToUw1QZVB4Fw=@vger.kernel.org X-Gm-Message-State: AOJu0YwwogXw54PUF1IKIISp+SoZK4yYIj5C3KGBigd/K7E+K5IdeOg/ ufktAhjjgdypST9J7s1w6eelSyvk6p4AMli116P8kdlTzhefWWdK9bAm X-Gm-Gg: ATEYQzxLE9k2L6MsIqQxwiohn0hv4ziQWaLWrjOROKEJfdJGdnQ+AY3NfBCYZsop0Ts UpXBcAcvPNjzSEofJvHXo63qXLuabIWkdI91YiCS6I0ZW2G5uyZydFgUmyzvfn6g8ivtFVD0Csv S9KyUval1WZNxwKWswA6lo/DOnoB1bZFz9MF5SBOJg5B1SuMrtU7vS0y5TEwy1nnHr6aqn0uQXs 4frd5YCWsJj1JN4bT2z+tToGiC1KyJ3WQxjCXPdjUsuGT6ZnULs9YTq7R3vgKk85a50UKe2f9IO UFl3F0wU8Cv8+oCX2y3p1pMCLULiVCWd0kDSGNKg1U8oO8bCLBct2g7K6fozcGsVw/oqG5maxTg 3YfP+ykEMfpuq+kReMHQUHpaFTLR40ZgpAjFW/A/58HNHebaaIcN6STcIkBMmioOBtjZRJph6k0 5bGX87fCovmlc8ZXNWVdz+0f/fyIsrATddbMBd6VNsjXveHZk= X-Received: by 2002:a05:6a00:2b97:b0:823:c59:9cb0 with SMTP id d2e1a72fcca58-82a196d3365mr8502749b3a.1.1773608775055; Sun, 15 Mar 2026 14:06:15 -0700 (PDT) Received: from mjmachine.localdomain ([131.255.96.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a0725e05esm13675506b3a.18.2026.03.15.14.06.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 14:06:14 -0700 (PDT) From: Marcos Andrade To: Greg Kroah-Hartman , Ethan Tidmore Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marcos Andrade Subject: [PATCH v4 2/2] staging: rtl8723bs: Replace msleep() with fsleep() Date: Sun, 15 Mar 2026 18:05:50 -0300 Message-ID: <20260315210550.6058-3-marcosandrade95963@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260315210550.6058-1-marcosandrade95963@gmail.com> References: <20260315210550.6058-1-marcosandrade95963@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace msleep(10) with fsleep(10 * USEC_PER_MSEC) in _rtw_init_xmit_priv(). fsleep() is the new standard API for delays, as it automatically chooses the best sleep method based on the duration. Suggested-by: Ethan Tidmore Signed-off-by: Marcos Andrade Reviewed-by: Ethan Tidmore --- Changes in v4: - Wrapped commit message lines to 75 columns. drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 4062fe0c1..dab16851f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -5,6 +5,7 @@ * *************************************************************************= *****/ #include +#include #include =20 static u8 P802_1H_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0xf8 }; @@ -129,7 +130,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) /* Tx buf allocation may fail sometimes, so sleep and retry. */ res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ += XMITBUF_ALIGN_SZ), true); if (res =3D=3D _FAIL) { - msleep(10); + fsleep(10 * USEC_PER_MSEC); res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ = + XMITBUF_ALIGN_SZ), true); if (res =3D=3D _FAIL) goto exit; --=20 2.53.0