smb: smbdirect: fix inverted comparison operator in negotiation log message

[PATCH] smb: smbdirect: fix inverted comparison operator in negotiation log message

Posted by David Carlier 3 weeks, 3 days ago

The condition checks preferred_send_size > max_recv_size, but the error
message prints "<" instead of ">", making the log misleading when
debugging SMBDirect RDMA negotiation failures.

Signed-off-by: David Carlier <devnexen@gmail.com>
---
 fs/smb/common/smbdirect/smbdirect_connect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/smb/common/smbdirect/smbdirect_connect.c b/fs/smb/common/smbdirect/smbdirect_connect.c
index b9be2f2f44be..2b54f79dba43 100644
--- a/fs/smb/common/smbdirect/smbdirect_connect.c
+++ b/fs/smb/common/smbdirect/smbdirect_connect.c
@@ -790,7 +790,7 @@ static void smbdirect_connect_negotiate_recv_work(struct work_struct *work)
 
 	if (preferred_send_size > sp->max_recv_size) {
 		smbdirect_log_rdma_event(sc, SMBDIRECT_LOG_ERR,
-			"invalid: preferred_send_size=%u < max_recv_size=%u\n",
+			"invalid: preferred_send_size=%u > max_recv_size=%u\n",
 			preferred_send_size,
 			sp->max_recv_size);
 		smbdirect_socket_schedule_cleanup(sc, -ECONNABORTED);
-- 
2.51.0

Re: [PATCH] smb: smbdirect: fix inverted comparison operator in negotiation log message

Posted by Namjae Jeon 3 weeks, 3 days ago

On Sat, Mar 14, 2026 at 6:13 AM David Carlier <devnexen@gmail.com> wrote:
>
> The condition checks preferred_send_size > max_recv_size, but the error
> message prints "<" instead of ">", making the log misleading when
> debugging SMBDirect RDMA negotiation failures.
>
> Signed-off-by: David Carlier <devnexen@gmail.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Thanks!

Re: [PATCH] smb: smbdirect: fix inverted comparison operator in negotiation log message

Posted by Steve French 3 weeks, 3 days ago

Added to ksmbd-for-next
(for 7.1-rc since file does not exist in 7.0-rc3 yet, it depends on
the RDMA/smbdirect patch series in ksmbd-for-next)

On Fri, Mar 13, 2026 at 8:00 PM Namjae Jeon <linkinjeon@kernel.org> wrote:
>
> On Sat, Mar 14, 2026 at 6:13 AM David Carlier <devnexen@gmail.com> wrote:
> >
> > The condition checks preferred_send_size > max_recv_size, but the error
> > message prints "<" instead of ">", making the log misleading when
> > debugging SMBDirect RDMA negotiation failures.
> >
> > Signed-off-by: David Carlier <devnexen@gmail.com>
> Acked-by: Namjae Jeon <linkinjeon@kernel.org>
> Thanks!



-- 
Thanks,

Steve