From nobody Tue Apr 7 09:05:10 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85C69282F04 for ; Fri, 13 Mar 2026 21:13:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773436429; cv=none; b=tQ80pJzUrev4nCtXYUkA6rfu+H73+2ppGL4W4KEPLQ+rMvhH4UrLwyMmcPv6n+T/SYdY0yr3/RnuVAVhg3v1V9kNDhjDl9MdUfOiPuQmQPx9tz/JakFxrvFhNNufEaemD+aEHNUPEUzCJAPx3JAtNDj9ETB+deYVYCmKAxaWisY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773436429; c=relaxed/simple; bh=I76/HLZiaym/OXbjhQMXkWvvZOLcApPBT/X2NqUIpXA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=g+muoeE2eQKAGsUPQItpmRI/N6UkkucZ+DpguVQI9WbiTzF6gcYBlWPCWz0q1qWyay12HCITSMdYguDjdo95H4mJCJ8NiZcsclaOs20oStQLRKRsETnSUz2etQOC9VAbssoSk13mRWlWY3Il8b8Ck4rofB4kgt4L30fB32JYP3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WCF09PQO; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WCF09PQO" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso23889735e9.3 for ; Fri, 13 Mar 2026 14:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773436427; x=1774041227; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BDv7h71YM4vlAO7NgBV84LFer9hX0UkXV0G3Fg6Lm04=; b=WCF09PQOud4UMfnXNf2peUJPyd9AJB4w3q2Ka+OezUibUJs80nRi4HNZDPUyhatjOs gXNzivDymMyXtIQevosxSN5RmDCxJPcvxAMsrbaTcX/mm8180zr6UsYepyCWbu1iuI+T 0hubGjUssrA+tIjUQwApVrLdqclUMrLVfkZU/qXU4iMd3BkPz15uos6vDE3qI2dDKo6Z mxyxHGqihyiMBronMCfoZsGzovPXgE/6u2X09uIbk59T0evsn0rTlPPe7ks2KBhEyLTH ldisIg8yCrg1OEnaxcdzajDjNKmLyGJHH6PiNC0ZdBlazBYnBfAl5aMop6CU2R2AmsA1 0Naw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773436427; x=1774041227; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BDv7h71YM4vlAO7NgBV84LFer9hX0UkXV0G3Fg6Lm04=; b=hyoCTPxn4Qv/2QGVgfF0cim32HPrtV9X78pFzyTGOLMuYOKyaYNj3TKhYtdJq6inpX /5DHriPFmaBcKOGwAjpMbSUswKlRHHCHgOeTTjSvReIx9Ke8QFiJnouPwbo4qVPjRXk8 73NNpOrgRmIz6IZNIbDH5H7TPJjtBTSU17MJVkWhg7Ntszxl5vxB90bMYp47Wrf6JbIO u30C7E5w1SMmU3w2kINZe5dB53iN4O8IWUEG2P+jEr0PTemQLFDpzZoTS2pnrr2cbNe+ XT9K0Ae2h9LMzNUHMWh/oqZva/5R9H0NGSeAORjoWdF0Y+KKNOj6WFFbn+OmZC6DOdae xshg== X-Gm-Message-State: AOJu0YzrS72g3+b0xFqpPE1o2ebN5HIIEmv7wdi0jm3jmkh5uByhwkII 7XaEKg2bHuRUO7FWGCyWQSeV/ZztwfLLCUUQ5Df+FMIA7dNlLchfV1oDPl+mnonr X-Gm-Gg: ATEYQzxEXSiLj0THkzmsErMJnzoH2mrfSaAKGJAi/143yTdh6x39VukwaNWH357t1i7 YtYHHLtbb0vYk03NSmMx3EWVuikqVE+yjNQTFSbpYfIoPMnwlBL2/qG45xhSGZQJwklalUZbHf8 zot/kqljfmxhdLr8LkGnTMo+AudUpokW+daPSYiJVbZk1kVRPYnP34fE/qXpaeCmO9ud0mbSuHS qwujNycwH4uToh72V0OHcAkp2ufXPICoTvAvPXMe3ty6EEBnOkOkq/fQwpD5Ij3anpv9OyWW+6w W9Sh0ZqwoPUgT2OoNpti4Y2XZbGFrx8bBbGj4Ub01c0ebEH/XmIqCnyvmL02D6U6lbY2HNFF7vs d+oJOu9Dk68mTeGYsmrisxksS4LRep7gxb8yU5kRlXGZgUjn5FOFvoL7PCTTpQ3owy9IQVHe8Aq L4nW1VfL4m7MVfuGLEG6om4uj8uBlCxEUcwZ+WqG3OEm+QyKClC8hUmWUYO3k+UX9RS5B3MNQhr 0W45kpiy0927dRflWYH X-Received: by 2002:a05:600c:a4b:b0:485:3692:e8f7 with SMTP id 5b1f17b1804b1-48556707ddbmr79022985e9.25.1773436426620; Fri, 13 Mar 2026 14:13:46 -0700 (PDT) Received: from rozandragon.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48557a732cesm28790965e9.12.2026.03.13.14.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 14:13:45 -0700 (PDT) From: David Carlier To: Namjae Jeon , Steve French Cc: linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH] smb: smbdirect: fix inverted comparison operator in negotiation log message Date: Fri, 13 Mar 2026 21:13:42 +0000 Message-ID: <20260313211342.137341-1-devnexen@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The condition checks preferred_send_size > max_recv_size, but the error message prints "<" instead of ">", making the log misleading when debugging SMBDirect RDMA negotiation failures. Signed-off-by: David Carlier Acked-by: Namjae Jeon --- fs/smb/common/smbdirect/smbdirect_connect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/common/smbdirect/smbdirect_connect.c b/fs/smb/common/sm= bdirect/smbdirect_connect.c index b9be2f2f44be..2b54f79dba43 100644 --- a/fs/smb/common/smbdirect/smbdirect_connect.c +++ b/fs/smb/common/smbdirect/smbdirect_connect.c @@ -790,7 +790,7 @@ static void smbdirect_connect_negotiate_recv_work(struc= t work_struct *work) =20 if (preferred_send_size > sp->max_recv_size) { smbdirect_log_rdma_event(sc, SMBDIRECT_LOG_ERR, - "invalid: preferred_send_size=3D%u < max_recv_size=3D%u\n", + "invalid: preferred_send_size=3D%u > max_recv_size=3D%u\n", preferred_send_size, sp->max_recv_size); smbdirect_socket_schedule_cleanup(sc, -ECONNABORTED); --=20 2.51.0