drivers/net/ipa/ipa_qmi.c | 6 ++---- drivers/net/wireless/ath/ath10k/qmi.c | 2 +- drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 - drivers/net/wireless/ath/ath11k/qmi.c | 2 +- drivers/net/wireless/ath/ath11k/qmi.h | 1 - drivers/net/wireless/ath/ath12k/qmi.c | 2 +- drivers/net/wireless/ath/ath12k/qmi.h | 1 - drivers/remoteproc/qcom_sysmon.c | 2 +- drivers/slimbus/qcom-ngd-ctrl.c | 5 ++--- drivers/soc/qcom/pdr_interface.c | 4 ++-- drivers/soc/qcom/pdr_internal.h | 3 --- drivers/soc/qcom/qcom_pd_mapper.c | 2 +- include/linux/soc/qcom/qmi.h | 12 ++++++++++++ samples/qmi/qmi_sample_client.c | 2 +- sound/usb/qcom/qc_audio_offload.c | 2 +- sound/usb/qcom/usb_audio_qmi_v01.h | 1 - 16 files changed, 25 insertions(+), 23 deletions(-)
The different subsystems implementing the QMI service protocol are
using their own definition of the service id. It is not a problem but
it results on having those duplicated with different names but the
same value and without consistency in their name.
It makes more sense to unify their names and move the definitions in
the QMI header file providing a consistent way to represent the
supported protocols. Consequently the different drivers will use them
instead of their own definition of the service id.
Cc: Alex Elder <elder@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Jeff Johnson <jjohnson@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Srinivas Kandagatla <srini@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Kees Cook <kees@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Mark Brown <broonie@kernel.org>
Cc: Wesley Cheng <quic_wcheng@quicinc.com>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: ath10k@lists.infradead.org
Cc: ath11k@lists.infradead.org
Cc: ath12k@lists.infradead.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-remoteproc@vger.kernel.org
Cc: linux-sound@vger.kernel.org
---
Daniel Lezcano (8):
soc: qcom: qmi: Enumerate the service IDs of QMI
net: ipa: Use the unified QMI service ID instead of defining it
locally
net: drivers: wireless: ath: Use the unified QMI service ID instead of
defining it locally
remoteproc: qcom: Use the unified QMI service ID instead of defining
it locally
slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of
defining it locally
soc: qcom: pdr: Use the unified QMI service ID instead of defining it
locally
ALSA: usb-audio: qcom: Use the unified QMI service ID instead of
defining it locally
samples: qmi: Use the unified QMI service ID instead of defining it
locally
drivers/net/ipa/ipa_qmi.c | 6 ++----
drivers/net/wireless/ath/ath10k/qmi.c | 2 +-
drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 -
drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
drivers/net/wireless/ath/ath11k/qmi.h | 1 -
drivers/net/wireless/ath/ath12k/qmi.c | 2 +-
drivers/net/wireless/ath/ath12k/qmi.h | 1 -
drivers/remoteproc/qcom_sysmon.c | 2 +-
drivers/slimbus/qcom-ngd-ctrl.c | 5 ++---
drivers/soc/qcom/pdr_interface.c | 4 ++--
drivers/soc/qcom/pdr_internal.h | 3 ---
drivers/soc/qcom/qcom_pd_mapper.c | 2 +-
include/linux/soc/qcom/qmi.h | 12 ++++++++++++
samples/qmi/qmi_sample_client.c | 2 +-
sound/usb/qcom/qc_audio_offload.c | 2 +-
sound/usb/qcom/usb_audio_qmi_v01.h | 1 -
16 files changed, 25 insertions(+), 23 deletions(-)
--
2.43.0
On Tue, Mar 10, 2026 at 12:03:29AM +0100, Daniel Lezcano wrote: > The different subsystems implementing the QMI service protocol are > using their own definition of the service id. It is not a problem but > it results on having those duplicated with different names but the > same value and without consistency in their name. > > It makes more sense to unify their names and move the definitions in > the QMI header file providing a consistent way to represent the > supported protocols. Consequently the different drivers will use them > instead of their own definition of the service id. Also this looks like a first step towards providing qrtr service debugfs in the kernel. > -- With best wishes Dmitry
On 3/9/2026 4:03 PM, Daniel Lezcano wrote: > The different subsystems implementing the QMI service protocol are > using their own definition of the service id. It is not a problem but > it results on having those duplicated with different names but the > same value and without consistency in their name. > > It makes more sense to unify their names and move the definitions in > the QMI header file providing a consistent way to represent the > supported protocols. Consequently the different drivers will use them > instead of their own definition of the service id. > > Cc: Alex Elder <elder@kernel.org> > Cc: Andrew Lunn <andrew+netdev@lunn.ch> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: Jeff Johnson <jjohnson@kernel.org> > Cc: Bjorn Andersson <andersson@kernel.org> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Cc: Srinivas Kandagatla <srini@kernel.org> > Cc: Konrad Dybcio <konradybcio@kernel.org> > Cc: Jaroslav Kysela <perex@perex.cz> > Cc: Takashi Iwai <tiwai@suse.com> > Cc: Kees Cook <kees@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Mark Brown <broonie@kernel.org> > Cc: Wesley Cheng <quic_wcheng@quicinc.com> > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-wireless@vger.kernel.org > Cc: ath10k@lists.infradead.org > Cc: ath11k@lists.infradead.org > Cc: ath12k@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-remoteproc@vger.kernel.org > Cc: linux-sound@vger.kernel.org > --- > Daniel Lezcano (8): > soc: qcom: qmi: Enumerate the service IDs of QMI > net: ipa: Use the unified QMI service ID instead of defining it > locally > net: drivers: wireless: ath: Use the unified QMI service ID instead of > defining it locally prefix for wireless drivers is simply wifi: <driver>: so s/net: drivers: wireless:/wifi:/ > remoteproc: qcom: Use the unified QMI service ID instead of defining > it locally > slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of > defining it locally > soc: qcom: pdr: Use the unified QMI service ID instead of defining it > locally > ALSA: usb-audio: qcom: Use the unified QMI service ID instead of > defining it locally > samples: qmi: Use the unified QMI service ID instead of defining it > locally > > drivers/net/ipa/ipa_qmi.c | 6 ++---- > drivers/net/wireless/ath/ath10k/qmi.c | 2 +- > drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 - > drivers/net/wireless/ath/ath11k/qmi.c | 2 +- > drivers/net/wireless/ath/ath11k/qmi.h | 1 - > drivers/net/wireless/ath/ath12k/qmi.c | 2 +- > drivers/net/wireless/ath/ath12k/qmi.h | 1 - > drivers/remoteproc/qcom_sysmon.c | 2 +- > drivers/slimbus/qcom-ngd-ctrl.c | 5 ++--- > drivers/soc/qcom/pdr_interface.c | 4 ++-- > drivers/soc/qcom/pdr_internal.h | 3 --- > drivers/soc/qcom/qcom_pd_mapper.c | 2 +- > include/linux/soc/qcom/qmi.h | 12 ++++++++++++ > samples/qmi/qmi_sample_client.c | 2 +- > sound/usb/qcom/qc_audio_offload.c | 2 +- > sound/usb/qcom/usb_audio_qmi_v01.h | 1 - You are touching a lot of subsystems with a single series. How do you plan on having these land? Do you have a maintainer who will take all of these through their tree? > 16 files changed, 25 insertions(+), 23 deletions(-) >
On 3/10/26 00:50, Jeff Johnson wrote: > On 3/9/2026 4:03 PM, Daniel Lezcano wrote: >> The different subsystems implementing the QMI service protocol are >> using their own definition of the service id. It is not a problem but >> it results on having those duplicated with different names but the >> same value and without consistency in their name. >> >> It makes more sense to unify their names and move the definitions in [ ... ] > prefix for wireless drivers is simply wifi: <driver>: > so s/net: drivers: wireless:/wifi:/ Noted, thanks >> remoteproc: qcom: Use the unified QMI service ID instead of defining >> it locally >> slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of >> defining it locally >> soc: qcom: pdr: Use the unified QMI service ID instead of defining it >> locally >> ALSA: usb-audio: qcom: Use the unified QMI service ID instead of >> defining it locally >> samples: qmi: Use the unified QMI service ID instead of defining it >> locally >> >> drivers/net/ipa/ipa_qmi.c | 6 ++---- >> drivers/net/wireless/ath/ath10k/qmi.c | 2 +- >> drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 - >> drivers/net/wireless/ath/ath11k/qmi.c | 2 +- >> drivers/net/wireless/ath/ath11k/qmi.h | 1 - >> drivers/net/wireless/ath/ath12k/qmi.c | 2 +- >> drivers/net/wireless/ath/ath12k/qmi.h | 1 - >> drivers/remoteproc/qcom_sysmon.c | 2 +- >> drivers/slimbus/qcom-ngd-ctrl.c | 5 ++--- >> drivers/soc/qcom/pdr_interface.c | 4 ++-- >> drivers/soc/qcom/pdr_internal.h | 3 --- >> drivers/soc/qcom/qcom_pd_mapper.c | 2 +- >> include/linux/soc/qcom/qmi.h | 12 ++++++++++++ >> samples/qmi/qmi_sample_client.c | 2 +- >> sound/usb/qcom/qc_audio_offload.c | 2 +- >> sound/usb/qcom/usb_audio_qmi_v01.h | 1 - > > You are touching a lot of subsystems with a single series. > How do you plan on having these land? > Do you have a maintainer who will take all of these through their tree? Yes I thought Bjorn or Konrad would take them with the acked-by from the different subsystems
On Tue, Mar 10, 2026 at 01:09:08AM +0100, Daniel Lezcano wrote: > On 3/10/26 00:50, Jeff Johnson wrote: > > On 3/9/2026 4:03 PM, Daniel Lezcano wrote: > > > The different subsystems implementing the QMI service protocol are > > > using their own definition of the service id. It is not a problem but > > > it results on having those duplicated with different names but the > > > same value and without consistency in their name. > > > > > > It makes more sense to unify their names and move the definitions in > > [ ... ] > > > prefix for wireless drivers is simply wifi: <driver>: > > so s/net: drivers: wireless:/wifi:/ > > Noted, thanks > > > > remoteproc: qcom: Use the unified QMI service ID instead of defining > > > it locally > > > slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of > > > defining it locally > > > soc: qcom: pdr: Use the unified QMI service ID instead of defining it > > > locally > > > ALSA: usb-audio: qcom: Use the unified QMI service ID instead of > > > defining it locally > > > samples: qmi: Use the unified QMI service ID instead of defining it > > > locally > > > > > > drivers/net/ipa/ipa_qmi.c | 6 ++---- > > > drivers/net/wireless/ath/ath10k/qmi.c | 2 +- > > > drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 - > > > drivers/net/wireless/ath/ath11k/qmi.c | 2 +- > > > drivers/net/wireless/ath/ath11k/qmi.h | 1 - > > > drivers/net/wireless/ath/ath12k/qmi.c | 2 +- > > > drivers/net/wireless/ath/ath12k/qmi.h | 1 - > > > drivers/remoteproc/qcom_sysmon.c | 2 +- > > > drivers/slimbus/qcom-ngd-ctrl.c | 5 ++--- > > > drivers/soc/qcom/pdr_interface.c | 4 ++-- > > > drivers/soc/qcom/pdr_internal.h | 3 --- > > > drivers/soc/qcom/qcom_pd_mapper.c | 2 +- > > > include/linux/soc/qcom/qmi.h | 12 ++++++++++++ > > > samples/qmi/qmi_sample_client.c | 2 +- > > > sound/usb/qcom/qc_audio_offload.c | 2 +- > > > sound/usb/qcom/usb_audio_qmi_v01.h | 1 - > > > > You are touching a lot of subsystems with a single series. > > How do you plan on having these land? > > Do you have a maintainer who will take all of these through their tree? > > Yes I thought Bjorn or Konrad would take them with the acked-by from the > different subsystems As we haven't received any such acks, I pulled patch 1 into an immutable branch and pushed it here: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git 20260309230346.3584252-2-daniel.lezcano@oss.qualcomm.com Other maintainers can use this to pull respective changes, or you can repost the individual patches with this (or follow up once it's in -rc1). Regards, Bjorn
On Tue, 10 Mar 2026 00:03:29 +0100, Daniel Lezcano wrote:
> The different subsystems implementing the QMI service protocol are
> using their own definition of the service id. It is not a problem but
> it results on having those duplicated with different names but the
> same value and without consistency in their name.
>
> It makes more sense to unify their names and move the definitions in
> the QMI header file providing a consistent way to represent the
> supported protocols. Consequently the different drivers will use them
> instead of their own definition of the service id.
>
> [...]
Applied, thanks!
[6/8] soc: qcom: pdr: Use the unified QMI service ID instead of defining it locally
commit: 24f80cbe0b8f4c6b27d03c7a7ad707d76c1c4885
[8/8] samples: qmi: Use the unified QMI service ID instead of defining it locally
commit: 8baf6b3b7695849581a91bdaf66af2be68ef32ed
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
On Tue, 10 Mar 2026 00:03:29 +0100, Daniel Lezcano wrote:
> The different subsystems implementing the QMI service protocol are
> using their own definition of the service id. It is not a problem but
> it results on having those duplicated with different names but the
> same value and without consistency in their name.
>
> It makes more sense to unify their names and move the definitions in
> the QMI header file providing a consistent way to represent the
> supported protocols. Consequently the different drivers will use them
> instead of their own definition of the service id.
>
> [...]
Applied, thanks!
[8/8] samples: qmi: Use the unified QMI service ID instead of defining it locally
commit: 8baf6b3b7695849581a91bdaf66af2be68ef32ed
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
© 2016 - 2026 Red Hat, Inc.