From nobody Thu Apr 9 09:02:44 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C0DC33DEC2 for ; Mon, 9 Mar 2026 23:05:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097550; cv=none; b=A+gevAH8b7ony96wPbf7qgLf3HFOnzG4XQZhPG8FrtZkqXymR7wpbyxyvQhAW8eUqwhhgAVIf8KxsLwc32DDCc7sVd8NqZo4Vdu8lcwsTf/63vN5jYuvpW8hViOzRtaRY9gJ8KNrZJvfTrIsc5kcaKbVFw/HK56MLek1oZ66L6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097550; c=relaxed/simple; bh=vxfMiR5RjXUasWyw4A83O5C4elvrw071f7dlCLFW+9s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mIRUEFqS7PvKB76sEVX7s2dCeFvaQM90rhQ1uj+wXB3j+H7IaCmb9+2hjuf4PGU/LOV9aq1IF0fwjz0ZIYCApaJ4FZgod5Z7mQBMQkxZIiGaQlpFGVyIJv/1IURHRl6PtbN444AlfYS+hH/mBsI4s4LVEMZuDqRNFYtVKVdjlks= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gloHc0jc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jTEJu0MJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gloHc0jc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jTEJu0MJ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HCVlD1204905 for ; Mon, 9 Mar 2026 23:05:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=4nuiFplGeEP W6F+CQFmrK11Lx/4N6iGgXoWw2lOEPQk=; b=gloHc0jcRhYOoGyz7DgdnhjiojN H9hpeKUd3Kr08GXwo2N3xaErYbMYE0ASu4NTUYcKjZ9ez2A9Ln/ugpg39/yqLKpt mJqC7xYLnB5LKufywMAf1lsUOjU0QpQNbrVZdB+sEyfZQPgeemL8PYJLPvILMPtg J9WFvV+Y+4Xa9nvrlKx47wQN0VDhAsMxk6T9hBaepKW6iyHsUBePHNABli94ozlE 2crJCJTHgxTLIb4YTD/Z6PXFQqMxMW/7NsUo2SFXI008JG2dOtvgKhb9qGrKUvGX iIBjRfQLrG1MsJtDR2Pool1dBuNiAgVrmfsr2Hh17M6MiZ/6pAmlisLu84Q== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct0329n2j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:05:49 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-899fa82ebb9so543538006d6.3 for ; Mon, 09 Mar 2026 16:05:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773097548; x=1773702348; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4nuiFplGeEPW6F+CQFmrK11Lx/4N6iGgXoWw2lOEPQk=; b=jTEJu0MJAhxNbmjysgomqhfYcYjYknku0qx7bFVcZoKbwwKDAwmCh61gMEijFL6lIM QUpW7k97vzkxS8AaoOVFDhFILXIhQo6tLshwmymfIbSVLO3e6Ipx/pQqVVjDPXGEuntS SMKISqVW7DMlqfr/frcyaKaLIiTX4mBkD5elNhbeAYb/CyP1shrlWS1g7li2hcrNGxgt mLN4StG4ClTNi7aQ3SwUaCsghA1W82NFQ8csA6mSuVrnM0x0J9tF2dKsIdCVu6lC8QoB vCHvAatWnrNVSZcA4MgTBg3mG0JpLxioLewX0hYywRcMHHy/miLPFNQmsXzxoswWIfd8 Pesw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773097548; x=1773702348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4nuiFplGeEPW6F+CQFmrK11Lx/4N6iGgXoWw2lOEPQk=; b=wVrmxKbotYojNlZOcm1TLOrEfWq66G2h2/A0yEvrf3suh9lX21VmqszLW9QZoJpeQ6 xu9rweUYlXmBeXQ+rmx3JTyHkSeCxhBDa/Q/XqlrF1nGg2XxyPBGKHlx48in81QD5HaM QgkI6IpK1FF85R9AKfx2RHS+zf4ZDVSJ3SQF7SFnnoqT5adQi2F7+PQwn/5RjpX1BT76 1mX4oQsDHGxcMxjuvVEbaZSFRPTj6K69c5SsYICE7kY6qRG/7Q3/WzdsDvI/QB6q8O3G mwmsBRVknVxWPJ6lW8vzwAsQIrfeedjwlzm4/W+sx/RGo2detXG2sh7xQui+0zIV1MdK nlyA== X-Gm-Message-State: AOJu0YxvpALbeHEwANvG/Kls3pzbuS9W5ETE+SI8oSlvUyBIdUSvNvnq H+hXh6bJcwZC2hmrigpkoCoX7v91j8CKhcaXqwLpdJDicQfc1jU+BZGpt+0PDQsXrwcPSj350uP h4rbijV2SsZLFFyr/dNC+Nz2AJ4bpBrT3+LO/8zty7xvdQeCv7Z/6uxLUOKNQxj3s+hQ= X-Gm-Gg: ATEYQzw4HMVnyalQUrOIYGQQgFrfasG0v7vwivlBVGtgnzGEyYVpodNKvB0vgp2m1nK L76+82ROEssiML9MTUtri7z9mn56aERfWzyBSP+AQar7Ge0WAc/sGYWM1C4GPZju/sPiQlipOmO T9nielulpauxsKXuGTm5wE9hgzqvrXK0+Si+Y65VteU2o2GOvfWKZ0zqGUU1Dej+xFKiF2yoBhx p1nv3oEd31pvf7f4Uex/Xkk1vk4WCXt5lv84TTn9CgIBIaqk5dajoTVgHKJQqcH3cF+Y9EOLIt3 W4LW65zTAKPRf559TyZnPyOd2tCaHE5o5RDlXDwfxQB3v6tTsmKJPbkfjyq7KlgOk45EB7ejffw vTiDHwupHwV4YZUUzF6v2u/MVjdMMJobqD9jRd0+aTvFAA0orSw== X-Received: by 2002:a05:620a:40d5:b0:8cd:8d4c:aa0c with SMTP id af79cd13be357-8cd8d4cadd9mr467940385a.0.1773097548057; Mon, 09 Mar 2026 16:05:48 -0700 (PDT) X-Received: by 2002:a05:620a:40d5:b0:8cd:8d4c:aa0c with SMTP id af79cd13be357-8cd8d4cadd9mr467934285a.0.1773097547515; Mon, 09 Mar 2026 16:05:47 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:ae20:597c:99b8:d161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae3d98asm33898478f8f.30.2026.03.09.16.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 16:05:46 -0700 (PDT) From: Daniel Lezcano To: konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI Date: Tue, 10 Mar 2026 00:03:30 +0100 Message-ID: <20260309230346.3584252-2-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIwNCBTYWx0ZWRfXxtOVz+xSNH+k 5Kog6K5qUaLTPpT7l4+aIiE3AtVYey8jx3L/DB39ExaOL+JF/ONDhai6+cWhxwbi8tPrCpqOQiR Jc6ReTheXQm8uD9heRlvhUWmaQL6D0QvjdIUFHlKfriATNLdVHuEgu39DPSG97fl9C3hrOGBpg6 qetLzf5Wz8BbFvT0Z1yx1MeVIlLNL36WPOTrmRa/rqbcLsIVp4aBNYEWSi83Wt0GhxC2xHbWhQi 0Pka0G2bVRl+z3SZ2gcmtCeBWsVJx3vtI0FkvKeTSgWMBcCK8Fii/JMsa1DzK8wNGIY6HDXWRBQ fjmSESJbI9odgHCoBp2qbw4OogR4nqBfowI8pYEayhjByusKCBUl416FQQrlj72q3s0ZZLSy2RW zUZW08qduCKoEWCl7Vu1v5tLG8yHlq+n0y1tfGE1SzKb+EX2vxVi7mGb4VnXkjtQcMhCtANIbTo 8icJ5FAkQn/NXGVcJLw== X-Proofpoint-ORIG-GUID: WldYOGMsaWi9e0Jy0XUh6ltQPbpGf0Rz X-Proofpoint-GUID: WldYOGMsaWi9e0Jy0XUh6ltQPbpGf0Rz X-Authority-Analysis: v=2.4 cv=WtEm8Nfv c=1 sm=1 tr=0 ts=69af524d cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=NWmyY4P_PqWfpxtJLaAA:9 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090204 Content-Type: text/plain; charset="utf-8" The QMI framework proposes a set of services which are defined by an integer identifier. The different QMI client lookup for the services via this identifier. Moreover, the function qmi_add_lookup() and qmi_add_server() must match the service ID but the code in different places set the same value but with a different macro name. These macros are spreaded across the different subsystems implementing the protocols associated with a service. It would make more sense to define them in the QMI header for the sake of consistency and clarity. This change use an unified naming for the services and enumerate the ones implemented in the Linux kernel. More services can come later and put the service ID in this same header. Signed-off-by: Daniel Lezcano Reviewed-by: Dmitry Baryshkov --- include/linux/soc/qcom/qmi.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/linux/soc/qcom/qmi.h b/include/linux/soc/qcom/qmi.h index 291cdc7ef49c..b8d07f2c07e7 100644 --- a/include/linux/soc/qcom/qmi.h +++ b/include/linux/soc/qcom/qmi.h @@ -92,6 +92,18 @@ struct qmi_elem_info { #define QMI_ERR_INCOMPATIBLE_STATE_V01 90 #define QMI_ERR_NOT_SUPPORTED_V01 94 =20 +/* + * Enumerate the IDs of the QMI services + */ +#define QMI_SERVICE_ID_TEST 0x0F /* 15 */ +#define QMI_SERVICE_ID_SSCTL 0x2B /* 43 */ +#define QMI_SERVICE_ID_IPA 0x31 /* 49 */ +#define QMI_SERVICE_ID_SERVREG_LOC 0x40 /* 64 */ +#define QMI_SERVICE_ID_SERVREG_NOTIF 0x42 /* 66 */ +#define QMI_SERVICE_ID_WLFW 0x45 /* 69 */ +#define QMI_SERVICE_ID_SLIMBUS 0x301 /* 769 */ +#define QMI_SERVICE_ID_USB_AUDIO_STREAM 0x41D /* 1053 */ + /** * struct qmi_response_type_v01 - common response header (decoded) * @result: result of the transaction --=20 2.43.0 From nobody Thu Apr 9 09:02:44 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8932F4266A3 for ; Mon, 9 Mar 2026 23:05:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097553; cv=none; b=QpTLANKDggX0jN268F3IO7/PfJXWB+uyJkGAImYi0gJ7TpI9LAopEjrQMnESvddYbtmC/DGp1ZeqPkX8GwoYsSfVAjp2C4tLP21FgkZzuOEZ7nzhN6YRMX9qtHRJoTuX8jPiRx+grjNO/fy4sFZhussx6x4hSDK5a8b8wPvr3zI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097553; c=relaxed/simple; bh=zL69uAdweI4X0y0Z+IAisT4rMg++38nfIAzKDgVfeho=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qcH4K1ZhlfHDPjsEDbvSsdQkCFmQrvguXp0EpxQc8AryQbFW9C1gUq+ktXCeVp/F6DBCbSIopYh5/dWhHizRRhMl+dwywa5nERiGg+uqLgGQR3ZC+B/zcxzqwHihegIxXUPBfzLeb7MTBPpMnz6WSL0cbcL21JfyZUJ6mCGUbDo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lBfD8/ns; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LRXwQU+a; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lBfD8/ns"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LRXwQU+a" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HBlx5296222 for ; Mon, 9 Mar 2026 23:05:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=PTfKdHxXDsD Bf9qbtcJy20RFKCKAaUi+C0QbWC3j2OY=; b=lBfD8/nsjfep7uWpNTtXTTH97LP adqHrnvrTVmVgz0lWbAL5VcrdHrI4FRTSXkiz+u1QcKmurgn/d88hHz/4iBBAoj+ SgF0dP66UX7GP3KqmHq4FBR51A54fIi9wNxDZIo/awWFssBbLgEaNe0j8xL0eSu4 6ohLKXiqBj9NRM3ztv9YLcdyDch7tWK3LyfdOBKXfoqDRIixooDyqouwjHgLJuOl Z4pMUTPjrfg3DUOyVZm3GPKNXh9IR5fH1JW8M+0dXX3xAhqbHxUTvP+UD3hMdiGU wmJYD7HdlW4rfeiSqQS1ja79m2ZdhWjJOgTQi0iWoF0sex2KenSTQG+ihSQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csyfy1ruu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:05:50 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd77e5e187so1438773085a.1 for ; Mon, 09 Mar 2026 16:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773097550; x=1773702350; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PTfKdHxXDsDBf9qbtcJy20RFKCKAaUi+C0QbWC3j2OY=; b=LRXwQU+ahVItUcd7XgXpLBKk5T4a+a5v6R6I4NCx63YBkMPsfSObF81oTrOp9iicyx EX5IYkV1xt3/rq6xrlSZKL1xf8Wt/x+iM+Aj2DALp1I0Dj+s1gTq0P9teJ6Qv6BiPEjt dgDHeQOLJnZIhSpmp2laI7BsJNlEW1f59plbJiL5roVffGTQvRPrb8vo1wkmrVzk2z8v RVE1UHlvuz73x7lVpOHZKmMQHJMZ8b/HuoKyWLA0poACviJINMqGokaD9KgCDuhdoQx8 LFQFG4C9GJTMj1yek+rSh1WcZrZSg/GSn5mqePkPpMAH228P8j4IdekoA1JA4qaNeaPi iQOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773097550; x=1773702350; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PTfKdHxXDsDBf9qbtcJy20RFKCKAaUi+C0QbWC3j2OY=; b=Ck4Zg4bfCSQVX1803TsGHmRA4h184sxMhKUf1y6udt50RJ1w+oiGRKWBMAakpKLHaf 44socKHMLSC9ThQdc2VGOh/rg0eUmre1xPJC82dOsHsMJu2bcDpxjydx/4PUedM6Jzk3 f9BSRni41SznWQoHSgvdDT1KTX8h90PIMED5FABnZK1LqvgogYAS8GSaIgNMPGeC+J8P zLNLm3ION2O8LNecpesbzEhgnJgSX5VTZ+JDX3TKiCAfUwAPrcC0VhSSRGtvyJ0nt04v M/6cXF0VC8ciynnj0z2YTVm1w5lOglv6TdDSnKidXILZOlYVJceqEImBEyPGTCNOZtMl s9FA== X-Gm-Message-State: AOJu0YxULl1sxlaXKv0ngYzifElMf8qD80gymCz4Ro7pQrZZyQOdt0dY XzcmeSL1v1WEw6MCrlv9WFduV7f3m4UzU+L1q5RlmVIsOh5jKbFWqHRZnak0wTf0XpcvI38k80Y sl8XBKezN83mYpB0oXE7q4kr1HfdHk7WjvKFpRkBE0W/cRnFYpgsrk+MtAeTjX3QQzBQKEwQS3f I= X-Gm-Gg: ATEYQzzudT8ToRy9hMsHfIPiT+UNtj+H9KwBLt8MU2TJA7kalY8kdvqkOaLXj18sXS8 RxKfmxTmdWbFi2+1PqseqMI9c0mDe3M+BFL8CfWU5+v8Qg+B/kIhbmKhRbJPOnM4ku1zZDTft9L o47DX9s42JiExe6b/5Awjo7Z1zSCeV+eYMBG0tqFGAHHYjwwLF73R+5VUii5nROvH2rRleDT6v0 h1N2CkMauXCvN8J4nd8Rk62EqSPBySTkOGbFv+ZjY+KPqHxAdLVjAmve9XgrNc4WvOhykgzeYha 4RkCG82ztA8Z/dwT87OBFir5yHh4JnarMQHnvtauFRl/RKJ9toLhJhXR0S4Hk+iyqhegvL9WqDV zKGa318ShpirpkJBZnCqDFLwhEgU2C0xEbm/8EgDcj7ChfVBkqQ== X-Received: by 2002:a05:620a:4002:b0:8ca:2a02:dfd5 with SMTP id af79cd13be357-8cd6d38f9bemr1747204085a.30.1773097549740; Mon, 09 Mar 2026 16:05:49 -0700 (PDT) X-Received: by 2002:a05:620a:4002:b0:8ca:2a02:dfd5 with SMTP id af79cd13be357-8cd6d38f9bemr1747199885a.30.1773097549238; Mon, 09 Mar 2026 16:05:49 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:ae20:597c:99b8:d161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae3d98asm33898478f8f.30.2026.03.09.16.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 16:05:48 -0700 (PDT) From: Daniel Lezcano To: konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: [PATCH v1 2/8] net: ipa: Use the unified QMI service ID instead of defining it locally Date: Tue, 10 Mar 2026 00:03:31 +0100 Message-ID: <20260309230346.3584252-3-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIwNCBTYWx0ZWRfX+B3OKnNsT9we LKaYCqqNRxGA5oewc9qWv3noZG2vvx78k0veLZgcxx+gsxSrH7qrhOfhU/2bXtKXrl59F6GBxtN LmnU75BlCG/2M8gw2Cm7y4UPytXgq04V8mMzZrTtjNYfLi7/z+YDMGYrvfZkfQI1fWokrjZlbWf wEZ3+kB3SCAqK47Wp3Mc+oytkwJ2Zl248HMZH4kK2BEKyGcg6h8SI/DcoU/+ZIiFEXSeqBGARFn nWAJEtHp48R3OXcmLunSx73p7Uja4MhBEF+yL5++tUOG3B5U87IH79W1hvIFO5wDyLYo8zP4F4h dRCnwWIFHcvlcjC4WOA4xu/381a9JP2MagiBv6eiPLwNh4Nqe49HG2HMXVoqFK5L0w0Pu8BqYhh tvpR67EtI0Mb4awvNH92Czz/VNKRE9oy8LB+gAQEmqVvq6idozbqkT+TNTrJ0l7MGP9uD6dqVbk dvE7/zMFwXCQNsKn9uw== X-Authority-Analysis: v=2.4 cv=OcmVzxTY c=1 sm=1 tr=0 ts=69af524e cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=shTvKy1OFHrmHVGPjj8A:9 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: EnU_hi0YwjMdpnqrKqZmC-J7-hM-W7yY X-Proofpoint-ORIG-GUID: EnU_hi0YwjMdpnqrKqZmC-J7-hM-W7yY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090204 Content-Type: text/plain; charset="utf-8" Instead of defining a local macro with a custom name for the QMI service identifier, use the one provided in qmi.h and remove the locally defined macro. Signed-off-by: Daniel Lezcano Reviewed-by: Dmitry Baryshkov --- drivers/net/ipa/ipa_qmi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c index d771f3a71f94..37936ad132a2 100644 --- a/drivers/net/ipa/ipa_qmi.c +++ b/drivers/net/ipa/ipa_qmi.c @@ -66,11 +66,9 @@ * determination of when things are "ready" */ =20 -#define IPA_HOST_SERVICE_SVC_ID 0x31 #define IPA_HOST_SVC_VERS 1 #define IPA_HOST_SERVICE_INS_ID 1 =20 -#define IPA_MODEM_SERVICE_SVC_ID 0x31 #define IPA_MODEM_SERVICE_INS_ID 2 #define IPA_MODEM_SVC_VERS 1 =20 @@ -484,7 +482,7 @@ int ipa_qmi_setup(struct ipa *ipa) if (ret) return ret; =20 - ret =3D qmi_add_server(&ipa_qmi->server_handle, IPA_HOST_SERVICE_SVC_ID, + ret =3D qmi_add_server(&ipa_qmi->server_handle, QMI_SERVICE_ID_IPA, IPA_HOST_SVC_VERS, IPA_HOST_SERVICE_INS_ID); if (ret) goto err_server_handle_release; @@ -501,7 +499,7 @@ int ipa_qmi_setup(struct ipa *ipa) /* We need this ready before the service lookup is added */ INIT_WORK(&ipa_qmi->init_driver_work, ipa_client_init_driver_work); =20 - ret =3D qmi_add_lookup(&ipa_qmi->client_handle, IPA_MODEM_SERVICE_SVC_ID, + ret =3D qmi_add_lookup(&ipa_qmi->client_handle, QMI_SERVICE_ID_IPA, IPA_MODEM_SVC_VERS, IPA_MODEM_SERVICE_INS_ID); if (ret) goto err_client_handle_release; --=20 2.43.0 From nobody Thu Apr 9 09:02:44 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05F16426D19 for ; Mon, 9 Mar 2026 23:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097554; cv=none; b=KRLLD+TpmBXTjf+L34QP2GBwTivpRXM0tENpocTq/UPpQigkHhgI44lmDTzJThhEA3qKZjbcDVDXEPSikP362CXKIXlOwoH6cm8NjKIS4Nq2qUdU6iS98U85Mzm3ZduIjGwiftiKNjN9/aZQWqoA3HwjSMTL+r1zXlel1IdQluE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097554; c=relaxed/simple; bh=QZQdxBzDREz32KOHpC6Wbf0TNGVbGzPhgBMYA+OuF1Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mZgxtGNaHU/f/OviEjqzwDbNZcKxbZNCUWKKaDUtRKPUF1ZBxkBQRcHdGyRh+Kaej3bFHgyNIYWySxkxsJmDkfM6nQ71o+MArnqMpNsswKfTRgJ/WrpJw6va/L146N764CQ1Usi6qIz/71X7K1WdOBacrvuIe8D+pyRhmTUx+ss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RdOiles1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LWmq9UZP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RdOiles1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LWmq9UZP" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HC5ji3280565 for ; Mon, 9 Mar 2026 23:05:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=03PO2ofFbk0 Yu5UA0mjka1WF4PLNd178/K38c0flSgc=; b=RdOiles10PVFNTsM+iN8mqyJAEY kLhkqbaC7CnBRxLlA4FssYmNKhQNycGzI6juLkAHvRtuzpXLnGxIHAbiBge3mT06 sdZOjrvEnZTmrxqVJb1x6EdFzDW/nHGtdRFao3ac/Y+g+o24BXIDHBfOLVa7FUk7 DmpcarEZxqgdUx/EefKsK+iK6bxGgq4Cp3hfOB4FryWGMKcFmYzwKGOjLkWYLj0y kBbEGi58WEdg4i42zYqUhKi1FK9+OIvOlu56FnolRdvOEJRAbRcxF4GuHNRhFWN4 WTxfDFn4JFdQeIFvDYQPvfCFYSh1c9YrbeTgXLlrnN2W3OtoNZKr19o/xOg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csqcybgmn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:05:52 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd77bc8186so2554238085a.0 for ; Mon, 09 Mar 2026 16:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773097551; x=1773702351; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=03PO2ofFbk0Yu5UA0mjka1WF4PLNd178/K38c0flSgc=; b=LWmq9UZPPbcP7ChKoM1E3dGiJn1hDoexA5f5WP/ahCjpT6u4OU1/2pnoWBHN50pHGI slAIApOTrSGb2PYnZrBc0MrFaUW+G+CoTl8GS56FMEzXFMHen+gGZVC4Ln4mCxCkG4ih icpYw7GHB90PIIWtTZrbxE4dFCj33/558hMpqFiQ7kOm4hEqUpPuXG+ApADKfH+6NS+Q 1eKLiI+vpzCrdI6xvkQzVv6atqCrxuq9E6ubY4IOspJZEcAjnNSzA2/c2K+XBi4M37ws MsnHDJGoYcd0dx0vOK+/g8xgHurkq4XYqwBQ5eBqkxPmDI2TS6hheoUlllDNkRY4YaLg uk0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773097551; x=1773702351; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=03PO2ofFbk0Yu5UA0mjka1WF4PLNd178/K38c0flSgc=; b=aHg3PV+TOBxM48vUN+c2W/q/25nYej7PtoGccDxURXpgrGZ+3LZzkfrPgdsubAPxxw L7m5rhHvVaDK5yoIrt0rdMe9+Pg72eer6Kjb69DD+CO7SpoxTt/Qhk39YTvu9nErfFL5 rUODYiJOiToiYh/1ys+Cn3SqX0GUAIUOLYkL39pGdkOZYu4Qz0KosyOtXo7vh2zLsZ5T A/wGJvgZr5vpd3ACTlV5N8jqB2rH0iD1o3rr2IK2KudbQvKav1bZRHzJFRbOPddfe5z9 jECte+VDy3QTqKDb4H+0a/MtdQKeUd/HiWsmBAOaRkwqyFafbCfnq4xk9lUvG4ezbb9+ yH7A== X-Gm-Message-State: AOJu0Yz4hvnbSkZVtwDWNcwdyY5XvvruyUW/wsL7DYdyMUijup9GWfS5 SX3jBQWT1+8UoFcfXTdIYJgte/DRLEXHXKx1HwWCQZvjFDGzR7PcVa7Tb4aViJ3t0fvby4zSV3Q hPpClpzI3UnVqMK2OF9ppf4vU2HOWdgjp8jRmygurGivY5SXmUXHna/EIA/y6YuYkEsfGvdK9E3 s= X-Gm-Gg: ATEYQzwdfiqEBtdzg4hu82oLdyjq0nmEWBeFBUEqboJqvJ1DlJWWBnBxH/SqitR7+oU /2cMe69xgVdiK7RUqknMYgLinigC6RNBlex+zM6ZbPQS9uMv1d2ZXO6lWzS1LTn16l9Sk2bjjOP yqB0nh6XvY4rN7xREMbBeTp5GhGhVbPWvBeAiKT4MOx/7sGmIfStEsELfTaN0SIIuVIcI93cjnm nEztwDCQ0NWoX/JAyV5JoubgyOvSLTz3uKX8wiIfUYvK4m+Gmkxn5cOTNYHhwMR+dJL2M6/blzk GvZZcuJjz/5xdBie54vEMq6qjc+8SVCs1/R9Yqu9lzqWIpRfooFKl3HkqXIaMF3NtxaWNW58x+V GVoTn2iqcj1Or5t3vNsex0U/IxHcznfKsXC75HnKPiJXGp2atZw== X-Received: by 2002:a05:620a:4445:b0:8cd:9584:6335 with SMTP id af79cd13be357-8cd9584736amr41475585a.77.1773097551408; Mon, 09 Mar 2026 16:05:51 -0700 (PDT) X-Received: by 2002:a05:620a:4445:b0:8cd:9584:6335 with SMTP id af79cd13be357-8cd9584736amr41472385a.77.1773097550949; Mon, 09 Mar 2026 16:05:50 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:ae20:597c:99b8:d161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae3d98asm33898478f8f.30.2026.03.09.16.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 16:05:50 -0700 (PDT) From: Daniel Lezcano To: konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: [PATCH v1 3/8] net: drivers: wireless: ath: Use the unified QMI service ID instead of defining it locally Date: Tue, 10 Mar 2026 00:03:32 +0100 Message-ID: <20260309230346.3584252-4-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIwNCBTYWx0ZWRfX/HM0UF3NtoXY 7yabkceMP3xmUAHcgO8dnxBSX7/VUwrJgri4jEeoJLZwBPAZ0Drtotu1i+ufO3hjT0Y9V9fTlhC w+B3INgbwurzmg5qYD1ggdCRV35Rnw2PNnZqtqqy4oHV/+FrocPcTEIOjbaHbfTvZdfm9v21tEK r+L4p4uoXCfEcYKh2UB311CA9OwBAg4oMprP2WKBoQy1tTCEsIlBk4sBrgNKRuxsQczo4Rn/VH1 BrU9276NlieWnFWcOyH/xWWpivF3/U5OB8aIzpAnqBYWLepqWh4vo42x9XKByHpMKn7om0ZaGvd oAXwH6SNQujTOVJxPqK8XQnO9/uLK7oFcCpv6yKPTFqa7Mx5GexBUjA0GHW2rD6BkTIxkNVOjT2 94mB26BbYkgzia9p5eWmRb9mvUtbNNZVDcvoLkEIzF/3IbMvJckMlScF2tSXQiXbGrz6ZvVgc6B p8cDb8zxmIf2FbvNRjg== X-Authority-Analysis: v=2.4 cv=QJtlhwLL c=1 sm=1 tr=0 ts=69af5250 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=DFXFU3FfpSgEbJi8yTMA:9 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: pQUD2wpD9ZLG9XL7k0W9LjbXNufyVvyb X-Proofpoint-GUID: pQUD2wpD9ZLG9XL7k0W9LjbXNufyVvyb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090204 Content-Type: text/plain; charset="utf-8" Instead of defining a local macro with a custom name for the QMI service identifier, use the one provided in qmi.h and remove the locally defined macro. Signed-off-by: Daniel Lezcano Reviewed-by: Dmitry Baryshkov --- drivers/net/wireless/ath/ath10k/qmi.c | 2 +- drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 - drivers/net/wireless/ath/ath11k/qmi.c | 2 +- drivers/net/wireless/ath/ath11k/qmi.h | 1 - drivers/net/wireless/ath/ath12k/qmi.c | 2 +- drivers/net/wireless/ath/ath12k/qmi.h | 1 - 6 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/a= th/ath10k/qmi.c index eebd78e7ff6b..4fdd0af415d5 100644 --- a/drivers/net/wireless/ath/ath10k/qmi.c +++ b/drivers/net/wireless/ath/ath10k/qmi.c @@ -1105,7 +1105,7 @@ int ath10k_qmi_init(struct ath10k *ar, u32 msa_size) spin_lock_init(&qmi->event_lock); INIT_WORK(&qmi->event_work, ath10k_qmi_driver_event_work); =20 - ret =3D qmi_add_lookup(&qmi->qmi_hdl, WLFW_SERVICE_ID_V01, + ret =3D qmi_add_lookup(&qmi->qmi_hdl, QMI_SERVICE_ID_WLFW, WLFW_SERVICE_VERS_V01, 0); if (ret) goto err_qmi_lookup; diff --git a/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h b/drivers/net/w= ireless/ath/ath10k/qmi_wlfw_v01.h index 9f311f3bc9e7..88d58f78989d 100644 --- a/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h +++ b/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h @@ -7,7 +7,6 @@ #ifndef WCN3990_QMI_SVC_V01_H #define WCN3990_QMI_SVC_V01_H =20 -#define WLFW_SERVICE_ID_V01 0x45 #define WLFW_SERVICE_VERS_V01 0x01 =20 #define QMI_WLFW_BDF_DOWNLOAD_REQ_V01 0x0025 diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/a= th/ath11k/qmi.c index feebbc30f3df..1397756d6251 100644 --- a/drivers/net/wireless/ath/ath11k/qmi.c +++ b/drivers/net/wireless/ath/ath11k/qmi.c @@ -3337,7 +3337,7 @@ int ath11k_qmi_init_service(struct ath11k_base *ab) spin_lock_init(&ab->qmi.event_lock); INIT_WORK(&ab->qmi.event_work, ath11k_qmi_driver_event_work); =20 - ret =3D qmi_add_lookup(&ab->qmi.handle, ATH11K_QMI_WLFW_SERVICE_ID_V01, + ret =3D qmi_add_lookup(&ab->qmi.handle, QMI_SERVICE_ID_WLFW, ATH11K_QMI_WLFW_SERVICE_VERS_V01, ab->qmi.service_ins_id); if (ret < 0) { diff --git a/drivers/net/wireless/ath/ath11k/qmi.h b/drivers/net/wireless/a= th/ath11k/qmi.h index 7968ab122b65..eae416db8b52 100644 --- a/drivers/net/wireless/ath/ath11k/qmi.h +++ b/drivers/net/wireless/ath/ath11k/qmi.h @@ -15,7 +15,6 @@ #define ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE 64 #define ATH11K_QMI_CALDB_ADDRESS 0x4BA00000 #define ATH11K_QMI_WLANFW_MAX_BUILD_ID_LEN_V01 128 -#define ATH11K_QMI_WLFW_SERVICE_ID_V01 0x45 #define ATH11K_QMI_WLFW_SERVICE_VERS_V01 0x01 #define ATH11K_QMI_WLFW_SERVICE_INS_ID_V01 0x02 #define ATH11K_QMI_WLFW_SERVICE_INS_ID_V01_QCA6390 0x01 diff --git a/drivers/net/wireless/ath/ath12k/qmi.c b/drivers/net/wireless/a= th/ath12k/qmi.c index c11b84b56f8f..f31cba7af722 100644 --- a/drivers/net/wireless/ath/ath12k/qmi.c +++ b/drivers/net/wireless/ath/ath12k/qmi.c @@ -4061,7 +4061,7 @@ int ath12k_qmi_init_service(struct ath12k_base *ab) spin_lock_init(&ab->qmi.event_lock); INIT_WORK(&ab->qmi.event_work, ath12k_qmi_driver_event_work); =20 - ret =3D qmi_add_lookup(&ab->qmi.handle, ATH12K_QMI_WLFW_SERVICE_ID_V01, + ret =3D qmi_add_lookup(&ab->qmi.handle, QMI_SERVICE_ID_WLFW, ATH12K_QMI_WLFW_SERVICE_VERS_V01, ab->qmi.service_ins_id); if (ret < 0) { diff --git a/drivers/net/wireless/ath/ath12k/qmi.h b/drivers/net/wireless/a= th/ath12k/qmi.h index b5a4a01391cb..2a63e214eb42 100644 --- a/drivers/net/wireless/ath/ath12k/qmi.h +++ b/drivers/net/wireless/ath/ath12k/qmi.h @@ -15,7 +15,6 @@ #define ATH12K_QMI_MAX_BDF_FILE_NAME_SIZE 64 #define ATH12K_QMI_CALDB_ADDRESS 0x4BA00000 #define ATH12K_QMI_WLANFW_MAX_BUILD_ID_LEN_V01 128 -#define ATH12K_QMI_WLFW_SERVICE_ID_V01 0x45 #define ATH12K_QMI_WLFW_SERVICE_VERS_V01 0x01 #define ATH12K_QMI_WLFW_SERVICE_INS_ID_V01 0x02 #define ATH12K_QMI_WLFW_SERVICE_INS_ID_V01_WCN7850 0x1 --=20 2.43.0 From nobody Thu Apr 9 09:02:44 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84F66426EB3 for ; Mon, 9 Mar 2026 23:05:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097556; cv=none; b=ct5j0zQdmiEWpaIP+zF/gCcwBca+6TQA6i50kNsOKEV76PUvsmKxMXI19PoNcjP7LKFfhXNmaVkReSeEZ72CnpXlhFl/PpmVhNz4Gi3+RS3VR6TXnK/Fe2s4MLdYPGEnTDfAS3+xwyu5CnIWWnb3llBmvqMXu25yYATinP1/Mt0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097556; c=relaxed/simple; bh=BaDqkDWGu+XD1uojRzTNHydt5ix2dxjskfbmR4KTJ9k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mzi9RKxQANawVaR1xy4swGtI+eAsQic8iuohyR+jtHhPZP2mU8OXSAXkKrHkinaOYyTFSrYHPQpSgQXw0RpOwC1Il387D5wlPibEctr2uWJ0G8U5/QGrH41GUBvhFYFqX6pKIjWCTPx9I5YWube1Buko4GoZ8dAQ7uNj5hOkXpY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EPv3YztV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NMD611H/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EPv3YztV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NMD611H/" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HBkQn296153 for ; Mon, 9 Mar 2026 23:05:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=auzznPiIzKm n9bZWwZ9h7mLY2h3ZNHzFBrhGQFkkIvg=; b=EPv3YztVJ+FAUct0n2jY0AEZbxq N4yJ5ZDT1QeglA759UBVXPrEh3zXHp5Ray5s7pgfyA7mLlCX3AQyJdv4N0XHVz1V OZ9QVTI8oCqhTWzLM+cVUnCNq+4M5Yzl97VoxT6SmJnlYgveq6RE7m8Y0lU7CCcx k8Haf9d+4068xXR+NUlHuEi8Xqxp2N3uCUYTJneVk3O8E/tX30xB4TcMIxeqWoZ0 JUFI6cMGgngrsXg/IZO2SB9y28JcPOBNpWnXBZTf8w6+yGT4I/WFdTaYfJcOf32Y WMB2yW2wjsiFRzhTaGFIC4a37N06tgo/lxuGc/eVVPmJ/AV+usj7OzLW6dg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csyfy1rva-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:05:53 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd80bea54dso1065805185a.3 for ; Mon, 09 Mar 2026 16:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773097553; x=1773702353; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=auzznPiIzKmn9bZWwZ9h7mLY2h3ZNHzFBrhGQFkkIvg=; b=NMD611H/h19jKpuLsVaSIEZmStieghkesArYWyGMCGWr5SFxYZngAP+FBROJe/lsSS K/adZlpKfn74TdinIBrHZIegYjsL/LU1xzbEqeNOJO+VF800E0Ko9v9fCbsvI3KKQJhn +F+gkU8beWD/RXhKXtAi7STEGjltqpOFs0uAZCL4QFObQFVzbKNV86yxc3Rp/wZNJx6l Zl8dGLD+82evulOHrsiy5GnDWGFlt3nlf/In8XAniBX6BexHUvyfErZHz6De0RZtHciz 48kkU+3UA3qB+zqG9fCPxaWdDJTd87fGTjipMzRupo2yZf/hc0AcbfGeLv2sMbwmIduP GzPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773097553; x=1773702353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=auzznPiIzKmn9bZWwZ9h7mLY2h3ZNHzFBrhGQFkkIvg=; b=Vhi9s+4DvtJit1fmA2lLYjITGW+xShS8yZrn77DSO0fLSpzgwc6PfmSQMuK/vV0YJu C6hAGxZFW2z9gd39WU6cAFBrjkK1ogRFD7myfypdvIHfe59RNB54VgJSrd6YRL7EkH/7 YsdKfeeIWqmsJn9KwH4vWy0dcWgAEj6lN+oRUd/z6PiHSWebI5F2iZHTofG7mvp2jjIk x7Hpk/ykKaawYSKB7uNqB1A2sR/4XzCS+oyo+ykVtP9WkW0HNjlmKIEm9fivTrG6S5C0 jlpd362LDR43ozeKlQQPPaPc/nyW3ZjeJRu8nP3VxYwXERxpV6pTvuWyFN3nwCP7O3xt gMFA== X-Gm-Message-State: AOJu0YwV6ubSBokIOjcv0WB8sxeR3I/eNJfzDgtgLRiXDgClDcimoECr ZsBoJERgcpKewAfFnkeOWwhlZ6ERYTwbvfR3qJZzZU1VX8Xv728jaEJjQihuFaDn4uHyYZH+4B4 cgu/rQYiVBauAL+GolGI7jOt0+WadhL17zXlqzZV8/aJLqMhTKHvrMhUn0gauGqKuB9A= X-Gm-Gg: ATEYQzx7uhZcFk4I4eywIAPiz5QK74dM0Noi2oTiU8D5aSaF4okZvOskeqGiHHlTcZ3 Hk6sTeEauyta0RVheCtJ+DPzvahyg/y2wYawAdltK3utBzZ4WOIJSa3Ge3nlokfan82+ZyawVOG Udh4Dk+mZP1M3hXV5TDQY+a5++RgN8TEiC7ES6PGDYxOOUWLV3XBSjQ8wJnOTS6odRJsTg4vs8E 8d99Lnu8NAStthKfr/9i0cj2brgRcc3H0bp+3FMSbvhbsSsYixFDdzea7mm2TpoDat6/+bUmy3K YIX1Q7iY71BqSgiqZ3aJR6VGdZLi9OfEHOksquLVdPu0laTbifWSSfdlUOcKxDjWPPxQ32xTSS4 yZkthxrrIXMATpXw4jmiUTvjeJZy+X4p8aMel5tSI1jIvjx21zA== X-Received: by 2002:a05:620a:269a:b0:8c7:140a:7dbf with SMTP id af79cd13be357-8cd6d4fcc9amr1622778885a.77.1773097552996; Mon, 09 Mar 2026 16:05:52 -0700 (PDT) X-Received: by 2002:a05:620a:269a:b0:8c7:140a:7dbf with SMTP id af79cd13be357-8cd6d4fcc9amr1622773385a.77.1773097552533; Mon, 09 Mar 2026 16:05:52 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:ae20:597c:99b8:d161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae3d98asm33898478f8f.30.2026.03.09.16.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 16:05:51 -0700 (PDT) From: Daniel Lezcano To: konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: [PATCH v1 4/8] remoteproc: qcom: Use the unified QMI service ID instead of defining it locally Date: Tue, 10 Mar 2026 00:03:33 +0100 Message-ID: <20260309230346.3584252-5-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIwNCBTYWx0ZWRfX0oKelARvFi3g tNe9ksz+li/7C6kdLjDiHmcs2BC2dgJXfOli0PTv7UKziWhuOItIJU71bVw2D14leISptbc7Yji rbdQuMqO1rA7n9pSYydkBDpGf0yg0L0kUdqaGW0eHuD+xJP08ihMWcfksqbYN0u+UqUdyTemfPA i5BLxuEQMnmOv/SQcS3aZEbDlz9sDxLOaj63S3dWQDSnRZsgZv7imKalnfDYS/kQOKG79Egani8 y4djtwufytUpBjyrL5s63X/z3A6vf1dH/kR9e7ET2GfQ/4EnczgY399sQVcJqG9Z6dZBTzFjr93 pKkREKilevfLPV7AGMvVQgcWskNXvrWlTbQEQ7Uh2HSSFfqYMnarot7+FxGlq3OvuEv96r6Q3g8 /fj3EZMMQr5otf5tq9PP9rhaCK2O1htfk5pG5l+O/A0GRdUL+QAX2iyEgOVw7NR545i8Bvns1Sh imauNlnkwyL/jhZcC3Q== X-Authority-Analysis: v=2.4 cv=OcmVzxTY c=1 sm=1 tr=0 ts=69af5251 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=LIGoIQd8k4OXu6S84WYA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: M75rSQjGlFmlt81RaXXNET2Vs3aAVPQn X-Proofpoint-ORIG-GUID: M75rSQjGlFmlt81RaXXNET2Vs3aAVPQn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090204 Content-Type: text/plain; charset="utf-8" Instead of defining a local macro with a custom name for the QMI service identifier, use the one provided in qmi.h and remove the locally defined macro. Signed-off-by: Daniel Lezcano Reviewed-by: Dmitry Baryshkov --- drivers/remoteproc/qcom_sysmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sys= mon.c index cf10e8ecfb8f..5bd4147f1f37 100644 --- a/drivers/remoteproc/qcom_sysmon.c +++ b/drivers/remoteproc/qcom_sysmon.c @@ -677,7 +677,7 @@ struct qcom_sysmon *qcom_add_sysmon_subdev(struct rproc= *rproc, return ERR_PTR(ret); } =20 - qmi_add_lookup(&sysmon->qmi, 43, 0, 0); + qmi_add_lookup(&sysmon->qmi, QMI_SERVICE_ID_SSCTL, 0, 0); =20 sysmon->subdev.prepare =3D sysmon_prepare; sysmon->subdev.start =3D sysmon_start; --=20 2.43.0 From nobody Thu Apr 9 09:02:44 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35BFF392832 for ; Mon, 9 Mar 2026 23:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097559; cv=none; b=dd5nZMEnBOy3iFTthRqrEPhcSbhvedg68jf6jPuzHr7UosgGqzu+IK5HogmywNwakg5jJTErU2+pzCMkYUlbC0Y0p4nnjj9X28gm/mlmXI1DIQuO4mheSFMiVM8tuewvTsr6wj0nraIovSLT+GSjZtARdGwYx+dt2w8jxOQmvSc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097559; c=relaxed/simple; bh=ulxSsa7188EBz+8PhYCrmatbVk0Sh+N5SiDD0XnhX7Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=srCAaN1Yi/XPAgK4F4d1H6LSucClEoG9wRkYCsYsJDUuH3yss39BqGPK8fHhm4JC74kJAftJsgKex5yMZi13z1saED7kg6TGE8GZ4uPjy/y7tSTinS0zohQiVT7GhDjk7ZfTpz37gks7Qp9dSD7jKt43eRXjTQJIHCtn1E+GRxM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PaYhT6ey; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=heE5DFLZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PaYhT6ey"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="heE5DFLZ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HBq0b1203558 for ; Mon, 9 Mar 2026 23:05:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=/gz4Ge3MHwk UDTTkujrW9dZ+6p+ProQlBVOR/K4PwRg=; b=PaYhT6eylqd83bpMQFYbYaV0W5S mkzH1MgbfuAvBJ/7ojSkvwmB2brtv9Dy0UGX8UfrUnxTxvdkTdNan6OUS2+NvZ3e sF4nS+5Yv9L3QfuMDCsD6Y+UAuJmb43YTmwqFS/Gys81rzF0MMxK7v08rJZhdA1b WV2fQRVJm2zf+akHmBl5+inla5z3FhhzRUmrUlgsAKzOM7bgrX6B1OO3v2UxpUMA AYOSjkMi2Tv+TU2zS8pwaDgeJpYWAu2pVQBaPXzhjOTfhZ+VLz3I6w89RDpVfuLp GxB1r5AI7dmq8fbxWWH/M/nZkJFhPG1GwJ7GLHTCooGJvaSAAf/y037ZHYw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct0329n3k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:05:55 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd900cd3a7so454438385a.0 for ; Mon, 09 Mar 2026 16:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773097555; x=1773702355; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/gz4Ge3MHwkUDTTkujrW9dZ+6p+ProQlBVOR/K4PwRg=; b=heE5DFLZZBFfzHQy57r9wHCcM5YyZkfzpeXU2HCzt/OvFiUW/GmmCMHNUKMFHibU9c yP4bGFgz/mapyRq735LKe9UDNwcX1Sm3nJhW8scXKUSJvK+xYC6O1p2h/Sh746jQfc9f 8dU9JpiWIOplw9CKZL4pUEe4UWJ1vC1lMybwsRSMqBQqCMFgU6f9IGs+f6urSWiIYHzu yi/zvoGtPs+CGXb6QOZDdISu7Bt9YXMJ1EgEhNevR+KEvdK/S72EbScaUAZYCWCbyfUN U3J3ya5ezlxjBm5Y6GZ1D9s4eVEZrJBI9YDE7oP7FprjG9WvTGPmjW85bODcPm/CXPem OjgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773097555; x=1773702355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/gz4Ge3MHwkUDTTkujrW9dZ+6p+ProQlBVOR/K4PwRg=; b=v78RxYdVJ4wi1pLLYSSdD3jOV0pVbijKQD1uWvcFEaqGlZE9MKf/cbqnp0ZOFMuMp0 aQpsP+/5at7LFcABN9ZoYKrfIpw4covTJTUyasmR1duIRvjmMXTGXLGtsyCTtCO9tulj HlHGKe2hNZ8rBef756dF4sGSZrYULkWK1hQt8EZqvjjVCZTxvOJNZqiM8BjwfZWvJqQ+ Gk67zCZ0VmVIkcHhRkemeIcs1jTo++3I5ajs71QoBEAAtc3coWR8KhAibZliRobgJdDQ U4lX0EWi5gzURrT99Ianf99+A1BC887NbLNEWvWuk9ntMWIz2RhCZx9HdHdS4ykgMHcP xExA== X-Gm-Message-State: AOJu0Yy9uB5W4N6gYTOra4hYMU7Z5e8jVTQDmwHSnigM1rTMGEC6JugJ xgJlrj00RHR8ckPnzAm4zslEEskMwoXSzz+VkK4mEW3ajxALCyzLKZs0kDH6EryB0Ctlz2O/COZ 68zRvvbOc3FbkL2prtWwqAe+hpe4nsIWSOVenKUIrnN5RKfiwMJf4AyQ0qLEmzsuowuE= X-Gm-Gg: ATEYQzx/9rIOIBEJr1Qp3QvDmXRk2yxVJjxIeJfiEYwlOJNYUfdV9ilrS/73ycjH5tZ dlivmPob5G7k72HmCSa1G1ysEr6BN2Xk1UvgNAPYhXY23Tie5QOTu8reK1k0F8nDVgugyFH4leY zJlUYP/OXBeOB7mOH7HxduRkmKi5Bj++Ycpu+iHWUza+1KCMJbIKmL1qJE1EV5xC5CsQOAlNO4E r9b9jgSTBiZHIarEg7C6ZAx+Y/79XbFXNUboqd4z4srV6Ls/qwOQn2MWsPlRG0EimPGQsxqWZW9 gCZLEqo8p0UuINLGso3rj6x2ih/OfvugpVvza8b2TxYIfswxcczy7rW9vruTZ5iofCHSa953RJ+ YEj6DaIJx1OmwRZp9DvQiLOjF7YtOCgzApTvqerZy9QkCbrfUSQ== X-Received: by 2002:a05:620a:1728:b0:8cd:8e8c:2076 with SMTP id af79cd13be357-8cd8e8c242dmr439789085a.77.1773097554727; Mon, 09 Mar 2026 16:05:54 -0700 (PDT) X-Received: by 2002:a05:620a:1728:b0:8cd:8e8c:2076 with SMTP id af79cd13be357-8cd8e8c242dmr439783485a.77.1773097554104; Mon, 09 Mar 2026 16:05:54 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:ae20:597c:99b8:d161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae3d98asm33898478f8f.30.2026.03.09.16.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 16:05:53 -0700 (PDT) From: Daniel Lezcano To: konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: [PATCH v1 5/8] slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of defining it locally Date: Tue, 10 Mar 2026 00:03:34 +0100 Message-ID: <20260309230346.3584252-6-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIwNCBTYWx0ZWRfX9WC031O31nCK fFy0v+a+ZD8koYuB69wYaoaOKHWQZs2GwAOPAxalJcxODw+/4P7T5U7nmIuyLuaQd1PKiB5VdOB tdVp8hJmWudbZ5OF5gbfe8FdYa4uR+wR7ydMcFhNmzL3vQsM32VGTkZSJaEVIuiNCdy5KKJEWeH QWBxKyecD8HOTzSumR8d1lxgeVgtY/ZNcMASNxc+O+tJl4NJhfi8NK2yvMMJejnDm66PxxuNVWu uncSoyzUBFQ3ZqDRxWxS+wtYBM3Kz9tMNrAYj4DvV6mueMCoI7cClJXGw/4JDA9Z1oR+Ry8MHq0 sAOCOeZjpLeB3DidZtr8liOdOTYy00qLcW4Yu6DyiEWFmz5QcNxQvs7Jdrvk2hrn8amiqZNFWFk cE5mNNYpRMAkWqn7kXsqsZfhE8tiBudPjB5aNZYxdz0OhCQ850pW+b8jA3sXnJgImqFJRHkAqYB b5eDcFObg+PGCCyocMw== X-Proofpoint-ORIG-GUID: 7NocoXDBaYbi0XF8D9WKdy-_xkoDEtJ5 X-Proofpoint-GUID: 7NocoXDBaYbi0XF8D9WKdy-_xkoDEtJ5 X-Authority-Analysis: v=2.4 cv=WtEm8Nfv c=1 sm=1 tr=0 ts=69af5253 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=PhtMypRRY1SmXJO8NnMA:9 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090204 Content-Type: text/plain; charset="utf-8" Instead of defining a local macro with a custom name for the QMI service identifier, use the one provided in qmi.h and remove the locally defined macro. Signed-off-by: Daniel Lezcano Reviewed-by: Dmitry Baryshkov --- drivers/slimbus/qcom-ngd-ctrl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index 9aa7218b4e8d..0b88b8577bdb 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -48,7 +48,6 @@ NGD_INT_RX_MSG_RCVD) =20 /* Slimbus QMI service */ -#define SLIMBUS_QMI_SVC_ID 0x0301 #define SLIMBUS_QMI_SVC_V1 1 #define SLIMBUS_QMI_INS_ID 0 #define SLIMBUS_QMI_SELECT_INSTANCE_REQ_V01 0x0020 @@ -1408,8 +1407,8 @@ static int qcom_slim_ngd_qmi_svc_event_init(struct qc= om_slim_ngd_ctrl *ctrl) return ret; } =20 - ret =3D qmi_add_lookup(&qmi->svc_event_hdl, SLIMBUS_QMI_SVC_ID, - SLIMBUS_QMI_SVC_V1, SLIMBUS_QMI_INS_ID); + ret =3D qmi_add_lookup(&qmi->svc_event_hdl, QMI_SERVICE_ID_SLIMBUS, + SLIMBUS_QMI_SVC_V1, SLIMBUS_QMI_INS_ID); if (ret < 0) { dev_err(ctrl->dev, "qmi_add_lookup failed: %d\n", ret); qmi_handle_release(&qmi->svc_event_hdl); --=20 2.43.0 From nobody Thu Apr 9 09:02:44 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 717D942847C for ; Mon, 9 Mar 2026 23:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097559; cv=none; b=X3Gx10WJZYuLgBwJqe7l61u0f1w28URXDfI3l5hbHcSdpnmpLVQ9oFU2ttiR8ogrKFyl/4je/QEmo/ffinvaaRyEw+MprSrVPmlBWk21PH9P8LnQWtIbLWEdrLmhpGeINn8KcMj3NhbRLcsIyblOTpak2ROUoUE3pptMgCLfJC4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097559; c=relaxed/simple; bh=gSGrdfWBD1PJQNA8FSE3vNlGaG4+Xx3EyKe0Xq77gxo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HaTzfQoCGJJpin0HFlumh6zzXtMBvzX+QPJxX2Rn7VP5Bx6h+S7GekwTFPYrJKQXslzQAOUt2fPx+ejvtu4zCyNs90P13fBxPmCZ8fXahQA4GPKi9oGKwxvP0ZJG+D/o9V17MFyrGyGsxF2O15O4DxCY+3XOlPb5OyI+oIeNSK0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ifd7yez9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y1jsX6D6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ifd7yez9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y1jsX6D6" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HC0KK1203723 for ; Mon, 9 Mar 2026 23:05:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=xPJuWGqmD+8 ZGPeNWjPXHXFYrZ4UhGUHfAbfp5Y2vtI=; b=ifd7yez9Im1NWd4QlgNWMkyW57W tVINyWDwUayU0ofvyVrNXpJlPZbi5BzPstvukcndCx8+sBUFqHybdIZIswuEEhzK zmFpSttCgyQIzDo0Uwgdl/0FaMmmN1EjgnaCA4AQmAxAFh50YkxYu49Gn997mxRc S575adbLb8WMzcm90Y2nFu6XMVgbx1fF0IPOGRUXNpT3vplyiumkPNTVWF65gXp6 n/mkmfTxImEfRtoCU5AyWCa8kx51DE8gFX6qwq2zP0hpXCvTgGH+HKqnmqVBKNzL PXY/qaHQigjhC7ZOOOfC0z4CflOArbZEHdbza4Mjlv/EpfwKbVd4mpZCysA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct0329n3x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:05:57 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd773dd39bso1734172485a.2 for ; Mon, 09 Mar 2026 16:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773097557; x=1773702357; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xPJuWGqmD+8ZGPeNWjPXHXFYrZ4UhGUHfAbfp5Y2vtI=; b=Y1jsX6D6D+gLOgPuFxjayg+3QDScUD1CtS26lwPEkmuoDWRju3/eG+yepQujaaYkbA SKahGwmiLonxF2bQ7PATwaJK19e3T+fazzoiRPThmJ0Y+f4cBgSjiTDp1mntehlQskZg i06XNupQTr5Jva01NbnYXbkNU1h+tebSH1FAgnf6hB9CdHzgIrz+gBAbE0bpDbcUrhlf xcwIblwVrRA6uFthIKoEsI5+NYTpoQ+hZlNliKiPqD2UuADgTRFXFXnAu+vfAjL5Velw nFa+bGAHZfybtW20rQbA3b5TKcCe2qzOWsupZ+PS6oHabzqZtPpo+KUZG5yNcxWKH7w5 iY0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773097557; x=1773702357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xPJuWGqmD+8ZGPeNWjPXHXFYrZ4UhGUHfAbfp5Y2vtI=; b=iEo6OHvDtbJbWX4YTIqFuSrvPd/cqY6nAwIgnRXkLtD7ENxgFDvfqxzjWlVH6kxOYB jS7mtqoTMLDJB80LG7f0hgHUlX3KsT/VZX5xFhpX4iCUtmvyU6SLl3/9ktLKWeShZimg FCCuqRw61FjBFBYUFNHBO8RjBrF1PSzvZvZK8Vnhqe6TFuHwvaoNHbwGEWRTDziirTlN YcQ2QYq9WrHGdsHIdGao5yUUrZQ9Y/fSTUW3eQfsBHpZYTqcD/Zo/Oq6EbiGQ/hWtmuS 6h8hegfKkCgArmifBo8T7Mw8/bqX70QQSu+dOhrjEYR2LLAdA4Utz5y48CF48nShNsgf ECNw== X-Gm-Message-State: AOJu0Ywiaxcmh+M47zhVWze/Q6Mi3BsOLzy60Y+RVL4onviuKGqsoNGo jKBJ0LxspRuV8ibx2Jiz3sTb26fVFDX2L41ezLNX01BJCjKehMx23hKL/Z96gklI/mCQWKBv+X1 ZxmQLq1b0Rl2WhbQHndAIOBPRewowC6aoKtMAbEt+wLhTCoJhlTOAmIrYoKxF2EQ7aFg= X-Gm-Gg: ATEYQzwCWLBtAPc3n+i0ek/vVil1zmJOGtRzkXqH8C9fbchpvCWV/HmPY7owvFDVYNL q+hMOA0Uku0yn8DhVN0TzgEGfzeWg2M7pWt4p1P2qvK/6hVoAIKZWumdjCt1xB8v6LqpQ74h0w7 LBXNwzanYu25Ja9SzS31kImTfgXr1CmsBMdRPvFJfe1eBIRllWPzWrCnLy2ESN2udg6LMA3/Yx3 2h/rVl/bOTWTYoR4rgGVO1DKObk62CvE8HphMUumGzn0nONtqZGijMUzeBA+SByOZfhL8c6z/aT yBV+H9DtvTetkmTTJwF/UwunoYzs4AYyWX1Huhfd4MZx/S9W0NTnjrlho3eObA53uY87iCgd3DX Ti6Vwm9WzJAl6H8CUvH8ia5QOAU9KzQtT5tC+7qvwshBmKq/IBQ== X-Received: by 2002:a05:620a:444d:b0:8cd:8751:2b26 with SMTP id af79cd13be357-8cd87512fcfmr673414985a.58.1773097556816; Mon, 09 Mar 2026 16:05:56 -0700 (PDT) X-Received: by 2002:a05:620a:444d:b0:8cd:8751:2b26 with SMTP id af79cd13be357-8cd87512fcfmr673408485a.58.1773097555998; Mon, 09 Mar 2026 16:05:55 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:ae20:597c:99b8:d161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae3d98asm33898478f8f.30.2026.03.09.16.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 16:05:55 -0700 (PDT) From: Daniel Lezcano To: konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: [PATCH v1 6/8] soc: qcom: pdr: Use the unified QMI service ID instead of defining it locally Date: Tue, 10 Mar 2026 00:03:35 +0100 Message-ID: <20260309230346.3584252-7-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIwNCBTYWx0ZWRfX6/OxioCNOC3a BzAzNRr/JJEzniUIiBY1b/5ATHGYMSNSrMGO+9zAACV/bZP+zPavQvOZTUrSySvQRMO0d8laNZ8 J3BAELBTJeiIIzHV2lwd80/DQesmgohtmMkizndkLIamW6Lp0T001ZSGqHM4C+MPAJF/WvB73N5 styge+ixnTCmbluMWB4YBcpU3YrMm6Ajqw0veRBbA/qYEgb3Vw4XMtaF1b/3IPEP7+SCIJKYmpW Z4JmyQZJv+I8ocDyvwOhp8BQCkZjYMWkHDZsexMn4Zd9pnukFwBIP4BD4r6fUvM28heFSjlns+6 6p7kBZxKgFS9JHgQoR9vQbEnOD7+g3xpsMJBxZ741sEfapJ5QwrvfEFxYVh5Ut7smscuEiKNimf 4sPCkix3XBDK8ysCaKLWCtRijXj7YPbxWtSQv76m9nYnJctnBKiilML8ut1DBDEJE/qIaDQpUSq 9MCUbhRBLm+G0nD0jkg== X-Proofpoint-ORIG-GUID: fEg6SACpdQRQY_b4c66HNYCrl5hYzgrv X-Proofpoint-GUID: fEg6SACpdQRQY_b4c66HNYCrl5hYzgrv X-Authority-Analysis: v=2.4 cv=WtEm8Nfv c=1 sm=1 tr=0 ts=69af5255 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=P-X4VuwvMnWJEdMca_IA:9 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090204 Content-Type: text/plain; charset="utf-8" Instead of defining a local macro with a custom name for the QMI service identifier, use the one provided in qmi.h and remove the locally defined macro. Signed-off-by: Daniel Lezcano Reviewed-by: Dmitry Baryshkov --- drivers/soc/qcom/pdr_interface.c | 4 ++-- drivers/soc/qcom/pdr_internal.h | 3 --- drivers/soc/qcom/qcom_pd_mapper.c | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/soc/qcom/pdr_interface.c b/drivers/soc/qcom/pdr_interf= ace.c index 72259f489075..6d879e1540b0 100644 --- a/drivers/soc/qcom/pdr_interface.c +++ b/drivers/soc/qcom/pdr_interface.c @@ -523,7 +523,7 @@ struct pdr_service *pdr_add_lookup(struct pdr_handle *p= dr, if (!pds) return ERR_PTR(-ENOMEM); =20 - pds->service =3D SERVREG_NOTIFIER_SERVICE; + pds->service =3D QMI_SERVICE_ID_SERVREG_NOTIF; strscpy(pds->service_name, service_name, sizeof(pds->service_name)); strscpy(pds->service_path, service_path, sizeof(pds->service_path)); pds->need_locator_lookup =3D true; @@ -678,7 +678,7 @@ struct pdr_handle *pdr_handle_alloc(void (*status)(int = state, if (ret < 0) goto destroy_indack; =20 - ret =3D qmi_add_lookup(&pdr->locator_hdl, SERVREG_LOCATOR_SERVICE, 1, 1); + ret =3D qmi_add_lookup(&pdr->locator_hdl, QMI_SERVICE_ID_SERVREG_LOC, 1, = 1); if (ret < 0) goto release_qmi_handle; =20 diff --git a/drivers/soc/qcom/pdr_internal.h b/drivers/soc/qcom/pdr_interna= l.h index 039508c1bbf7..6cd8cbe26822 100644 --- a/drivers/soc/qcom/pdr_internal.h +++ b/drivers/soc/qcom/pdr_internal.h @@ -4,9 +4,6 @@ =20 #include =20 -#define SERVREG_LOCATOR_SERVICE 0x40 -#define SERVREG_NOTIFIER_SERVICE 0x42 - #define SERVREG_REGISTER_LISTENER_REQ 0x20 #define SERVREG_GET_DOMAIN_LIST_REQ 0x21 #define SERVREG_STATE_UPDATED_IND_ID 0x22 diff --git a/drivers/soc/qcom/qcom_pd_mapper.c b/drivers/soc/qcom/qcom_pd_m= apper.c index dc10bc859ff4..bb60b5c40554 100644 --- a/drivers/soc/qcom/qcom_pd_mapper.c +++ b/drivers/soc/qcom/qcom_pd_mapper.c @@ -656,7 +656,7 @@ static struct qcom_pdm_data *qcom_pdm_start(void) goto err_stop; } =20 - ret =3D qmi_add_server(&data->handle, SERVREG_LOCATOR_SERVICE, + ret =3D qmi_add_server(&data->handle, QMI_SERVICE_ID_SERVREG_LOC, SERVREG_QMI_VERSION, SERVREG_QMI_INSTANCE); if (ret) { pr_err("PDM: error adding server %d\n", ret); --=20 2.43.0 From nobody Thu Apr 9 09:02:44 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 411C4426682 for ; Mon, 9 Mar 2026 23:06:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097565; cv=none; b=I/xGdz20lIwnzMcDp6YrHsur3FKHkeTy7G6Mf/oWAXZZ91uaf94LrtAkmmliOB1gzIMXSWow4/YaEAXrScD9MlZggPYLT0d/McIUVKX3XI9fBPxqA+/Av1pf9D56JTovhYkHmhM8/5HCbOcmyha1fchYMt0fdhKqUxa0QBCRDe0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097565; c=relaxed/simple; bh=Y5kmOc/Td+3kz/MbZfYNPyjwrYkMruVLbGOtRAiAKz0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lLuulj2KRXGhOBj2FU0/lDPm7hL2Bp1h1MtxaGENSJyPWE4rv1I1Z7ylBNIA1YMCHh5j7/fS0orhM5Mc+Afc9YDqWQMtpbBDFT10/Nulk4DU7yOeUBe47pZHtOxZUqFFtaRwCXPdl3AUYK+xiEEhPzBT1+ydUXr41uQeqQ6kwkM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EnmPJzaX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HjDTeJsz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EnmPJzaX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HjDTeJsz" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HBq0f1203558 for ; Mon, 9 Mar 2026 23:06:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=o+8grnDyx3a Y04II25yHs+DhlQHwGyE329UXeTulGfo=; b=EnmPJzaXDKfHbBKit2i6OzOm42b lS7sFWuQdyT6nOJsixiASHIu6RV+GBs7xstRQSxbPvjcChqJJ9XpdtxtEefvRUJ0 /vzUYoWy6seDLrKnbfnBzBZ7VHyqTEwYNlJxSa42KZQ35lhO+qqrwgr0MhgF2v2u XIUOlYcxN0l/SiTaVR+/4vyGrXSRUNY4xGr02/UBTsA/bgKRuSiv0R0QaNzhBiq4 c9maWi3bGH5wkaI4/sbRIvQcfqVK9l5BSHbTV8yOOhJoz5OsXsJifEfv9WwX4F3p jdImAMabQQwyG3m/dV4KrPkxvDG2ukxU3wSswURC0mqLM6NZKINavIDuW5A== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct0329n51-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:06:03 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-899f92be718so341576566d6.1 for ; Mon, 09 Mar 2026 16:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773097563; x=1773702363; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o+8grnDyx3aY04II25yHs+DhlQHwGyE329UXeTulGfo=; b=HjDTeJszeb9Q3Zwb8jX/rHo/6iVYdGgz+RFLTkKOiy9ET/j6T4mtZ3sJjfgYExcHPM S0XbQmXwK5M4LXvWbjKxqA2hqVWat/67xWaVKTOBTyLS0jQWg8TAAOTF5v5x+2ZBt73R 9CCKauRusnnGy5Z1w07WkGCB3G8fnQTlWKO9Jb4Cs2b9/Mii6N3BaDeBCz6MxDz9PknP 6/BCgC5yEYaht2N+ILHB9Zx14lhnGp+sT5uPNWtqhv/C53/BFgAXKUKp5dJhiMw+vzbV XkE0B9dWYgWMIQSf94mvtlHDav+x3sRAoJBiCjlpAMZjjOqHbG64m7naa7GojNECgjs8 xF+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773097563; x=1773702363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=o+8grnDyx3aY04II25yHs+DhlQHwGyE329UXeTulGfo=; b=iYUzswvMmxnFKvZBgXzfWffldy9AuQhEFTScrleZ+jAy01m45zIqxCLPJegc4I+nsp t9fvsjINJ/naOH9u+W89eEnF9zX5LtlkvvdnZAA2hBC3F2feRKp7ItoeiRrX/Qd6ja9A V4ZQaU/AH/otglJ+aGyRcQnzwwTzvU0YixDJH33HooDmWx1LqmtsVvN/tqeiIpgHeZAF 0SjcfxoNpK0GwdJhts7Ws8Rw/wuiPTMrjbHNpd1Ym6Fcn1u/Bjbm51XUD1uSgHMOVBlq 3lgDFGru31uiZygOsj8rPwopcBswi4ySHx172rMSZkYh3/N/MVKFao4ifKU1JwgX8Saz Q4tA== X-Gm-Message-State: AOJu0YwS0VUeRp1IapeSFjEK3HCt7IHq7v42Z8iTkGKIRVMPoryu+Q0s wiyIKd9XnwQNbaBW2uQyYdMyR2CtOI2LVlaVZrbeqXR/IzVNowjqP468ZtQ250u4C2Vf0q0D4Ay gIpjrE78S/TY2eYE0bXpPvLHCU49uX7m8dtF6wY4/0BvXVjOpUd9WLL1u+jq9YGxLcNE= X-Gm-Gg: ATEYQzyj5cibcMGI4phWWFoEyoMTy8FVFMdymLN87AFLpbtvgeuI+P4v5o1NyIvCLua tg6tspqD22LBAAaC3j7h3T3G9vrIPCXGPtWaAIuj/yaan9X/QR4c2eNQqHUX8gfZLyPaDOQfaz2 PiXxU2Od98/INeKUcN57x2aKqQXlmbCSBjuWpoXQ8FWX/IilD8LQVm/BwuP+YNwBOpGG5UXYNCA QWKbNxq+PpimsPJxRu2eTw3mFFz/jN+FVcyPOJgi9ATHOmx6QoooFAjdvN1nLPXntt7LL1OkfsK hHJ2rvLERP+2dUpTa/2oaK1bqCa4xVnBnlXwcWapAYpfBboGFMPERSgNst20SrwIexJRrYjSF2N qbYzSq242oxuYrXuaWDRYyNrEo8/CF//767M/tqQga02hOQcN6Q== X-Received: by 2002:a05:620a:4044:b0:8c0:d16b:b0a7 with SMTP id af79cd13be357-8cd6d340439mr1568428585a.2.1773097562702; Mon, 09 Mar 2026 16:06:02 -0700 (PDT) X-Received: by 2002:a05:620a:4044:b0:8c0:d16b:b0a7 with SMTP id af79cd13be357-8cd6d340439mr1568423485a.2.1773097562240; Mon, 09 Mar 2026 16:06:02 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:ae20:597c:99b8:d161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae3d98asm33898478f8f.30.2026.03.09.16.06.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 16:06:01 -0700 (PDT) From: Daniel Lezcano To: konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org, Erick Karanja Subject: [PATCH v1 7/8] ALSA: usb-audio: qcom: Use the unified QMI service ID instead of defining it locally Date: Tue, 10 Mar 2026 00:03:36 +0100 Message-ID: <20260309230346.3584252-8-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIwNCBTYWx0ZWRfXwV7hqktTG7n+ gG7IIJTIcxDvwi0Tx7T7Rhoh6kFEagt+Px9JuMMRzORNpiIZUZi2Q4kpjyz5bibtVrEXXOflXjG qSNVbH8rS/i26YXGKoXJtKpQrlwzTwWRKvAVNSBZW7KTSq8yL7WCEznsh50I+p0kwxWw+JMr0ml VCLqEfNCeezx8HPPDxJqA8ZdJz5JWfurSWUkG/s6no/kV3WABKN976JNj0Tox8KDIMmcOAiWfYe bTIa3dJ9QbeZzOE2DsecsAxxX5D6+Qbe/JIqYqEf6aSxaYNVwgGPq4wSe6DZ1frKwO4vPcr00HL PYc2hlYivwkjZkaXoaGIFe86DsQ9MyEDOGbSAmmtx5IS1wbXHCsjEKWPmr2tkSW7nPYSSEE0pkQ OzhQIvkYQQG4Yc7YiH+Ah9cJ2hK7kAQoer3x7RdYU4mev8c9y8OKqSLf/GZtZIarVWUawsMb3cG RZ7hmc0TjKgxb9248AQ== X-Proofpoint-ORIG-GUID: fGOYI4TEPLmpOwctIPjs8npp0z8-CvaE X-Proofpoint-GUID: fGOYI4TEPLmpOwctIPjs8npp0z8-CvaE X-Authority-Analysis: v=2.4 cv=WtEm8Nfv c=1 sm=1 tr=0 ts=69af525b cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=GLuZV9TbpKr0kWuSc8UA:9 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090204 Content-Type: text/plain; charset="utf-8" Instead of defining a local macro with a custom name for the QMI service identifier, use the one provided in qmi.h and remove the locally defined macro. Signed-off-by: Daniel Lezcano Reviewed-by: Dmitry Baryshkov --- sound/usb/qcom/qc_audio_offload.c | 2 +- sound/usb/qcom/usb_audio_qmi_v01.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_of= fload.c index 510b68cced33..bc4e1bdacaa8 100644 --- a/sound/usb/qcom/qc_audio_offload.c +++ b/sound/usb/qcom/qc_audio_offload.c @@ -1927,7 +1927,7 @@ static int qc_usb_audio_probe(struct auxiliary_device= *auxdev, QMI_UAUDIO_STREAM_REQ_MSG_V01_MAX_MSG_LEN, &uaudio_svc_ops_options, &uaudio_stream_req_handlers); - ret =3D qmi_add_server(svc->uaudio_svc_hdl, UAUDIO_STREAM_SERVICE_ID_V01, + ret =3D qmi_add_server(svc->uaudio_svc_hdl, QMI_SERVICE_ID_USB_AUDIO_STRE= AM, UAUDIO_STREAM_SERVICE_VERS_V01, 0); =20 uaudio_svc =3D svc; diff --git a/sound/usb/qcom/usb_audio_qmi_v01.h b/sound/usb/qcom/usb_audio_= qmi_v01.h index a1298d75d9f8..c7eee03225ec 100644 --- a/sound/usb/qcom/usb_audio_qmi_v01.h +++ b/sound/usb/qcom/usb_audio_qmi_v01.h @@ -6,7 +6,6 @@ #ifndef USB_QMI_V01_H #define USB_QMI_V01_H =20 -#define UAUDIO_STREAM_SERVICE_ID_V01 0x41D #define UAUDIO_STREAM_SERVICE_VERS_V01 0x01 =20 #define QMI_UAUDIO_STREAM_RESP_V01 0x0001 --=20 2.43.0 From nobody Thu Apr 9 09:02:44 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F1CE426EDF for ; Mon, 9 Mar 2026 23:06:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097567; cv=none; b=bMB4Q3SvWLA0fWQV+vKDyF4Kl1cPMR3rCmXQet92z4gkVWuDokKeL/UziiNJCkl+YbF1WFi1bcr5sXZMKKPqMO2Qyxi9qGmtNcXip04qO4ObujWKgm9iNM0WPm71sPYph+jexy1pwoWFkH0JgMPoUo/Ssc+7ajsvB1K5/M7XaT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097567; c=relaxed/simple; bh=JA1Emk2GOGrNm0wBvip1tqJqrJtVwNB/O0vGeFWX/84=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BEQqm/XpSN0sWNQPNu+7D7IM1GVt3htVCOccHbjwEac6hnKk7fB41QUTUwwduM/0RiHN5vH2PIP7puO6PRt2iZqBcXWZ/B5j8iPmaJxf8TJjTDqaWkqa5wIDt+QeSKcb8r8KWYfErYCgo18f0bU2BisSoS1KWEBrON5x7+5CFzs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cR9bULr3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g8XOX31C; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cR9bULr3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g8XOX31C" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HBox4296384 for ; Mon, 9 Mar 2026 23:06:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=v2mAeI36jMe fxLTQ32eNJQTAV5FQOsM8JFUnk8b12HY=; b=cR9bULr3HuHIdluNoBJGFv+4inn oEkch/dAK8iHZXChBmP5YbxIOSs9RppPQ3TOJwqxNc6KjUG44l0NGpnP6kv+bW+n 93OhKIOseaCH6RpcaT4bQYVVTt2zIv9g1XXzGixEOaqkG8xPAETVQCoustms+8/l 1XL6XKajpsOZ7fXoIessDCYomEMqLT1Sx6X3lbhM3jZxWSOKB3YGmGnJ74qcBg4q AsE7BsGsPW2E1XJkUAqbhWuTQ8OdZtuPblMct+hrtcMMvkjsLExjzi9rEA4GjGOg PXDfBsHsJPiT4nYN8l0FHvpiUBgWVuZ9EIQhJ32d6/k+OSx5hXtL/yADkxQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csyfy1rxc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:06:05 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd80bea54dso1065874185a.3 for ; Mon, 09 Mar 2026 16:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773097565; x=1773702365; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v2mAeI36jMefxLTQ32eNJQTAV5FQOsM8JFUnk8b12HY=; b=g8XOX31CxcmXx766z2IReF1IJvIswtIf5plLemO9Y8QXZHkKlFmlhiDNpl3v5o3+zZ SC6yDf7u8KyhpmeWRkL8KN4vIbavmu8TGnR/wapjh5/wN8uzqXrkiSfAypXpIjl2LpMH NhsYyx9v41ITpBZ9SLwd+I17SaxI1b8VPt1/JaSsnbFLGbE8Mmiacpd/ru8KB0+GiOyG 6yQtx+vxXwnTukAkBwhS/jqXA+tCa0MTrStzdmLlXk2bZxumm07HAYvqA/NTEo2tv1H4 gS78ZaphzaKzKMKq6AYNYL4ZJRp4iFJFFoWeO27TWz58d4JoCaJxtoaQHqJiZXruBvL5 vsVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773097565; x=1773702365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=v2mAeI36jMefxLTQ32eNJQTAV5FQOsM8JFUnk8b12HY=; b=fAMsesR+vE46XuPTyIDld5Ts7l4qXADXfDdzzm5GSnDrlNVgCf1ttBiOi4Yhb2mTMo +UQVfWdtQ1qp80W5qK0oJH7gi+yNI6uZ9kbz19GW8VsLzIcngk3Fq0DlIzHTG5bDIyai kga8T8csDs7W3pVfscOtlt6R4M3MXVxTvhpUb27KqMYv5tAh6LbH5RgAnjAE/cNGRiJf 1wN+D1aXTCHO2tm0vIyS5Mo5JuhvvZvHqyYiS2zbpionfNGl31dNEKHz1Vq4imMopGep MyPqSJlwXwNbnylp51hb0+NYqiCfcXFj2k/HTLL5j3FSapzAgdmS9gF+6xchUaETDRGW faRw== X-Gm-Message-State: AOJu0YyVF9Vscdux6WAVy8CVlMY7qQJvH5AHEHqVaZwrW+eW+3NR2C6q grToCfgDGJXzQfxntKuLkOSgopbY0IZ7fQbBgk2LB9MJabJZwL9Af/f77N9F3UU5yk/sNTqXaeC fe3LsDbGNRziLSPDEUBXtrjnyRkLMD+DJ/7N8Fqkaj3GBtCoqFOMS1YbJf2zZ0ALMe+A= X-Gm-Gg: ATEYQzzYicwvfpHHdEu32jrztevB9ffZbqdkuxHp3xeAftjSb2tp8O+Yaz1q9tPRoF1 3cnubC+apmU6pGUBdqqSo51RbyiiBDEjwHG0SgPChLIT7rrA9sBNqoAYMjJK9vZ4ghdfHN0tKU/ lbyv1jAyAat7h7wIsdAnwLu3e4qNTQyDW4+tB+N3tSeR8F7d9kRK0f+j8aBtdeK8U5dfE2JHoE2 6vFSRmrbQZeu97iANlPWpmMIC8ONQynXWVOOErEfcHOSkbRQrccQXlTO/QeiG7V/RWp5Qn2+Of6 hy1cKWUegDUESWC9EZ8o2uSM1XIaQsDH6TyLWh3PZIomNM0BdIAw73NrDKS7+zv2bpEybJt1jme KJRzt/E9TvA7fZv63fE5v0e5e1gz3O2XPW70LcZgt+1Ep5VxlKQ== X-Received: by 2002:a05:620a:571:b0:8cd:7cea:aead with SMTP id af79cd13be357-8cd7ceac62fmr770643585a.2.1773097564715; Mon, 09 Mar 2026 16:06:04 -0700 (PDT) X-Received: by 2002:a05:620a:571:b0:8cd:7cea:aead with SMTP id af79cd13be357-8cd7ceac62fmr770640485a.2.1773097564261; Mon, 09 Mar 2026 16:06:04 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:ae20:597c:99b8:d161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae3d98asm33898478f8f.30.2026.03.09.16.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 16:06:03 -0700 (PDT) From: Daniel Lezcano To: konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: [PATCH v1 8/8] samples: qmi: Use the unified QMI service ID instead of defining it locally Date: Tue, 10 Mar 2026 00:03:37 +0100 Message-ID: <20260309230346.3584252-9-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIwNCBTYWx0ZWRfXwKcgNOeio1KK rkpfNDyvXYrKvrhS7d+rAkYmiL+BE5KULTC/Uhd/hTR/gFY/l9/EOXGQppNCZkZb4WIauDKyBWq kJ3hXvc98W5jbepPreExFYS8g53kOosD0e86tXIYru4JPBBtsmmImUjQQNFP2AD1/eiARVYyrfK TgTfUpjUJ4HGnQLgL44cxH1Z92wI04c9ZrEyVwScv1mGogIZD7WZ+6F4D2md3ATlN8Wq9DM3Y1k TRPC5clmts5alwrbxZt2WC80FIBOiNwqI3r19Rb6rbjfCIJFkXC266y4ExbxKbvMdGa6rFGhEX4 6KjzFRiaOv5AffmJxlR4QnL/sbW5Mo8jPlk3JzHj6+bf+uWvS3BM2G5Sg7wX1vzeWLK1ZqXsQAj DOlis/IqHwZbTK6kHscKuD3Szu7/w4dtbxSxNGk/beMZR9EpJBxtiAXPj6Y7eyXqAmz08IAtI5T /QIqg5Sm7zux6wirqqw== X-Authority-Analysis: v=2.4 cv=OcmVzxTY c=1 sm=1 tr=0 ts=69af525d cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=RE031ben1CQMdFOqpmIA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: TMaXZz2aKM-B4OBXGP3rd9w-nXh1gEw3 X-Proofpoint-ORIG-GUID: TMaXZz2aKM-B4OBXGP3rd9w-nXh1gEw3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090204 Content-Type: text/plain; charset="utf-8" Instead of defining a local macro with a custom name for the QMI service identifier, use the one provided in qmi.h and remove the locally defined macro. Signed-off-by: Daniel Lezcano Reviewed-by: Dmitry Baryshkov --- samples/qmi/qmi_sample_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/qmi/qmi_sample_client.c b/samples/qmi/qmi_sample_clien= t.c index d1814582319b..247ec5e54c4f 100644 --- a/samples/qmi/qmi_sample_client.c +++ b/samples/qmi/qmi_sample_client.c @@ -592,7 +592,7 @@ static int qmi_sample_init(void) if (ret < 0) goto err_unregister_driver; =20 - qmi_add_lookup(&lookup_client, 15, 0, 0); + qmi_add_lookup(&lookup_client, QMI_SERVICE_ID_TEST, 0, 0); =20 return 0; =20 --=20 2.43.0