accel/amdxdna: Fix major version check on NPU1 platform

[PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform

Posted by Lizhi Hou 1 month ago

Add the missing major number in npu1_fw_feature_table.

Without the major version specified, the firmware feature check fails,
preventing new firmware commands from being enabled on the NPU1
platform.

With the correct major version populated, the driver properly detects
firmware support and enables the new command.

Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check for latest firmware")
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
 drivers/accel/amdxdna/npu1_regs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c
index 6e3d3ca69c04..1320e924e548 100644
--- a/drivers/accel/amdxdna/npu1_regs.c
+++ b/drivers/accel/amdxdna/npu1_regs.c
@@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = {
 
 static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = {
 	{ .major = 5, .min_minor = 7 },
-	{ .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 },
+	{ .features = BIT_U64(AIE2_NPU_COMMAND), .major = 5, .min_minor = 8 },
 	{ 0 }
 };
 
-- 
2.34.1

Re: [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform

Posted by Mario Limonciello 1 month ago

On 3/4/26 1:50 PM, Lizhi Hou wrote:
> Add the missing major number in npu1_fw_feature_table.
> 
> Without the major version specified, the firmware feature check fails,
> preventing new firmware commands from being enabled on the NPU1
> platform.
> 
> With the correct major version populated, the driver properly detects
> firmware support and enables the new command.
> 
> Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check for latest firmware")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
>   drivers/accel/amdxdna/npu1_regs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c
> index 6e3d3ca69c04..1320e924e548 100644
> --- a/drivers/accel/amdxdna/npu1_regs.c
> +++ b/drivers/accel/amdxdna/npu1_regs.c
> @@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = {
>   
>   static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = {
>   	{ .major = 5, .min_minor = 7 },
> -	{ .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 },
> +	{ .features = BIT_U64(AIE2_NPU_COMMAND), .major = 5, .min_minor = 8 },
>   	{ 0 }
>   };
>

Re: [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform

Posted by Lizhi Hou 1 month ago

Applied to drm-misc-fixes

On 3/4/26 11:54, Mario Limonciello wrote:
> On 3/4/26 1:50 PM, Lizhi Hou wrote:
>> Add the missing major number in npu1_fw_feature_table.
>>
>> Without the major version specified, the firmware feature check fails,
>> preventing new firmware commands from being enabled on the NPU1
>> platform.
>>
>> With the correct major version populated, the driver properly detects
>> firmware support and enables the new command.
>>
>> Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check 
>> for latest firmware")
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
>> ---
>>   drivers/accel/amdxdna/npu1_regs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/amdxdna/npu1_regs.c 
>> b/drivers/accel/amdxdna/npu1_regs.c
>> index 6e3d3ca69c04..1320e924e548 100644
>> --- a/drivers/accel/amdxdna/npu1_regs.c
>> +++ b/drivers/accel/amdxdna/npu1_regs.c
>> @@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = {
>>     static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = {
>>       { .major = 5, .min_minor = 7 },
>> -    { .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 },
>> +    { .features = BIT_U64(AIE2_NPU_COMMAND), .major = 5, .min_minor 
>> = 8 },
>>       { 0 }
>>   };
>