From nobody Fri Apr 10 00:56:56 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010059.outbound.protection.outlook.com [52.101.193.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2E6D3890ED for ; Wed, 4 Mar 2026 19:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772653822; cv=fail; b=fOzxXJcdpy4+dUV9hGxI4djAEQ5D250naTuXF7FxII1ug7LLNN3mtNoEV+Mh27JlyW6u3SNoruEKd4Puesmy3lEVKWbf3rvl9wWPc5MSUhoer9BECIQsfywVJKvrUGkaIG2eIDBUAJhyaac8LcuEs07nytql1+tYJtXtB4t9xT0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772653822; c=relaxed/simple; bh=W0QpSH3TxzmbD/unNVzYcSNK/XSivKRZixsvgHw8KOM=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=RynNdx02Mg0GZtOIwrr0B86G2LbAznLhH3UYhOALPPIROLnJz0qAbjVMOx+ojJ9gNGUa3cTH7ap+I78PfB1PPv2KAjBjSY4g4ag2iSVvWsqjeZG+r2qv7sozoj4daNRsMGUNKm1XWAxaZ5BmaOLQEZFuRIDerFZDKqZ1YxQXry0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=WHLWLP9o; arc=fail smtp.client-ip=52.101.193.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="WHLWLP9o" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=irhpXSuwsL868y17poqpkbi4TNlhyPhB+4uDV7+ks3KTxUrmFcNV3L/idFNySD+AEOLcEQw/NZ1tLy3NU+wp1dFKXZz1snYrT2U21KX3ZWZgxx0W6Z64zH9sYhN9xpPQa5SfEIaxJCYnAIp/Jd+3NrmMjo2Jskw3bZVGhC1HQDXf5I0dD38jRR9y4N7OqmxKlhFQcC3WHWHscxVMwhmQhsqkPTGJw4ZGOw3+6CkNkN9Jaj/NslzsXko2WQxbKoxjDfylTxL9BD42tuSjM0nS6xylVxM7r/AUs+DdZxBjnyIm84DTKM/cIWnjfskwSs4dTh9BpLC0NUjIwslL7oe5Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q4ji+xj4ziPS0SgQnhFCf8xuwbTEjGjzKLKd91lGmCw=; b=YRKyMWO1eotHLzlMortUndOE9jDbLoj47IbabvUnET9eBAJBje8T8A7lmSLWx+Bs7gitxAucCCwk6uF9aKis4j/8UG8t2Weq+IkF8dfEkBtiYlMiPM84LB2p8My0DzxH/FgGF2jFpK2t0zUCp3DN90mN4OughO6F5OnpRs4E1lpO0kC/ZFGQb891Il/z3NELdfx9YBYQhAC0Klm6wMbSZ9qgSSgjz3UpBuvmY7dxRTGiAckS27NWXTGisztUvvIOtFITDYfpxbHzjFXR9lg/ppW0AremTnPTLirNsAM3TUpxfAESVu2+xV3xIU+AIxvefLEH54opr8XazPfAo/R9wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q4ji+xj4ziPS0SgQnhFCf8xuwbTEjGjzKLKd91lGmCw=; b=WHLWLP9o3t/3w1jNJGsQp+edaUXU3Grj5NZG2fN9KdNurD5XQSSQnKF7KHNjpYLdwXFke5zCgTqibCAMQcaA4JiZE8eVU7Rz5E1qWjAJczkAteatZigdNWHKV5EaOsjHbxKJixZHoRiKMXwMW/PF+q+7EiAqRgYTNFiARDQnvms= Received: from BY3PR04CA0004.namprd04.prod.outlook.com (2603:10b6:a03:217::9) by DS0PR12MB7778.namprd12.prod.outlook.com (2603:10b6:8:151::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.17; Wed, 4 Mar 2026 19:50:16 +0000 Received: from SJ1PEPF000026CA.namprd04.prod.outlook.com (2603:10b6:a03:217:cafe::83) by BY3PR04CA0004.outlook.office365.com (2603:10b6:a03:217::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.22 via Frontend Transport; Wed, 4 Mar 2026 19:49:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SJ1PEPF000026CA.mail.protection.outlook.com (10.167.244.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.18 via Frontend Transport; Wed, 4 Mar 2026 19:50:15 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Wed, 4 Mar 2026 13:50:15 -0600 Received: from satlexmb07.amd.com (10.181.42.216) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 4 Mar 2026 13:50:14 -0600 Received: from xsjlizhih51.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 4 Mar 2026 13:50:14 -0600 From: Lizhi Hou To: , , , CC: Lizhi Hou , , , , Subject: [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform Date: Wed, 4 Mar 2026 11:50:12 -0800 Message-ID: <20260304195012.3616908-1-lizhi.hou@amd.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026CA:EE_|DS0PR12MB7778:EE_ X-MS-Office365-Filtering-Correlation-Id: 87eec42a-3174-4c24-d924-08de7a27419c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|82310400026|376014; X-Microsoft-Antispam-Message-Info: nt36WU+5cuO8SqySYp6aHwA8QufiWSlgc2i+puiZizuMtzRZFiGmxMXeeGgRW6i6IlGJ/lRFbmst2/2Oq/xwmgYCd5TKaPqaB2NwZJsYuQPGjODXSPDQ+PJJKk8FNTbr//UMAPjIUFR42g6ybWuGBKTXMFGyAS6CutI34APS4Ny+omioNniIBELvOoCOuTG+ne3LfRB52lAvlZpfwJ25FFgKi/ulc1/IQsSgoGrHZbvzzWmRLVuH+8wL2be/heidNvZxwl58RtcKWypkmsz5XOq9/A4+9jpM5CulsvMtbqy7panW1DD3a4X34Bw9uacBpH1JwHw+1ph6a+0GJ+vGntZnycB9Bw3BQJoCD6PZ0er9Kf4HQ/ctXQiC/Z/5TsDTe+HAMwatBqQlPqPzSO/f1Dbc31CJ20VtAuxcccIImgE2hZ48GcLhtWaELXamRtJMig2iCn8E+HvpLEp3H0KfAh3AlhRRCMArk9OFonA2jy31965ceh7E4PnrLEvrtoRu36xP8RnthiMTJulkFAFweT4/wBwKTonxQfsw8OpJknilORDlXeviskWIHe2W/im8GCwzQFDjAl1FWCeFsnLPGStzba3P7PK25QooUOrg46d0wQ/4pdfAmq0NWafsWLJ0RXYCzo4UEYsiuc8NXYtYE+hC7yNmPoKTl/b58nYk7tsPXFnJN378ujxUYDVxknGvMQdfiMeivNRGWyRxRJlSA5SFA5XDlpivpUki8ydvnBwjXLegCKstnKp+iZ8woJOZ8stzQ5ghH7DLY1s7hgQThA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(82310400026)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tXL+gW0pUR4X+E9MQljIVERMUXW0EQ8mtP68E5vmRYjlBlGVI9ydoAgeAO2th7KSaXoIr70lM7o9Empc/j7ioghd6ShG3xB1VgrToqL/GNZOurhtAWYdjdzO8BzwdVBMC6Ix9pFyA+I+RAeZih4M3maVkI4MY9wOXHnS7SzOLu5O78H1hKjevujMdxqaJ0RLq6NtWeTtTRa7aBL4ycEGqXjs2X7COQqlFOurX2epznM18YWHidQFamfoD2qs7n1W58iVDiUTt8FwlSrOf8zAo6PijIdnHSXLLNPefoWPVpD1TJJOTQAHFCknljR70UdcQRz121YoXQZ6R57BKhX9iMfFZ5vzw9TXHZidG6yZkIh+0d+yfUumHpZJvI+uEnsbOXFeqLNtcYPbpZvcHw++rJZ8jjsraM6Ue2d2/dBwhvCJK+TNNJZy1L1lwvzi3fED X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2026 19:50:15.5232 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 87eec42a-3174-4c24-d924-08de7a27419c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026CA.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7778 Content-Type: text/plain; charset="utf-8" Add the missing major number in npu1_fw_feature_table. Without the major version specified, the firmware feature check fails, preventing new firmware commands from being enabled on the NPU1 platform. With the correct major version populated, the driver properly detects firmware support and enables the new command. Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check for late= st firmware") Signed-off-by: Lizhi Hou Reviewed-by: Mario Limonciello (AMD) --- drivers/accel/amdxdna/npu1_regs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1= _regs.c index 6e3d3ca69c04..1320e924e548 100644 --- a/drivers/accel/amdxdna/npu1_regs.c +++ b/drivers/accel/amdxdna/npu1_regs.c @@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] =3D { =20 static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] =3D { { .major =3D 5, .min_minor =3D 7 }, - { .features =3D BIT_U64(AIE2_NPU_COMMAND), .min_minor =3D 8 }, + { .features =3D BIT_U64(AIE2_NPU_COMMAND), .major =3D 5, .min_minor =3D 8= }, { 0 } }; =20 --=20 2.34.1