[PATCH v5 0/4] arm64: dts: rockchip: Fix vdec register blocks order on RK3576/RK3588

Cristian Ciocaltea posted 4 patches 1 month ago
.../devicetree/bindings/media/rockchip,vdec.yaml   | 22 ++++++++++++++--------
arch/arm64/boot/dts/rockchip/rk3576.dtsi           |  6 +++---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi      | 12 ++++++------
3 files changed, 23 insertions(+), 17 deletions(-)
[PATCH v5 0/4] arm64: dts: rockchip: Fix vdec register blocks order on RK3576/RK3588
Posted by Cristian Ciocaltea 1 month ago
When building device trees for the RK3576 based boards, DTC shows the
following complaint:

  rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"

The first two patches updates 'reg-names' property in rockchip,vdec
binding to make it mandatory for RK3576 & RK3588, since this is what the
driver expects, as well as to allow providing the register blocks
following the address-based order and, consequently, ensure the video
decoder unit address points to the primary register range.

The next two patches reorder 'reg' and 'reg-names' for the impacted
RK3576 & RK3588 vdec nodes.

While the binding changes introduce an ABI break, the expected impact on
potential users should be minimal, if any, since the old SoCs are
unaffected, while the video decoder support for these newer variants in
mainline driver and devicetrees hasn't been released yet, it just landed
in v7.0-rc1.  Therefore this series is intended to be part of upcoming
v7.0 kernel release.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
Changes in v5:
- Addressed feedback from Krzysztof and Conor resulting in further
  updates to the commit descriptions, as well as marking reg-names
  required for RK35{76,88}, handled in a dedicated (prerequisite) patch
- Collected R-b and (re)added Fixes tags indicating patches should land
  as part of the upcoming v7.0 release
- Link to v4: https://lore.kernel.org/r/20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com

Changes in v4:
- Removed the unnecessary one-entry item from the reg-names oneOf clause
- Minor adjustment of the commit descriptions as 'function' naming was
  not used in the context of the older SoCs
- Link to v3: https://lore.kernel.org/r/20260225-vdec-reg-order-rk3576-v3-0-5a2ebe1b11a8@collabora.com

Changes in v3:
- Mark the current 'reg-names' listing in the binding as deprecated and
  introduce an alternative 'link,function,cache' one
- Drop the Fixes tags from all patches and updated commit descriptions
- Link to v2: https://lore.kernel.org/r/20260223-vdec-reg-order-rk3576-v2-0-daf4942dfc02@collabora.com

Changes in v2:
- Added patch for updating rockchip,vdec.yaml binding
- Added patch for updating RK3588 vdec nodes
- Link to v1: https://lore.kernel.org/r/20260223-vdec-reg-order-rk3576-v1-1-560976566bd3@collabora.com

---
Cristian Ciocaltea (4):
      media: dt-bindings: rockchip,vdec: Mark reg-names required for RK35{76,88}
      media: dt-bindings: rockchip,vdec: Add alternative reg-names order for RK35{76,88}
      arm64: dts: rockchip: Fix vdec register blocks order on RK3576
      arm64: dts: rockchip: Update vdec register blocks order on RK3588

 .../devicetree/bindings/media/rockchip,vdec.yaml   | 22 ++++++++++++++--------
 arch/arm64/boot/dts/rockchip/rk3576.dtsi           |  6 +++---
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi      | 12 ++++++------
 3 files changed, 23 insertions(+), 17 deletions(-)
---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260223-vdec-reg-order-rk3576-cc2ec6e05e98
Re: (subset) [PATCH v5 0/4] arm64: dts: rockchip: Fix vdec register blocks order on RK3576/RK3588
Posted by Heiko Stuebner 6 days, 12 hours ago
On Wed, 04 Mar 2026 23:00:39 +0200, Cristian Ciocaltea wrote:
> When building device trees for the RK3576 based boards, DTC shows the
> following complaint:
> 
>   rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"
> 
> The first two patches updates 'reg-names' property in rockchip,vdec
> binding to make it mandatory for RK3576 & RK3588, since this is what the
> driver expects, as well as to allow providing the register blocks
> following the address-based order and, consequently, ensure the video
> decoder unit address points to the primary register range.
> 
> [...]

Applied, thanks!

[3/4] arm64: dts: rockchip: Fix vdec register blocks order on RK3576
      commit: f8fa98aa23699b7019023cc7cd8bbb8d837f2d3b
[4/4] arm64: dts: rockchip: Update vdec register blocks order on RK3588
      commit: 6c4a6f7f19e69bedddee87bebd4f1f1c7411b820

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>
Re: [PATCH v5 0/4] arm64: dts: rockchip: Fix vdec register blocks order on RK3576/RK3588
Posted by Heiko Stuebner 4 weeks ago
Am Mittwoch, 4. März 2026, 22:00:39 Mitteleuropäische Normalzeit schrieb Cristian Ciocaltea:
> When building device trees for the RK3576 based boards, DTC shows the
> following complaint:
> 
>   rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"

[...]

> Cristian Ciocaltea (4):
>       media: dt-bindings: rockchip,vdec: Mark reg-names required for RK35{76,88}
>       media: dt-bindings: rockchip,vdec: Add alternative reg-names order for RK35{76,88}

due to media "applied" messages most of the time not reaching all Cc'ed
recipients, please tell me once the binding patches landed somewhere.

Thanks a lot
Heiko

>       arm64: dts: rockchip: Fix vdec register blocks order on RK3576
>       arm64: dts: rockchip: Update vdec register blocks order on RK3588
> 
>  .../devicetree/bindings/media/rockchip,vdec.yaml   | 22 ++++++++++++++--------
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi           |  6 +++---
>  arch/arm64/boot/dts/rockchip/rk3588-base.dtsi      | 12 ++++++------
>  3 files changed, 23 insertions(+), 17 deletions(-)
> ---
> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> change-id: 20260223-vdec-reg-order-rk3576-cc2ec6e05e98
> 
> 
Re: [PATCH v5 0/4] arm64: dts: rockchip: Fix vdec register blocks order on RK3576/RK3588
Posted by Cristian Ciocaltea 1 week, 3 days ago
On 3/10/26 10:44 AM, Heiko Stuebner wrote:
> Am Mittwoch, 4. März 2026, 22:00:39 Mitteleuropäische Normalzeit schrieb Cristian Ciocaltea:
>> When building device trees for the RK3576 based boards, DTC shows the
>> following complaint:
>>
>>   rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"
> 
> [...]
> 
>> Cristian Ciocaltea (4):
>>       media: dt-bindings: rockchip,vdec: Mark reg-names required for RK35{76,88}
>>       media: dt-bindings: rockchip,vdec: Add alternative reg-names order for RK35{76,88}
> 
> due to media "applied" messages most of the time not reaching all Cc'ed
> recipients, please tell me once the binding patches landed somewhere.

Yeah, sadly I also haven't received any notification so far, but just noticed
the binding patches are now in next-20260326, as a result of merging branch
'next' of https://git.linuxtv.org/media-ci/media-pending.git:

a11db8d8b403 ("media: dt-bindings: rockchip,vdec: Mark reg-names required for RK35{76,88}")
35c8178ed2bd ("media: dt-bindings: rockchip,vdec: Add alternative reg-names order for RK35{76,88}")

Thanks,
Cristian