[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers

Antoniu Miclaus posted 12 patches 1 month ago
drivers/iio/dac/ad7293.c         | 31 ++++++-----
drivers/iio/filter/admv8818.c    | 56 +++++++++-----------
drivers/iio/frequency/adf4377.c  | 56 ++++++++++----------
drivers/iio/frequency/admv1013.c | 43 +++++++--------
drivers/iio/frequency/admv1014.c | 89 ++++++++++++++------------------
drivers/iio/frequency/adrf6780.c | 60 +++++++++++----------
6 files changed, 155 insertions(+), 180 deletions(-)
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Posted by Antoniu Miclaus 1 month ago
Use dev_err_probe() consistently in the probe path of several ADI IIO
drivers. This simplifies error handling and ensures proper logging of
deferred probes.

Each driver is updated in two patches: first introducing a local
struct device *dev variable alongside the existing spi variable to
replace &spi->dev references in non-error paths, then converting
dev_err() error paths to use dev_err_probe().

Drivers updated:
 - adrf6780
 - admv1014
 - admv1013
 - adf4377
 - ad7293
 - admv8818

Changes in v4:
 - Split each driver update back into two separate patches: one for
   introducing the struct device variable and one for the dev_err_probe()
   conversion. No lines are edited twice cross patch pairs, error-only
   functions get dev introduced in the "use dev_err_probe" commit.

Antoniu Miclaus (12):
  iio: frequency: adrf6780: add dev variable
  iio: frequency: adrf6780: use dev_err_probe
  iio: frequency: admv1014: add dev variable
  iio: frequency: admv1014: use dev_err_probe
  iio: frequency: admv1013: add dev variable
  iio: frequency: admv1013: use dev_err_probe
  iio: frequency: adf4377: add dev variable
  iio: frequency: adf4377: use dev_err_probe
  iio: dac: ad7293: add dev variable
  iio: dac: ad7293: use dev_err_probe
  iio: filter: admv8818: add dev variable
  iio: filter: admv8818: use dev_err_probe

 drivers/iio/dac/ad7293.c         | 31 ++++++-----
 drivers/iio/filter/admv8818.c    | 56 +++++++++-----------
 drivers/iio/frequency/adf4377.c  | 56 ++++++++++----------
 drivers/iio/frequency/admv1013.c | 43 +++++++--------
 drivers/iio/frequency/admv1014.c | 89 ++++++++++++++------------------
 drivers/iio/frequency/adrf6780.c | 60 +++++++++++----------
 6 files changed, 155 insertions(+), 180 deletions(-)

-- 
2.43.0
Re: [PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Posted by Andy Shevchenko 1 month ago
On Fri, Feb 27, 2026 at 04:01:29PM +0200, Antoniu Miclaus wrote:
> Use dev_err_probe() consistently in the probe path of several ADI IIO
> drivers. This simplifies error handling and ensures proper logging of
> deferred probes.
> 
> Each driver is updated in two patches: first introducing a local
> struct device *dev variable alongside the existing spi variable to
> replace &spi->dev references in non-error paths, then converting
> dev_err() error paths to use dev_err_probe().
> 
> Drivers updated:
>  - adrf6780
>  - admv1014
>  - admv1013
>  - adf4377
>  - ad7293
>  - admv8818

> Changes in v4:
>  - Split each driver update back into two separate patches: one for
>    introducing the struct device variable and one for the dev_err_probe()
>    conversion. No lines are edited twice cross patch pairs, error-only
>    functions get dev introduced in the "use dev_err_probe" commit.

Thanks, I briefly looked and it looks fine to me,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Posted by Jonathan Cameron 1 month ago
On Fri, 27 Feb 2026 17:03:44 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Fri, Feb 27, 2026 at 04:01:29PM +0200, Antoniu Miclaus wrote:
> > Use dev_err_probe() consistently in the probe path of several ADI IIO
> > drivers. This simplifies error handling and ensures proper logging of
> > deferred probes.
> > 
> > Each driver is updated in two patches: first introducing a local
> > struct device *dev variable alongside the existing spi variable to
> > replace &spi->dev references in non-error paths, then converting
> > dev_err() error paths to use dev_err_probe().
> > 
> > Drivers updated:
> >  - adrf6780
> >  - admv1014
> >  - admv1013
> >  - adf4377
> >  - ad7293
> >  - admv8818  
> 
> > Changes in v4:
> >  - Split each driver update back into two separate patches: one for
> >    introducing the struct device variable and one for the dev_err_probe()
> >    conversion. No lines are edited twice cross patch pairs, error-only
> >    functions get dev introduced in the "use dev_err_probe" commit.  
> 
> Thanks, I briefly looked and it looks fine to me,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Applied with a minor tweak to add () after dev_err_probe in the
the patch titles.

I like to encourage that way of indicating functions and don't want too many
patches not doing that in the tree.  You had the () in the more detailed
descriptions so this is a really minor thing.

Thanks,

Jonathan

>