From nobody Fri Apr 3 11:12:47 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC46D423A6C; Fri, 27 Feb 2026 14:02:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200955; cv=none; b=F5EBnxbgA685JsW2vu7DUTsuEXT72uFSoNadKgSqVVFSzvfiuFTYtaQT+dcjIdjks6Q14hkejThiV8fMyC+CRwez0kBvlZD9h2P1dmnoN2nUMT9C6SfRxZeKnbsi5M4FkZyq9ywySGFBuKi8tvLTCxdI+F5p8XcQ8fCnbZ5W+Lw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200955; c=relaxed/simple; bh=1qicuhJCKRNOpCUiuetwWDqGKNcuozXE8Ecv8g2bRiA=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=E9i35Hej6YnqxSYHR7/OG/cDoEObp0rqPM4thJuaLnQJgf6LQYREKyglccv22XSGed4ohGqyarBl7InmYKDGXq3wWkRJd9oeaIw72eIvD3lQqmi3DbZZOAh4L/Mqk6SrrdDbURcgjK2CyaY14r+AU6UBB3sdx9Ejr3XidtlG0wQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=tAh76HUb; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="tAh76HUb" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61RBUokP1380239; Fri, 27 Feb 2026 09:02:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=Y5cL0 Y+dwFT7jueP1cOEGOWoc74NS81KRcAy675a1sU=; b=tAh76HUbE3OrZmZaPGbWI JpGQ6D1geLv7GC3OHQMhGFxozoPtBwbDCRHRcLn7uvK3bHgwMLaL+IUXQQoUHr8O HsoiUnzMFOylyt0yYr6h4wtsQ7k8phm/c+y0wys5ZI4y1uX2Rhyf2KltMgDsGssx lhFnDdw/a0T11EK7sv/QhmZZ87FkrkE7Ns0zMrDhRl4v/+AxsILfP5aC6yP+JZEH 7B6lj5748kQRw1MZsh4uiRPX5t4zUXvdTaK9wOCxjQ3DZU4cQLXEFClDGoAf/2AI sJs43a98FUHzwCF2PhED1yh4uLnFgi594izeI6+fs6ykxNkC5ytnJsYu2yGCB90r A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cja98r2ck-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:11 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2AE9064789 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:10 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:10 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:10 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t3n001982; Fri, 27 Feb 2026 09:02:04 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 01/12] iio: frequency: adrf6780: add dev variable Date: Fri, 27 Feb 2026 16:01:30 +0200 Message-ID: <20260227140152.77529-2-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfX5VuyNnY5lddZ GuTl7EhisCa9RoRh3DjrSZJvREbDlqoJBqehJMSO5BA06nFogHrkn8MKLr2NR1ef/tT4sQTO3j2 idQw7H3oeWkxWnDM4Q40WG7G/5OJWkFvJ+7CmNbtvMDx1t7d+MZ/pyfW84JQOLrCOFzGdqwgUjc KYX7Jt7l5mCdY+5Z1vgsGkKBQOsd1uUCVZDfXw91zUfsumuN9zLQTSQW0hv00OidvoxQ8SlUOBK Lz5TnNu2QgSxu3DmJDECjTfSEWivMbXO4jBZaO9XBzLjGo1pEUM/aZ1+VLvue72brLrVa1aNQnR eqtIFZteTnJ0sjFLW0Uz7Iokx86Bv45u/zpXIX0jY2+0pXEeGsHaXQeU11zG86KiFo1s6L8/IIu 1Egr+eEn17nHEZQ6KmmZYz9kn5TBcPlz3OG3likV7OXSUi7P4/pWs2AHbCdBB0i71uPeKw+6HnI 5S2rS4sqcueKjmfaeoA== X-Authority-Analysis: v=2.4 cv=a+A9NESF c=1 sm=1 tr=0 ts=69a1a3e3 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=Z0pTeXoby7EwIRygza74:22 a=gAnH3GRIAAAA:8 a=2djtLzYQq7BR6x-tG2YA:9 X-Proofpoint-ORIG-GUID: 168GuxZq_ZUIMi9rL80aSOhsakaYAYIE X-Proofpoint-GUID: 168GuxZq_ZUIMi9rL80aSOhsakaYAYIE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/adrf6780.c | 35 ++++++++++++++++---------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/iio/frequency/adrf6780.c b/drivers/iio/frequency/adrf6= 780.c index a7a21f929970..1899995f7b20 100644 --- a/drivers/iio/frequency/adrf6780.c +++ b/drivers/iio/frequency/adrf6780.c @@ -426,18 +426,18 @@ static int adrf6780_init(struct adrf6780_state *st) =20 static void adrf6780_properties_parse(struct adrf6780_state *st) { - struct spi_device *spi =3D st->spi; - - st->vga_buff_en =3D device_property_read_bool(&spi->dev, "adi,vga-buff-en= "); - st->lo_buff_en =3D device_property_read_bool(&spi->dev, "adi,lo-buff-en"); - st->if_mode_en =3D device_property_read_bool(&spi->dev, "adi,if-mode-en"); - st->iq_mode_en =3D device_property_read_bool(&spi->dev, "adi,iq-mode-en"); - st->lo_x2_en =3D device_property_read_bool(&spi->dev, "adi,lo-x2-en"); - st->lo_ppf_en =3D device_property_read_bool(&spi->dev, "adi,lo-ppf-en"); - st->lo_en =3D device_property_read_bool(&spi->dev, "adi,lo-en"); - st->uc_bias_en =3D device_property_read_bool(&spi->dev, "adi,uc-bias-en"); - st->lo_sideband =3D device_property_read_bool(&spi->dev, "adi,lo-sideband= "); - st->vdet_out_en =3D device_property_read_bool(&spi->dev, "adi,vdet-out-en= "); + struct device *dev =3D &st->spi->dev; + + st->vga_buff_en =3D device_property_read_bool(dev, "adi,vga-buff-en"); + st->lo_buff_en =3D device_property_read_bool(dev, "adi,lo-buff-en"); + st->if_mode_en =3D device_property_read_bool(dev, "adi,if-mode-en"); + st->iq_mode_en =3D device_property_read_bool(dev, "adi,iq-mode-en"); + st->lo_x2_en =3D device_property_read_bool(dev, "adi,lo-x2-en"); + st->lo_ppf_en =3D device_property_read_bool(dev, "adi,lo-ppf-en"); + st->lo_en =3D device_property_read_bool(dev, "adi,lo-en"); + st->uc_bias_en =3D device_property_read_bool(dev, "adi,uc-bias-en"); + st->lo_sideband =3D device_property_read_bool(dev, "adi,lo-sideband"); + st->vdet_out_en =3D device_property_read_bool(dev, "adi,vdet-out-en"); } =20 static void adrf6780_powerdown(void *data) @@ -450,9 +450,10 @@ static int adrf6780_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct adrf6780_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -467,9 +468,9 @@ static int adrf6780_probe(struct spi_device *spi) =20 adrf6780_properties_parse(st); =20 - st->clkin =3D devm_clk_get_enabled(&spi->dev, "lo_in"); + st->clkin =3D devm_clk_get_enabled(dev, "lo_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the LO input clock\n"); =20 mutex_init(&st->lock); @@ -478,11 +479,11 @@ static int adrf6780_probe(struct spi_device *spi) if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, adrf6780_powerdown, st); + ret =3D devm_add_action_or_reset(dev, adrf6780_powerdown, st); if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id adrf6780_id[] =3D { --=20 2.43.0 From nobody Fri Apr 3 11:12:47 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC3CC423A6B; Fri, 27 Feb 2026 14:02:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200955; cv=none; b=OtxgAs2ARjZkiCXhUjWmuBFHUMsFArpK/VuKatuwwSUgmuuNq1VBM8d+czaZjBmPeLglNwtFKOM6XLTGetwkSAmxWJziJJP+QsNlcDvHP48lbRyhtnLGSNvfzYUpv5Dmqb9pVeYiVLe7uHNHFEQ4iBwEkARpBIGaPbfdrgMjsc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200955; c=relaxed/simple; bh=g6eO3s5rFnTdvnNMAQl/mYoZarNKwZi5bs4gNrz+KGk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VnFD/56YJ3BJ71++B+xGTC7aMtjZ+yByAEQWFM81LmeKSUIZCgiMd8D5NMOB6OzR0w8DfA/Npcsd+eriv9Trm0XpaHyKcqpJE7DtslHDhXX41Gr/ElJx2mbRDi7KGVJ0kJgJoDyJIwrrWiz2xuxzeyu5duniFdqqAtwpZ5yxMdc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=HcjiN0Ke; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="HcjiN0Ke" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61RBfx5N1380254; Fri, 27 Feb 2026 09:02:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=bwIZa hzf/2xI79oT6khag0iXQuYtkUC6EXcy89W3+yg=; b=HcjiN0Keh1NOqWXcbDqrA 7SygvoAkwzE59Kkj+FTBRcvxlwx+7aZ72/oGvOaaw1dl9joUJZ37bHquD80IlMU4 YFGFUop1FDykSm67auypGrA2yujaDYNDVBhDeoR5bLpG7JMm31OvdZ8zEjhL8Gr3 hi2YVoxx4Y1Rx7aPI988vvJNYNRLGfah9BlxxF8PfhJ58BARauusI1XkxqIVK8IT fVynHnL66ic3lyuFp+VjzHQtq2Hk35kD4ofmhl3YRHSfYp6Gxciu2tZo9bIQLRaG XPLhB8/eXUSgzoj5dJT4V/ghPU42QdoPy/q7GDYvcx+feX3QvGjbWaJMxRXEsFJz A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cja98r2cm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:11 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2Agh064792 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:10 -0500 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:10 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:10 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:10 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t3o001982; Fri, 27 Feb 2026 09:02:06 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 02/12] iio: frequency: adrf6780: use dev_err_probe Date: Fri, 27 Feb 2026 16:01:31 +0200 Message-ID: <20260227140152.77529-3-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfXwZWCoCDm9qdr yS4Qk2rzJGBlKIdCh+0ifE0YfAHOQ6w6dKhrhZdzFzE1dHUShGjC97e5SrJ9TM3KdLPIcBjszg6 7DtAGl0ww1EO1FIXPy2RXDkqiMSAK97IvkDpSwCqjnR9QKXW5i8yMa9I3sYPFVbjGzUsdS5bF8p eH+ZnPlOnt+S1FYzQCy9cZkp4iGsWOwE+mg/5F67Nue/bXw6j7WMKudNO1w8lMi7owpyIdX1vnW hyqdx2q9pEUmLuaZoBvbo3ecUxKkcQ0TllybpsbTAjWCPg5yjQ0tR6SYTv4Z32dEBmA3Q5IhOqP pb7HAhA6J8h0ndFG1CH7CqFMEgOV2CD3vgfN8Q24Okbat5lCms591Fw61BhPTFlckxJQTXa3rHq PeXy6CfA38G1vMzMiYIh1bt3r6w6YtQ9u6w7Sd09BiQZYpe5IJNNH41PPZjWF/4WqmIqhNwNQK9 QavlW1u5TEWeLz8huVQ== X-Authority-Analysis: v=2.4 cv=a+A9NESF c=1 sm=1 tr=0 ts=69a1a3e3 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=Z0pTeXoby7EwIRygza74:22 a=gAnH3GRIAAAA:8 a=Hf3kJZ1x935sqW1ssrkA:9 X-Proofpoint-ORIG-GUID: gecItKZ6iOx7FePTKZJ1P0r7cLdb3q7K X-Proofpoint-GUID: gecItKZ6iOx7FePTKZJ1P0r7cLdb3q7K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/adrf6780.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/iio/frequency/adrf6780.c b/drivers/iio/frequency/adrf6= 780.c index 1899995f7b20..257fd31a0b0e 100644 --- a/drivers/iio/frequency/adrf6780.c +++ b/drivers/iio/frequency/adrf6780.c @@ -346,23 +346,21 @@ static const struct iio_chan_spec adrf6780_channels[]= =3D { static int adrf6780_reset(struct adrf6780_state *st) { int ret; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 ret =3D __adrf6780_spi_update_bits(st, ADRF6780_REG_CONTROL, ADRF6780_SOFT_RESET_MSK, FIELD_PREP(ADRF6780_SOFT_RESET_MSK, 1)); - if (ret) { - dev_err(&spi->dev, "ADRF6780 SPI software reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADRF6780 SPI software reset failed.\n"); =20 ret =3D __adrf6780_spi_update_bits(st, ADRF6780_REG_CONTROL, ADRF6780_SOFT_RESET_MSK, FIELD_PREP(ADRF6780_SOFT_RESET_MSK, 0)); - if (ret) { - dev_err(&spi->dev, "ADRF6780 SPI software reset disable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADRF6780 SPI software reset disable failed.\n"); =20 return 0; } @@ -371,7 +369,7 @@ static int adrf6780_init(struct adrf6780_state *st) { int ret; unsigned int chip_id, enable_reg, enable_reg_msk; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 /* Perform a software reset */ ret =3D adrf6780_reset(st); @@ -383,10 +381,9 @@ static int adrf6780_init(struct adrf6780_state *st) return ret; =20 chip_id =3D FIELD_GET(ADRF6780_CHIP_ID_MSK, chip_id); - if (chip_id !=3D ADRF6780_CHIP_ID) { - dev_err(&spi->dev, "ADRF6780 Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D ADRF6780_CHIP_ID) + return dev_err_probe(dev, -EINVAL, + "ADRF6780 Invalid Chip ID.\n"); =20 enable_reg_msk =3D ADRF6780_VGA_BUFFER_EN_MSK | ADRF6780_DETECTOR_EN_MSK | --=20 2.43.0 From nobody Fri Apr 3 11:12:47 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9D9B423A71; Fri, 27 Feb 2026 14:02:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200955; cv=none; b=lSeT3sAaI/sOYi0RxUSKpuV3y9braZaEodjBfxmw6IvWYHfp0LbaVRdgmP/P4yETtW12nra1N1WZNQlCu5DT1DdyXXRzquip+kT37W23bB7auIO7GK/mqsLzNEJwkKNaX46SgoKG2iH4lzF/WSdNsH0H7lHCE+VEGjLUY4Sk7pU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200955; c=relaxed/simple; bh=Ruhb8t/iOGzwzF35KttoSKS0HZERoy3mKtVzcFYC4pI=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BXkIWGl+iQ22D6uf3k/vCW66G4hpq2Foerci634+4gaKagzDfPlBIBvHQHifCcYUk6M90pECUB15zfY2NyA8ZjQtSKxz28fGUW0tWYhcR02pe49/bF4/d7vRTUa4UlIqxrvzRxhle1lpNiIXppeuEV+nZcbXtMbwqNOjJMdWmEg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=ikrqO71t; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="ikrqO71t" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61RACUXx2502285; Fri, 27 Feb 2026 09:02:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=nmuHg 0A99dItASrXa3p/fn2EKC6ScvBKqKNPrB4uYIk=; b=ikrqO71t+C9DE0XkC3fhK VbzuM48qEIZluhYaYeeCNxlqWIzoSxoVKIqZ4RQM8InBd6Zx/jr5jH7xxrQBQgs3 aJggsG/CgAhPrGi3bE0SaG6cm6QSQEglgvb+IEtoKVJ1G9e5Oaups6K7e4QzPe9E O640QZ+Dcs7MN6q3ZrysUHvYYR9xYf2Xa6vOW6BAoVrqxoaRUOAIpAqkIqiLvPOz JSvg2Z9erndblEye4hB1qiiZ2oKACZSyqXrw4QS2HSM+MBZnDu3eCi8t04Ocp1yr zsW6iFtly4TJf4gC9UlgYuK4YBy8bXqZdYtYj4SCerPo+4FXpyVrDPHsKiLZYRae g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cjbw3yk78-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:15 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2E8o064799 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:15 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:14 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:14 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t3p001982; Fri, 27 Feb 2026 09:02:08 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 03/12] iio: frequency: admv1014: add dev variable Date: Fri, 27 Feb 2026 16:01:32 +0200 Message-ID: <20260227140152.77529-4-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfXyrBjCwSFknJT PJlfH1fycGU/R97NUgTCcsWivg9rObtJRao6Uh7LgyJ47XpdNHYSzPEQXeTl8OPH4jE1KZkZ2B3 mFxo6H4My9sD1cAq5HMBZmQvjlt4C6/rvXe8g721gZqQbI3JHIocOivo4w+AY0x+LdKXTF4mN4D YgI7OUWpoVc/ewGFX05pY3H2UPKkLcEYd5IUpF4nD63wVSz4BA/bQNe0LKSfCVW/QBlpvBC0MUE rgpPI9e+kMliJdR8xgwQHNnTJ7Z77y75ZoOI2RXqQg0y2NHuTrnHAbpjsUucA/QDqXwsfOvd3/O H84PYkaZHH8SsEIokDCoIkWEM4mjT4a1DVhM3O6N55Ff3z9yJ9g09J5rMnOED1+e4setJcDhQHN +yo11uwssLObxSkYKVu1pybNl4RR/+7JJILUxCExU/hEzTZc4U1pnjhGEHgKPPedrZR7W8+4oBZ PpjSXqPTiIFioMwvmEg== X-Authority-Analysis: v=2.4 cv=AtXjHe9P c=1 sm=1 tr=0 ts=69a1a3e8 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=s4zbWEo9eQHfHvupQDMA:9 X-Proofpoint-ORIG-GUID: 8cw4LSooDIY5fcRU11mkEs8XHBMZjMe4 X-Proofpoint-GUID: 8cw4LSooDIY5fcRU11mkEs8XHBMZjMe4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/admv1014.c | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/iio/frequency/admv1014.c b/drivers/iio/frequency/admv1= 014.c index 7a8f92ec80a2..f829c4595df3 100644 --- a/drivers/iio/frequency/admv1014.c +++ b/drivers/iio/frequency/admv1014.c @@ -610,6 +610,7 @@ static int admv1014_init(struct admv1014_state *st) { unsigned int chip_id, enable_reg, enable_reg_msk; struct spi_device *spi =3D st->spi; + struct device *dev =3D &spi->dev; int ret; =20 ret =3D regulator_bulk_enable(ADMV1014_NUM_REGULATORS, st->regulators); @@ -618,7 +619,7 @@ static int admv1014_init(struct admv1014_state *st) return ret; } =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1014_reg_disable, st->reg= ulators); + ret =3D devm_add_action_or_reset(dev, admv1014_reg_disable, st->regulator= s); if (ret) return ret; =20 @@ -626,16 +627,16 @@ static int admv1014_init(struct admv1014_state *st) if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1014_clk_disable, st->clk= in); + ret =3D devm_add_action_or_reset(dev, admv1014_clk_disable, st->clkin); if (ret) return ret; =20 st->nb.notifier_call =3D admv1014_freq_change; - ret =3D devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb); + ret =3D devm_clk_notifier_register(dev, st->clkin, &st->nb); if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1014_powerdown, st); + ret =3D devm_add_action_or_reset(dev, admv1014_powerdown, st); if (ret) return ret; =20 @@ -712,13 +713,14 @@ static int admv1014_properties_parse(struct admv1014_= state *st) { unsigned int i; struct spi_device *spi =3D st->spi; + struct device *dev =3D &spi->dev; int ret; =20 - st->det_en =3D device_property_read_bool(&spi->dev, "adi,detector-enable"= ); + st->det_en =3D device_property_read_bool(dev, "adi,detector-enable"); =20 - st->p1db_comp =3D device_property_read_bool(&spi->dev, "adi,p1db-compensa= tion-enable"); + st->p1db_comp =3D device_property_read_bool(dev, "adi,p1db-compensation-e= nable"); =20 - ret =3D device_property_match_property_string(&spi->dev, "adi,input-mode", + ret =3D device_property_match_property_string(dev, "adi,input-mode", input_mode_names, ARRAY_SIZE(input_mode_names)); if (ret >=3D 0) @@ -726,7 +728,7 @@ static int admv1014_properties_parse(struct admv1014_st= ate *st) else st->input_mode =3D ADMV1014_IQ_MODE; =20 - ret =3D device_property_match_property_string(&spi->dev, "adi,quad-se-mod= e", + ret =3D device_property_match_property_string(dev, "adi,quad-se-mode", quad_se_mode_names, ARRAY_SIZE(quad_se_mode_names)); if (ret >=3D 0) @@ -737,16 +739,16 @@ static int admv1014_properties_parse(struct admv1014_= state *st) for (i =3D 0; i < ADMV1014_NUM_REGULATORS; ++i) st->regulators[i].supply =3D admv1014_reg_name[i]; =20 - ret =3D devm_regulator_bulk_get(&st->spi->dev, ADMV1014_NUM_REGULATORS, + ret =3D devm_regulator_bulk_get(dev, ADMV1014_NUM_REGULATORS, st->regulators); if (ret) { dev_err(&spi->dev, "Failed to request regulators"); return ret; } =20 - st->clkin =3D devm_clk_get(&spi->dev, "lo_in"); + st->clkin =3D devm_clk_get(dev, "lo_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the LO input clock\n"); =20 return 0; @@ -756,9 +758,10 @@ static int admv1014_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct admv1014_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -787,7 +790,7 @@ static int admv1014_probe(struct spi_device *spi) if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id admv1014_id[] =3D { --=20 2.43.0 From nobody Fri Apr 3 11:12:47 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 035FE423A83; Fri, 27 Feb 2026 14:02:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200956; cv=none; b=uzswLa2P+juCvLhs33MTx3xTeew7MdKqgeurexfdG07vsUkIFvnNutGV2qjbXpYaxNo3Zu1Zm47v88n238+s4dvDyyLx1q+KYq2wmAK1Lgj3D3q+u7e+jsjCVYMwWoDCih0F9u5rT3b1LCGcgbj0c3RaXS7CbwvA2/zZb3RMWCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200956; c=relaxed/simple; bh=2Ch6tPmhTC0Lswo8HeSwVeBN1MHd8JHIo0Qx6Oxac90=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FbpDUO/qTEjveObp9Ph5yNwmrNQLIRAShO4tvHjRt6+bV+/BBJzc8B3ZZs9U9Dhu1K4kYD10qlkvQJQ7c5eBqFYwfC3r36fruAJqQUPu5wuzPm6sJYk0/KuIDDzfz6Hds2/XaKRO+DS2QNihM+HmNO+h6qUD/Z3NH21w4MoNH+s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=WDtSNiPk; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="WDtSNiPk" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61R8TNXu1869280; Fri, 27 Feb 2026 09:02:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=uU4u4 hNtxkhUcPsn2f5KtM8AR0gVA6XH8HcXyHeZIsA=; b=WDtSNiPkSNFjSGdL30Y+7 PUjC64U1XLr+EbcKYsi+VNdNQvagsZ9QMpmlaqgqnS9JX+5LSV1H41upJv/POzp1 yEum+mBE1SmsOCwaat4iUdFr2aHqtYlbRMF/mXwVme5us6b4mcxVERlQJwsjpdME h32fgPU9nTM0Qmi5xWHqs8lQwtVcXbFsoMPdgwJmDf5kk/oX0sHxKEfqo3cad2rD 6DFb9o9LzNcD5AMFOPR84yVt6gHIprF0+ys5y0P4xcMqXlDkrGpxKhez0BwBp12t Zq4ofVPEt4OjDgH6stmsS026dTIGgaMj7vacwHacRS7OuET4NDnOhtwIEmktLlJ4 g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4chvwgben5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:16 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2FOS064802 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:15 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:15 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:15 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t3q001982; Fri, 27 Feb 2026 09:02:11 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 04/12] iio: frequency: admv1014: use dev_err_probe Date: Fri, 27 Feb 2026 16:01:33 +0200 Message-ID: <20260227140152.77529-5-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=Dcgaa/tW c=1 sm=1 tr=0 ts=69a1a3e8 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=YSkx0eS_6WgA8UCED4YA:9 X-Proofpoint-GUID: 9Y5c8ZCqtMPLsa53CVVmGQcmZsDIhkNz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfX1vruIb5EfOBD CU2y7suzaMaArkxhK8I2nvx2LX0axd33jMo6WKVww1BrQHd99pN+tap2F5RSs/+Vie1mMlYceGI UGpK3hFn6NQPhvTVKmRurho1x3RNx0z0ktfkAn4NFmnBTMQk6q0vhjKbo2PZC10BWfm2ZpAiDWT vK9W3Qx8Kzo4CoAZArBfaTiLdyyV4rHjlaQQGYRoor8EUhA9pQLoAI9F+gdfm5RG1rc/L4/6sMF wWa2+WU6SDenDl5aO2QokfNRAV2eqIpis6AVZmwl4ZdcV+kR7rD31L3SVYgVRjpae0mNx3r4Naa 9rEOz1O0WGUp20opp9mgmomnA4Y90UGMCklEC6OtagUu5x8cg6aeacn7463tUkZlvcOJZV2r0ar RNZXbSHD0IhkI5un9xF3qQMwQvKxcS7LLSzOhOa06/k8ACKRi++09b5fKXKQQcG+yw/r8J5BeyF l2kSYRzoiI6JeXNCs4Q== X-Proofpoint-ORIG-GUID: 9Y5c8ZCqtMPLsa53CVVmGQcmZsDIhkNz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/admv1014.c | 60 +++++++++++++------------------- 1 file changed, 24 insertions(+), 36 deletions(-) diff --git a/drivers/iio/frequency/admv1014.c b/drivers/iio/frequency/admv1= 014.c index f829c4595df3..25e8cd8135ad 100644 --- a/drivers/iio/frequency/admv1014.c +++ b/drivers/iio/frequency/admv1014.c @@ -614,10 +614,8 @@ static int admv1014_init(struct admv1014_state *st) int ret; =20 ret =3D regulator_bulk_enable(ADMV1014_NUM_REGULATORS, st->regulators); - if (ret) { - dev_err(&spi->dev, "Failed to enable regulators"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Failed to enable regulators"); =20 ret =3D devm_add_action_or_reset(dev, admv1014_reg_disable, st->regulator= s); if (ret) @@ -644,55 +642,47 @@ static int admv1014_init(struct admv1014_state *st) ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_SPI_CONTROL, ADMV1014_SPI_SOFT_RESET_MSK, FIELD_PREP(ADMV1014_SPI_SOFT_RESET_MSK, 1)); - if (ret) { - dev_err(&spi->dev, "ADMV1014 SPI software reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV1014 SPI software reset failed.\n"); =20 ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_SPI_CONTROL, ADMV1014_SPI_SOFT_RESET_MSK, FIELD_PREP(ADMV1014_SPI_SOFT_RESET_MSK, 0)); - if (ret) { - dev_err(&spi->dev, "ADMV1014 SPI software reset disable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV1014 SPI software reset disable failed.\n"); =20 ret =3D __admv1014_spi_write(st, ADMV1014_REG_VVA_TEMP_COMP, 0x727C); - if (ret) { - dev_err(&spi->dev, "Writing default Temperature Compensation value faile= d.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Writing default Temperature Compensation value failed.\n"); =20 ret =3D __admv1014_spi_read(st, ADMV1014_REG_SPI_CONTROL, &chip_id); if (ret) return ret; =20 chip_id =3D FIELD_GET(ADMV1014_CHIP_ID_MSK, chip_id); - if (chip_id !=3D ADMV1014_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D ADMV1014_CHIP_ID) + return dev_err_probe(dev, -EINVAL, "Invalid Chip ID.\n"); =20 ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_QUAD, ADMV1014_QUAD_SE_MODE_MSK, FIELD_PREP(ADMV1014_QUAD_SE_MODE_MSK, st->quad_se_mode)); - if (ret) { - dev_err(&spi->dev, "Writing Quad SE Mode failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Writing Quad SE Mode failed.\n"); =20 ret =3D admv1014_update_quad_filters(st); - if (ret) { - dev_err(&spi->dev, "Update Quad Filters failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Update Quad Filters failed.\n"); =20 ret =3D admv1014_update_vcm_settings(st); - if (ret) { - dev_err(&spi->dev, "Update VCM Settings failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Update VCM Settings failed.\n"); =20 enable_reg_msk =3D ADMV1014_P1DB_COMPENSATION_MSK | ADMV1014_IF_AMP_PD_MSK | @@ -741,10 +731,8 @@ static int admv1014_properties_parse(struct admv1014_s= tate *st) =20 ret =3D devm_regulator_bulk_get(dev, ADMV1014_NUM_REGULATORS, st->regulators); - if (ret) { - dev_err(&spi->dev, "Failed to request regulators"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Failed to request regulators"); =20 st->clkin =3D devm_clk_get(dev, "lo_in"); if (IS_ERR(st->clkin)) --=20 2.43.0 From nobody Fri Apr 3 11:12:47 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84182425CC0; Fri, 27 Feb 2026 14:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200956; cv=none; b=FYYL5ZKi0xp16u+mvKyh55ls9Y4Gcx5V9Ml+z/1Rjduk1vf6oK9MWb0O6fXGRD/yW5egQrSXHiugUEB6oJ11Q+a2HPcl0sOAymBeGLCO/odJGIP/pBQ/5BzHqIrGypQJdrH0ltryLEHAx1I6E3y3bXAmXh/qTOPU9h7JBUcpYBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200956; c=relaxed/simple; bh=v86xXTeVxTMvVGf1thyODtL1X0KlBxfFI3afYE0/HII=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HzcdmNEo8j1LUELxkHs0MewFGdNEVa6KUUM63tnmqbELHdFAZUckr1Hu0nodyddeFKqkxEBKEvYNtEsN5YE3ZzHn32TqMBx/enasvhCCf2QdBrb850pR1qHTIf/AjccxTw6Q12dJYepiAq4wSzpM1btbymz9QeCANujN3svhcxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=spaGrKt5; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="spaGrKt5" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61R8SE9n1868874; Fri, 27 Feb 2026 09:02:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=Hl+po 7naQ5bu38zu1PL9JxNMil9BWfkuByY8PFeWlvk=; b=spaGrKt51Mk9o6dBnS/lO kAylgJxR1d4UiotxhXXzCzdV06F35E7IsLhCV692ktrtDJiBRtNLEby87p7OnXf+ +ZOrCvAiwOCPS/hGlJXmIY+YlV1UEmWpysbtVRXcsitoNjRAZnPPiIVfOWIXPX2p HzgKQlHPCFYuuSROtM4iuIrphsKvaLYFKUE/rbv0lNvLlGFoGkbkxhPy5TT2HURm mUhZbddhT3hnElJmNxSZBThjVWj66LkSOL5BYtckSjvuM0cihoOGYBCd4jxMshSC c1e8v2jQTy/T3+iF/S/CC3O1ZEobmFAQMMxkP6b0bVfdlYYV3qp2oymmh/vruG2N g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4chvwgbena-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:20 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2Jmg064813 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:19 -0500 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:19 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:19 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:19 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t3r001982; Fri, 27 Feb 2026 09:02:13 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 05/12] iio: frequency: admv1013: add dev variable Date: Fri, 27 Feb 2026 16:01:34 +0200 Message-ID: <20260227140152.77529-6-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=Dcgaa/tW c=1 sm=1 tr=0 ts=69a1a3ec cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=10hQEsXEFSuYOAtga18A:9 X-Proofpoint-GUID: cVo8QEK1lzubd74GU6kX9T-QIVzLx7lv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfX6hwKPIvLS71M RwHN/G0eFsSQT2x8l+GjvNTNFoA7wT4w4Uy81lE5wUvpuuMo3Ehyja+p9OhOORnymvI4sLlmxCj x3y9zflDhtFi9c3mZb4TCodt3ZohM/UC3kVT+t5oZpMpXbxq10m0ja/9sipl9o9/AndyO9G9RYl LZPu6DqrbU5+OlSWsKcReo5nmBW7Sm3GQZWUyVfnNdqbx2hjwLvwKI2TU+5Ur7iJb18Wj9+G8y0 QGgrSxh7aXkvMEu2ohh5RK1QQxkHChrvTYDwI1p4SgpDGRXuJFVfxkzg6+9JsMqLKfTmDaNw8eL wVcrYGPfNBC/ugwRfSAK5s6fKvcy6XLbbsmc5CWOj/Fx9mU3bHbqIqrXB2xB79VDNUWnVOLimbD DaKm8cHzD/ognTZJCK6YM0je46K62QJq63qxIkrXy8q+uu8wOopbLVHU6tOt4mF4+voB/cURmJ3 owmvJMSkTQKZGMq9eKw== X-Proofpoint-ORIG-GUID: cVo8QEK1lzubd74GU6kX9T-QIVzLx7lv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/admv1013.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1= 013.c index d8e8d541990f..d29e288da011 100644 --- a/drivers/iio/frequency/admv1013.c +++ b/drivers/iio/frequency/admv1013.c @@ -518,11 +518,11 @@ static int admv1013_properties_parse(struct admv1013_= state *st) { int ret; const char *str; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 - st->det_en =3D device_property_read_bool(&spi->dev, "adi,detector-enable"= ); + st->det_en =3D device_property_read_bool(dev, "adi,detector-enable"); =20 - ret =3D device_property_read_string(&spi->dev, "adi,input-mode", &str); + ret =3D device_property_read_string(dev, "adi,input-mode", &str); if (ret) st->input_mode =3D ADMV1013_IQ_MODE; =20 @@ -533,7 +533,7 @@ static int admv1013_properties_parse(struct admv1013_st= ate *st) else return -EINVAL; =20 - ret =3D device_property_read_string(&spi->dev, "adi,quad-se-mode", &str); + ret =3D device_property_read_string(dev, "adi,quad-se-mode", &str); if (ret) st->quad_se_mode =3D ADMV1013_SE_MODE_DIFF; =20 @@ -546,11 +546,11 @@ static int admv1013_properties_parse(struct admv1013_= state *st) else return -EINVAL; =20 - ret =3D devm_regulator_bulk_get_enable(&st->spi->dev, + ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(admv1013_vcc_regs), admv1013_vcc_regs); if (ret) { - dev_err_probe(&spi->dev, ret, + dev_err_probe(dev, ret, "Failed to request VCC regulators\n"); return ret; } @@ -562,9 +562,10 @@ static int admv1013_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct admv1013_state *st; + struct device *dev =3D &spi->dev; int ret, vcm_uv; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -581,20 +582,20 @@ static int admv1013_probe(struct spi_device *spi) if (ret) return ret; =20 - ret =3D devm_regulator_get_enable_read_voltage(&spi->dev, "vcm"); + ret =3D devm_regulator_get_enable_read_voltage(dev, "vcm"); if (ret < 0) - return dev_err_probe(&spi->dev, ret, + return dev_err_probe(dev, ret, "failed to get the common-mode voltage\n"); =20 vcm_uv =3D ret; =20 - st->clkin =3D devm_clk_get_enabled(&spi->dev, "lo_in"); + st->clkin =3D devm_clk_get_enabled(dev, "lo_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the LO input clock\n"); =20 st->nb.notifier_call =3D admv1013_freq_change; - ret =3D devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb); + ret =3D devm_clk_notifier_register(dev, st->clkin, &st->nb); if (ret) return ret; =20 @@ -606,11 +607,11 @@ static int admv1013_probe(struct spi_device *spi) return ret; } =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1013_powerdown, st); + ret =3D devm_add_action_or_reset(dev, admv1013_powerdown, st); if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id admv1013_id[] =3D { --=20 2.43.0 From nobody Fri Apr 3 11:12:47 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 392F5426EDD; Fri, 27 Feb 2026 14:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200961; cv=none; b=XvCNOcoiDVcq12nnvi9hz7Qc8+/Piw5QdB/QgVRqbVHkz1tO899rYhZ5bMtsS+sTw/C2IgKTNPHbfgJqzF0fImaNEOdthfJXxBzoNWEk33hqCb4E+MKK8gtqcGSXSmFg/px+CrqSuhNrFkzXnnfRbqsCtGIX4tstZdTbolAR7x0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200961; c=relaxed/simple; bh=GuuWwLJ6njYTtZ1JiTfEHEIz79SGVEnWz2x7X8FpBj8=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ELT0m+XCG6CACbJwjynlStFsIOzIeMId2IQNPPJvd5nP507i5hfzs96Ufmtdga3EDlLkuTdCRhlA2digGoVBcOL3LMh/ZwIZqPxSpXripSMZGIeCMVfoAW05kuIVjiabS/qsUHk66deNmcIpsZK6RDH/5r5BHHItFUm9LSJPM3w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=OOwUNT/1; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="OOwUNT/1" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61RC0bGp3025436; Fri, 27 Feb 2026 09:02:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=d75vg 3L+dqBXCyoT8acH6+8Zz8oG43fZ3HYHTETG/JE=; b=OOwUNT/1hQKI9q3dUkcYy ASDU06P07OfHRti4A5QzPXf7Wcp7wLa043528/Ycc5LabmKL09DbmtvNB76aYUeD /PDCMU2c+N+XPsfCCVb8AbinGiPOAPbYsrEhM7EHgVsoKE0hB3VTzD5HFiUKPZnv jBSLt7WgUUPrtUWW1nEzxZMRGdsx6P6za1C6tiStb1HKhnGqhty8YLmTBqsDDT/U Uy1T6uDe3THjjRkdjD8cFiiNYNSRkRlbTiDarLo+lE4NMEeAaviiwt3V1de68fgC 8/M4TpsqnkXTmi1TQjpyLcAEEG+t/Zrkqz3AG8ieo31IyKDoOJRr21eWz8BbSm0I g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4cj8tdgbyf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:20 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2J8f064816 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:19 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:19 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:19 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t3s001982; Fri, 27 Feb 2026 09:02:15 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 06/12] iio: frequency: admv1013: use dev_err_probe Date: Fri, 27 Feb 2026 16:01:35 +0200 Message-ID: <20260227140152.77529-7-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=NubcssdJ c=1 sm=1 tr=0 ts=69a1a3ec cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=-l8ofh8svJz_XcbgydgA:9 X-Proofpoint-GUID: 0oWMRCxUtD_7kUiaVViBUr2oiJ4oOAzY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfXzqaZvcTLX/0G vfp+E6J/8NlBIM+Pj8nMQzXMM8HEGeZngHPtSsePDE0Kd2PPUdegy1+nK4ESwgZGQdTL/Qq29NQ FT40MvVxxwFanjIOvhdAGLfKgU7FfjrhfbUm6oZMLv3acbyFJKe0B+gPMxw43DOG3IfP/hmcgwN mMqSZ//9OFtKdGlPQ6K5lC0NaRieMVLej+kmYHeJPX4MXgEtI6CXBcIOfIHI270tJsoct6ZFtA7 Cd7z/ufvGczZNhQTZpV11HgwNIHxdGdG9FQFJUly6OlAlXS2vplhjApG+60E3v6jC5Gw2O41nKM TA+4C2LGBtrNP7uEn/1OPd9xCjUF4hyqdToo3m7i+ddv0EkRa1trW8/P8AJQkSAenm/NnA6opys NXC8hiT5538mxQDbtvvzOFjI7qC7dsIlP2TOxIq2WWOT/Ti/QsWhMPBcjB3icPw7rNZgu/W6Jk6 c58sFGv2SYjvc7H3jWg== X-Proofpoint-ORIG-GUID: 0oWMRCxUtD_7kUiaVViBUr2oiJ4oOAzY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/admv1013.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1= 013.c index d29e288da011..9202443ef445 100644 --- a/drivers/iio/frequency/admv1013.c +++ b/drivers/iio/frequency/admv1013.c @@ -441,7 +441,7 @@ static int admv1013_init(struct admv1013_state *st, int= vcm_uv) { int ret; unsigned int data; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 /* Perform a software reset */ ret =3D __admv1013_spi_update_bits(st, ADMV1013_REG_SPI_CONTROL, @@ -461,10 +461,8 @@ static int admv1013_init(struct admv1013_state *st, in= t vcm_uv) return ret; =20 data =3D FIELD_GET(ADMV1013_CHIP_ID_MSK, data); - if (data !=3D ADMV1013_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (data !=3D ADMV1013_CHIP_ID) + return dev_err_probe(dev, -EINVAL, "Invalid Chip ID.\n"); =20 ret =3D __admv1013_spi_write(st, ADMV1013_REG_VVA_TEMP_COMP, 0xE700); if (ret) @@ -602,10 +600,8 @@ static int admv1013_probe(struct spi_device *spi) mutex_init(&st->lock); =20 ret =3D admv1013_init(st, vcm_uv); - if (ret) { - dev_err(&spi->dev, "admv1013 init failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "admv1013 init failed\n"); =20 ret =3D devm_add_action_or_reset(dev, admv1013_powerdown, st); if (ret) --=20 2.43.0 From nobody Fri Apr 3 11:12:47 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D2DF4279F8; Fri, 27 Feb 2026 14:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200964; cv=none; b=St5PsDHUjY0CHOfKGIgCfivfZsehTIPZWbXxLdoR0n+nFpUWjzTvPIDE9Pr+nvWmUoGoNP0OdIqp/bKwEQ8SRWJhmLFX0BUBlfz8jyJEFr9qsp/NUYTqG10tT1DZePwIXG2S1HsMl5kLF4iT/YHG63C6uR27CNJCnustuZMHwrM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200964; c=relaxed/simple; bh=Nu9Huj+p0YZcCPqgiK+kXyOum6DeVNqzR8QcNdYgA4o=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ja6PjVk6r+Eb0dsAc9HvSRdpOMvqZqf3/zkSh+Jnx1nSfmQLrwoGEhYZZqVldYze9gyT5uPpUvfKsyFqcYLG4D4PthsnjY/MgINmNuv/n1Atd/1NGtS3vojuIyLAeW3PucTKkEjkqMNZ9Lf4pMSbe6BjU732ZHfNjJ4txGcxORg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=Ycvbn2Uu; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="Ycvbn2Uu" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61R8SE9o1868874; Fri, 27 Feb 2026 09:02:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=oPXHl ewuIfQZEXspZZYOaDdNdBCyLYmMKR1JodC36cc=; b=Ycvbn2UucGnsZkXomxjD+ naLC8qStByVx+X41fWRG+v+2Wn/kzDK9FzgbrQ41nkRyYdMo4w/n0TzduVbSDMnl bCkHs6SsPg9g0pVMrLMYZTxQKWYMci7kUYKL8SpSBgteq6QVERV7ix0YHSaf4k0G TiguFO6uGudB0cc8p2XxLfFD1BWT1XE+9HBdFn3gVNpygBlZ+MEJn3n/XtbyFg9v z8Me811mTsR5afcHLaUUWOzcfIzSDCFe44WfC5ye9eU4xCXXDC26SEVQBhKOfQ7X E8WQ1k0VIkHBFPJpKGVMMHNuecs+oFHc/QENReeem+8f1w+Vb0+5aM60sfoUdNVT A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4chvwgbeng-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:23 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2MGm064828 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:22 -0500 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:22 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:22 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:22 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t3t001982; Fri, 27 Feb 2026 09:02:18 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 07/12] iio: frequency: adf4377: add dev variable Date: Fri, 27 Feb 2026 16:01:36 +0200 Message-ID: <20260227140152.77529-8-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=Dcgaa/tW c=1 sm=1 tr=0 ts=69a1a3ef cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=EBMa5aonOlVRU8X19M8A:9 X-Proofpoint-GUID: HWcNwoPuapf1WRf6__19GXLzkUuu8G6l X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfXy6Pmj+Bh1/KE m2MXASqHQDDJAWfENxXOIYzRWeI4NRtLqfm93QfnGC6pMwJBZW0PcsJzRhc/zC3ABrK4BIgDanH I71wwxa7Nnxpr8a6q4G6kPN13JCm11bCASU6Ju/NRd6aPV2jg05kbWhnRm8Xg8TGZ1BuSPefwdN dFJ17giJcLXIKS4042kkFsKSCSJC4pGDcIeUDoJetvXjytW16LCezagrGnCe8IO4g4aJmouTDqF k8mDoScNq+iPmh+0fmSTcrBezrs+WR7g+t8x+uky4nauFe0ayYKnxIJ379LpnwWkhkvTiKEmN0Q 8seJx46JcMdZA+qg5B14vjTm0tmROjnuITnvIg1Q0PfyMwq5/goSi2nDjFVUA+CiTbe0OE4DW85 kVSNas2vpCluHWHGqXy6t/aXkVNTuQE915iugbzT/78o2PzF3DYx/KO8b35Ew4aB49KnESSiodY y6hpDBQ+Sye/UyHDCMQ== X-Proofpoint-ORIG-GUID: HWcNwoPuapf1WRf6__19GXLzkUuu8G6l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/adf4377.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/iio/frequency/adf4377.c b/drivers/iio/frequency/adf437= 7.c index fa686f785fa4..c2ae6f2012ce 100644 --- a/drivers/iio/frequency/adf4377.c +++ b/drivers/iio/frequency/adf4377.c @@ -882,35 +882,35 @@ static const struct iio_chan_spec adf4377_channels[] = =3D { =20 static int adf4377_properties_parse(struct adf4377_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 - st->clkin =3D devm_clk_get_enabled(&spi->dev, "ref_in"); + st->clkin =3D devm_clk_get_enabled(dev, "ref_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the reference input clock\n"); =20 - st->gpio_ce =3D devm_gpiod_get_optional(&st->spi->dev, "chip-enable", + st->gpio_ce =3D devm_gpiod_get_optional(dev, "chip-enable", GPIOD_OUT_LOW); if (IS_ERR(st->gpio_ce)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_ce), + return dev_err_probe(dev, PTR_ERR(st->gpio_ce), "failed to get the CE GPIO\n"); =20 - st->gpio_enclk1 =3D devm_gpiod_get_optional(&st->spi->dev, "clk1-enable", + st->gpio_enclk1 =3D devm_gpiod_get_optional(dev, "clk1-enable", GPIOD_OUT_LOW); if (IS_ERR(st->gpio_enclk1)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_enclk1), + return dev_err_probe(dev, PTR_ERR(st->gpio_enclk1), "failed to get the CE GPIO\n"); =20 if (st->chip_info->has_gpio_enclk2) { - st->gpio_enclk2 =3D devm_gpiod_get_optional(&st->spi->dev, "clk2-enable", + st->gpio_enclk2 =3D devm_gpiod_get_optional(dev, "clk2-enable", GPIOD_OUT_LOW); if (IS_ERR(st->gpio_enclk2)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_enclk2), + return dev_err_probe(dev, PTR_ERR(st->gpio_enclk2), "failed to get the CE GPIO\n"); } =20 - ret =3D device_property_match_property_string(&spi->dev, "adi,muxout-sele= ct", + ret =3D device_property_match_property_string(dev, "adi,muxout-select", adf4377_muxout_modes, ARRAY_SIZE(adf4377_muxout_modes)); if (ret >=3D 0) @@ -1055,9 +1055,10 @@ static int adf4377_probe(struct spi_device *spi) struct iio_dev *indio_dev; struct regmap *regmap; struct adf4377_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -1080,7 +1081,7 @@ static int adf4377_probe(struct spi_device *spi) return ret; =20 st->nb.notifier_call =3D adf4377_freq_change; - ret =3D devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb); + ret =3D devm_clk_notifier_register(dev, st->clkin, &st->nb); if (ret) return ret; =20 @@ -1097,7 +1098,7 @@ static int adf4377_probe(struct spi_device *spi) indio_dev->num_channels =3D ARRAY_SIZE(adf4377_channels); } =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id adf4377_id[] =3D { --=20 2.43.0 From nobody Fri Apr 3 11:12:47 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 616024279FC; Fri, 27 Feb 2026 14:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200964; cv=none; b=XzvCMRmEO3eoF4XHK/ROeE9ozhFBLTBdXZDGTQbVvAxlKRxbI0Apu0zh/bQBcPfGBM5yX187sOLIb6mw2FUshYcSZetEOkrX4uDL0+oQOXocFfogQ+g1HVAw1JnVAzGRDP79kS13yUeEKkLmzRBZsARtsoaGTOtyJTm7xqLMpbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200964; c=relaxed/simple; bh=Lz8inzcLH6RaPE/NrJV18w59d0D95PaXBZB3NnkyL+M=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rHCMZzBbRnQQ73DhImEn6sJwDFcQ5f4P/xd/4focwsB8KQKpb7ptGzcf+WiA3P3Bu5bWVtZuQnWfS9aDWsa9QZ7O1skqgEWGWjJ3e4KWASHyy4PERI8vDuEyDTGgRhDAIPni32eL43xO4vyFcCqxj8eClhBu5FBfkCFZWVH1gZw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=Y1nNgRrB; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="Y1nNgRrB" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61RAUHYf3025200; Fri, 27 Feb 2026 09:02:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=rhiVX 9WkkVOkqjtf6FmEWAPtcvi7hDIoIeJvyd3sXf0=; b=Y1nNgRrBZUvvIcBqsx/p/ flpmyzv+D9Ro3+U5Uw0A+0rg9akz7DZvitkWl+zF/bDogs8suGLHC4MIa5mPFMMf CgWxU4ZXqDMNEe0tMvst0E4PqBgm5FxBDhnInnV24naeqJMXQ5wPeNBnA6k4/mwB +o6Iw4KmLGTm058i90QYnLVAurKUyl/zB1z6NABUu6YX1APVFBQaL8pNQaXzXg6R MKfVXZ0IaGvhHCLi+CnmkgW2x0yfqYort63KYWjn6b6+0sEXR90qviL88KvOqqkR qXnXuoe/zDV+8+j+l3sl0sUGTF8HTrl5WpjSn/tYYgeEChkQrPVHEl/AxLbcRC51 w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4cj8tdgc01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:27 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2QlU064838 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:26 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:26 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:26 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t3u001982; Fri, 27 Feb 2026 09:02:20 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 08/12] iio: frequency: adf4377: use dev_err_probe Date: Fri, 27 Feb 2026 16:01:37 +0200 Message-ID: <20260227140152.77529-9-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=NubcssdJ c=1 sm=1 tr=0 ts=69a1a3f3 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=SF_i7ZEFwfkAXJdm2GcA:9 X-Proofpoint-GUID: T_iq4dosV96wLe5co8as9lmJ3Z9zc0SS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfXwpUiAZHKc4Wr DxpN52xHt4V1KeyvRBgtWSqHmNUHjOJWJl83+I2lPHdnizLUBngGRh+HVWZnz76mzV5MUdhGuLw 2oMCH1o0BFmGvyTblfa1w7EuGFNWUX44eyMllCKYps+9B0FEv+cu1B78AhcgNL1w6xujUnbu6dN cixatPkjW7JAOvAO1xbJjMGrcvIPWIMKuh9uSRViocbF6jl5mUcZUwESR8Ng9nFx4ZZ1okhPwZv jc8Wntjvk8MYtaJt4kXJYwkpEEyw0ZgRzPyEWC7X0NxJGsz4H7f7fdScoIodhT/PHya6IKQ50Pw J6bamyRbR/2uM0mTAONFYbOX4f9HW9+UcvnCf/ES6FYpfVl4p4vZE61lM2WK3EwMFLX2R86ZIZ3 948pNUfmQkH9bp7lb3+4mkix6dCVEDoAfVTJ86g6lUzz0WA8BaXwSQPRUjVhZw78RitTC1b4L2x L86hbeGEnKuIHrsJLpw== X-Proofpoint-ORIG-GUID: T_iq4dosV96wLe5co8as9lmJ3Z9zc0SS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/adf4377.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/iio/frequency/adf4377.c b/drivers/iio/frequency/adf437= 7.c index c2ae6f2012ce..ce3a396624c3 100644 --- a/drivers/iio/frequency/adf4377.c +++ b/drivers/iio/frequency/adf4377.c @@ -706,23 +706,20 @@ static void adf4377_gpio_init(struct adf4377_state *s= t) =20 static int adf4377_init(struct adf4377_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 adf4377_gpio_init(st); =20 ret =3D adf4377_soft_reset(st); - if (ret) { - dev_err(&spi->dev, "Failed to soft reset.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Failed to soft reset.\n"); =20 ret =3D regmap_multi_reg_write(st->regmap, adf4377_reg_defaults, ARRAY_SIZE(adf4377_reg_defaults)); - if (ret) { - dev_err(&spi->dev, "Failed to set default registers.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to set default registers.\n"); =20 ret =3D regmap_update_bits(st->regmap, 0x00, ADF4377_0000_SDO_ACTIVE_MSK | ADF4377_0000_SDO_ACTIVE_R_MSK, @@ -730,10 +727,9 @@ static int adf4377_init(struct adf4377_state *st) ADF4377_0000_SDO_ACTIVE_SPI_4W) | FIELD_PREP(ADF4377_0000_SDO_ACTIVE_R_MSK, ADF4377_0000_SDO_ACTIVE_SPI_4W)); - if (ret) { - dev_err(&spi->dev, "Failed to set 4-Wire Operation.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to set 4-Wire Operation.\n"); =20 st->clkin_freq =3D clk_get_rate(st->clkin); =20 @@ -747,10 +743,9 @@ static int adf4377_init(struct adf4377_state *st) FIELD_PREP(ADF4377_001A_PD_PFDCP_MSK, 0) | FIELD_PREP(ADF4377_001A_PD_CLKOUT1_MSK, 0) | FIELD_PREP(ADF4377_001A_PD_CLKOUT2_MSK, 0)); - if (ret) { - dev_err(&spi->dev, "Failed to set power down registers.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to set power down registers.\n"); =20 /* Set Mux Output */ ret =3D regmap_update_bits(st->regmap, 0x1D, --=20 2.43.0 From nobody Fri Apr 3 11:12:47 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DED6A42882C; Fri, 27 Feb 2026 14:02:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200972; cv=none; b=Wx+5+MU9QecB+QwymFCgbPOE2qxR+BfyvJ8e7twO2truCzOumQzTVaBYsujiuk6N2fq0UR0z9tnHb6XN5Vw3GSsJclosnX851vtyQh8n6QFLcrYW5SOQq44R/0QYvaa2VFepF0BJ6QHpDMXn/bApiwCxFpb/Kmr6WnZEgQ8BDyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200972; c=relaxed/simple; bh=VzB/StMLYqZx0HzaIcYdtM4PC/90ggm4BLWNAJbB1hw=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uZzI0Hp1pSqd53UKRXBr2bDXvEyc3JJCTFWm/Dr7Hhx4RnDcjB3MT0xjLQ8As+p0nJHodAuH9FyF5u8cUtLzUASyIVpGI/vFmtzNHoxx3V10phyhfl81+JvGUwwz3X/pxWAvUdp0I2dM4Y90VfcfPP4Ip7KiUq4nyuLNE7i9CYE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=0uHmPsVy; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="0uHmPsVy" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61RAjOCk3025355; Fri, 27 Feb 2026 09:02:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=+RqHD q+WGBPm9NgDUB1HFwT8z3xzNPx2sOpi1JO9g5E=; b=0uHmPsVyA7cAdKKfSuKir U0uRkqtO0ByyVlk+P4hAeCZ6okAqVQA54+RPQcltpJ1CoDwD4Y0N8bKnSo90hWR6 xHYsR9iqb53Uku3AX8yr+Cl5NQN2jTlUucy3kJqnwl9Zf7OOejYDTXMIXBbm52A1 hEUwF96pDDLVEHuuDJauyGfcSPeKu9f/gy1WBqsPP4SVGEbdRV9KEyjU8sHstMCr I/Wb0KJc4TCvj8eTnB+m4ljggnsJhdzX0B8Pn44aC9zMwidCu8PONGekt/b9kYb0 UMIpK1oxEJ5gomPg9vyme0t14J+7U+oMZAlgrCATUnnBj4zA2+/VItK7V47zu9Id Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4cj8tdgc05-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:29 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2SDQ064844 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:28 -0500 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:28 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:28 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:28 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t3v001982; Fri, 27 Feb 2026 09:02:22 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 09/12] iio: dac: ad7293: add dev variable Date: Fri, 27 Feb 2026 16:01:38 +0200 Message-ID: <20260227140152.77529-10-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=NubcssdJ c=1 sm=1 tr=0 ts=69a1a3f5 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=ZsvJIcEP_zl-ui44aFkA:9 X-Proofpoint-GUID: eoj_XUvlWf8fwzZTEHv9Lj42jMq7MfsQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfX/Mo0GNeNoWp4 sg7xfo823mHJt17EifuqQ5kcNWRwBgLL734+s3jGAFiiC3ukd5J6+yHORoXEtjjOCktX8IJwM/z /FRBUQ+zNQPVW8NY9yPLwaxkqS3BhrG1E0D+8XcOsc4eCDl83FW+wtrg5uLuPlPHQ1vPU75wP7c AXeat+wweHzD9B1ofs0aJ4C6xrge8o5lmdjQFlGWMOL0DI/AxIqA+S25BVEDNDB8+rb7kH9Fger AX8+Q40DBYnr+A/6Xaby1KjU9A8VJFvODlkfR3IieHQFM3eF+GyJc4QmMMYxL687QVn2fKqrKYb UIF3Jll2UDcsKprYJun/LrAdhbmR+TOaLIk+GsDt0R07nhYF1PmVZ+JSWpdDzFziZYbiqmCmkVY xZjXnCTiZbwWakr0388d3P+r8y4FvXdAh01nUN44DTYhcJ9Ish5iKOZ3Xq2/y76l4iOIxaOhg4y SfGfsQMVfHtBk/4W6Zw== X-Proofpoint-ORIG-GUID: eoj_XUvlWf8fwzZTEHv9Lj42jMq7MfsQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/dac/ad7293.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/iio/dac/ad7293.c b/drivers/iio/dac/ad7293.c index c3797e40cdd9..c86c54d53df1 100644 --- a/drivers/iio/dac/ad7293.c +++ b/drivers/iio/dac/ad7293.c @@ -776,27 +776,27 @@ static int ad7293_reset(struct ad7293_state *st) =20 static int ad7293_properties_parse(struct ad7293_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 - ret =3D devm_regulator_get_enable(&spi->dev, "avdd"); + ret =3D devm_regulator_get_enable(dev, "avdd"); if (ret) - return dev_err_probe(&spi->dev, ret, "failed to enable AVDD\n"); + return dev_err_probe(dev, ret, "failed to enable AVDD\n"); =20 - ret =3D devm_regulator_get_enable(&spi->dev, "vdrive"); + ret =3D devm_regulator_get_enable(dev, "vdrive"); if (ret) - return dev_err_probe(&spi->dev, ret, "failed to enable VDRIVE\n"); + return dev_err_probe(dev, ret, "failed to enable VDRIVE\n"); =20 - ret =3D devm_regulator_get_enable_optional(&spi->dev, "vrefin"); + ret =3D devm_regulator_get_enable_optional(dev, "vrefin"); if (ret < 0 && ret !=3D -ENODEV) - return dev_err_probe(&spi->dev, ret, "failed to enable VREFIN\n"); + return dev_err_probe(dev, ret, "failed to enable VREFIN\n"); =20 st->vrefin_en =3D ret !=3D -ENODEV; =20 - st->gpio_reset =3D devm_gpiod_get_optional(&st->spi->dev, "reset", + st->gpio_reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(st->gpio_reset)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_reset), + return dev_err_probe(dev, PTR_ERR(st->gpio_reset), "failed to get the reset GPIO\n"); =20 return 0; @@ -845,9 +845,10 @@ static int ad7293_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct ad7293_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -867,7 +868,7 @@ static int ad7293_probe(struct spi_device *spi) if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad7293_id[] =3D { --=20 2.43.0 From nobody Fri Apr 3 11:12:47 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 641BF428820; Fri, 27 Feb 2026 14:02:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200968; cv=none; b=D/VyX7MFw/B0pm08FafcsbnpG6oIXWhlt7iXZNVoB1ka7NQUYus6G+UkujO5n9R/mlq93eS15cICC2vzb3a0Qz0I34WNwLTfjZb5qVgRctRqYzjWGmapQF8pJPUcO6+eQgm9JvXWSdSE/eIWS1GEPZNslWBCLBJ7dzRLwuWKJcA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200968; c=relaxed/simple; bh=FU4UKwNtcGttS8EsQDjVjV/j7nZWls5PYrFK6wJCWp0=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nEuSWp0rysbMCMsu2Cd2GaidW3dp+lXQevk2cU21Bf/xwRHSmr9o08q+OoI6xHe9cco1KTyHf6EDw3ZyfPT7uho69mHdP9ZnMsx6gyKraCH6HFoFM+u3nrPxPW2eFor73rRrbrk/fxCj71Say/DBA+Q3tW7ZnH8DBgwNVQvj1nY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=CW0lmBKC; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="CW0lmBKC" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61RACUY12502285; Fri, 27 Feb 2026 09:02:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=/I6Rx aKz95PajiTSO80ix/Q+En69PBeEBx4xXcBSUdQ=; b=CW0lmBKCuLOqQf9IAtl54 A5xr7JX7CpMdTUxjxZC3qWK7dLnWj2fxfy5GLWAhY55n4pN98KIhA7YrgloIUeM7 l6fidHn1Xee2sHzo9vdGgmkNi+w0UOo3ZsJe8MA+Pp0dBStEgWXgmdjsBhdNDp07 Gju9SUFURdJLwrjVNEYOXTp5/cWRYDlZ/zlxTcmUZXPwMo2fA2viSnywfPCBIcbf 7uYphLQF/I4JR1MGKMKWda5xjHoifnjNVpmNfg/LdfcuRnb8+0WUBkQVZgqdvxqY kSfrEgaPraJ+voCPyXiGAtFf8T562fszmw6Z0iKx+BMYlZxrjOG6dTlsOiiWA5fj Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cjbw3yk85-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:30 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2TI3064847 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:29 -0500 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:29 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:28 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:28 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t3w001982; Fri, 27 Feb 2026 09:02:24 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 10/12] iio: dac: ad7293: use dev_err_probe Date: Fri, 27 Feb 2026 16:01:39 +0200 Message-ID: <20260227140152.77529-11-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfXxXhg8Pwdnc59 QeOAS9kD3ZBxRlmIU5DOsbSOtfgnEGMNAm2Jy8NgkAGpyXk6d6yLqovJP/BJAA8VUsEnHWAZX6r wVGo805qLWWpDFuBmwwNNv9g0fx92vUlOCiCnVZ7ZJ+o+SMSUxm2vyZPsJJW1oZeGSBQXFbjdm7 v7FU1ubHczgx9s3V+lPz2QT3Jtql5a75MEM1POIhGcYPnPmvdUU4OH8iM1IUKy4KvecTA6pyRka aDP1YQQGsYVofa+lZoul36GtpKsOE6ukmvK/5r0faHciitg+G/9eXL3D1s4NoeqDOmuLXUc0k+N 0EpAO4QbzKZxEyqQwhr2sCZBzk+z3DePl/8ND9CeZTIjvvKrUYvnWuekfs5dogRNsCnCR2cLRlo 0z3wrD/a8PFAledl1Gzs/EACp+janyv3SMpkRiiIGEwWLnd2Ol51I/ohEg9BDxRtanQYJVRG147 Q+oBttyUtUFFh6tjeNA== X-Authority-Analysis: v=2.4 cv=AtXjHe9P c=1 sm=1 tr=0 ts=69a1a3f6 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=iLbTipQpLQTOoodFea4A:9 X-Proofpoint-ORIG-GUID: AFcg1IfV32TYHyc8VkNIXp7IR5raGWKC X-Proofpoint-GUID: AFcg1IfV32TYHyc8VkNIXp7IR5raGWKC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/dac/ad7293.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/iio/dac/ad7293.c b/drivers/iio/dac/ad7293.c index c86c54d53df1..df6f126abf05 100644 --- a/drivers/iio/dac/ad7293.c +++ b/drivers/iio/dac/ad7293.c @@ -806,7 +806,7 @@ static int ad7293_init(struct ad7293_state *st) { int ret; u16 chip_id; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 ret =3D ad7293_properties_parse(st); if (ret) @@ -821,10 +821,8 @@ static int ad7293_init(struct ad7293_state *st) if (ret) return ret; =20 - if (chip_id !=3D AD7293_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D AD7293_CHIP_ID) + return dev_err_probe(dev, -EINVAL, "Invalid Chip ID.\n"); =20 if (!st->vrefin_en) return __ad7293_spi_update_bits(st, AD7293_REG_GENERAL, --=20 2.43.0 From nobody Fri Apr 3 11:12:47 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76321428841; Fri, 27 Feb 2026 14:02:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200974; cv=none; b=aYtKoHd7KoVlvF5VJ1HlkuwHMcFzscHXwn2eD1+Kyo/cu/THE91hyYnj08tSrwEx4FSZkw4S33s/UjgTSWBa9J2gFkRmtsUaq2gLmcfJ35r9k/R45zieVD0qC/8+E/owcMQzLUUkZUrtMOIrCqLke9NyNbdD11M4qWeUJKI9vyU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200974; c=relaxed/simple; bh=/QLC81W/SInE3P+w+3/xmwEpp/B2O2Z0inLaU0AK4kg=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pi6U1bzn/ZXo4y86ycGHd9kG/tlBiiF8rb0wF1BbQ3EKn5W9GsF4FTkFdLsiB8Y/NxpthPnxU7Oc8mQEeFoNEqRtaahjt/YGU0IQWarPqojqPmKJuycymYWFjSleXDmR3qpJEszA94aIKk9HosH+m6+ReVanUAvkdzyqWapEjCQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=WUgBUYLR; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="WUgBUYLR" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61RA9c2X1869414; Fri, 27 Feb 2026 09:02:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=IOKCP 599HQChc+Z8PdN5cd33mW/bosxLoI2LnZ5ZxnY=; b=WUgBUYLRSYyR7janRFcWw RxL48nkZkSRNRK9HuX6UFK5H8uwocu1Yv65LBMtY5klADK1IWk6Cif4MeEXGRDtG /H4Oc+/kqzBAReSY4XH4g8GN7xSxJtxS/Mqck7d/oZB2HvZuc5Sx1AVil1Ke5uY1 XVvaovQQPu3+0+3lEmoTFGHNLJ5POAxh6JNVJzkvMp4+Uw6L+M61f7/4m2li79yN kEIyElFUCb3UtHtfpQM6qMKUfelFdfXGSmUS0Il2x2qufZsb8XBVqL8sutYpX3Vc nWTCp0aB+1V2X4ePbJQzNnVKwgrzjueLqoITqGIwHsfcjNCWPqrnp/MZHKPp+qgB Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4chvwgbep5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:34 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2Xew064858 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:33 -0500 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:33 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:33 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:33 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t3x001982; Fri, 27 Feb 2026 09:02:27 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 11/12] iio: filter: admv8818: add dev variable Date: Fri, 27 Feb 2026 16:01:40 +0200 Message-ID: <20260227140152.77529-12-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=Dcgaa/tW c=1 sm=1 tr=0 ts=69a1a3fa cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=i-jfU8uie5Aefr0KE-8A:9 X-Proofpoint-GUID: lIiVNkLgJeBCojnnpQO0554ovEG_G1sC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfX05MYnQMXGE1X rpeaRIfbBMRDibrdhK6rnAtx5o+A+kOtzURtqJN576LG4xz3loPSqzT4mz3gfgc/S0x3QbImeva UDnid9ZrgjgZyEBCmP9qryRl/FyPYCPOZqvVyYpY+wMkL+F+Ut+ReUqOzXGis06ZItRgh7j6Vbk HCRPSQPUG2YuUV4CnDKDOg38fsjE7y5vhaUKAcZqdAwfyhTC9Yeu87EC9CkL3glv+x5ZwAUCrKf HPtG5qnPNpijQJ3ZA17FfknIIz/ZB+Dk2yI7b+yBE8wRdcVRr/tB8BK7DBT+pOyrLfdLKKw333E ZKixsYozH3VrscE9KGkyQVxPxkg0dzA1Rc8FYhBEqnIv+1LQJ8Vs9mv6fwDEdrlpsJzNumPodUV w9NuTnS/zDyRKWVu1n6Na+zEOeIe010GV8u93y+savORwsGcDkrswfcv4HpvO5hvjuN/bdeL6Nz QdhYaKsVNTGSAhqJZKw== X-Proofpoint-ORIG-GUID: lIiVNkLgJeBCojnnpQO0554ovEG_G1sC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/filter/admv8818.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c index 19f823446cda..5fafd71da2b3 100644 --- a/drivers/iio/filter/admv8818.c +++ b/drivers/iio/filter/admv8818.c @@ -701,12 +701,12 @@ static int admv8818_init(struct admv8818_state *st) =20 static int admv8818_clk_setup(struct admv8818_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 - st->clkin =3D devm_clk_get_optional(&spi->dev, "rf_in"); + st->clkin =3D devm_clk_get_optional(dev, "rf_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the input clock\n"); else if (!st->clkin) return 0; @@ -715,7 +715,7 @@ static int admv8818_clk_setup(struct admv8818_state *st) if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv8818_clk_disable, st); + ret =3D devm_add_action_or_reset(dev, admv8818_clk_disable, st); if (ret) return ret; =20 @@ -724,16 +724,16 @@ static int admv8818_clk_setup(struct admv8818_state *= st) if (ret < 0) return ret; =20 - return devm_add_action_or_reset(&spi->dev, admv8818_clk_notifier_unreg, s= t); + return devm_add_action_or_reset(dev, admv8818_clk_notifier_unreg, st); } =20 static int admv8818_read_properties(struct admv8818_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; u32 mhz; int ret; =20 - ret =3D device_property_read_u32(&spi->dev, "adi,lpf-margin-mhz", &mhz); + ret =3D device_property_read_u32(dev, "adi,lpf-margin-mhz", &mhz); if (ret =3D=3D 0) st->lpf_margin_hz =3D (u64)mhz * HZ_PER_MHZ; else if (ret =3D=3D -EINVAL) @@ -742,7 +742,7 @@ static int admv8818_read_properties(struct admv8818_sta= te *st) return ret; =20 =20 - ret =3D device_property_read_u32(&spi->dev, "adi,hpf-margin-mhz", &mhz); + ret =3D device_property_read_u32(dev, "adi,hpf-margin-mhz", &mhz); if (ret =3D=3D 0) st->hpf_margin_hz =3D (u64)mhz * HZ_PER_MHZ; else if (ret =3D=3D -EINVAL) @@ -758,9 +758,10 @@ static int admv8818_probe(struct spi_device *spi) struct iio_dev *indio_dev; struct regmap *regmap; struct admv8818_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -792,7 +793,7 @@ static int admv8818_probe(struct spi_device *spi) if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id admv8818_id[] =3D { --=20 2.43.0 From nobody Fri Apr 3 11:12:47 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4488542B72B; Fri, 27 Feb 2026 14:02:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200975; cv=none; b=dArhWd8ZdFkWwzu/mcEY8YB5qU2vQXBFUUWx2aah3tmvonMQytxAwE6F8d5KWGTRxobTOQU4bLmhXXq0QKdFexYrIRviaNg6T9tUhOq/Zp4ICJ21zeLe+2N4dFDOdawaCHv5Z4TQ5StuPLHz/LWIVBNkHxQDTJKbsLR+7h5+LdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200975; c=relaxed/simple; bh=5d0uKzynfG4aR2rTXOs/TJpC/Ni+jVbOz19e5BqPuGQ=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Y0MGDwAaKQcHGr3tsjkn3Y/ftB7FkozYtjJHDMfupYaNY91cfVDBu6D+v+KhxTgK6pLLFLSJX4N+TQ3otWsvjy77NXy69vkT/rSFZSwD4+1xENpO+t5V+lC6MDNRZ7jz8zn0WtgbbsKJMbMOj5cFq0bam8TG2M29p+ztBSjUif0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=t47Tpdeh; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="t47Tpdeh" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61R8N07j2503421; Fri, 27 Feb 2026 09:02:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=tTy4U QjwjXMCB3pTfM6BvJYl6/oelW7t0M0WX6YwZLU=; b=t47TpdehvTjdvO059MJqe VTHBDUwM2kFIR4tV5NTC0sk2krFtDX6PrPkBNzjmKmXW6ehW12amuelwHGighXTn 7ksdcN7WuWoyRGJXkJvy8ZEtXnf+Gy/7iEyS7b0zRfZFmgGt+nPGksJuvRmBaFBZ soagLzDRRtNPSpbZS2UkWBOdiHL4T+Uz8wkb3VlMZ0GqLNsAGINby96W2KqCj3mw m6NGznkKCfsEXL2G39b/a4FSjCY74zuyKk1O66X1KriGZohb+RRdwKWnE/QZUysw GBx6jCsxrry4pGkYr9eFRQ8r+PBtUigzVYGqZJRTNhiwq0Nd3T8cZVl193Xzmr3q g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cjbw3yk8j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 09:02:34 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61RE2XFU064861 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2026 09:02:33 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 27 Feb 2026 09:02:33 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 27 Feb 2026 09:02:33 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61RE1t40001982; Fri, 27 Feb 2026 09:02:29 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v4 12/12] iio: filter: admv8818: use dev_err_probe Date: Fri, 27 Feb 2026 16:01:41 +0200 Message-ID: <20260227140152.77529-13-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227140152.77529-1-antoniu.miclaus@analog.com> References: <20260227140152.77529-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDEyNCBTYWx0ZWRfXyHFLwlcp2Z6t P7V8CqOOsJ5SypwIjC1/TkrzzWHbinIko2qu+jYgmFOjhvgGgPD0g3v/7VZQA24BYVIck/axCDG JYLGLkiNgi9N+W4kgIOlUVOXJd96E0uwVC6E21uRn00sxbutVzm2SNdwfs22SrQJWb/ax27ZyTR K/2tdm+OII4TgMcM2apUEWzjifoFu+kGaUsMcEi+SraFAEKWvdK2EX0UPA7B6I8GO4nOVlpTbM3 WxZOs4GPDkm3Vefy6hT7M/ou0/zeLW8YV6luQRtVERmgfVuLQoW9h1TFCTOUytn/CAScttQcoYr DcMVJp4f7b9s51I51eUSBtW9I4IEG90qGmFg6uyd4CCfVUtqjTaHVFU9tehAUwxkvbQOwwaXRZR 74d8vqFgzF++Xjay91h4FgHrCI04R+mSGPDB/72p++1D43AnE6Yijn7rwYOb6lF7cxZCM3KizTM Fnppbkdu7eIp/z2nlzw== X-Authority-Analysis: v=2.4 cv=AtXjHe9P c=1 sm=1 tr=0 ts=69a1a3fa cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=bzgjXaNoBxcg6uAtW_MA:9 X-Proofpoint-ORIG-GUID: zMbrysNc0nvHdtjgqE-bGyAziFw3Zo-x X-Proofpoint-GUID: zMbrysNc0nvHdtjgqE-bGyAziFw3Zo-x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_02,2026-02-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270124 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/filter/admv8818.c | 35 ++++++++++++++--------------------- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c index 5fafd71da2b3..0b9e3ba55476 100644 --- a/drivers/iio/filter/admv8818.c +++ b/drivers/iio/filter/admv8818.c @@ -657,41 +657,34 @@ static void admv8818_clk_disable(void *data) static int admv8818_init(struct admv8818_state *st) { int ret; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; unsigned int chip_id; =20 ret =3D regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A, ADMV8818_SOFTRESET_N_MSK | ADMV8818_SOFTRESET_MSK); - if (ret) { - dev_err(&spi->dev, "ADMV8818 Soft Reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "ADMV8818 Soft Reset failed.\n"); =20 ret =3D regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A, ADMV8818_SDOACTIVE_N_MSK | ADMV8818_SDOACTIVE_MSK); - if (ret) { - dev_err(&spi->dev, "ADMV8818 SDO Enable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "ADMV8818 SDO Enable failed.\n"); =20 ret =3D regmap_read(st->regmap, ADMV8818_REG_CHIPTYPE, &chip_id); - if (ret) { - dev_err(&spi->dev, "ADMV8818 Chip ID read failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV8818 Chip ID read failed.\n"); =20 - if (chip_id !=3D 0x1) { - dev_err(&spi->dev, "ADMV8818 Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D 0x1) + return dev_err_probe(dev, -EINVAL, + "ADMV8818 Invalid Chip ID.\n"); =20 ret =3D regmap_update_bits(st->regmap, ADMV8818_REG_SPI_CONFIG_B, ADMV8818_SINGLE_INSTRUCTION_MSK, FIELD_PREP(ADMV8818_SINGLE_INSTRUCTION_MSK, 1)); - if (ret) { - dev_err(&spi->dev, "ADMV8818 Single Instruction failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV8818 Single Instruction failed.\n"); =20 if (st->clkin) return admv8818_rfin_band_select(st); --=20 2.43.0