[PATCH v2 0/4] Multiple bug fixes

Ethan Tidmore posted 4 patches 1 month, 1 week ago
drivers/iio/gyro/mpu3050-core.c | 33 ++++++++++++++++++++++-----------
1 file changed, 22 insertions(+), 11 deletions(-)
[PATCH v2 0/4] Multiple bug fixes
Posted by Ethan Tidmore 1 month, 1 week ago
This series fixes 4 bugs:
- Patch 1: Fix free_irq() being called with wrong handler.
- Patch 2: Added missing free_irq() in an error path.
- Patch 3: Moved iio_device_register() to end of probe function, in
  doing so had to implement correct error cleanups and place
  iio_device_unregister in beginning of remove callback.
- Patch 4: free_irq() is after called iio_triggered_buffer_cleanup()
  which breaks LIFO, place it before it.

I plan on doing a proper devm_ conversion of this driver, but went ahead
and did these fixes so they could be backported.

Ethan Tidmore (4):
  iio: gyro: mpu3050: Fix incorrect free_irq() variable
  iio: gyro: mpu3050: Fix irq resource leak
  iio: gyro: mpu3050: Move iio_device_register() to correct location
  iio: gyro: mpu3050: Fix out-of-sequence free_irq()

 drivers/iio/gyro/mpu3050-core.c | 33 ++++++++++++++++++++++-----------
 1 file changed, 22 insertions(+), 11 deletions(-)

-- 
2.53.0
Re: [PATCH v2 0/4] Multiple bug fixes
Posted by Andy Shevchenko 1 month, 1 week ago
On Mon, Feb 23, 2026 at 08:35:07PM -0600, Ethan Tidmore wrote:
> This series fixes 4 bugs:
> - Patch 1: Fix free_irq() being called with wrong handler.
> - Patch 2: Added missing free_irq() in an error path.
> - Patch 3: Moved iio_device_register() to end of probe function, in
>   doing so had to implement correct error cleanups and place
>   iio_device_unregister in beginning of remove callback.
> - Patch 4: free_irq() is after called iio_triggered_buffer_cleanup()
>   which breaks LIFO, place it before it.

All good, except one stray change and some work needed in the commit messages.

> I plan on doing a proper devm_ conversion of this driver, but went ahead
> and did these fixes so they could be backported.

This would be nice!

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v2 0/4] Multiple bug fixes
Posted by Ethan Tidmore 1 month, 1 week ago
On Mon Feb 23, 2026 at 8:35 PM CST, Ethan Tidmore wrote:

Just realized I didn't put a changelog, the only actual changes is the
implementation of devm_ to manual cleanup with Patch 2 [1]. The rest are
new patches.

[1] https://lore.kernel.org/all/20260220200522.19967-1-ethantidmore06@gmail.com/

Thanks,

ET