From nobody Sun Apr 5 19:43:15 2026 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB8011DDA24 for ; Tue, 24 Feb 2026 02:35:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900533; cv=none; b=p8I9iNz049dU5mVzCYAyExr/1ctqMdDTajqh3bBbTuHdZih/b/jRNNseyo0LV+aTbNm20fH41IcDMG8h+W7zKj5nH/DI+i1wWwtQ1KWjtHs4bqp2nSVnF2YPhunVZRU9Zs49tjF0GMNvInleY+oFStPC8HO+gCOFerv3MnCQvdA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900533; c=relaxed/simple; bh=sUUTc4p7Q7MAk0TuxPkh3WHIjMo9QRDZGHXqzu1O01c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f+fsykWhPyu24hkCHCDXiPOycK8El/7olYoWqOYaaW9hMz6pM2IZVV2BafSYdiuFC28FblOo42eDPWO06te81Pj14xVsw0igvfBwMIyUf+whdtGvh+Pg0B70LGZH2DSbqcXQC7eO6uiJW7A0HneLSteZVqxmRjriKtB+uDAcxR0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AAJGrccW; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AAJGrccW" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-793fdbb8d3aso42162017b3.3 for ; Mon, 23 Feb 2026 18:35:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771900532; x=1772505332; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iusn9u4xQvFJzEMelWbMLj7LoP4DkYbFjiqTDekST5o=; b=AAJGrccW6VcC//BwO6jckPpRLhhcDVA96MghbutJxCNLfI4fOtLuIVSMCOUT9udrH3 KC2C7NP9SK15ol5ugtyTuxczDkn0G5OxPCIvrzn4BfV/EBN0mYlCMaZqOjiHEOQxuPJh ot0Qj/CwezWQLycDzUyWoNtqFeQMTZ72MB6WrNnPrZB+liW2ATU6yzGthBWTlSaxmddV I3t1KaZ942XDURuSU7+QSaiyWk0EufEe3+ahdLPAG7EJf7vnIOgtAwVK2gTlZNYHAw2s ja5C1pYiDi4EIH9b+BAr804z3Z7oF2hM0PzRWLekl2aCXTtYnz2NfizXxub/hYCcfPf5 SQVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771900532; x=1772505332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iusn9u4xQvFJzEMelWbMLj7LoP4DkYbFjiqTDekST5o=; b=L8ZB9gD/EktExMIY+GC1XJArbqQORvFTikxZzppvj5hJle9agaU4cQf9SmSx619awW xEP9PEBx/LHN2zICUVfgublyOWkaNCsNRztVXzRpTps8W4oQRxkIKDZmwkrJ+YchIALn yMHTpJv2U/G9g09CtFPl2Up3p9hyxdAGEu7XWbRvCR6/FP7oyTMqMKEDP7zambgfenwc Xi1l5LX80WtvwiJ9WjkAB38rDr+qdx1Y3S+87MyvX1O+FH+ZoV9JgHNmUM40XXd26K1k 0TdNX5lDlLBSreriJkx+LsIHgpKAfjeyu+JV7lPUTgoel3juYzB09YP2TIaAuq8CuXcQ G9kw== X-Forwarded-Encrypted: i=1; AJvYcCWzsctN3IVu+ZjIJ+f6e2+Q4meHR5O0+UhyfaajE4FOav9cqcW2dBGORxlb//i41njKO5UWUYcY4c/oOiw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl/HnRUcQZXvcohOErSkDV4lAo7GrybI/tv6ZORT+2tux1nHd9 9SxF+blmu6z9rfmh+RM3ml9WdPHTY+NdxK1LwpgOhftKtnIq5JRL3c48 X-Gm-Gg: ATEYQzz/CPNwAd7V2+PMi5DEIEusoKbg2Wuk7NUcDGVhzUxwawrFTYNroVVabWHNkBI KiNas0Zkiq9RgUxIAm4xKJefHwdCu+5txYzsBXeSM4NIgg1Nl71U0PNvs4VXIiIRw1ejHvlf3J5 UUm/pgggP2BDLKS+dMe0xBknWHiN+RZAky51+TmG57bOOC8Xf1jci1GP36M4YjIBQkXpzlu1owK gmxdsamf0ywR2J4uF7URleEW7MH8HxkIPCnEhdiC2idWiyekRqF3PDmEY5b/mbSK3WfIKF26Q+3 usRKPagYLk30AkQQyk9/MB43fVxOKN590gEAcHMOH4bUjoXU8dU3iIj1u3gTCqRu871j5KacY/V 7xIFS3H6vV/QWiWI2lJssX7vc1FbepEbPvGnU5AsgYPO5YxVe/w0aLZqoyOOMElgbgA4D9IHKD+ Fn1e2P/VEUrLXrG1+64z4c8ikIydQI8IZkv1ae8acJxstLfCBkCGsF2nJXKa+OnMgkKANWmYfqI ts4rc7um/yLvOpRyD2h+7BY X-Received: by 2002:a05:690c:e3ee:b0:794:ea75:4856 with SMTP id 00721157ae682-79828f36062mr94265277b3.23.1771900531787; Mon, 23 Feb 2026 18:35:31 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982d985074sm39585407b3.0.2026.02.23.18.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 18:35:31 -0800 (PST) From: Ethan Tidmore To: Linus Walleij , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 1/4] iio: gyro: mpu3050: Fix incorrect free_irq() variable Date: Mon, 23 Feb 2026 20:35:08 -0600 Message-ID: <20260224023511.274038-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224023511.274038-1-ethantidmore06@gmail.com> References: <20260224023511.274038-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The handler for the IRQ part of this driver is mpu3050->trig but, in the teardown free_irq() is called with handler mpu3050: ret =3D request_threaded_irq(irq, mpu3050_irq_handler, mpu3050_irq_thread, irq_trig, mpu3050->trig->name, mpu3050->trig); ... void mpu3050_common_remove(struct device *dev) { ... if (mpu3050->irq) free_irq(mpu3050->irq, mpu3050); iio_device_unregister(indio_dev); mpu3050_power_down(mpu3050); } Use correct IRQ handler when calling free_irq(). Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Signed-off-by: Ethan Tidmore Reviewed-by: Linus Walleij --- drivers/iio/gyro/mpu3050-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-cor= e.c index ee2fcd20545d..06162d886b59 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1261,7 +1261,7 @@ void mpu3050_common_remove(struct device *dev) pm_runtime_disable(dev); iio_triggered_buffer_cleanup(indio_dev); if (mpu3050->irq) - free_irq(mpu3050->irq, mpu3050); + free_irq(mpu3050->irq, mpu3050->trig); iio_device_unregister(indio_dev); mpu3050_power_down(mpu3050); } --=20 2.53.0 From nobody Sun Apr 5 19:43:15 2026 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0437239E7F for ; Tue, 24 Feb 2026 02:35:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900534; cv=none; b=HpvVsL4/Xc9Qwwg1PjQN2LG7RYDZPZHHucdkczeU8NVfNPGAqk1GeyIrtzIhZqt4wjKpvmJo8Bud0G3cQzFXFrHdh2KTMpHCUB7EHZiJyxhbRqKQwYL8DgvX+32wQQvL1IJhooMeGNEvkpWvJvS8vlERtXzVzoftXcrutS15Cbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900534; c=relaxed/simple; bh=JjkQ46yG8p0a6c9D14dqWVJYigSn20ev39pBlgmVkBk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QJ5fi1rU/Nu+gqupE6ZIUTavZv1MNnQ0wolaipXLThR8ys6j0astfAdomb7RzciCr1V2IbAAvmU3h2Kw2wtU3vQYL2n716U5UaY1W0gXJNjez3aMCMBlY+wzfvsg/vs2Eld19Pk1U2SNQkCiR6Z21V2/wNrvenf8nSn79NpoUjw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KkO15hWe; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KkO15hWe" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-7947cf097c1so46109957b3.2 for ; Mon, 23 Feb 2026 18:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771900533; x=1772505333; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w7iGixlg0fjOS+Dh9LySNPkYFcBUk+pqdTwPH6+Zlvs=; b=KkO15hWeVtt39fM8N+XTKysoSZT+Cuf6NlUk4ud4G3I2vFfNw7XUw6RhCMlvyfEaSn X6FP5AdEccBAFBWzl1Ncwz2fseSg4VHgbHPDFrYK+XRUhNoowU8Z7a06VuW7FymZZ5hY 2V3smkmxDLA2rZ1rFIzPx3Y5gEmW2gBpJ7+tfl2blq4U4pvZacJXLFm2kNSvGFLHgCaL XlJQfHRN5QNXxpDzZY8tF4nYsHEBBzI0k9HC0dVTRHAMcMzBVY/aCLp6vZDR0vHj/IFb SoVcViP1ZiuegDyrp90ESCmhiE6lhBbDhnnoRwBv6qnf3C+YBXQeePhU+Plw0r5BUjCx L5RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771900533; x=1772505333; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=w7iGixlg0fjOS+Dh9LySNPkYFcBUk+pqdTwPH6+Zlvs=; b=lwpYzYKKcprOr4XOeaNeVg8C5J+HsumldNOziH0ShE1B8HlrgXjGyXDum3eJc9gExz Ltdt1zsECEXdI7KP3AMICnEHphyiQJgrOoGCjlLuHFng/mftxOV3pVCPQ65+9T6X2CWR QcOEXKFXH12Z4bEjYwLhXJD74Ur5mjq4OKzZ/4q14wKIvkNvUYKZ9VshKvYVAREQeRmM nRj0Bxup2LEAsbfB3JiehAQEHMAzhrbX28nFK5NGDlTK3V6XjbN1CgfgtHqc80lu4bh8 UnXJcBh5TC17t8HoOE+5mQkjG6yR7PGFTe4Q6wf0Zl9yEzM9UeLxKfJ0og86WsSi6Ish 7HQw== X-Forwarded-Encrypted: i=1; AJvYcCU4T1z0YuNLENVQr/+NqdP7YaHSWeJojx5zDGZXIohrP4Dezlwo1jJ84YwQ9wwR71LZyxIJq67E2ziZ00U=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8ebOeNOr4h8djYPfgP0REcp4zfWkJplK2w9o5pBhq9q63Y6q/ shwaZwRszDWXRRR9KAswfX1xvOpmEJ4sHogbTDCLZU0g0hu+alCLOjRBmbnuVi1Cjkw= X-Gm-Gg: ATEYQzzpplJ9hZVmhGdYjtc/D6JiiMyUbaLRJ/KdAiWjf6zWigSt2Da7Q9pYovKTKMl Fpxf5+FkQgojWK40pOytyFqpy3mNIMtG85SqCwwQkHzXfOzb3zZtJYXH/LKCmN0XyW8xZW3cXlw D7B0LRu7U9yWr3wjn4aKVnfahfY2VXP7fV1/WxrqkUBRRYkhB8CThSGEabVTfAEW0VjJO1tVP94 STM/SJmcyFvgMjDd2l5AKtvIA9lWVsn3mhvKabm+jL9SUUJFTejEj8ldY/BVzC8X0jYUEOyWD43 +f7eehfSMDCR8QdjGNma6MtgOxrZycPgZYtOw+glI4i8m/HYvry1sLTfflqgl3Wkt4FI/1f5mPv zfe/zbw8vm0paZIX5eOIPDUYKDKqDMICxDIaKiJ9iakS8Jatqek/IQu+9ZJzmdY6o1/9vVJL0Zq A26D5FBKW5JQliWxMaTGcvSO0TwDwA6knt4fU/OQZknWfCaS8SG/LhKes76voxS42HmE5oDSmbv DU0QNV/zyz30AkJ1XdSrx9N X-Received: by 2002:a05:690c:6c89:b0:798:3051:2f22 with SMTP id 00721157ae682-7983051331amr73611867b3.49.1771900532669; Mon, 23 Feb 2026 18:35:32 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982d985074sm39585407b3.0.2026.02.23.18.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 18:35:32 -0800 (PST) From: Ethan Tidmore To: Linus Walleij , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 2/4] iio: gyro: mpu3050: Fix irq resource leak Date: Mon, 23 Feb 2026 20:35:09 -0600 Message-ID: <20260224023511.274038-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224023511.274038-1-ethantidmore06@gmail.com> References: <20260224023511.274038-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The interrupt handler is setup but only a few lines down if iio_trigger_register() fails the function returns without properly releasing the handler: ret =3D request_threaded_irq(irq, mpu3050_irq_handler, mpu3050_irq_thread, irq_trig, mpu3050->trig->name, mpu3050->trig); ... ret =3D iio_trigger_register(mpu3050->trig); if (ret) return ret; indio_dev->trig =3D iio_trigger_get(mpu3050->trig); return 0; } Add cleanup goto to resolve resource leak. Detected by Smatch: drivers/iio/gyro/mpu3050-core.c:1128 mpu3050_trigger_probe() warn: 'irq' from request_threaded_irq() not released on lines: 1124. Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Signed-off-by: Ethan Tidmore Reviewed-by: Linus Walleij --- drivers/iio/gyro/mpu3050-core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-cor= e.c index 06162d886b59..b6e05afbe512 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1121,11 +1121,16 @@ static int mpu3050_trigger_probe(struct iio_dev *in= dio_dev, int irq) =20 ret =3D iio_trigger_register(mpu3050->trig); if (ret) - return ret; + goto err_iio_trigger; =20 indio_dev->trig =3D iio_trigger_get(mpu3050->trig); =20 return 0; + +err_iio_trigger: + free_irq(mpu3050->irq, mpu3050->trig); + + return ret; } =20 int mpu3050_common_probe(struct device *dev, --=20 2.53.0 From nobody Sun Apr 5 19:43:15 2026 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91E24265298 for ; Tue, 24 Feb 2026 02:35:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900535; cv=none; b=TtacogjeMZRcDj5yRmKW4RUFB+bv1EMeSiB3SOAW2uQLismRM+3DZ0v8O9bEeQwp9BxP8HH7RMVDpwL5BTxFdTiAMgiLmyCmo+G/OYxV2E0pHmE5Ox51RJHzkM70n+id53FmLZk9u9BoJNwBtTHEtXnI3hdiwcTAyWXRREl1+6Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900535; c=relaxed/simple; bh=gYvFshSHeFO4g3kALOTIM0u06mqGXjlapA5rA+UNYK8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CevDtByv38hUJHMJtZ2XTnmEOWesOQKe4ekswWAWbYF24dKxRbpe20pMbbRQ9Bir55FVLhDQ8mycdQtEcPtjgrykkpdgXUOO5M9/NlvtBC6KsGd/+BjJYPVV93sPfFGjEC0t8B7yamCn8Fu6S+LOhkPoOn87JJexsyqAlewbcwA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mX6RXOao; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mX6RXOao" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-79427f739b0so45556657b3.3 for ; Mon, 23 Feb 2026 18:35:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771900534; x=1772505334; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M4MU5OJCaPocPPn0n0+lESzz/W1ZYrIATioLMy1y+L4=; b=mX6RXOao0SVM56z++x0ueIa1FA9AtWVEhogsJfQZNrWTCZ5P14+t00monlm7EHYHXH tpe+RSjPBSkMCLq4zSvD6u0yi+BrIcRUoePYzkJk6iSv7Tv2vex84cI+E5PU+0q2y4VO 4pBSLhC5TlVF0n/McUezxefJzBSodk7QkIJQqGesY5xU15hdYJoiaQ6atH0x+hUT+pbV fxAXCc6KQdsxvK1IFpuwNnSrW/B5lXAdP+f968ogG3hFjso6Q9k8ymX4LWp2UGSZ/of1 xOVzmGH4fgAI5/rAEuqVDZ46M/jQs8POpTErDQomsot9o8rCu0aBAUZkc44Dbi5q5aCX A+aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771900534; x=1772505334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M4MU5OJCaPocPPn0n0+lESzz/W1ZYrIATioLMy1y+L4=; b=GGse2hdD8SaVKReg2q9UKE4aM+zAmO0r1jMx/zg3v3dB1b1qWF2JDOo7Oro0Dp6hOR fYFBIth4oAA4Jr3BpCF1ecOrclTEsD6GmISoCi+Xfn5qvQw85+WSJ2tFna0d6hz4lEh2 UUwNd/E9aOupXaGEDIfQ750xXpouTrqx0sNtP7DfDL/ar5VHuxTduWLd2z2WwAe1C83L tWOGbrW36iqCcponXMkPv92aQJRoUimt5qjirI9iF24PKFk8s6XyF1L8VmVOUpZJzVm/ UxrqCnI2kDuS0rTQ+2onYgp6mz7DzZt7kDaTpAYF0n2WRkfcH4vsgoo3wa50QTDAh/HA 0N9g== X-Forwarded-Encrypted: i=1; AJvYcCUoQBFO1c/WFJKpLP2nE+OJTFhv3NeBok9IEikPb8tLmBaxKMqCel5ltKvT0SvRjvwQJEopFzoTi7Pn4G0=@vger.kernel.org X-Gm-Message-State: AOJu0YwIucTuC5/KweUzeEN8iK4BWPd5QDFkf+05x+9B1p0hvew0yz8x RlYpxvu/N9PHIWAqfHDqEX3nuJSyVV1Y6ebgoW3EYvIBFHgAB7THlF89 X-Gm-Gg: ATEYQzx1oG+jrwu7gN2BE3h2Tg26d6zhwjNRO3xQ2z34ooM+afuGGRavwjVkleAzlKJ EF28uEno/ghlmwCdY9Qhuif6sd4M9JAP3OjK+YpL1dxN1xR5KiTe5tEfBIiILBWabJEObTnCYpU PEEnKwwyQWdcfPq4xCBo1+fDoITX/gEWJVAt6CF8KGZYk/p+0hR2YQOSY1qFBppwKyxoSqFdfoi ipikGKncV4VCyn0p9ZlCucBosyfkUBsBK5JPqW6UETkq3OWI8Pn6TBBAS1J1nPJ4Wk+1T3DO2P+ bBWTlk4e3fGSpbGsl6pISZkXL//54CHkX2FJTjQ61XxmoQHHOn6PLp5DciFEH4IBcZ6ehVb9ilP MmLXquWTZtYTM/0XYCYvhPAZAuVsYC0/yIIT+6AHgNjnudbaOssQWeYyaxuVr77QW45yatGskz3 GjtwUjnVxQQvNFN3UWhzBeNTbvqsZ2Rg1YGGGi3c30GPeeT4q7/qeMbBoU48JS84n2YYePJ/cur qV2MOx5sOljsl4yQFTGBV0JkEU6KdkAlm0= X-Received: by 2002:a05:690c:67c4:b0:796:3787:39ad with SMTP id 00721157ae682-79828f249a1mr112426477b3.27.1771900533662; Mon, 23 Feb 2026 18:35:33 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982d985074sm39585407b3.0.2026.02.23.18.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 18:35:33 -0800 (PST) From: Ethan Tidmore To: Linus Walleij , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 3/4] iio: gyro: mpu3050: Move iio_device_register() to correct location Date: Mon, 23 Feb 2026 20:35:10 -0600 Message-ID: <20260224023511.274038-4-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224023511.274038-1-ethantidmore06@gmail.com> References: <20260224023511.274038-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" iio_device_register() should be at the end of the probe function to prevent race conditions. Place iio_device_register() at end of probe function and place iio_device_unregister() accordingly. Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Suggested-by: Jonathan Cameron Signed-off-by: Ethan Tidmore Reviewed-by: Linus Walleij --- drivers/iio/gyro/mpu3050-core.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-cor= e.c index b6e05afbe512..73dc7ea1f075 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1218,12 +1218,6 @@ int mpu3050_common_probe(struct device *dev, goto err_power_down; } =20 - ret =3D iio_device_register(indio_dev); - if (ret) { - dev_err(dev, "device register failed\n"); - goto err_cleanup_buffer; - } - dev_set_drvdata(dev, indio_dev); =20 /* Check if we have an assigned IRQ to use as trigger */ @@ -1231,6 +1225,7 @@ int mpu3050_common_probe(struct device *dev, ret =3D mpu3050_trigger_probe(indio_dev, irq); if (ret) dev_err(dev, "failed to register trigger\n"); + } =20 /* Enable runtime PM */ @@ -1246,9 +1241,20 @@ int mpu3050_common_probe(struct device *dev, pm_runtime_use_autosuspend(dev); pm_runtime_put(dev); =20 + ret =3D iio_device_register(indio_dev); + if (ret) { + dev_err(dev, "device register failed\n"); + goto err_iio_device_register; + } + return 0; =20 -err_cleanup_buffer: +err_iio_device_register: + pm_runtime_get_sync(dev); + pm_runtime_put_noidle(dev); + pm_runtime_disable(dev); + if (irq) + free_irq(mpu3050->irq, mpu3050->trig); iio_triggered_buffer_cleanup(indio_dev); err_power_down: mpu3050_power_down(mpu3050); @@ -1261,13 +1267,13 @@ void mpu3050_common_remove(struct device *dev) struct iio_dev *indio_dev =3D dev_get_drvdata(dev); struct mpu3050 *mpu3050 =3D iio_priv(indio_dev); =20 + iio_device_unregister(indio_dev); pm_runtime_get_sync(dev); pm_runtime_put_noidle(dev); pm_runtime_disable(dev); iio_triggered_buffer_cleanup(indio_dev); if (mpu3050->irq) free_irq(mpu3050->irq, mpu3050->trig); - iio_device_unregister(indio_dev); mpu3050_power_down(mpu3050); } =20 --=20 2.53.0 From nobody Sun Apr 5 19:43:15 2026 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C0802749DF for ; Tue, 24 Feb 2026 02:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900536; cv=none; b=fDKpTeZxfFIg5gRyaivOY5C38ZgnuO5Ne9qW9gy/T5SSBmuSPl5ofbJvBb/p0oNLULDT7FusKZ9yv34Dk1miEbg2n+ey48qGj5rP3STgWE9Wd65tx1D0KMF490faLiKToJj0ET1ourvtrwJnkKHom7BTEVM8AcPeCqVmYyuYbBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900536; c=relaxed/simple; bh=KUnaoDdsl8scQ/d6Iox00XXk6u382zdfvElDYxnQ6FQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=THUft9l+2muD9okbBblMskMe1pMPEGu5RXzUFo3XbKB8K+cOYnZFMBQYSSNQkmZiIfKGSOm5F2stZng4W7DFLEHP1JSGAHwHqYBFMtSt92pNiy6cXQci1SwlxuQseTtgq7qedl7YRv5ppe8b9i0IDTQKPJHZBTMlwQ0jwCspj3Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nmEA4bJe; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nmEA4bJe" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-798527f822cso11698067b3.3 for ; Mon, 23 Feb 2026 18:35:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771900534; x=1772505334; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=syQrnKdSaSXvjiSlw6u25fzSgvyUrjxfjMVEd7QS078=; b=nmEA4bJeJ/arfUSzBIEiEwvTlUvp7TSzVQYzHrvvPolNeDy6WrGH3Xmqpd9viIwZTX 1zjMPPfv/9alOSisj0IDL2ZTNDh5blK6cXh44MzvbP5B1BGyAMFTt1C21OUKktBE0w1n ws3rkIDrpeVtXA579vcaPtFEYFPrd5MElp+JdncyeSn1PGZt3EO4UW379tD8047DtxGr rGudQJthsNCimdIZcFT/9jSW9gR32aThi7yFWvdBbCpNVLM5ME+R1/Xh0Hu4JvDD4YIk eC4KtGsdx4m9H5H9vh05g7xmjg3negfw/FvgwcaadWFpRAzIDW56bayC3Jr9eFKJD76n WakQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771900534; x=1772505334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=syQrnKdSaSXvjiSlw6u25fzSgvyUrjxfjMVEd7QS078=; b=DPYTr+0Eslcpou5Ojo4lwU6c0zgpE1FUfX5Nd8eEs24gyzYvCmWU1i10ZGPPh33oWI 9CptLKHe/xFCX7qfzFyXzaIctZUoiQ2F9ueIMlcNmK4W6N08MsIrYGT5ucEXV9rm8etv 8pPPx2JeQliGbxrE3llJWeDPk4wynGdNBC6gPGJHkCp4ennPRRparOqpB5+Ys6P6sFMA TnNO63sRu/bYP0bASrs1q+8SIw5gBUY4KLINGVo87S/Lh9ooqd0JBkSXKZLoleFuPmnd qZ+uSZJVs1PUanWeNlInntsMMaXdhc0PZMOQIpNeM3a0bk05DDvF+bFvpm1bXiYA5GLv Ybmw== X-Forwarded-Encrypted: i=1; AJvYcCUNqiEKDP9iCFnowF6yPh9FGq+JXV19kuWimBH94L5gnqSzdmMs6tlIuMF1D3DZ3f3EMne0Q4beQ4Mpo1g=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3rYfawY5jtchHvRHJ5ITJLDWN3u9+KdH8G/XS4uFIG8Wqcw1o Pk+00hqBEgb8oyKrEPzOJERKTSqIprplsngEXh28RotIvYHbzC5A7Rlh X-Gm-Gg: ATEYQzycSXsLVj6oPD4yLBqrIIpy/uJWJHGCr9C+4AXj5kpPLkjo7GjsbeAspjDqaz+ vBQTKALkTQICpk2hAf9tuM6G43Pfk2SdVgzGxu1aDh8ox9N4hyEAtTACHHrJxHjGrDIOBHJQifA ngIw+HQX/3HGzvwmewBYq64bN6pRVdl7SHvZsZLZQYuWDot2e/HoMdecLra+0/VoOQx05MsPZhX 84yQStfpKM0263plkbfCtZSYIYKafIW1pG75Fd48Ud3Xpq/jKJT9n6+HW5wkjTvK8ILRR4Z2k5H k14VLKcPdTLKpr6GRRIonXwkPcMVHklyC6Ob4OlGYvH1AWtl0l/COpV+WXDllZXtCXbk3iZKeO/ ckHjGT6NIIu4dh4EOlmsPbankkh5yNrgdRMZ8+zEQvPYpnXIkB2fY57jcapG9AlplZHVyY2Ft2s eaecyjVix9CTuaGEKU1ab4aLrNDVIJZlrDHN7vm055Qvy+3TpLZE7bl8xrIcXF8fvDqf0EUlgbM JqNhBbz2c+iKocpNXRPSYM2iA8ab8LHM7Y= X-Received: by 2002:a05:690c:46c6:b0:794:7e1e:7f8d with SMTP id 00721157ae682-79828f18314mr88008657b3.18.1771900534476; Mon, 23 Feb 2026 18:35:34 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982d985074sm39585407b3.0.2026.02.23.18.35.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 18:35:34 -0800 (PST) From: Ethan Tidmore To: Linus Walleij , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 4/4] iio: gyro: mpu3050: Fix out-of-sequence free_irq() Date: Mon, 23 Feb 2026 20:35:11 -0600 Message-ID: <20260224023511.274038-5-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224023511.274038-1-ethantidmore06@gmail.com> References: <20260224023511.274038-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function free_irq() is placed after iio_triggered_buffer_cleanup() which breaks LIFO because the IRQ was setup after iio_triggered_buffer_setup(). Place free_irq() in correct location. Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Suggested-by: Jonathan Cameron Signed-off-by: Ethan Tidmore Reviewed-by: Linus Walleij --- drivers/iio/gyro/mpu3050-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-cor= e.c index 73dc7ea1f075..3517522e3a51 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1271,9 +1271,9 @@ void mpu3050_common_remove(struct device *dev) pm_runtime_get_sync(dev); pm_runtime_put_noidle(dev); pm_runtime_disable(dev); - iio_triggered_buffer_cleanup(indio_dev); if (mpu3050->irq) free_irq(mpu3050->irq, mpu3050->trig); + iio_triggered_buffer_cleanup(indio_dev); mpu3050_power_down(mpu3050); } =20 --=20 2.53.0