[PATCH v4 0/3] iio: frequency: ad9523: fix checkpatch

Bhargav Joshi posted 3 patches 1 month, 3 weeks ago
drivers/iio/frequency/ad9523.c | 88 +++++++++++++---------------------
1 file changed, 33 insertions(+), 55 deletions(-)
[PATCH v4 0/3] iio: frequency: ad9523: fix checkpatch
Posted by Bhargav Joshi 1 month, 3 weeks ago
Changes in v3:
-Patch 1: updated macros to use '(x)' instead of 'x'.
-Patch 2: collected reviewed-by (no code changes).
-Patch 3: fixed vertical spacing and broken indentation.

These patches address several checkpatch warnings in the ad9523 driver.

Patch 1: Updated the macros to properly use their argument x.
Patch 2: Fixed the multi-line pointer dereferences.
Patch 3: Updated symbolic permissions to octal (0444/0200).


Bhargav Joshi (3):
  iio: frequency: ad9523: fix implicit variable usage in macros
  iio: frequency: ad9523: avoid multiple line dereferences for pdata
  iio: frequency: ad9523: fix checkpatch warnings for symbolic
    permissions

 drivers/iio/frequency/ad9523.c | 88 +++++++++++++---------------------
 1 file changed, 33 insertions(+), 55 deletions(-)

-- 
2.53.0
Re: [PATCH v4 0/3] iio: frequency: ad9523: fix checkpatch
Posted by Andy Shevchenko 1 month, 3 weeks ago
On Tue, Feb 24, 2026 at 03:26:33AM +0530, Bhargav Joshi wrote:

This is v4, what changes did you make?

> Changes in v3:
> -Patch 1: updated macros to use '(x)' instead of 'x'.
> -Patch 2: collected reviewed-by (no code changes).
> -Patch 3: fixed vertical spacing and broken indentation.

Why did not you pick my tags for patches 1 & 3?

> These patches address several checkpatch warnings in the ad9523 driver.
> 
> Patch 1: Updated the macros to properly use their argument x.
> Patch 2: Fixed the multi-line pointer dereferences.
> Patch 3: Updated symbolic permissions to octal (0444/0200).

-- 
With Best Regards,
Andy Shevchenko