From nobody Fri Apr 17 07:13:22 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18F873793C7 for ; Mon, 23 Feb 2026 21:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883837; cv=none; b=uic03q33M2vmka4sxcxIQCdGXjoNm93pEZCD4tgX8nGAX/IEBw6Sfxy6FT73Y6ek/rQAimeVoGK24pf5IzmG4YT0mpEA69xb4/Uw92WFk+2+Z7cCcFMnkaoCvmeuDM7FPuTry4a0QsGXmvb7zETxAm1KaRVt1QtlG5YU44bk2eE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883837; c=relaxed/simple; bh=E92lXIRr60SHMg2fArc47BQNbTfjxQG/SOtt2nLRB3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X4ixJKPbiSwZlfPHPdYVWH1mZbQYE0sR1jMf4SmTU84kuGtFHCcrDd7C1lCShe4Akwjt2tK7qUJiNYcCgiqnfnRyF2NK4MdpRFnXU0pAXP12i1yW4BnG6HZjMEzDbMeuX4zKvCQin0UupkTKN2KNRqPVZaIicJEmtzjdgYEsag4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q7iBs5jA; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q7iBs5jA" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3530715386cso4018193a91.2 for ; Mon, 23 Feb 2026 13:57:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771883835; x=1772488635; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lQTr7mgIilChf/JeESIDYXvGnp4mBQvya6Be0H5NIwM=; b=Q7iBs5jA4ZkGHyjPCDWIne4dRD4AbPC8Bk2OU9oDin1l7AW9zpXyNJ/lCncbPWN/1n QE5TL455craZ1baYHR8sZ/0MoolX0tthbzMu8Gx6PBtaa5FW+0yHcNST+JwDEhtw/7Bv dcSf1cEvVeLEmXo9YolRpKggsHmyBp8XCLWRBbrKOXmYyxSXnvKJY6DjPioFm4BXnqlQ ZLjtkbgqMecxnW3kzC3PqyKB/njcHQCnlzfufgLZ7pcFvhiwJtEEemnzA5k3dOpgZ/aA 8++x8Rixh9bucORypwujWkqRI0HcP1NqEhQ59gKN3pdcQYfI9V3OGiTYF4GYBzdcivKi vikg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771883835; x=1772488635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lQTr7mgIilChf/JeESIDYXvGnp4mBQvya6Be0H5NIwM=; b=bcEtmilu0GFBktWJVPALJSAi9ACa5nKRpOtr7ujbCiLpg8dfRYn2eY7cd2mGyg98Ow wOzRwy+SKeu/kwU74Hd2AR/fyRBAIgHX6QUxOkMOJaTuy5CImo+CqDSMbRKdjfyytSLH 8nnIqju16yfHqB9FSbcfSdW1cK7q0D74hRLvVWvbxIEuljfSgfrUoQ+K5iUUZEXwAnFW VxKFbH1jWT6fnlrYKtL1cOiFf+roUk3o7AAgpSTCqFh/Ged6CkUW+kA76ikd8ciEnmUv HYHskod9gI/vgzY5jhqkQK+afQeNj46C8K9RaTDnOCAmRpRa9bJKm9l4/9Pc/U+LsdEV GiQQ== X-Forwarded-Encrypted: i=1; AJvYcCVtS56eWSTWzXvtYkmDTLxUMIl/Cqkb4LCMKa9TS2/o9decSaTOphGWT4klizULfK43hOAaByRRic1xMBY=@vger.kernel.org X-Gm-Message-State: AOJu0YzihNj4iDNjXgTYdaJOz1uD4O7EHH5zI1+uPv/KK3/IPCoX17Bi kJadN6wuMhJd667kbnWIr6ozHTsA/mdZ/JOuxKo82+r0IzrjV0cdhZ1q X-Gm-Gg: ATEYQzw7fv8g7wd4GswxvZN9/WhGEFVTxpjPrYeqV6aSYouoiOIR2HrbfIuqeOqdAAa Cbyxpx+cPs988/I/aBHNNgL/625fUrcA0v7sPhBM3iupvFp3595tHuUx56IZCpKH5gj6ZJqiOE2 R6vzI+SfpQGTYDCfgnSyvbDEoOp4kzYgKkiAToUNrnasdO6Ez7cKkk4v84BQrCzKUCRdQNdKdWc KtoKts+qO7xdyDKrej5E/BdlV7TVrOdDQiMxI7ifBc6ShSt4n8bRlHHoSzT8oLN8QNB0d5li89/ 13PgXj+4tFY91DaHlxr6oTY3l295z+MaF2+LapHY526xFFd/BK5Nj7UJgJ4/UYA4BkzAhB0w3Ml SJxx4hkQcrF1NN472jXY68yVD28AePGNWA8A+o82/+HUwG3zdWACkiUc/n/I/2/h7R08/ITJVft NSh5Bn3wXHckxnJh3soJQhIw== X-Received: by 2002:a17:90b:5410:b0:340:ca7d:936a with SMTP id 98e67ed59e1d1-358ae8a87e3mr9532992a91.18.1771883835258; Mon, 23 Feb 2026 13:57:15 -0800 (PST) Received: from arch ([2409:40c2:5428:afe:6feb:bc4:5ef7:1700]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-358dc0092d1sm352772a91.5.2026.02.23.13.57.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 13:57:15 -0800 (PST) From: Bhargav Joshi To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com Subject: [PATCH v4 1/3] iio: frequency: ad9523: fix implicit variable usage in macros Date: Tue, 24 Feb 2026 03:26:34 +0530 Message-ID: <20260223215636.18606-2-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260223215636.18606-1-rougueprince47@gmail.com> References: <20260223215636.18606-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and AD9523_CLK_DIST_DIV_REV(x) implicitly relied on variable named 'ret' instead of using passed argument '(x)'. Update the macros to explicitly use the argument '(x)' for their operations. This also resolves the following checkpatch.pl warning: WARNING: Argument '(x)' is not used in function-like macro Signed-off-by: Bhargav Joshi --- drivers/iio/frequency/ad9523.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 63c485e9e44c..5725ab62e0fd 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -167,9 +167,9 @@ =20 /* AD9523_CHANNEL_CLOCK_DIST */ #define AD9523_CLK_DIST_DIV_PHASE(x) (((x) & 0x3F) << 18) -#define AD9523_CLK_DIST_DIV_PHASE_REV(x) ((ret >> 18) & 0x3F) +#define AD9523_CLK_DIST_DIV_PHASE_REV(x) (((x) >> 18) & 0x3F) #define AD9523_CLK_DIST_DIV(x) ((((x) - 1) & 0x3FF) << 8) -#define AD9523_CLK_DIST_DIV_REV(x) (((ret >> 8) & 0x3FF) + 1) +#define AD9523_CLK_DIST_DIV_REV(x) ((((x) >> 8) & 0x3FF) + 1) #define AD9523_CLK_DIST_INV_DIV_OUTPUT_EN (1 << 7) #define AD9523_CLK_DIST_IGNORE_SYNC_EN (1 << 6) #define AD9523_CLK_DIST_PWR_DOWN_EN (1 << 5) --=20 2.53.0 From nobody Fri Apr 17 07:13:22 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CC28379966 for ; Mon, 23 Feb 2026 21:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883845; cv=none; b=ROFX7kChHwKTP9cRSdwJfvsrDEqAGo81a80BFROwsBPhUDSCLK5qz64YJEDvlwdYpNuOptIWwZ5YOCN3E3GXeh/8S3cMVtZEtKrSvGdBHKBRvsgwBYgjgRqQTJ7in7xSZLWFTbBk3Q3nSeDbUXUO5hjNgtlhxvEsfqHS3No+GDg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883845; c=relaxed/simple; bh=PFgKxE6kd0+0Gn8FzSRLyAHBvf9/IgdDl2hwNLrsxQw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d3h90gBmA8PUbD4X+awf6sJ6PLLBukSgUYFzmxVDBwZMfvG3TVEME/gtx8UPo7ztQJv98VU39dL83wYwnDu3vTetl7Aau7QsZRdJVEsLPvB36kjYMv4f5fcJolHSKVEkyj0Rlk8gCxisvC8Z5Lwq7lbnAYivEsnKux6Ot6kaGrE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ecsRMJoV; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ecsRMJoV" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-358e3cc5e7eso26144a91.0 for ; Mon, 23 Feb 2026 13:57:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771883843; x=1772488643; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mc+2JM9mzVfHLoEtVQbn4jvvZEFjVrivm9/PyMFwuiQ=; b=ecsRMJoVnOExPmMwpanxhR0tz0/aEEwyi/4Ynipd9rzZKaFCrWSI/fVdJs0kYn4ydU oGRNjVDQ8208sNJQOo0HuHpyTLQZN4Yt6p0oBOJdx3nQsSMShT6BoiD+zDGUS1Mg+CjF E9OX8axZwE9jSmwNfLQqtgLqoLSVG7+r+T80xAWT8EsXgYxsnfr82+HypGvszEivnwDw tHS2s+mPQBMJGXAJ4Ls9wFSL3aFNL8/N/tX3TEeiFlvlyPbbAuFdUGAsztxZ+F6rsvmT bR4BzRexqFVrUTxZVhKOPVPkcEUwLf95biQQrBmEolwjfkEvYuWBmL8nTyWd8NPz7z2Y kuYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771883843; x=1772488643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mc+2JM9mzVfHLoEtVQbn4jvvZEFjVrivm9/PyMFwuiQ=; b=wRB42UxWwA4+P2Qw6DZO+iqcxUi9omITpIpV8WAae9oM6BgVQdeKpfU1/Sd31af8Z9 A9B5pcdZudKbY9z60egRg+Xc8DwBH9Hpc11+qp0XzCfQfj4jcDdcOZyBl+lE5XCuIZCl VIcEW98MHZ9oqQPQobWYQvcNeoohloSRBLp76Sl8XaTijtEB0Edw5I195VJfJ3AORVXu SWVjgMBYhTANsehSSaUo23lTOlB/jEY0RwLOMg2kbezTjGis5Y/5peJsG+YlA+0ndau3 yVEFROb/rB2/wa62xWS4Euc5Wp+MBMFUZa5e4wvkGvFyWGzCyYHOa6YG01DhIDpqgkGz 13nA== X-Forwarded-Encrypted: i=1; AJvYcCVTYgHXvWAFdEai1D+slukEMG1NH9qi3spjNBEyWIfoScuuc1Oi2Qso96uiDL481xy6quD2mDiIlmSemb8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+U5JZ+DZi3lVyaJ1ZeUvYdL4OD5Q464pIMeSp3XaMu9XKH0l/ u/zPdyn2rYsdnCnrBNIFb5Jq4PDtsx8LFMPyjUHXRjJ2l/5sxUiPJvyy X-Gm-Gg: ATEYQzzJxtH/14o5Eqt7qx/DZRhff5cHF03snTRdMItdonbCVwyKtackpX3E3g97xOA IEsMaLqT13WFeJtX/ToOCuwGIBgc2YMdkQDov55Ixo9CDqFVNq9bOql2FnCff8B3083x7w9wv/s zBOHrhWCMBIukLWMJXZ+IBa+qNlrrHoQTGKcZVovOzXnQOsbPahlD9r5wVBTnxcd6HOYvXinhEr bIGgGTpUjmym1qCZ8SMIAG6IPGViZZgqjvf63zDajtAsF/AUYJ/w78kP5SDp6sCAEpxEcpB7Gg6 vjT0wEjIwEYunMBD4T9F7T5/gzAIsuZYn+Z2LX7KmBbt2CsKaH5R+r1uvdOkwftJQJAt87mqAq2 EiWD/Fi/laG4ogGQ+a4Iq4sgMCOEVkYRaqjbJCkzEE3Gzf9iZDidwKFyykEY9MCTHY2RAtXi3ei rGwntzIzXkDXcruMw0mUNQpQ== X-Received: by 2002:a17:90b:4d90:b0:340:bde5:c9e3 with SMTP id 98e67ed59e1d1-358ae8c2d4dmr8551876a91.23.1771883843464; Mon, 23 Feb 2026 13:57:23 -0800 (PST) Received: from arch ([2409:40c2:5428:afe:6feb:bc4:5ef7:1700]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-358dc0092d1sm352772a91.5.2026.02.23.13.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 13:57:23 -0800 (PST) From: Bhargav Joshi To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com, Andy Shevchenko Subject: [PATCH v4 2/3] iio: frequency: ad9523: avoid multiple line dereferences for pdata Date: Tue, 24 Feb 2026 03:26:35 +0530 Message-ID: <20260223215636.18606-3-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260223215636.18606-1-rougueprince47@gmail.com> References: <20260223215636.18606-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Platform data pointer dereferences for pll1_charge_pump_current_nA and pll2_charge_pump_current_nA were split across multiple lines. Bring the dereference chains onto a single line. This resolves the following checkpatch.pl warnings: WARNING: Avoid multiple line dereference - prefer 'pdata->pll1_charge_pump_= current_nA' WARNING: Avoid multiple line dereference - prefer 'pdata->pll2_charge_pump_= current_nA' Signed-off-by: Bhargav Joshi Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/ad9523.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 5725ab62e0fd..6daa2ea354a8 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -797,8 +797,7 @@ static int ad9523_setup(struct iio_dev *indio_dev) return ret; =20 ret =3D ad9523_write(indio_dev, AD9523_PLL1_CHARGE_PUMP_CTRL, - AD9523_PLL1_CHARGE_PUMP_CURRENT_nA(pdata-> - pll1_charge_pump_current_nA) | + AD9523_PLL1_CHARGE_PUMP_CURRENT_nA(pdata->pll1_charge_pump_current_nA) | AD9523_PLL1_CHARGE_PUMP_MODE_NORMAL | AD9523_PLL1_BACKLASH_PW_MIN); if (ret < 0) @@ -842,8 +841,7 @@ static int ad9523_setup(struct iio_dev *indio_dev) */ =20 ret =3D ad9523_write(indio_dev, AD9523_PLL2_CHARGE_PUMP, - AD9523_PLL2_CHARGE_PUMP_CURRENT_nA(pdata-> - pll2_charge_pump_current_nA)); + AD9523_PLL2_CHARGE_PUMP_CURRENT_nA(pdata->pll2_charge_pump_current_nA)); if (ret < 0) return ret; =20 --=20 2.53.0 From nobody Fri Apr 17 07:13:22 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B291379978 for ; Mon, 23 Feb 2026 21:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883864; cv=none; b=T2paOZp+/tP2JLh+LioBO7kbVZjGDL+ERdOxVkgPR+xLTlJ1oR2VJU1pyHWIQ44khJa219NONV+/1j2PqocrXAQGSWWjU7wGgAQ1gWYel7JclbzkfpR7NjoHMUtIpQjOWUaHDCy4y7C1f8fwkV017hNs3TTuS0+Igaft0/+Rh+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883864; c=relaxed/simple; bh=7oo9T8B+FeTgiTuGE51KQBYrxr/r6RR5TDgp6mMWUEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=duOuJ27m10kNsTcJKd4sTrV8kWR3rMPg2fwOjf/BWGlfnJCnqmGfbxoaPSlx4CncYOIjkl/oaxamfSstDOk7xfS3ZornKnFHywGkIZ5HFoTZHlfa+do5UVnh3xcDQSSn1+DnaHt5HBY+YDha9kkkvd4orfSU/l4fzccMKOXKQ2M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YatqPKnz; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YatqPKnz" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ab46931cf1so35505595ad.0 for ; Mon, 23 Feb 2026 13:57:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771883863; x=1772488663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zd8TDmTMVMgTxvBQpe26DMVz8nZYPD6skY/6JxqF5/M=; b=YatqPKnzP+WYsN+WDmf2+7XbUUp2NCtgiU5ayD7EZhDH8PCOwP66lMLTWYoWSCXTyG bj2M4JNp10BlKBeEOWvFhIqIincneZztklwKcNXUFDPc00xNxCJds9MTkUjsmcPmxsk1 hPf0Xy8N/XhCq3cN8wxk7iqSrOWCrPwk+P2znDhYGB3RFE/TC94xVsIo43wIYUP3os2k 9uHVNssbZPoKHw45mUBU9/TpZNhi2gnByTXinDijIHIJMEOMVtN6iajG2IYFcVJQvq61 sSjkYfpA0HRbkxyFfI2rmkqkD2i31ypEzGSahsbIVFP56k/cUEzHB+wBPJCEUQOAPULW NUJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771883863; x=1772488663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Zd8TDmTMVMgTxvBQpe26DMVz8nZYPD6skY/6JxqF5/M=; b=WZgQU9IZkKed3OM6qVPFHb6zjzMD48840dhZonGBY76jRSQaGA8XHtLW47CaFWOj/9 ILGRiBgjGyqIX+SkLSQX3lowHgYp12CFtDQ5UKsIaxSvgbnJX37N+z21/O+ufZX/cMfi +VS0dfohlMZpeyyx/Gsgss6QYkfw5WoaArB7pv2Dcfmx56E7E5ssybK5mz8iMabAhyaU 4p3oTI17V81eq7pTzg4X4nSf7njaRQKYQOHDr8nO4dkaC+feynyhILxfhP81acWbZH6c W8qzxgxzfE7dix0LQWPg9rS/F2+zYhyRhEh2kcETfpg9Vh3hmHDIXHdpaBrJFCKI5F+c WC+Q== X-Forwarded-Encrypted: i=1; AJvYcCUnakgmvJ4ZcFC3+7jtK6wA1ksZSckhQauS/p3AtinEDpPr96kuOlTOVZhJ0eze5TYh7lyMdJTl0UrrvsQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwkmteXjD1u/nC0TEJ3HSM6emFOUgJPjxuVGRUfBAddCl8XgHDe bsimYHOxBxBtJxJoks3PhGrO53id596/NvNj1gnmZPbb7e/3zIua0o72 X-Gm-Gg: ATEYQzzYcnDT3K9MEos0hZS3v2kG9qmK4AHq7m3gKH8+EgIvrx9YCskhW6TYKYbjuIB s9kXFaO8qz3QiVul0B4kwzxzN8/KY0xeXdjhlKV7C+1JGEmLRABSHA3B8lvvwaZxAxGXV0VvbTm oSbmE4l0rF2m9PVtyHrtqFI3hPayJqb9KMICAcrXLt6i6uAcJJfxd2KvXNkBPtbB7iIE6k8ubUN Uw6TIdPOZZ10hWB44/CuE2Bc7nQ+cNOZAMgUOfOu6v1ocukWoB99+UnIA7BOnUvNOm5QScBu8NZ 3vHQhK+sNWtVKpxccDNduv/166qNLxx3/eSaLtYFNnWLSnJfFyYd5mhLmAmuQ4AoPQ8f9oQP4WI H86C1adzCCEY3G3bOz7cuR4wZCX9pSFWa1JBV7FhCdvMexlidMP/Lb3lzPNZokIuji4x8KZGUSD okP5qA+1bV4IyWzozSJhDTqw== X-Received: by 2002:a17:90a:d888:b0:354:c3a4:3a6 with SMTP id 98e67ed59e1d1-358aeab3addmr7740458a91.3.1771883862730; Mon, 23 Feb 2026 13:57:42 -0800 (PST) Received: from arch ([2409:40c2:5428:afe:6feb:bc4:5ef7:1700]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-358dc0092d1sm352772a91.5.2026.02.23.13.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 13:57:42 -0800 (PST) From: Bhargav Joshi To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com Subject: [PATCH v4 3/3] iio: frequency: ad9523: fix checkpatch warnings for symbolic permissions Date: Tue, 24 Feb 2026 03:26:36 +0530 Message-ID: <20260223215636.18606-4-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260223215636.18606-1-rougueprince47@gmail.com> References: <20260223215636.18606-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver currently defines device attributes using symbolic permission flags (S_IRUGO and S_IWUSR). Update these to use octal permissions (0444 and 0200) to resolve checkpatch warnings. Signed-off-by: Bhargav Joshi --- drivers/iio/frequency/ad9523.c | 78 +++++++++++++--------------------- 1 file changed, 29 insertions(+), 49 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 6daa2ea354a8..ad32eb66edca 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -558,55 +558,35 @@ static ssize_t ad9523_show(struct device *dev, return ret; } =20 -static IIO_DEVICE_ATTR(pll1_locked, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL1_LD); - -static IIO_DEVICE_ATTR(pll2_locked, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_LD); - -static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REFA); - -static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REFB); - -static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REF_TEST); - -static IIO_DEVICE_ATTR(vcxo_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_VCXO); - -static IIO_DEVICE_ATTR(pll2_feedback_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_FB_CLK); - -static IIO_DEVICE_ATTR(pll2_reference_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_REF_CLK); - -static IIO_DEVICE_ATTR(sync_dividers, S_IWUSR, - NULL, - ad9523_store, - AD9523_SYNC); - -static IIO_DEVICE_ATTR(store_eeprom, S_IWUSR, - NULL, - ad9523_store, - AD9523_EEPROM); +static IIO_DEVICE_ATTR(pll1_locked, 0444, ad9523_show, NULL, + AD9523_STAT_PLL1_LD); + +static IIO_DEVICE_ATTR(pll2_locked, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_LD); + +static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, 0444, ad9523_show, NU= LL, + AD9523_STAT_REFA); + +static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, 0444, ad9523_show, NU= LL, + AD9523_STAT_REFB); + +static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, 0444, ad9523_show,= NULL, + AD9523_STAT_REF_TEST); + +static IIO_DEVICE_ATTR(vcxo_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_VCXO); + +static IIO_DEVICE_ATTR(pll2_feedback_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_FB_CLK); + +static IIO_DEVICE_ATTR(pll2_reference_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_REF_CLK); + +static IIO_DEVICE_ATTR(sync_dividers, 0200, NULL, ad9523_store, + AD9523_SYNC); + +static IIO_DEVICE_ATTR(store_eeprom, 0200, NULL, ad9523_store, + AD9523_EEPROM); =20 static struct attribute *ad9523_attributes[] =3D { &iio_dev_attr_sync_dividers.dev_attr.attr, --=20 2.53.0