[PATCH v2 00/12] iio: use dev_err_probe in probe path for ADI drivers

Antoniu Miclaus posted 12 patches 1 month, 3 weeks ago
There is a newer version of this series
drivers/iio/dac/ad7293.c         | 32 +++++------
drivers/iio/filter/admv8818.c    | 61 ++++++++++-----------
drivers/iio/frequency/adf4377.c  | 57 +++++++++----------
drivers/iio/frequency/admv1013.c | 51 ++++++++---------
drivers/iio/frequency/admv1014.c | 94 +++++++++++++++-----------------
drivers/iio/frequency/adrf6780.c | 60 ++++++++++----------
6 files changed, 168 insertions(+), 187 deletions(-)
[PATCH v2 00/12] iio: use dev_err_probe in probe path for ADI drivers
Posted by Antoniu Miclaus 1 month, 3 weeks ago
Use dev_err_probe() consistently in the probe path of several ADI IIO
drivers. This simplifies error handling and ensures proper logging of
deferred probes.

Each driver is updated in two patches: first introducing a local
struct device variable to simplify repeated &spi->dev / &client->dev
references, then converting error paths to use dev_err_probe().

Drivers updated:
 - adrf6780
 - admv1014
 - admv1013
 - adf4377
 - ad7293
 - admv8818

Changes in v2:
 - Split each driver update into two patches: one precursor for introducing the
   struct device variable, and one for the dev_err_probe() conversion.(as
   Jonathan Cameron suggested).
 - Dropped ade9000 patch (already accepted).

Antoniu Miclaus (12):
  iio: frequency: adrf6780: introduce struct device variable
  iio: frequency: adrf6780: use dev_err_probe in probe path
  iio: frequency: admv1014: introduce struct device variable
  iio: frequency: admv1014: use dev_err_probe in probe path
  iio: frequency: admv1013: introduce struct device variable
  iio: frequency: admv1013: use dev_err_probe in probe path
  iio: frequency: adf4377: introduce struct device variable
  iio: frequency: adf4377: use dev_err_probe in probe path
  iio: dac: ad7293: introduce struct device variable
  iio: dac: ad7293: use dev_err_probe in probe path
  iio: filter: admv8818: introduce struct device variable
  iio: filter: admv8818: use dev_err_probe in probe path

 drivers/iio/dac/ad7293.c         | 32 +++++------
 drivers/iio/filter/admv8818.c    | 61 ++++++++++-----------
 drivers/iio/frequency/adf4377.c  | 57 +++++++++----------
 drivers/iio/frequency/admv1013.c | 51 ++++++++---------
 drivers/iio/frequency/admv1014.c | 94 +++++++++++++++-----------------
 drivers/iio/frequency/adrf6780.c | 60 ++++++++++----------
 6 files changed, 168 insertions(+), 187 deletions(-)

-- 
2.43.0
Re: [PATCH v2 00/12] iio: use dev_err_probe in probe path for ADI drivers
Posted by Andy Shevchenko 1 month, 3 weeks ago
On Mon, Feb 23, 2026 at 03:13:51PM +0200, Antoniu Miclaus wrote:
> Use dev_err_probe() consistently in the probe path of several ADI IIO
> drivers. This simplifies error handling and ensures proper logging of
> deferred probes.
> 
> Each driver is updated in two patches: first introducing a local
> struct device variable to simplify repeated &spi->dev / &client->dev
> references, then converting error paths to use dev_err_probe().
> 
> Drivers updated:
>  - adrf6780
>  - admv1014
>  - admv1013
>  - adf4377
>  - ad7293
>  - admv8818

As I mentioned, use a rule of thumb:

- when devm_ is used in the function, error messages may be converted to
dev_err_probe() as devm_ is supposed to be used only at ->probe() stage

- try to avoid ping-pong type of changes when the same line is modified
2+ times in a row in the same series (there are exceptions, but not here)

-- 
With Best Regards,
Andy Shevchenko