From nobody Fri Apr 17 06:15:34 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E2AC36680D; Mon, 23 Feb 2026 13:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852493; cv=none; b=dNF/7y1l37LwvyILh4AvFew2FqLU7drz0d8YTTfB49WoXI1YUagjQkS2ErNYHVDzOIigpFIh2c8al5vn8OXCJbQCNFxSuYJ5w+6v5vUecAU2OG6BwYYuFd1T1lU48b1gnaG9fmvXTnuUWkhUjj/tkrC+9I8M/8yPp+KyS3iGaKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852493; c=relaxed/simple; bh=Wfcw7h2HRxMJ3tUvGKVFqAlsgmbs4Z3t6y9mEavclcw=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=miAzEiE4pHCGAhJzMNwKT8jYmgMQkETxCEdbD0qxtpOiG0hkT4U4c3xpglmEvfOZqpxD1nRQsWu2S65jPFAsVyoR9v+BondcCsD6fX9f4lN9W5Pkt94Lu2hIIMWjp638MoMJyJx16XvoWDYsx/4yCXHOGvm+tvWH+a8VP20q2wo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=yZxKnMJ/; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="yZxKnMJ/" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61NCkFXD1743403; Mon, 23 Feb 2026 08:14:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=W8KTF OozPbxLj2Q7nSU/Hh2MnTSqLb3qfKDpWFLdoJo=; b=yZxKnMJ/u92KLjxtbQ1E4 LTp3zcKsY9/BF4e309DSkRK/+hPIuvQmZIQwmGXCNxc0Y2k2/7t/W9+3MMjqX+PB 8ySgvm3kgN5F44AZP/M+uuiZIXKiPS0znKeZXHf1VW5kpAvfIk1vvaaRjLkQTwJ+ MqUWJsm/y7EZxz3DZ3giE3vGjsCy/jMzqCArUZJTZjUd1hwnaR7liTGfK9h+grAX O6A2KvpfEL+MwtQ559uUzSNmHPYf/gWoJsJNeXg73Kk+klEnHUIKyBlYY/azongA kbuCXkQRKFeIC986rXbD11/bw1NJ0YQLNav8iLIuUoWwdvVAOvg1UnWxXFFBnaDf A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7p4k2wd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:14:37 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDEaLS009724 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:14:36 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:36 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:14:36 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXX006594; Mon, 23 Feb 2026 08:14:30 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 01/12] iio: frequency: adrf6780: introduce struct device variable Date: Mon, 23 Feb 2026 15:13:52 +0200 Message-ID: <20260223131418.55414-2-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfX9TmG67M7mYRX cMeSE1SlKkxAdbZn0ScQlwDEXni0XVapcbAY07gH47gOGum0pAfB2z3cJhSQqnn583DJUKaj74M +fMS6UZImYBC/9ecJGYp4GfM4pwCcnnkW5QqNDhAVtv61e2V14gMoPlRHSJt6/E42SDcCQQMIgb lm9Bcims8mMB1bk0RO/gnSwXBQvDCSC6tzfRHNul4afKcmeWgd0LIhlFbN5vyNU86J6+sYiXA3U 0KzVEqOzgFP2VPxWyYi82XZUz0Mpxdtw2IzF8n2jxH8Ii6O/Ih58E7GABCgkpoI8L4cZrEzsWaI /5ux8BO7bKeEyXC53vw22h35RvVdG7uQEragdhFprPMHAJGGQnW6mNjWT3xJLzZ4p5SQzTNAZ0u mDVbXzKmDta21s7rTERDYhk/fvqpovusuNoPKgB/eGifQZ1Qm3gKy3vkkDkNzsnV+HHXnrRgdtl B+QGdI/rTKq0ofLo2AQ== X-Proofpoint-ORIG-GUID: GRwOeCJO2EcVg691PS8GesiCo7vs4O41 X-Authority-Analysis: v=2.4 cv=LfgxKzfi c=1 sm=1 tr=0 ts=699c52bd cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=hY51SqySecd9eNirzRkA:9 X-Proofpoint-GUID: GRwOeCJO2EcVg691PS8GesiCo7vs4O41 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Add struct device *dev local variable to simplify repeated &spi->dev dereferences. Where spi is no longer needed beyond &spi->dev, replace struct spi_device *spi with struct device *dev =3D &st->spi->dev. No functional change. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/adrf6780.c | 45 ++++++++++++++++---------------- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/drivers/iio/frequency/adrf6780.c b/drivers/iio/frequency/adrf6= 780.c index a7a21f929970..918a7a511d09 100644 --- a/drivers/iio/frequency/adrf6780.c +++ b/drivers/iio/frequency/adrf6780.c @@ -346,13 +346,13 @@ static const struct iio_chan_spec adrf6780_channels[]= =3D { static int adrf6780_reset(struct adrf6780_state *st) { int ret; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 ret =3D __adrf6780_spi_update_bits(st, ADRF6780_REG_CONTROL, ADRF6780_SOFT_RESET_MSK, FIELD_PREP(ADRF6780_SOFT_RESET_MSK, 1)); if (ret) { - dev_err(&spi->dev, "ADRF6780 SPI software reset failed.\n"); + dev_err(dev, "ADRF6780 SPI software reset failed.\n"); return ret; } =20 @@ -360,7 +360,7 @@ static int adrf6780_reset(struct adrf6780_state *st) ADRF6780_SOFT_RESET_MSK, FIELD_PREP(ADRF6780_SOFT_RESET_MSK, 0)); if (ret) { - dev_err(&spi->dev, "ADRF6780 SPI software reset disable failed.\n"); + dev_err(dev, "ADRF6780 SPI software reset disable failed.\n"); return ret; } =20 @@ -371,7 +371,7 @@ static int adrf6780_init(struct adrf6780_state *st) { int ret; unsigned int chip_id, enable_reg, enable_reg_msk; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 /* Perform a software reset */ ret =3D adrf6780_reset(st); @@ -384,7 +384,7 @@ static int adrf6780_init(struct adrf6780_state *st) =20 chip_id =3D FIELD_GET(ADRF6780_CHIP_ID_MSK, chip_id); if (chip_id !=3D ADRF6780_CHIP_ID) { - dev_err(&spi->dev, "ADRF6780 Invalid Chip ID.\n"); + dev_err(dev, "ADRF6780 Invalid Chip ID.\n"); return -EINVAL; } =20 @@ -426,18 +426,18 @@ static int adrf6780_init(struct adrf6780_state *st) =20 static void adrf6780_properties_parse(struct adrf6780_state *st) { - struct spi_device *spi =3D st->spi; - - st->vga_buff_en =3D device_property_read_bool(&spi->dev, "adi,vga-buff-en= "); - st->lo_buff_en =3D device_property_read_bool(&spi->dev, "adi,lo-buff-en"); - st->if_mode_en =3D device_property_read_bool(&spi->dev, "adi,if-mode-en"); - st->iq_mode_en =3D device_property_read_bool(&spi->dev, "adi,iq-mode-en"); - st->lo_x2_en =3D device_property_read_bool(&spi->dev, "adi,lo-x2-en"); - st->lo_ppf_en =3D device_property_read_bool(&spi->dev, "adi,lo-ppf-en"); - st->lo_en =3D device_property_read_bool(&spi->dev, "adi,lo-en"); - st->uc_bias_en =3D device_property_read_bool(&spi->dev, "adi,uc-bias-en"); - st->lo_sideband =3D device_property_read_bool(&spi->dev, "adi,lo-sideband= "); - st->vdet_out_en =3D device_property_read_bool(&spi->dev, "adi,vdet-out-en= "); + struct device *dev =3D &st->spi->dev; + + st->vga_buff_en =3D device_property_read_bool(dev, "adi,vga-buff-en"); + st->lo_buff_en =3D device_property_read_bool(dev, "adi,lo-buff-en"); + st->if_mode_en =3D device_property_read_bool(dev, "adi,if-mode-en"); + st->iq_mode_en =3D device_property_read_bool(dev, "adi,iq-mode-en"); + st->lo_x2_en =3D device_property_read_bool(dev, "adi,lo-x2-en"); + st->lo_ppf_en =3D device_property_read_bool(dev, "adi,lo-ppf-en"); + st->lo_en =3D device_property_read_bool(dev, "adi,lo-en"); + st->uc_bias_en =3D device_property_read_bool(dev, "adi,uc-bias-en"); + st->lo_sideband =3D device_property_read_bool(dev, "adi,lo-sideband"); + st->vdet_out_en =3D device_property_read_bool(dev, "adi,vdet-out-en"); } =20 static void adrf6780_powerdown(void *data) @@ -450,9 +450,10 @@ static int adrf6780_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct adrf6780_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -467,9 +468,9 @@ static int adrf6780_probe(struct spi_device *spi) =20 adrf6780_properties_parse(st); =20 - st->clkin =3D devm_clk_get_enabled(&spi->dev, "lo_in"); + st->clkin =3D devm_clk_get_enabled(dev, "lo_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the LO input clock\n"); =20 mutex_init(&st->lock); @@ -478,11 +479,11 @@ static int adrf6780_probe(struct spi_device *spi) if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, adrf6780_powerdown, st); + ret =3D devm_add_action_or_reset(dev, adrf6780_powerdown, st); if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id adrf6780_id[] =3D { --=20 2.43.0 From nobody Fri Apr 17 06:15:34 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E21E36680B; Mon, 23 Feb 2026 13:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852493; cv=none; b=R/NXhR4M5n/NDqKWRI+5jg1c0oaNwb2LEeXiOxWaeQ6cnNSjHK2c6PMYs7KLJ/M+5IZTxyBzMoOoYqY0O5qwWhB8eRGI2Sa4uzzOPQgOHXGmuVVGnZFblwaXRMXpU2Y3aTZRUMSankoaNJKfxCq/+kkD/MzYyfX+Gg5H13ZxZtw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852493; c=relaxed/simple; bh=3Nwrdi9xGML1C0bCqTLhF8uBNFWnLudDdj5ld1cOCdk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=evOJg4WRsJ/AkSE/h7NcuqdtDgUmzIf+LhvRvXEnnSVcbNB3Ca4AzXaYn+5xs/gUPLxetDYzr1C/sKN42AOFNDMj2yuWBthWDO/oKxUe64rAeEryX+4C3ieWq6+tLc7puseb6AQyUVZnwdm5ROISzs5bPonwKbP7j4MKiJYg/fA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=ZiOR6Mw4; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="ZiOR6Mw4" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61NCsWw43320378; Mon, 23 Feb 2026 08:14:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=4ve0z tLchl87o4rE+r0nzeJff2ZRaJxe7r8Zg5ZS8H0=; b=ZiOR6Mw4OJsTke3hCUjXd pJebbPaF2CwLcprOS4w7NjQkMZ6dngRDRM2lqbMG5UifaOHKHqcRTVV8CSaXZHhN LFgtd3AKDZ849BVaw+gZ6KggsFs1HyT4XD9reHXmVo7c5CFizVM3dV1zHxBI1t09 ha3DCASH8cYRGN2hILKKjCjE09ATExJiH0VLtuqaeA9hRMZKJVuRH+DY5YWcXBWR CWiOqh9NOtYo+XbuGuu3GOsjVdDg1P5O/r+0bJ4gaPT2di7gXySSYgw87NneBRO5 279Da00e3rmuhAQwoXXiEckSNv8HDMIZlgzwmhwTGsaAUQCu59VbSDdQ0yj3w6WB w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cf7e1y92s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:14:38 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDEbJv009727 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:14:37 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:37 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:14:37 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXY006594; Mon, 23 Feb 2026 08:14:33 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 02/12] iio: frequency: adrf6780: use dev_err_probe in probe path Date: Mon, 23 Feb 2026 15:13:53 +0200 Message-ID: <20260223131418.55414-3-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=WsUm8Nfv c=1 sm=1 tr=0 ts=699c52be cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=3LiYLoh_h3RjBjQ2HpkA:9 X-Proofpoint-GUID: kL9MTNfiBhKaRj8qpji6hI17cZjDv-Wo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfX0X2+zlrpuGJF hpofdcHlL7Ce3pXiPK+1quIppVn4hnhyC7XlddcZNEaD4ebNFDWJgLbhgmLbpPR0eHAUH5a2u3q N2kmj97+CAUZY63t5KyzherQxuoNQVsioXu0bBfun6GYMs5cA3hInkntCbNtdmedL1jNhdlxkS3 FStaYpafv6nUUwLPk6EumUBEYLsZJbK+YaBz/p4XLYgOViJGAyEXkcvGj26Sk5A54fdeam4tsdo VclAbqzwbJyod1xvz5ewrtIuEEcT2NZwfVmr1W4HXN8k8GBgDllSKnoieNO2S2PJGZbS2qcYTvL wBDzW4G9pl4prnR1igdzogJXr7D9WFvRzOF1UZ+AT4lKPba5BSmz6PDgLDLvP9WTJr3usyAlAKm UQoJ0B7pFbAWJm24514dVlTw9Ti8TYYXiNah3uXSSG2FtdwemjiHmeqlEK+Fj5jktEV535ZzTuA 2jANsNgLnhxXBY5VLrQ== X-Proofpoint-ORIG-GUID: kL9MTNfiBhKaRj8qpji6hI17cZjDv-Wo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in the probe path to simplify error handling and to ensure the error code is logged. Drop 'SPI' from error messages since the bus type is evident. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/adrf6780.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/iio/frequency/adrf6780.c b/drivers/iio/frequency/adrf6= 780.c index 918a7a511d09..be8838ab10fb 100644 --- a/drivers/iio/frequency/adrf6780.c +++ b/drivers/iio/frequency/adrf6780.c @@ -351,18 +351,16 @@ static int adrf6780_reset(struct adrf6780_state *st) ret =3D __adrf6780_spi_update_bits(st, ADRF6780_REG_CONTROL, ADRF6780_SOFT_RESET_MSK, FIELD_PREP(ADRF6780_SOFT_RESET_MSK, 1)); - if (ret) { - dev_err(dev, "ADRF6780 SPI software reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADRF6780 software reset failed.\n"); =20 ret =3D __adrf6780_spi_update_bits(st, ADRF6780_REG_CONTROL, ADRF6780_SOFT_RESET_MSK, FIELD_PREP(ADRF6780_SOFT_RESET_MSK, 0)); - if (ret) { - dev_err(dev, "ADRF6780 SPI software reset disable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADRF6780 software reset disable failed.\n"); =20 return 0; } @@ -383,10 +381,9 @@ static int adrf6780_init(struct adrf6780_state *st) return ret; =20 chip_id =3D FIELD_GET(ADRF6780_CHIP_ID_MSK, chip_id); - if (chip_id !=3D ADRF6780_CHIP_ID) { - dev_err(dev, "ADRF6780 Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D ADRF6780_CHIP_ID) + return dev_err_probe(dev, -EINVAL, + "ADRF6780 Invalid Chip ID.\n"); =20 enable_reg_msk =3D ADRF6780_VGA_BUFFER_EN_MSK | ADRF6780_DETECTOR_EN_MSK | --=20 2.43.0 From nobody Fri Apr 17 06:15:34 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1932A350A3A; Mon, 23 Feb 2026 13:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852500; cv=none; b=irRfBvC9vHQxZYwC9EsCTt2JjXIctx1PWNZkZr/UrxsCTO6BkZXFA11V/ashykIzopNSJg/8znWKdJ5OoHvemV3Z2UZ8Ra9cpC/6l+Ls39GGo6GjKSCwDP/ekWmHbzArYsL+rkG7l0sUYKgGC7y2fwD8+GpmaKefacy2PWRkftc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852500; c=relaxed/simple; bh=zoRRQ2Y+uOTVBOcGOroJE1GMkC7URafjlCM95HMX7MQ=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Cm8aagLBvcTOI2Onm5MJPeN4ebghyZ+gRP0nuxtsWuSjaJ0X5QUxYZDn7Dfh3hVLERXcCncn7RRM7syHEgn0Ieg1EIhJcJLC0Ov3VncHTrbm9VxpJ/7WjOTPhXz4ubW4bdOSZby+n/oZ6FIEKCJVvAhFqvXnQFhliPKVwwKEoWg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=rDhAdCXk; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="rDhAdCXk" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N80KUN818277; Mon, 23 Feb 2026 08:14:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=Y/kEl OwJQuMO9xmSTzf9jfBYP+Ja0F98LNQ/0sYtOGs=; b=rDhAdCXkwMk7Myb+4Hqqx l89zxiusPIo3U+XfRS1D32gJdOZIAa6HK9T9eJIWOYrJAF1oamvdy/Tz+c1WTSYN RSsUHmaLKnLN9x24OxJPpX92dDR+CDF5pKf0e8/XZDQ/5/IDkyzkVqUL/FzDdEpB FEH7UzSzoQrv4mMuZkb/Rxo/Q+K9jacOitqPndYeUWOdYHG7z675pt2Ok+UbMAgt C5WYRjlY+vSucJL7akx4chgx9C4m5hE36zdR2dhcNLeCiPybP10Pp+Q0E77HHCSn 5SRJezP+vjKkXbdfLF8eLcx8XCAfWU8L9+SkdatiwkywAZl2dBOLDGidjSDpsouw Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7p02y7d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:14:43 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDEgZI009730 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:14:42 -0500 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:42 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:42 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:14:42 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXZ006594; Mon, 23 Feb 2026 08:14:36 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 03/12] iio: frequency: admv1014: introduce struct device variable Date: Mon, 23 Feb 2026 15:13:54 +0200 Message-ID: <20260223131418.55414-4-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: B8fm6KfHYtjkPFfneOnmLBm75iBu9LPZ X-Proofpoint-GUID: B8fm6KfHYtjkPFfneOnmLBm75iBu9LPZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfX9RNsj4/RVr2h pfEIcZx33ErcWbKpWcpPtoOT1lc8OFUJZbi4y7AB+vJqE/3Ac9pHvSe6cO0khTooK4LjvmgME/9 tMOWpd9iPj9MAy5SNFU6xvUf9q47yL9Ve4nRonTvSJ889pQads7khYZ2pJNgI/qxPYMIXtby6LE uXm37EJEgF0Y8spLVR0k7TRV4n1gVZT+Y4/E0CJZkFNBs13j5OAjREY33gPP1bXM1P7vqEQPeOW Tp6Rt0rCrFOo9QK+UbQwMXrufoOOh1nlm8T+48KoUFbajHPmzoRv5laABQRvyUoVjlQY5j6t4Ac q6DSdx1IzYZgX4axzzD9nhQfoZ4kRIj9o2dW8ctHB3wm1Ky8KsEalidHmhk2nA1z+dudoG7HMZw Q5jBUFY9mvxlnPfG17+MYHMOPY3s+827Zfbw3MUOrf8tYl3CtWtUPUJNmUqq7UXXvWM9eYEtV+W Da/YmUkpiOqW+vURzdg== X-Authority-Analysis: v=2.4 cv=Fq4IPmrq c=1 sm=1 tr=0 ts=699c52c3 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=Z0pTeXoby7EwIRygza74:22 a=gAnH3GRIAAAA:8 a=WtxQy0Aqn4yjT93-wUwA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Add struct device *dev local variable to simplify repeated &spi->dev dereferences. Where spi is no longer needed beyond &spi->dev, replace struct spi_device *spi with struct device *dev =3D &st->spi->dev. No functional change. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/admv1014.c | 49 ++++++++++++++++---------------- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/drivers/iio/frequency/admv1014.c b/drivers/iio/frequency/admv1= 014.c index 7a8f92ec80a2..ce1b40336e15 100644 --- a/drivers/iio/frequency/admv1014.c +++ b/drivers/iio/frequency/admv1014.c @@ -609,16 +609,16 @@ static void admv1014_powerdown(void *data) static int admv1014_init(struct admv1014_state *st) { unsigned int chip_id, enable_reg, enable_reg_msk; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 ret =3D regulator_bulk_enable(ADMV1014_NUM_REGULATORS, st->regulators); if (ret) { - dev_err(&spi->dev, "Failed to enable regulators"); + dev_err(dev, "Failed to enable regulators"); return ret; } =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1014_reg_disable, st->reg= ulators); + ret =3D devm_add_action_or_reset(dev, admv1014_reg_disable, st->regulator= s); if (ret) return ret; =20 @@ -626,16 +626,16 @@ static int admv1014_init(struct admv1014_state *st) if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1014_clk_disable, st->clk= in); + ret =3D devm_add_action_or_reset(dev, admv1014_clk_disable, st->clkin); if (ret) return ret; =20 st->nb.notifier_call =3D admv1014_freq_change; - ret =3D devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb); + ret =3D devm_clk_notifier_register(dev, st->clkin, &st->nb); if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1014_powerdown, st); + ret =3D devm_add_action_or_reset(dev, admv1014_powerdown, st); if (ret) return ret; =20 @@ -644,7 +644,7 @@ static int admv1014_init(struct admv1014_state *st) ADMV1014_SPI_SOFT_RESET_MSK, FIELD_PREP(ADMV1014_SPI_SOFT_RESET_MSK, 1)); if (ret) { - dev_err(&spi->dev, "ADMV1014 SPI software reset failed.\n"); + dev_err(dev, "ADMV1014 SPI software reset failed.\n"); return ret; } =20 @@ -652,13 +652,13 @@ static int admv1014_init(struct admv1014_state *st) ADMV1014_SPI_SOFT_RESET_MSK, FIELD_PREP(ADMV1014_SPI_SOFT_RESET_MSK, 0)); if (ret) { - dev_err(&spi->dev, "ADMV1014 SPI software reset disable failed.\n"); + dev_err(dev, "ADMV1014 SPI software reset disable failed.\n"); return ret; } =20 ret =3D __admv1014_spi_write(st, ADMV1014_REG_VVA_TEMP_COMP, 0x727C); if (ret) { - dev_err(&spi->dev, "Writing default Temperature Compensation value faile= d.\n"); + dev_err(dev, "Writing default Temperature Compensation value failed.\n"); return ret; } =20 @@ -668,7 +668,7 @@ static int admv1014_init(struct admv1014_state *st) =20 chip_id =3D FIELD_GET(ADMV1014_CHIP_ID_MSK, chip_id); if (chip_id !=3D ADMV1014_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); + dev_err(dev, "Invalid Chip ID.\n"); return -EINVAL; } =20 @@ -677,19 +677,19 @@ static int admv1014_init(struct admv1014_state *st) FIELD_PREP(ADMV1014_QUAD_SE_MODE_MSK, st->quad_se_mode)); if (ret) { - dev_err(&spi->dev, "Writing Quad SE Mode failed.\n"); + dev_err(dev, "Writing Quad SE Mode failed.\n"); return ret; } =20 ret =3D admv1014_update_quad_filters(st); if (ret) { - dev_err(&spi->dev, "Update Quad Filters failed.\n"); + dev_err(dev, "Update Quad Filters failed.\n"); return ret; } =20 ret =3D admv1014_update_vcm_settings(st); if (ret) { - dev_err(&spi->dev, "Update VCM Settings failed.\n"); + dev_err(dev, "Update VCM Settings failed.\n"); return ret; } =20 @@ -711,14 +711,14 @@ static int admv1014_init(struct admv1014_state *st) static int admv1014_properties_parse(struct admv1014_state *st) { unsigned int i; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 - st->det_en =3D device_property_read_bool(&spi->dev, "adi,detector-enable"= ); + st->det_en =3D device_property_read_bool(dev, "adi,detector-enable"); =20 - st->p1db_comp =3D device_property_read_bool(&spi->dev, "adi,p1db-compensa= tion-enable"); + st->p1db_comp =3D device_property_read_bool(dev, "adi,p1db-compensation-e= nable"); =20 - ret =3D device_property_match_property_string(&spi->dev, "adi,input-mode", + ret =3D device_property_match_property_string(dev, "adi,input-mode", input_mode_names, ARRAY_SIZE(input_mode_names)); if (ret >=3D 0) @@ -726,7 +726,7 @@ static int admv1014_properties_parse(struct admv1014_st= ate *st) else st->input_mode =3D ADMV1014_IQ_MODE; =20 - ret =3D device_property_match_property_string(&spi->dev, "adi,quad-se-mod= e", + ret =3D device_property_match_property_string(dev, "adi,quad-se-mode", quad_se_mode_names, ARRAY_SIZE(quad_se_mode_names)); if (ret >=3D 0) @@ -737,16 +737,16 @@ static int admv1014_properties_parse(struct admv1014_= state *st) for (i =3D 0; i < ADMV1014_NUM_REGULATORS; ++i) st->regulators[i].supply =3D admv1014_reg_name[i]; =20 - ret =3D devm_regulator_bulk_get(&st->spi->dev, ADMV1014_NUM_REGULATORS, + ret =3D devm_regulator_bulk_get(dev, ADMV1014_NUM_REGULATORS, st->regulators); if (ret) { - dev_err(&spi->dev, "Failed to request regulators"); + dev_err(dev, "Failed to request regulators"); return ret; } =20 - st->clkin =3D devm_clk_get(&spi->dev, "lo_in"); + st->clkin =3D devm_clk_get(dev, "lo_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the LO input clock\n"); =20 return 0; @@ -756,9 +756,10 @@ static int admv1014_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct admv1014_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -787,7 +788,7 @@ static int admv1014_probe(struct spi_device *spi) if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id admv1014_id[] =3D { --=20 2.43.0 From nobody Fri Apr 17 06:15:34 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0606A366048; Mon, 23 Feb 2026 13:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852502; cv=none; b=ayG8jbiNXL+vxa6r96I1f0FRnTh61nS3is6aqlewk2NwTLRg1D4QOZzxKdpPax/WYyLQlDIPq8ls2G1WOsI8AoqeXr7p7TOjK5KFUJcg1sQQf7013dKBrRWiM8svMENZmpGSKn82/JEZ11bkP7PcvxtaUKMiw7WkSpaBlbJSiEs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852502; c=relaxed/simple; bh=ZbarGkOZnbAkx72n8CmJ0NvZPXlg+jSYO7+jtsQZlR4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f9PS1IPSZD/JRuZ2u7a11ZfLWdU6CMteScI1Ynglr0pMawRMR2mA8kN6WjTjfBoUhTm4wBUxtS5E2lB02EetlnaJNGsP94Ih+cnJNeSfye3pTubZlR1EAOJFS9WGE9a1Y7aUwg3rRBcEEcu0IRzBq+8h9/RWboQ5cqkEYhu3moY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=pCEBA8lK; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="pCEBA8lK" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61NBpIHM3320843; Mon, 23 Feb 2026 08:14:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=LNfha hLNGyyCYlw8KIVPm65z5yfbsUpC8+OWEdDtPDs=; b=pCEBA8lKP6Hnh50jPVId6 n6giHKYrfWn/dGB2vVVBrn2Xyv6qGwZFMiW4i0p1EyfAgr/7YmrN14ZgHY2C6gCd yx2V8pSzeV2ySc+QSRn8QRJgkz7DT4309giZEfXBMv/GRfXV62ro0t6ZSTaE0Us+ b0CiwKAtNwpmn/NqxG1osHnhXfiOgWx6Bu8YGhZFAZ7BTQWJQtbwAGGfEElAgMv9 oSoW//qb9Qplxq8soL8kVnNS7cuuKHjNPHk55Fapj8zPMH4yR12O5o1x1C72/2C9 HKNyEekyYDB7bamaAPiYtLcymjNQNhd6/FOE357cOc5oW4MCslma8seHW4UVG884 Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cf7e1y92y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:14:45 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDEiTh009744 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:14:44 -0500 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:44 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:44 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:14:44 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXa006594; Mon, 23 Feb 2026 08:14:38 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 04/12] iio: frequency: admv1014: use dev_err_probe in probe path Date: Mon, 23 Feb 2026 15:13:55 +0200 Message-ID: <20260223131418.55414-5-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=WsUm8Nfv c=1 sm=1 tr=0 ts=699c52c5 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=S22sRNvq--lf_LWfmLgA:9 X-Proofpoint-GUID: RnSCddPr0x4BIDKrOvtYE5dyTofv0Awt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfX1NaIHvjtsUM/ TknHOSLTe1iR1reN4Z76Oic0vqRMW1Oqs8eV2gJ0EYn8Cx3Lxk9X5anDOOLP+z209lwucWzBiiV JVgxlf5rwIBeAwyAbiQpC/3jw59/wLPQjMAFUFsTRbcae8mmxxQ9DpQf3pG61RbxchJtld80G2A vDsEWqapEbAI5l/K3+xswds7eCFZVSzIOvZCviz8bO6Jq/g5MqCTJqDJ4gPxp7TfCQJGnFFHo3i xklemHrH4jh4oZ4mRrtu5/8Otjl69nKwXdyQ8bOc0XAMbDPnwOv7uwcprfSqTrPBjb4L7555vvE a93eD3bEQjtYMIm5fu09No13Rx9DiNdTXxJWrNbRvMPjtzW2GY28+jkrLvBVR0oyVEJZMcXb7Yu kgW/wWqqPMAUAY8Ki1/Ot44s/kSnvcgIkaHEcVcadumGLXiLVwSCLhXKDGttgrA7bUwx+I/2tgR eEcBnCsYxI8YnD37DGg== X-Proofpoint-ORIG-GUID: RnSCddPr0x4BIDKrOvtYE5dyTofv0Awt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in the probe path to simplify error handling and to ensure the error code is logged. Drop 'SPI' from error messages since the bus type is evident. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/admv1014.c | 63 ++++++++++++++------------------ 1 file changed, 27 insertions(+), 36 deletions(-) diff --git a/drivers/iio/frequency/admv1014.c b/drivers/iio/frequency/admv1= 014.c index ce1b40336e15..eeb01cfb799f 100644 --- a/drivers/iio/frequency/admv1014.c +++ b/drivers/iio/frequency/admv1014.c @@ -613,10 +613,9 @@ static int admv1014_init(struct admv1014_state *st) int ret; =20 ret =3D regulator_bulk_enable(ADMV1014_NUM_REGULATORS, st->regulators); - if (ret) { - dev_err(dev, "Failed to enable regulators"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to enable regulators"); =20 ret =3D devm_add_action_or_reset(dev, admv1014_reg_disable, st->regulator= s); if (ret) @@ -643,55 +642,48 @@ static int admv1014_init(struct admv1014_state *st) ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_SPI_CONTROL, ADMV1014_SPI_SOFT_RESET_MSK, FIELD_PREP(ADMV1014_SPI_SOFT_RESET_MSK, 1)); - if (ret) { - dev_err(dev, "ADMV1014 SPI software reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV1014 software reset failed.\n"); =20 ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_SPI_CONTROL, ADMV1014_SPI_SOFT_RESET_MSK, FIELD_PREP(ADMV1014_SPI_SOFT_RESET_MSK, 0)); - if (ret) { - dev_err(dev, "ADMV1014 SPI software reset disable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV1014 software reset disable failed.\n"); =20 ret =3D __admv1014_spi_write(st, ADMV1014_REG_VVA_TEMP_COMP, 0x727C); - if (ret) { - dev_err(dev, "Writing default Temperature Compensation value failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Writing default Temperature Compensation value failed.\n"); =20 ret =3D __admv1014_spi_read(st, ADMV1014_REG_SPI_CONTROL, &chip_id); if (ret) return ret; =20 chip_id =3D FIELD_GET(ADMV1014_CHIP_ID_MSK, chip_id); - if (chip_id !=3D ADMV1014_CHIP_ID) { - dev_err(dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D ADMV1014_CHIP_ID) + return dev_err_probe(dev, -EINVAL, + "Invalid Chip ID.\n"); =20 ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_QUAD, ADMV1014_QUAD_SE_MODE_MSK, FIELD_PREP(ADMV1014_QUAD_SE_MODE_MSK, st->quad_se_mode)); - if (ret) { - dev_err(dev, "Writing Quad SE Mode failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Writing Quad SE Mode failed.\n"); =20 ret =3D admv1014_update_quad_filters(st); - if (ret) { - dev_err(dev, "Update Quad Filters failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Update Quad Filters failed.\n"); =20 ret =3D admv1014_update_vcm_settings(st); - if (ret) { - dev_err(dev, "Update VCM Settings failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Update VCM Settings failed.\n"); =20 enable_reg_msk =3D ADMV1014_P1DB_COMPENSATION_MSK | ADMV1014_IF_AMP_PD_MSK | @@ -739,10 +731,9 @@ static int admv1014_properties_parse(struct admv1014_s= tate *st) =20 ret =3D devm_regulator_bulk_get(dev, ADMV1014_NUM_REGULATORS, st->regulators); - if (ret) { - dev_err(dev, "Failed to request regulators"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to request regulators"); =20 st->clkin =3D devm_clk_get(dev, "lo_in"); if (IS_ERR(st->clkin)) --=20 2.43.0 From nobody Fri Apr 17 06:15:34 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBB90366542; Mon, 23 Feb 2026 13:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852502; cv=none; b=VJAsbMK9b0Tx9g/WqSjjbfLugcWpIniW7RgJGSpODimBOt60JL5yI8NtD01tbqMlOvnkar9gN9H4J13EnfmGgpPHqahYxnvvz7u5IjQ218ArBv+iHV4ojC6dWHUmiLqNxbtiOs87uEKTRYiaBVOECBFHavNgGbREKtrppFJgTrc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852502; c=relaxed/simple; bh=AvFrLwFPZxIb2JqSSuJ2Vk75qbD7Bqmzb7yTRi+e4Hc=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eL1SURLP8m+hcTuvaSLvGE4OmEsLjfecNkyrSkJjfO9yfOGwUhwbK+PD8xhbQT8QtCYZebxANbpJHrCHRVsgDSWpZG6MIVx2HyBKYTqGxjN6ZTHJLWkKKNgEehmx/ZqSzE484G0ZT9lg9oVhkuzaRF+vb8bejc1DeXycK9kpTZg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=nkIRRjBt; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="nkIRRjBt" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N8TNj61742992; Mon, 23 Feb 2026 08:14:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=fUVuM INfEV/vwHxhJyoSgukVLInyqFeH+ltiXg/HAX0=; b=nkIRRjBtwGB8JrQz8Zs// BRwb+6KGTt60Az9r1nGzn/Jr8mJZN6Hf6utK8TBOHThWSu/n/DPmyQHF5pvHxE9c eHDc2lXAXRNZSEJbXXu5BeS+6tHsjaNKaWg3VVsEGky2PvHPH1PiulWj/dm8NG3K nHCsG+VDUnKD3YiUQgNmzyV8Dmdq6AcaHlBq3PqDuGZzh8IJEqwhHFL6sN6u9f/n vX1//kZG4tCCEJtu4RF3oZPMetBoGt/ZWLI17/rtvs1qIsxii3XWrKFf+l0dF/Jq SA9oCq8HuqJpsIqJANtSK6iYklMIVDQfChZUDWgqRzHNnMCk9JHL2jueadetgqgM A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7p4k2wm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:14:47 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDEjYD009747 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:14:46 -0500 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:45 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:45 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:14:45 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXb006594; Mon, 23 Feb 2026 08:14:41 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 05/12] iio: frequency: admv1013: introduce struct device variable Date: Mon, 23 Feb 2026 15:13:56 +0200 Message-ID: <20260223131418.55414-6-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfX3sZDJ5vqrf3T 4/iuD2JYA4VVJWsb0/9TffQaBqJ88nakQD/0+flRiKamJdx16v9dvWdrwX4XV9hXzxu2yY9Nbf2 ljyr8N4trfG4tkchfBOa/8eGEQnrTVakS9h82AkAYaVuqNb0jXLIPBrPhHptP/khlgyCEuA2qOy ouMOjyPMEG+N51u/suKM/etJnlzLMjvyG/sKRFNEc998SfHPrl3LAnnv6+G9dJc9CQuf1T4FLqG bJI4FvQezHBkwlHyo6ByVO8ArqD/kNnzUxbhVmBgaHrpUvSsLbm25Wg1WkGBRNw68DHHhayMmso uwYLa9MPNci8MlAoeQnCIlJjnqC3WPD18qc9dAgbDgwdSXXlTBXvvcmdIjvAbXcldK7EH1NKdO7 irXtxj6gw2s7hgZAbf77zJYiNXQsN7EWmWQ4uZZ6idCQM0iGGl2WDdxJ6qUel20UC1VnBOdqEbU NiCOZGMOTB/L2BO9rlg== X-Proofpoint-ORIG-GUID: y4aAfQMb5pGAye8WzJTn9cmwF-lZ60Wv X-Authority-Analysis: v=2.4 cv=LfgxKzfi c=1 sm=1 tr=0 ts=699c52c7 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=j11YKoYN7QvLHPzYg_IA:9 X-Proofpoint-GUID: y4aAfQMb5pGAye8WzJTn9cmwF-lZ60Wv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Add struct device *dev local variable to simplify repeated &spi->dev dereferences. Where spi is no longer needed beyond &spi->dev, replace struct spi_device *spi with struct device *dev =3D &st->spi->dev. No functional change. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/admv1013.c | 35 ++++++++++++++++---------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1= 013.c index d8e8d541990f..4e1ebb9a537b 100644 --- a/drivers/iio/frequency/admv1013.c +++ b/drivers/iio/frequency/admv1013.c @@ -441,7 +441,7 @@ static int admv1013_init(struct admv1013_state *st, int= vcm_uv) { int ret; unsigned int data; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 /* Perform a software reset */ ret =3D __admv1013_spi_update_bits(st, ADMV1013_REG_SPI_CONTROL, @@ -462,7 +462,7 @@ static int admv1013_init(struct admv1013_state *st, int= vcm_uv) =20 data =3D FIELD_GET(ADMV1013_CHIP_ID_MSK, data); if (data !=3D ADMV1013_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); + dev_err(dev, "Invalid Chip ID.\n"); return -EINVAL; } =20 @@ -518,11 +518,11 @@ static int admv1013_properties_parse(struct admv1013_= state *st) { int ret; const char *str; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 - st->det_en =3D device_property_read_bool(&spi->dev, "adi,detector-enable"= ); + st->det_en =3D device_property_read_bool(dev, "adi,detector-enable"); =20 - ret =3D device_property_read_string(&spi->dev, "adi,input-mode", &str); + ret =3D device_property_read_string(dev, "adi,input-mode", &str); if (ret) st->input_mode =3D ADMV1013_IQ_MODE; =20 @@ -533,7 +533,7 @@ static int admv1013_properties_parse(struct admv1013_st= ate *st) else return -EINVAL; =20 - ret =3D device_property_read_string(&spi->dev, "adi,quad-se-mode", &str); + ret =3D device_property_read_string(dev, "adi,quad-se-mode", &str); if (ret) st->quad_se_mode =3D ADMV1013_SE_MODE_DIFF; =20 @@ -546,11 +546,11 @@ static int admv1013_properties_parse(struct admv1013_= state *st) else return -EINVAL; =20 - ret =3D devm_regulator_bulk_get_enable(&st->spi->dev, + ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(admv1013_vcc_regs), admv1013_vcc_regs); if (ret) { - dev_err_probe(&spi->dev, ret, + dev_err_probe(dev, ret, "Failed to request VCC regulators\n"); return ret; } @@ -562,9 +562,10 @@ static int admv1013_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct admv1013_state *st; + struct device *dev =3D &spi->dev; int ret, vcm_uv; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -581,20 +582,20 @@ static int admv1013_probe(struct spi_device *spi) if (ret) return ret; =20 - ret =3D devm_regulator_get_enable_read_voltage(&spi->dev, "vcm"); + ret =3D devm_regulator_get_enable_read_voltage(dev, "vcm"); if (ret < 0) - return dev_err_probe(&spi->dev, ret, + return dev_err_probe(dev, ret, "failed to get the common-mode voltage\n"); =20 vcm_uv =3D ret; =20 - st->clkin =3D devm_clk_get_enabled(&spi->dev, "lo_in"); + st->clkin =3D devm_clk_get_enabled(dev, "lo_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the LO input clock\n"); =20 st->nb.notifier_call =3D admv1013_freq_change; - ret =3D devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb); + ret =3D devm_clk_notifier_register(dev, st->clkin, &st->nb); if (ret) return ret; =20 @@ -602,15 +603,15 @@ static int admv1013_probe(struct spi_device *spi) =20 ret =3D admv1013_init(st, vcm_uv); if (ret) { - dev_err(&spi->dev, "admv1013 init failed\n"); + dev_err(dev, "admv1013 init failed\n"); return ret; } =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1013_powerdown, st); + ret =3D devm_add_action_or_reset(dev, admv1013_powerdown, st); if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id admv1013_id[] =3D { --=20 2.43.0 From nobody Fri Apr 17 06:15:34 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E7D5883F; Mon, 23 Feb 2026 13:15:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852504; cv=none; b=q7K+YbTbXo6iZ9xd+WLfxUTZ2Jc3tNk8/psWpDnvZ2bd8E7Jgjc5Lg4LyCstdSSPRxuaCvN02M8/Wj+Cs/h4xeEd8wg1SYXa0MT4QfEecpqPLndq4RqSOBYgRvW4zXZQ0LJBQaTywEdi5Gf00DVVs6JAOTwc8oAVMXuFoeZIRsM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852504; c=relaxed/simple; bh=hBssVFaNQY0+yXmiNeK96LwwS3FgXo76PlnB942ElrU=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DcgA4ncKJ8x7eScyucgMhpwCWYnmT+QY1Ef9ITjFqmDBuK5dg7EWja/C5ZKDC0nGe+GojaImDV4ZDssCIJfIY3kiXsxxoJ4xhXcHMI2MdxgeLNsRcKos/4uBFND2Z2nC6BRXqfnPfrwEXX3ZPGHzMOC3wbzUWVQaCSfdW1xMON8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=aOCEqXVS; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="aOCEqXVS" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N6xcNL2667992; Mon, 23 Feb 2026 08:14:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=o5Doc GBc4zeUhe88Xnw5qRJAxb9dZbudffZpZAIEvzM=; b=aOCEqXVSkmHiqgBpRXDC5 k/Du348j5x5pmFhzK9FzqXf/qoomn3tGbJjWQPGy3tcyjCzOVF1/j/XFIgFWNOXD F4j2JBPEO71yY0pOP/23MSq34wEQWb4FhNOMYsZIqKi0ybrRgM36M0eSolDTpwg3 tUDmWTHzj8YbeaFwHpwOwFqjWgSnFTSFtIvQGw7N79Js92naL0jjJwyelrEE51AU CLjUBQKj25X5CAozXIgR5IhiIWf3+MCLzGUSWM3qnhY4isErTKYrsUkd71Nrvvwi Cka/BVWHxQXnXNhFRNZu7u/z33H1qttyANIHYTz8J4EM31xM8AVV5hTi/PyY2QR8 A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7pbb12d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:14:49 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDEmJe009755 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:14:48 -0500 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:48 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:48 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:14:48 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXc006594; Mon, 23 Feb 2026 08:14:44 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 06/12] iio: frequency: admv1013: use dev_err_probe in probe path Date: Mon, 23 Feb 2026 15:13:57 +0200 Message-ID: <20260223131418.55414-7-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: AmvjIIqnDWi1hrLxYwObeVB70jBi8667 X-Authority-Analysis: v=2.4 cv=RPK+3oi+ c=1 sm=1 tr=0 ts=699c52c9 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=3LiYLoh_h3RjBjQ2HpkA:9 X-Proofpoint-ORIG-GUID: AmvjIIqnDWi1hrLxYwObeVB70jBi8667 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfXx1hZ4X/U7aHz cKc61v+2brQF7jrNC04INvx0AIJl8yVukqZe5KjSYtUfXnrQuiZZrHUEAk+i/NJgfk6/ym7qWv0 0d3QNCTaPlxXIPmdebdES1a6FcPRTsDGfTnZbLLJ0Ghp+vK7DEffXfNdjqEJtnjWSaVHSLCAELD e+9A85g4ACE/eW29lqiHHoqj/0JEk0c/Me623NZmO/OB14QdpCMwqXUDhAmZ0UneZNeQtsTgVZT tnbeYqi6XHQ6elFfCRVmxbKSZjLM60Fq6PB6RwDp4CHJUSAp644EbfOs/S9AkJzlv5qKulnuAt+ elpjjR+L7gt1S3S6Yhjl6fTXnotRuKZLVPW62d98BmDAsmcdD3CKhHRpC/ivZQWFlM+RIGIIu2i O12doHBV8oPTBukhcj/7sQn/iLQhJZw9Qhc6pKIsY/8GvWG6jdUcpaekdsOj4LYGvpkrSILBv31 h33tTezW1KlBM6VG3Bw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 adultscore=0 priorityscore=1501 spamscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in the probe path to simplify error handling and to ensure the error code is logged. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/admv1013.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1= 013.c index 4e1ebb9a537b..514cf9f8eacb 100644 --- a/drivers/iio/frequency/admv1013.c +++ b/drivers/iio/frequency/admv1013.c @@ -461,10 +461,9 @@ static int admv1013_init(struct admv1013_state *st, in= t vcm_uv) return ret; =20 data =3D FIELD_GET(ADMV1013_CHIP_ID_MSK, data); - if (data !=3D ADMV1013_CHIP_ID) { - dev_err(dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (data !=3D ADMV1013_CHIP_ID) + return dev_err_probe(dev, -EINVAL, + "Invalid Chip ID.\n"); =20 ret =3D __admv1013_spi_write(st, ADMV1013_REG_VVA_TEMP_COMP, 0xE700); if (ret) @@ -549,11 +548,9 @@ static int admv1013_properties_parse(struct admv1013_s= tate *st) ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(admv1013_vcc_regs), admv1013_vcc_regs); - if (ret) { - dev_err_probe(dev, ret, - "Failed to request VCC regulators\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to request VCC regulators\n"); =20 return 0; } @@ -602,10 +599,9 @@ static int admv1013_probe(struct spi_device *spi) mutex_init(&st->lock); =20 ret =3D admv1013_init(st, vcm_uv); - if (ret) { - dev_err(dev, "admv1013 init failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "admv1013 init failed\n"); =20 ret =3D devm_add_action_or_reset(dev, admv1013_powerdown, st); if (ret) --=20 2.43.0 From nobody Fri Apr 17 06:15:34 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6949B1EB9F2; Mon, 23 Feb 2026 13:15:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852514; cv=none; b=GAvxfqq0Zc7W/ypjCxfaiVtiiE4dVgEmYMSGhRLmoJjE9XCjqG7VuQhDfqNcj1LCUp5gKfrDptP+qGCNQOy4R5ffjGd/1R0eq6SI/uGKXhvUkARXivBL/Y85OLG7dkpHegzmmCDdgSL1tSnKJ0B649xwi1rz0NXpDmRXLAFK4NE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852514; c=relaxed/simple; bh=UR0cvINV7Cf3IaNBpeC5pV4GQESP4KSvxF1kPsvMzqg=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Cr7zsWU0OwS/JCSY2yDmS7FE3RXtJ20XT0xqxCceZLCdzQUyL0nSED/fwh5NlF4Va/SSigAju5eSvJIc9cPHEXtinXTe7M/vxtV5CtBVOLNsvbXg36670nUUO+AS5zSQkMKcYm+W/PhdmoSr8K/OPqEpk7ZtFFSut+r8753ROQs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=RVeh9sVa; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="RVeh9sVa" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N6gebm2668062; Mon, 23 Feb 2026 08:14:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=CceAy mbNYmLaNdeJU+zYFk+D1oNDCfXFz3BRkZs3MbU=; b=RVeh9sVaMaWCyGSuLzAGK qTeUNdgo1OegDmBx+mZzc3ssTG42Ve40DYF6I9vDxKFp8bxRp17U0gLlWu+3yThd MJlXxFwI/Xzru2cWaeRA94VfbbD9qGYux2AjbFwFhvEiq6k6YvWdZ/e2rsS/7hVs mFVFsY2/gK7aK+aiMlTjRz4AqvG0tOogpmsUXivMZ+4VWCrkju/3uLudmuTkRPBw mDD2yGeMmoVxZdTsbcGSJlGNdpLzl9hglwvHAWo2KqD21MBheLu8XgbyVZ3/2nnh 6miwEzyauzyJBMPMeiSKqom5s0bt1WQWS9tde8LoH23KwFo001OBL1pEkZAAjuZ3 w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7pbb12j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:14:52 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDEp0t009764 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:14:51 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:51 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:14:51 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXd006594; Mon, 23 Feb 2026 08:14:47 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 07/12] iio: frequency: adf4377: introduce struct device variable Date: Mon, 23 Feb 2026 15:13:58 +0200 Message-ID: <20260223131418.55414-8-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: 6kXypGpJsOUy3_vjoHpvklTxv_a8voOf X-Authority-Analysis: v=2.4 cv=RPK+3oi+ c=1 sm=1 tr=0 ts=699c52cc cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=fOTDyBl8tY8esg50VKwA:9 X-Proofpoint-ORIG-GUID: 6kXypGpJsOUy3_vjoHpvklTxv_a8voOf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfX3vungmR1SKmY V52wb0EhXNFTGf5y7t8ox1CeI+TfXGhsCz2EpMX8r0451ftEqcEbtnyjpewU+OeRvtpHjigTRdv PgmQw5b1cTlv3B0x5vlQ9vIcfHqskLHfFMcbKG3gUAdXaeTyaiwFSOncBZPED/SHZ930S82WXU7 mhfBBvfN3wCr5I6BuUUZyhN24AL7TR9+2buNJSFk489djw302IvK0cOQf1kjAIsOUv/sgGmUYIb bEks1xiw7+f3Jx8Gh/YNc3jpEIMXB2iDGv1iILLDsNezmr+5Qp8TQaP/PC/6LaoQpZ9n0WWT5I0 NmOnCgfvdfa7PCzcnUTRPiAvBCrGmw8SExziaszFO8zKovyQrQ2sSBBJIR3lrsPLw6PMs/b4KRt IuRXUFd3Mdxz2A5F/cao7Y/Fc6MTmIdcjq5tP0ApV+JbuGG4K93fYzWHCsARHkDenr75Fs/9439 br7avaaKVXMHTKP3WrQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 adultscore=0 priorityscore=1501 spamscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Add struct device *dev local variable to simplify repeated &spi->dev dereferences. Where spi is no longer needed beyond &spi->dev, replace struct spi_device *spi with struct device *dev =3D &st->spi->dev. No functional change. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/adf4377.c | 37 +++++++++++++++++---------------- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/iio/frequency/adf4377.c b/drivers/iio/frequency/adf437= 7.c index fa686f785fa4..919b604b2ce6 100644 --- a/drivers/iio/frequency/adf4377.c +++ b/drivers/iio/frequency/adf4377.c @@ -706,21 +706,21 @@ static void adf4377_gpio_init(struct adf4377_state *s= t) =20 static int adf4377_init(struct adf4377_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 adf4377_gpio_init(st); =20 ret =3D adf4377_soft_reset(st); if (ret) { - dev_err(&spi->dev, "Failed to soft reset.\n"); + dev_err(dev, "Failed to soft reset.\n"); return ret; } =20 ret =3D regmap_multi_reg_write(st->regmap, adf4377_reg_defaults, ARRAY_SIZE(adf4377_reg_defaults)); if (ret) { - dev_err(&spi->dev, "Failed to set default registers.\n"); + dev_err(dev, "Failed to set default registers.\n"); return ret; } =20 @@ -731,7 +731,7 @@ static int adf4377_init(struct adf4377_state *st) FIELD_PREP(ADF4377_0000_SDO_ACTIVE_R_MSK, ADF4377_0000_SDO_ACTIVE_SPI_4W)); if (ret) { - dev_err(&spi->dev, "Failed to set 4-Wire Operation.\n"); + dev_err(dev, "Failed to set 4-Wire Operation.\n"); return ret; } =20 @@ -748,7 +748,7 @@ static int adf4377_init(struct adf4377_state *st) FIELD_PREP(ADF4377_001A_PD_CLKOUT1_MSK, 0) | FIELD_PREP(ADF4377_001A_PD_CLKOUT2_MSK, 0)); if (ret) { - dev_err(&spi->dev, "Failed to set power down registers.\n"); + dev_err(dev, "Failed to set power down registers.\n"); return ret; } =20 @@ -882,35 +882,35 @@ static const struct iio_chan_spec adf4377_channels[] = =3D { =20 static int adf4377_properties_parse(struct adf4377_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 - st->clkin =3D devm_clk_get_enabled(&spi->dev, "ref_in"); + st->clkin =3D devm_clk_get_enabled(dev, "ref_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the reference input clock\n"); =20 - st->gpio_ce =3D devm_gpiod_get_optional(&st->spi->dev, "chip-enable", + st->gpio_ce =3D devm_gpiod_get_optional(dev, "chip-enable", GPIOD_OUT_LOW); if (IS_ERR(st->gpio_ce)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_ce), + return dev_err_probe(dev, PTR_ERR(st->gpio_ce), "failed to get the CE GPIO\n"); =20 - st->gpio_enclk1 =3D devm_gpiod_get_optional(&st->spi->dev, "clk1-enable", + st->gpio_enclk1 =3D devm_gpiod_get_optional(dev, "clk1-enable", GPIOD_OUT_LOW); if (IS_ERR(st->gpio_enclk1)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_enclk1), + return dev_err_probe(dev, PTR_ERR(st->gpio_enclk1), "failed to get the CE GPIO\n"); =20 if (st->chip_info->has_gpio_enclk2) { - st->gpio_enclk2 =3D devm_gpiod_get_optional(&st->spi->dev, "clk2-enable", + st->gpio_enclk2 =3D devm_gpiod_get_optional(dev, "clk2-enable", GPIOD_OUT_LOW); if (IS_ERR(st->gpio_enclk2)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_enclk2), + return dev_err_probe(dev, PTR_ERR(st->gpio_enclk2), "failed to get the CE GPIO\n"); } =20 - ret =3D device_property_match_property_string(&spi->dev, "adi,muxout-sele= ct", + ret =3D device_property_match_property_string(dev, "adi,muxout-select", adf4377_muxout_modes, ARRAY_SIZE(adf4377_muxout_modes)); if (ret >=3D 0) @@ -1055,9 +1055,10 @@ static int adf4377_probe(struct spi_device *spi) struct iio_dev *indio_dev; struct regmap *regmap; struct adf4377_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -1080,7 +1081,7 @@ static int adf4377_probe(struct spi_device *spi) return ret; =20 st->nb.notifier_call =3D adf4377_freq_change; - ret =3D devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb); + ret =3D devm_clk_notifier_register(dev, st->clkin, &st->nb); if (ret) return ret; =20 @@ -1097,7 +1098,7 @@ static int adf4377_probe(struct spi_device *spi) indio_dev->num_channels =3D ARRAY_SIZE(adf4377_channels); } =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id adf4377_id[] =3D { --=20 2.43.0 From nobody Fri Apr 17 06:15:34 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6943818FDBE; Mon, 23 Feb 2026 13:15:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852512; cv=none; b=HXxgYyPZkZYO+FZIJpiZtxUXTOeQuwajEBI6bXTUdQviu05n0j69RqtTR0l4qkbER98YCjSr96hfqzj8eXQp10SufDirRVAnQckt1AA1Wx8L9j6ap6kEqN1neQ0S6hneQISUuG7iqV/3AVHxo6XrXJIk1WHf2wKwwV2suFcDZQQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852512; c=relaxed/simple; bh=+rlHpUtmIGLBKv6QD3GOr1gK5xCaxsR6NkdY8SgE3WM=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n2JNUtcUeq9Cs1aC3aFDP425lWogmCD/Aa3rOzVeSNjrYhb3aPnBD6GJQe0IpB21e9xYfX+FkWZ7qkM9sl5c0EELs/rnUEtKh70i9VtT2bCeGXS2Fq4FL/Fb2ymoIZzZDbu4vkRpOeWzxo/yZ5StUb3ed226Gpx9xETrJQ7yl5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=mf+/wtih; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="mf+/wtih" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N80KUQ818277; Mon, 23 Feb 2026 08:14:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=wddPJ Mp7lNFnMlvHlmcmFwcuINWMNAFAp4nj8L/wpgk=; b=mf+/wtihhAiPEwCQQPkzm NaJ3yfYqDBEkT7szsxVeJMhuqPPW8X17esuCY9kSAzkT6zUakN9cBK59my27bZC0 b+jI5R/RHYFpL1GsOKTebCkT8tHWADqPdoBK6zEIQjPrLE2+85ZcsA9PbVfDE2CP JPYdFVmoOBbzflzsihSmFIxgAZdZeb4iHZhl8yG3WpDoh1v6KbjJN4GChQeAA8Ku lyOAlP1AwtSN92LVRInSE1RGJAGeM+Eh0600knoxZheK+l0Q8++gEx5TEyh0qiLe 4AmdzzegqClFKV/mihAoywwcU9pDmUPe6FACX8IqqjNk20jgeYvV+7HnZIN/yc// g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7p02y7u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:14:55 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDEsec009768 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:14:54 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:53 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:14:53 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXe006594; Mon, 23 Feb 2026 08:14:50 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 08/12] iio: frequency: adf4377: use dev_err_probe in probe path Date: Mon, 23 Feb 2026 15:13:59 +0200 Message-ID: <20260223131418.55414-9-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: hP0Nuf0I7ItywHtsqUuEJw75Ve7ojYeC X-Proofpoint-GUID: hP0Nuf0I7ItywHtsqUuEJw75Ve7ojYeC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfX0O7AI5Pd4G9i oqsb9HFoUo5QXZ8V2t12DtUjZ6oTdTpj/jj01FLk283Xfgs7Jqaiztc9mue8lljpNpiTrxCVsXc DQZzINskH7uzS2VsitwWcvdv3QmJqJwvtF0DqbMuW1M5hfJEr1uHeeL1Hq9gfTXN6GUSyRMnQSe 3SYlhZjM1yG6nfXoNTLFNHN7zjEP0nYHFUu9wL7mvlcf5OM7vOuRi8kaakJpdl3tOLPEAlOXnDX s2wwOOlKpV5siezypcFJ7mlLr7zJEkOjU6s8qLHOfeaNZzDuwV5GWRA8w3U811qEK8oV/u7Oz+Z 9wHBAfY0BAtH1gIS0ePlg2sfppIegju+sT1p4sIhDjCkN+EkCODXM7GomR/6w0AbSS24Tulr2/c O8VkGVgjXPMG/rDPuFft94gTFBXE/kmSaoGlf1be/332aa+RnA+G80Q6PH/9ma5sjcR5vBqUnKi j6qJ7iUMKMYG8v6xbZg== X-Authority-Analysis: v=2.4 cv=Fq4IPmrq c=1 sm=1 tr=0 ts=699c52cf cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=Z0pTeXoby7EwIRygza74:22 a=gAnH3GRIAAAA:8 a=XIZiaBmXTVxVH1IbRYoA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in the probe path to simplify error handling and to ensure the error code is logged. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/adf4377.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/iio/frequency/adf4377.c b/drivers/iio/frequency/adf437= 7.c index 919b604b2ce6..cfc0c524c4a4 100644 --- a/drivers/iio/frequency/adf4377.c +++ b/drivers/iio/frequency/adf4377.c @@ -712,17 +712,15 @@ static int adf4377_init(struct adf4377_state *st) adf4377_gpio_init(st); =20 ret =3D adf4377_soft_reset(st); - if (ret) { - dev_err(dev, "Failed to soft reset.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to soft reset.\n"); =20 ret =3D regmap_multi_reg_write(st->regmap, adf4377_reg_defaults, ARRAY_SIZE(adf4377_reg_defaults)); - if (ret) { - dev_err(dev, "Failed to set default registers.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to set default registers.\n"); =20 ret =3D regmap_update_bits(st->regmap, 0x00, ADF4377_0000_SDO_ACTIVE_MSK | ADF4377_0000_SDO_ACTIVE_R_MSK, @@ -730,10 +728,9 @@ static int adf4377_init(struct adf4377_state *st) ADF4377_0000_SDO_ACTIVE_SPI_4W) | FIELD_PREP(ADF4377_0000_SDO_ACTIVE_R_MSK, ADF4377_0000_SDO_ACTIVE_SPI_4W)); - if (ret) { - dev_err(dev, "Failed to set 4-Wire Operation.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to set 4-Wire Operation.\n"); =20 st->clkin_freq =3D clk_get_rate(st->clkin); =20 @@ -747,10 +744,9 @@ static int adf4377_init(struct adf4377_state *st) FIELD_PREP(ADF4377_001A_PD_PFDCP_MSK, 0) | FIELD_PREP(ADF4377_001A_PD_CLKOUT1_MSK, 0) | FIELD_PREP(ADF4377_001A_PD_CLKOUT2_MSK, 0)); - if (ret) { - dev_err(dev, "Failed to set power down registers.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to set power down registers.\n"); =20 /* Set Mux Output */ ret =3D regmap_update_bits(st->regmap, 0x1D, --=20 2.43.0 From nobody Fri Apr 17 06:15:34 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 909BB1A9FA8; Mon, 23 Feb 2026 13:15:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852516; cv=none; b=qUAPOIeHG6fYtl4H39QgQSs+c82uAD4+bO8dVTTKw/4HlfEr9nEHBFog7hNTmqhnvWZEUGyn0KmLe+irfatWD+s7BJ3G8KPSwDFOUK2ZJqnfCdM9QxvIy7YwVBH4Uxu8YTnMacRTkoUTn3X0aUAHgcIyyxDHT6iwLmvk6OxGWXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852516; c=relaxed/simple; bh=0NDMZ0guBQkdGSQJjwXkzesTGiCfDQd8YSxGTzs+OSg=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pAeytK5+XyD9SZCqInL2PAUR0St4ektNNCSl7LZBlFz+DVavXYmkbAKgczDuYLBDzmOO6Mi9ajlO2zKCHJeEuuiva5z+dHWec58xkJ1bnSCw+gnjR6d9/3NWHfbJV7WNTkJnCo9oLda6UYhLSTg5PZnPdznv57nw3kUDLsZ/Dy4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=BdCk2+11; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="BdCk2+11" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N6gebo2668062; Mon, 23 Feb 2026 08:15:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=7NB7g Jk60goleya4WTN0G6xyz/+UgYn4umNGueq5I0c=; b=BdCk2+113uc+coUBTus3D d0Ulkk1Toh353K6yKk+UvFY8w6QZIiN35QXoJ+scmhhmSnFoEcCKE9ikkZsy8c+u S/h8AjbtQbXUK6JRwKXEy9C3vmdTURXQI5zWOo8Q5cpIDNGO4tdeIyFV4DxYOOkF 7U2XCIEFPg0sWsVjwJEqU7Qey1LPGjsLuZ7xJcgWN2vuVFJfmiJS1vryoU5RQILZ d9+bKq57zSfYRTusKvJvDGVqZimUtQAFsWS/5/mOqFm4l4fyvMzHGxklcJfT3wg+ K/zGB/dVwmo8npOBrGLlw7TJQ0nqPjuNqVCHjGadRqtbgkadfuuJtZ7mx4B7NpIA A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7pbb12w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:15:00 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDExSZ009776 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:14:59 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:59 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:14:59 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXf006594; Mon, 23 Feb 2026 08:14:53 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 09/12] iio: dac: ad7293: introduce struct device variable Date: Mon, 23 Feb 2026 15:14:00 +0200 Message-ID: <20260223131418.55414-10-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: LH6buICk24YikVxMT7GGHmkeBS8cteO6 X-Authority-Analysis: v=2.4 cv=RPK+3oi+ c=1 sm=1 tr=0 ts=699c52d4 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=vjhhOmsZBZqeCypw3Y8A:9 X-Proofpoint-ORIG-GUID: LH6buICk24YikVxMT7GGHmkeBS8cteO6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfX20fifIyWHglw DfbWcvDEkeMrW/2t+PxAWQex7ZKcwRngE8wnmWdO8JBtNJX9dcwiaiUm06dMuwSkieq/G303IcY 8Z9pgHFNztfa3D0EOiacD/aaHrkSOhb5cQOq7CHZDzU/kn16+0/pbcyYYDnDImzRbKjWeuVhWXQ YeT6g/G/ewySGnZ0v8PNXkT2oc15Se93FK0WO35ku7l96W/Np1mXdlWm8QJwTs84HQ943TZ2XX3 2IYgTgGn++rEHm3vBhzEv9u3Jp6queS1k5crU03MrUP24zhWpfnbsDjIMk6ZVk5/DvRUYJgeY97 /lAUgiEGM3mQyUlF/ebKD1LHCM2XObOaVGN+qvKO+1sdFVE4XZDueliEey1ExVOsfSF9s9eFftj 8nX8cdVsd81X9A1P9hVaRt1DHEW/G0decXdVaT4hYDyKZVKsIVCZWdynizUPxYMjEPWdsDky7vX JaxbZgSReV6vIrE7b1w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 adultscore=0 priorityscore=1501 spamscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Add struct device *dev local variable to simplify repeated &spi->dev dereferences. Where spi is no longer needed beyond &spi->dev, replace struct spi_device *spi with struct device *dev =3D &st->spi->dev. No functional change. Signed-off-by: Antoniu Miclaus --- drivers/iio/dac/ad7293.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/iio/dac/ad7293.c b/drivers/iio/dac/ad7293.c index c3797e40cdd9..0168d111ecbc 100644 --- a/drivers/iio/dac/ad7293.c +++ b/drivers/iio/dac/ad7293.c @@ -776,27 +776,27 @@ static int ad7293_reset(struct ad7293_state *st) =20 static int ad7293_properties_parse(struct ad7293_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 - ret =3D devm_regulator_get_enable(&spi->dev, "avdd"); + ret =3D devm_regulator_get_enable(dev, "avdd"); if (ret) - return dev_err_probe(&spi->dev, ret, "failed to enable AVDD\n"); + return dev_err_probe(dev, ret, "failed to enable AVDD\n"); =20 - ret =3D devm_regulator_get_enable(&spi->dev, "vdrive"); + ret =3D devm_regulator_get_enable(dev, "vdrive"); if (ret) - return dev_err_probe(&spi->dev, ret, "failed to enable VDRIVE\n"); + return dev_err_probe(dev, ret, "failed to enable VDRIVE\n"); =20 - ret =3D devm_regulator_get_enable_optional(&spi->dev, "vrefin"); + ret =3D devm_regulator_get_enable_optional(dev, "vrefin"); if (ret < 0 && ret !=3D -ENODEV) - return dev_err_probe(&spi->dev, ret, "failed to enable VREFIN\n"); + return dev_err_probe(dev, ret, "failed to enable VREFIN\n"); =20 st->vrefin_en =3D ret !=3D -ENODEV; =20 - st->gpio_reset =3D devm_gpiod_get_optional(&st->spi->dev, "reset", + st->gpio_reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(st->gpio_reset)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_reset), + return dev_err_probe(dev, PTR_ERR(st->gpio_reset), "failed to get the reset GPIO\n"); =20 return 0; @@ -806,7 +806,7 @@ static int ad7293_init(struct ad7293_state *st) { int ret; u16 chip_id; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 ret =3D ad7293_properties_parse(st); if (ret) @@ -822,7 +822,7 @@ static int ad7293_init(struct ad7293_state *st) return ret; =20 if (chip_id !=3D AD7293_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); + dev_err(dev, "Invalid Chip ID.\n"); return -EINVAL; } =20 @@ -845,9 +845,10 @@ static int ad7293_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct ad7293_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -867,7 +868,7 @@ static int ad7293_probe(struct spi_device *spi) if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad7293_id[] =3D { --=20 2.43.0 From nobody Fri Apr 17 06:15:34 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C454F1CEAC2; Mon, 23 Feb 2026 13:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852514; cv=none; b=Q2QDRV8FXGa2wRx0rMLYlVLV9Yun69qrwoTegmVjMn0/g1GWdyWjHHx8NQhtb4UtR8uzpRqAuB1qO89pmFcnWGv6lHpfu58Pj/ik9Qx2H/Cz3slA5S56Q2Z/rR/1/yliXtkfcPlFgvAAP8K2bUHD5N/pjp+ZCe2lv/2ligk2nxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852514; c=relaxed/simple; bh=xxV19UaSe1TjP6wo05av6XlzTmJB/AE0dGKKG2NIorc=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LQxb2WHiPcaRWDneAfk7dp878bjnZgpg3Ae0puT8SXVPsx0V9MPxP3a9HNsXinuvGQeXBRiAEZ9nDNppO58j3yWDfmZsL548jqSoZESUfCL1wdDHHHjF4Dh1DRNoJHGPrNYE8QCsF//MiPnQk7xHeOeOBmfpDxr2hwr6vb2OkqM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=RtlX8eIC; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="RtlX8eIC" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N9CE793131600; Mon, 23 Feb 2026 08:15:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=rieTi KDp0nQjO7gSgCfl0+xFegx2D5On4IPvrm+kN5U=; b=RtlX8eICGo6TqHy/6tvm/ 8btwm6sup6Sl2DIJ05+gWiNTiXpnJWlJ5A6EzxF9PTzgZkH23ipl045vWyb1Ou1w 5H/jalssjslznmY2Vyp/XC9wAGjNQpa4Hq0iNSCIrQGJocKa1BopGdt0BkRnOssR O/PqnamAbhxzIRufOx722RxwhbF8dlbbQJfwxEn5kxlEYi6Xq43cxuZ0ACMPrAxy wiGbmue3uKxjFCNtYaE/bD3Uob/AZZ4Bllj9KAc0OGH3wCDwq/aLkjQbw84x5EVy NTOFSanvBQWXmfYJtWC2eUkruyNSzP/D6QUI0A54EG3s5ib1LZfD6exsIPQWPMU3 w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cf7e1y93f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:15:00 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDExvH009779 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:14:59 -0500 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:59 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:14:59 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:14:59 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXg006594; Mon, 23 Feb 2026 08:14:55 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 10/12] iio: dac: ad7293: use dev_err_probe in probe path Date: Mon, 23 Feb 2026 15:14:01 +0200 Message-ID: <20260223131418.55414-11-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=WsUm8Nfv c=1 sm=1 tr=0 ts=699c52d4 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=Dq2lWTSAZ_tVkdDfGW0A:9 X-Proofpoint-GUID: 3WDwPtdk9O7t8EB0YLHK9ehQDiZvBmFd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfX8SesEYr4e/Lh ES6WjJtMFsHD7EbpcbkP/ecA9NFYwmEvHDipTyEZFYiUALjN7hIP4q0WH9M8912yGcGmN0Kiqg+ mbNZyoBsHJZ24HeEoSbQtpjHA+iK9S/qLh/fN8Qwem06sdLVhY5qTI3iAaDL2m7sON1nPsWYK1w JIDE/S2Qel5zfdSuKIuCMTMU//nWVRi10VZ+AAUvMd+lMaATIVRMYUClc5o4da1sDmSfwD3E0E7 TKuZIrjJZU6RmYaD1cWhjk6pkQttgVaWXZfFLP4t2lEwx/AYjhxciwRFAwhWYZSBcXVAFYFggGJ EE9iLBYx3MMInWxMeXgMLJc2nbtOFgPCfozKMKg44ubASsivnJyNyOWlfFmMjOGZrMfG9oYYyM1 p80kYgbyd2JlCwZtjMf4tQdT55WJA1+tkc/nC+PTudj6p30hTolPqn662kEBH05wdbGuOEcU6SP Gos7ju6qNEhXaB5vTgg== X-Proofpoint-ORIG-GUID: 3WDwPtdk9O7t8EB0YLHK9ehQDiZvBmFd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in the probe path to simplify error handling and to ensure the error code is logged. Signed-off-by: Antoniu Miclaus --- drivers/iio/dac/ad7293.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/iio/dac/ad7293.c b/drivers/iio/dac/ad7293.c index 0168d111ecbc..e26cc36e9270 100644 --- a/drivers/iio/dac/ad7293.c +++ b/drivers/iio/dac/ad7293.c @@ -821,10 +821,9 @@ static int ad7293_init(struct ad7293_state *st) if (ret) return ret; =20 - if (chip_id !=3D AD7293_CHIP_ID) { - dev_err(dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D AD7293_CHIP_ID) + return dev_err_probe(dev, -EINVAL, + "Invalid Chip ID.\n"); =20 if (!st->vrefin_en) return __ad7293_spi_update_bits(st, AD7293_REG_GENERAL, --=20 2.43.0 From nobody Fri Apr 17 06:15:34 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FD7F1EB1AA; Mon, 23 Feb 2026 13:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852520; cv=none; b=EOg2nAimQKhY33MXWPihJ/HvKXgCIUJi1+qVdKnpiPrBvVjkHJppoe4PvulFe/BFZejuq6Qw96xQbwJB8EROHjsJKfGtHU9OsJXnla/BFdu4JsWDoKWJgGoaDITzuczEX3iMrnBTISm2lqOeOCsca1mjHX4mZ/Bssv2j0/AbZFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852520; c=relaxed/simple; bh=iQ0FWS3u+37EHGx/N/pb7Y6TPa8UdE2UuVeZ0GOOHns=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HroE3af0aKn8HDpG898u4fnp+2nZ7hESXChEZ0Jy/Nii0JhMgl+m9MRv35XaAbzSUqwTT+/9IXZpC9x4RUSP6Z4zzAnuUyBWmcDLLrstTjBpUeECb724LBv/s/uKGc6GyJAq6vXXkw/7VfuhH7+/1Pr8pVDr428Zh96yxVnU9pw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=ieG545A0; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="ieG545A0" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61NCkFXE1743403; Mon, 23 Feb 2026 08:15:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=OioOC +JW0PwjYrfOxpz0Dm+oQC1LdkY/Vx5aPNljTlM=; b=ieG545A0EYSNRhq4qxazW z1O+vhAOfvvLsVCXfTXGJGIfX+LhgR+odC+rrJHJLS6w2Oe+TRSYMXgJzIj9bORi xbeRtJ6waqvgxNPNExIQ0mDwHbZe4qJ1BWINz+X7akUB2G6gNPXYDxDGCfF/tfNT mTGTiecKU7IBYP96ZjFiyPwYr3tqkIVX7fi8dFCktlXmm9yDqxaRG4ajlxc9WR/q VgVPu/Rrb6n9i0elBoKXBxMxwFy4vzIF+qkjAUYntn4L+40oEj7NltOFwOcNcT/N V0Ol4WiXVEfCSO7YWgFt+kJcbxTV55kqMaaBnduOMVaeScfuyuyGUUCd04ToPfxu Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7p4k2x9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:15:05 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDF4vh009795 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:15:04 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:15:04 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:15:03 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXh006594; Mon, 23 Feb 2026 08:14:58 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 11/12] iio: filter: admv8818: introduce struct device variable Date: Mon, 23 Feb 2026 15:14:02 +0200 Message-ID: <20260223131418.55414-12-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfX/KjFTDnDDgxC R1qDi61sUDyWHmuxcticcYCpEkuGsYNVeCummBB4QErUB36Q92yHOofTJwrC6x+agGWJ86eYj4G 0WHogUHzy7nHBKJIodiMcpxdHJdmiheqRSCcfrriamW2xIuoFxdLUR2EZ3jtouPtVR9Y+gHpQmf zwpCvGeyoxwxGVxJv/xiHhe8OyEgMAdjba8chsk+66Grez7TC3zRwrkDFnhz/TqACOTEEbGtnjK F7HYqkBRZLwtdqCwjOt6lDTQOv94QkfIpHN3v5t9zu3WFRRZvq3uaNNXLTMq93ItOWr4vOH9VG5 8s4xbeXj3/y2cavyC/AQRGsh+9PhQb2SDts1/4f82wB5jZRqe0Pl3rUsWFORa4eYOL4JsNC2Qum /6uVGwlXcI+I5rh8W5X5P24ia+uAyfgKxyt2Jzhbtr8tjdm69/r6Ow/auQS87QwoGdUz2WfyBWV KRJ6CxCjGY6dgCJFdWg== X-Proofpoint-ORIG-GUID: qwbuyU1-bbMEv4ufFs1ZhRAez7mDZncM X-Authority-Analysis: v=2.4 cv=LfgxKzfi c=1 sm=1 tr=0 ts=699c52d9 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=8Kcs3v0qrSCJUSES1_wA:9 X-Proofpoint-GUID: qwbuyU1-bbMEv4ufFs1ZhRAez7mDZncM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Add struct device *dev local variable to simplify repeated &spi->dev dereferences. Where spi is no longer needed beyond &spi->dev, replace struct spi_device *spi with struct device *dev =3D &st->spi->dev. No functional change. Signed-off-by: Antoniu Miclaus --- drivers/iio/filter/admv8818.c | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c index 19f823446cda..82f433532804 100644 --- a/drivers/iio/filter/admv8818.c +++ b/drivers/iio/filter/admv8818.c @@ -657,31 +657,31 @@ static void admv8818_clk_disable(void *data) static int admv8818_init(struct admv8818_state *st) { int ret; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; unsigned int chip_id; =20 ret =3D regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A, ADMV8818_SOFTRESET_N_MSK | ADMV8818_SOFTRESET_MSK); if (ret) { - dev_err(&spi->dev, "ADMV8818 Soft Reset failed.\n"); + dev_err(dev, "ADMV8818 Soft Reset failed.\n"); return ret; } =20 ret =3D regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A, ADMV8818_SDOACTIVE_N_MSK | ADMV8818_SDOACTIVE_MSK); if (ret) { - dev_err(&spi->dev, "ADMV8818 SDO Enable failed.\n"); + dev_err(dev, "ADMV8818 SDO Enable failed.\n"); return ret; } =20 ret =3D regmap_read(st->regmap, ADMV8818_REG_CHIPTYPE, &chip_id); if (ret) { - dev_err(&spi->dev, "ADMV8818 Chip ID read failed.\n"); + dev_err(dev, "ADMV8818 Chip ID read failed.\n"); return ret; } =20 if (chip_id !=3D 0x1) { - dev_err(&spi->dev, "ADMV8818 Invalid Chip ID.\n"); + dev_err(dev, "ADMV8818 Invalid Chip ID.\n"); return -EINVAL; } =20 @@ -689,7 +689,7 @@ static int admv8818_init(struct admv8818_state *st) ADMV8818_SINGLE_INSTRUCTION_MSK, FIELD_PREP(ADMV8818_SINGLE_INSTRUCTION_MSK, 1)); if (ret) { - dev_err(&spi->dev, "ADMV8818 Single Instruction failed.\n"); + dev_err(dev, "ADMV8818 Single Instruction failed.\n"); return ret; } =20 @@ -701,12 +701,12 @@ static int admv8818_init(struct admv8818_state *st) =20 static int admv8818_clk_setup(struct admv8818_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 - st->clkin =3D devm_clk_get_optional(&spi->dev, "rf_in"); + st->clkin =3D devm_clk_get_optional(dev, "rf_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the input clock\n"); else if (!st->clkin) return 0; @@ -715,7 +715,7 @@ static int admv8818_clk_setup(struct admv8818_state *st) if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv8818_clk_disable, st); + ret =3D devm_add_action_or_reset(dev, admv8818_clk_disable, st); if (ret) return ret; =20 @@ -724,16 +724,16 @@ static int admv8818_clk_setup(struct admv8818_state *= st) if (ret < 0) return ret; =20 - return devm_add_action_or_reset(&spi->dev, admv8818_clk_notifier_unreg, s= t); + return devm_add_action_or_reset(dev, admv8818_clk_notifier_unreg, st); } =20 static int admv8818_read_properties(struct admv8818_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; u32 mhz; int ret; =20 - ret =3D device_property_read_u32(&spi->dev, "adi,lpf-margin-mhz", &mhz); + ret =3D device_property_read_u32(dev, "adi,lpf-margin-mhz", &mhz); if (ret =3D=3D 0) st->lpf_margin_hz =3D (u64)mhz * HZ_PER_MHZ; else if (ret =3D=3D -EINVAL) @@ -742,7 +742,7 @@ static int admv8818_read_properties(struct admv8818_sta= te *st) return ret; =20 =20 - ret =3D device_property_read_u32(&spi->dev, "adi,hpf-margin-mhz", &mhz); + ret =3D device_property_read_u32(dev, "adi,hpf-margin-mhz", &mhz); if (ret =3D=3D 0) st->hpf_margin_hz =3D (u64)mhz * HZ_PER_MHZ; else if (ret =3D=3D -EINVAL) @@ -758,9 +758,10 @@ static int admv8818_probe(struct spi_device *spi) struct iio_dev *indio_dev; struct regmap *regmap; struct admv8818_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -792,7 +793,7 @@ static int admv8818_probe(struct spi_device *spi) if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id admv8818_id[] =3D { --=20 2.43.0 From nobody Fri Apr 17 06:15:34 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 102721F4615; Mon, 23 Feb 2026 13:15:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852522; cv=none; b=UHkm6hmW6ycAOoLyliC+NM/eSx/yC5arUpFaB/R5lz2zWoBXkvoEayvI6qFzN3fw3LN69B/tLPKe6UeBJolhLaL2H72qC3ym6F27CiP9yb9Pg/wMbDPwIaXp6WuWUzSPJfaRHgkoBeHPowWFx6wFGAvWjuSj9z7G/C1XDgWj/zw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771852522; c=relaxed/simple; bh=iB6gga91VTjtuHbXqJjutwhI8s26s1hSSthoZne7jlU=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R6vFdUAOnVBMrW6NDKGAGK769Or4xfhSC0RnC2kubOHuyPHnqsKMC3NjKXY5fvP9lDm+Ab3PrQHgcodyBcy8HSKInk1bIGvsOikexdWFTvxR15KXP7KplMdbZU2OlPo28sfLZB9/zoBKBodf+4EUIneqLeS8S/hgZfTfUIHhSiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=RCOY1ymS; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="RCOY1ymS" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61NCW8ak1742937; Mon, 23 Feb 2026 08:15:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=jaTt0 jIK95oTCetEWdWJWZAdMh8suzvV8zjRYwvUX60=; b=RCOY1ymSTGrtM9ORqkhd4 syToEh4nCYPFl/T/GDLjVSLOnYe2XZKzW7q4Ear8soouokcTG+IXNQSfhj5z+7HE lZFcfi/iAwObu77/dfz1v4ur1boF4QLDqiFiUof1KiEemsliVVL9xv5g+IASinpE GCewS6evsMWKH68G91dDeHl11l8txiYG3E+wP6BpcK/Pc9kXET3/VENNDHAhmfgl ch9Md+XyYDVPRydXQPJrl+RN46Lw1ACsjbn+4H3YGyFTqJy+C6KFaZuVhqxL8ZbE 7rZsPUGo2vc7yTrjniwVInONIxn/eOO5XJpW8Zoj6czuTq275VcfQKGP8FQcnC1f Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7p4k2xf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 08:15:07 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61NDF6VY009812 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2026 08:15:06 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 23 Feb 2026 08:15:06 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 23 Feb 2026 08:15:06 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61NDEMXi006594; Mon, 23 Feb 2026 08:15:00 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v2 12/12] iio: filter: admv8818: use dev_err_probe in probe path Date: Mon, 23 Feb 2026 15:14:03 +0200 Message-ID: <20260223131418.55414-13-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223131418.55414-1-antoniu.miclaus@analog.com> References: <20260223131418.55414-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfX15vM64T+mMg8 /UlmR9Dryr/pK8dYISIWrvtM4vTTYHdrOpy9Yp5qmccYZg9YD43WQiXN2obVe5eCyeck/GZuICb tcY/PgEXT2RfPJIN+ZmrIsKLA1IbjxHU+YJrJ3TqSUIFIBKREJok3icGi50xSXIOScsePFbhPA2 AhkGP2A8o4wJcnxLQn5H9nhJow0GnIroFGkogbsFYcg5UNBmtmyzxR9pBBIXoLUDkz9iBvv2Dec 0sMdLBbb2Ny4jn2qj4kHgqQSIiVtQiulrOViHs7cpxaPXKyg76JcZlFcv1K/uZXwJ6NHAN/aQgS RHk9PiVdQU418+rHru7DdiOuPSCRYgQ84cNrEPAEmBU8/zR7JDQ/xtW3jeswrvxOBAAiGrkrzcX tOB9ighIglmQLWCXAOdNwonCilA+Ux3w2s40Z9urS6XVB3Hy5SMExRmp4HWrsq9vQ4ZIyODBXN+ 3iTFqRkkG00eaHYHrNQ== X-Proofpoint-ORIG-GUID: P-hv0wZzhUeYGYMo9Afd6qH3dmaMHupm X-Authority-Analysis: v=2.4 cv=LfgxKzfi c=1 sm=1 tr=0 ts=699c52db cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=XIZiaBmXTVxVH1IbRYoA:9 X-Proofpoint-GUID: P-hv0wZzhUeYGYMo9Afd6qH3dmaMHupm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230113 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in the probe path to simplify error handling and to ensure the error code is logged. Signed-off-by: Antoniu Miclaus --- drivers/iio/filter/admv8818.c | 38 ++++++++++++++++------------------- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c index 82f433532804..a4c127d12882 100644 --- a/drivers/iio/filter/admv8818.c +++ b/drivers/iio/filter/admv8818.c @@ -662,36 +662,31 @@ static int admv8818_init(struct admv8818_state *st) =20 ret =3D regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A, ADMV8818_SOFTRESET_N_MSK | ADMV8818_SOFTRESET_MSK); - if (ret) { - dev_err(dev, "ADMV8818 Soft Reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV8818 Soft Reset failed.\n"); =20 ret =3D regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A, ADMV8818_SDOACTIVE_N_MSK | ADMV8818_SDOACTIVE_MSK); - if (ret) { - dev_err(dev, "ADMV8818 SDO Enable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV8818 SDO Enable failed.\n"); =20 ret =3D regmap_read(st->regmap, ADMV8818_REG_CHIPTYPE, &chip_id); - if (ret) { - dev_err(dev, "ADMV8818 Chip ID read failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV8818 Chip ID read failed.\n"); =20 - if (chip_id !=3D 0x1) { - dev_err(dev, "ADMV8818 Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D 0x1) + return dev_err_probe(dev, -EINVAL, + "ADMV8818 Invalid Chip ID.\n"); =20 ret =3D regmap_update_bits(st->regmap, ADMV8818_REG_SPI_CONFIG_B, ADMV8818_SINGLE_INSTRUCTION_MSK, FIELD_PREP(ADMV8818_SINGLE_INSTRUCTION_MSK, 1)); - if (ret) { - dev_err(dev, "ADMV8818 Single Instruction failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV8818 Single Instruction failed.\n"); =20 if (st->clkin) return admv8818_rfin_band_select(st); @@ -767,7 +762,8 @@ static int admv8818_probe(struct spi_device *spi) =20 regmap =3D devm_regmap_init_spi(spi, &admv8818_regmap_config); if (IS_ERR(regmap)) - return PTR_ERR(regmap); + return dev_err_probe(dev, PTR_ERR(regmap), + "Failed to initialize regmap\n"); =20 st =3D iio_priv(indio_dev); st->regmap =3D regmap; --=20 2.43.0