Changes in v3:
-Patch 1: updated macros to use '(x)' instead of 'x'.
-Patch 2: collected reviewed-by (no code changes).
-Patch 3: fixed vertical spacing and broken indentation.

These patches address several checkpatch warnings in the ad9523 driver.

Patch 1: Updated the macros to properly use their argument x.
Patch 2: Fixed the multi-line pointer dereferences.
Patch 3: Updated symbolic permissions to octal (0444/0200).

bhargav (3):
  iio: frequency: ad9523: fix implicit variable usage in macros
  iio: frequency: ad9523: avoid multiple line dereferences for pdata
  iio: frequency: ad9523: fix checkpatch warnings for symbolic
    permissions

 drivers/iio/frequency/ad9523.c | 88 +++++++++++++---------------------
 1 file changed, 33 insertions(+), 55 deletions(-)

-- 
2.53.0

On Fri, Feb 20, 2026 at 03:05:46AM +0530, bhargav wrote:
> Changes in v3:
> -Patch 1: updated macros to use '(x)' instead of 'x'.
> -Patch 2: collected reviewed-by (no code changes).
> -Patch 3: fixed vertical spacing and broken indentation.
> 
> These patches address several checkpatch warnings in the ad9523 driver.

Do a new email thread for each new version of the series.
Do not send a new version more often than a couple of days.
(The very bare minimum is 24h.)


-- 
With Best Regards,
Andy Shevchenko

On Fri, 20 Feb 2026 09:22:34 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Fri, Feb 20, 2026 at 03:05:46AM +0530, bhargav wrote:
> > Changes in v3:
> > -Patch 1: updated macros to use '(x)' instead of 'x'.
> > -Patch 2: collected reviewed-by (no code changes).
> > -Patch 3: fixed vertical spacing and broken indentation.
> > 
> > These patches address several checkpatch warnings in the ad9523 driver.  
> 
> Do a new email thread for each new version of the series.
> Do not send a new version more often than a couple of days.
> (The very bare minimum is 24h.)
> 

Series is simple enough I'm not going to wait on Michael
giving it a quick look (as the driver maintainer).  Still
time for more feedback though given I'll be rebasing the tree
anyway on rc1 later this week.

Applied to the testing branch of iio.git.

Thanks,

Jonathan

>

On Sun, 22 Feb 2026 13:50:54 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Fri, 20 Feb 2026 09:22:34 +0200
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> 
> > On Fri, Feb 20, 2026 at 03:05:46AM +0530, bhargav wrote:  
> > > Changes in v3:
> > > -Patch 1: updated macros to use '(x)' instead of 'x'.
> > > -Patch 2: collected reviewed-by (no code changes).
> > > -Patch 3: fixed vertical spacing and broken indentation.
> > > 
> > > These patches address several checkpatch warnings in the ad9523 driver.    
> > 
> > Do a new email thread for each new version of the series.
> > Do not send a new version more often than a couple of days.
> > (The very bare minimum is 24h.)
> >   
> 
> Series is simple enough I'm not going to wait on Michael
> giving it a quick look (as the driver maintainer).  Still
> time for more feedback though given I'll be rebasing the tree
> anyway on rc1 later this week.
> 
> Applied to the testing branch of iio.git.
Pulled again.  Just a small thing I need to check.

For sign off we need a "known identity" - see submitting patches.
Mostly that's a legal name, but if people are commonly known
by other names that's acceptable as well.

Given short nature of your SoB and that this is (I think?) your
first upstream commit I just wanted to check that bhargav is 
sufficient to meet this level.  

What counts for this varies a lot by culture or country so if
that is the right level of identification to use that that's
fine, just reply to let me know.

Thanks,

Jonathan


> 
> Thanks,
> 
> Jonathan
> 
> >   
>

On Sun, Feb 22, 2026 at 7:28 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sun, 22 Feb 2026 13:50:54 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Fri, 20 Feb 2026 09:22:34 +0200
> > Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> >
> > > On Fri, Feb 20, 2026 at 03:05:46AM +0530, bhargav wrote:
> > > > Changes in v3:
> > > > -Patch 1: updated macros to use '(x)' instead of 'x'.
> > > > -Patch 2: collected reviewed-by (no code changes).
> > > > -Patch 3: fixed vertical spacing and broken indentation.
> > > >
> > > > These patches address several checkpatch warnings in the ad9523 driver.
> > >
> > > Do a new email thread for each new version of the series.
> > > Do not send a new version more often than a couple of days.
> > > (The very bare minimum is 24h.)
> > >
> >
> > Series is simple enough I'm not going to wait on Michael
> > giving it a quick look (as the driver maintainer).  Still
> > time for more feedback though given I'll be rebasing the tree
> > anyway on rc1 later this week.
> >
> > Applied to the testing branch of iio.git.
> Pulled again.  Just a small thing I need to check.
>
> For sign off we need a "known identity" - see submitting patches.
> Mostly that's a legal name, but if people are commonly known
> by other names that's acceptable as well.
>
> Given short nature of your SoB and that this is (I think?) your
> first upstream commit I just wanted to check that bhargav is
> sufficient to meet this level.
>
> What counts for this varies a lot by culture or country so if
> that is the right level of identification to use that that's
> fine, just reply to let me know.
>
> Thanks,
>
> Jonathan
>
>
> >
> > Thanks,
> >
> > Jonathan
> >
> > >
> >
>
Hi Jonathan,

Thank you for checking! Yes, this is my first patch.
Actually "bhargav" is fine for me , but if you need my full name on
signed-off (i.e Bhargav Joshi) then please let me if i need to send a
v4 with updated signature or it is possible for you to amend the
Signed-off-by line to "Bhargav Joshi " rougueprince47@gmail.com" on
your end while applying.

Best regards,
Bhargav

On Mon, Feb 23, 2026 at 02:49:12AM +0530, Rogue prince wrote:
> On Sun, Feb 22, 2026 at 7:28 PM Jonathan Cameron <jic23@kernel.org> wrote:
> > On Sun, 22 Feb 2026 13:50:54 +0000
> > Jonathan Cameron <jic23@kernel.org> wrote:

...

> > Given short nature of your SoB and that this is (I think?) your
> > first upstream commit I just wanted to check that bhargav is
> > sufficient to meet this level.
> >
> > What counts for this varies a lot by culture or country so if
> > that is the right level of identification to use that that's
> > fine, just reply to let me know.

> Thank you for checking! Yes, this is my first patch.
> Actually "bhargav" is fine for me , but if you need my full name on
> signed-off (i.e Bhargav Joshi) then please let me if i need to send a
> v4 with updated signature or it is possible for you to amend the
> Signed-off-by line to "Bhargav Joshi " rougueprince47@gmail.com" on
> your end while applying.

Please, make sure you send patches with this SoB (using Bhargav Joshi).
Also make sure there are no double quotes. It's all documented, please
take your time to study Submitting Patches and Submitting Patches Checklist
documentation.


-- 
With Best Regards,
Andy Shevchenko

On Mon, 23 Feb 2026 10:35:57 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Mon, Feb 23, 2026 at 02:49:12AM +0530, Rogue prince wrote:
> > On Sun, Feb 22, 2026 at 7:28 PM Jonathan Cameron <jic23@kernel.org> wrote:  
> > > On Sun, 22 Feb 2026 13:50:54 +0000
> > > Jonathan Cameron <jic23@kernel.org> wrote:  
> 
> ...
> 
> > > Given short nature of your SoB and that this is (I think?) your
> > > first upstream commit I just wanted to check that bhargav is
> > > sufficient to meet this level.
> > >
> > > What counts for this varies a lot by culture or country so if
> > > that is the right level of identification to use that that's
> > > fine, just reply to let me know.  
> 
> > Thank you for checking! Yes, this is my first patch.
> > Actually "bhargav" is fine for me , but if you need my full name on
> > signed-off (i.e Bhargav Joshi) then please let me if i need to send a
> > v4 with updated signature or it is possible for you to amend the
> > Signed-off-by line to "Bhargav Joshi " rougueprince47@gmail.com" on
> > your end while applying.  
> 
> Please, make sure you send patches with this SoB (using Bhargav Joshi).
> Also make sure there are no double quotes. It's all documented, please
> take your time to study Submitting Patches and Submitting Patches Checklist
> documentation.
> 
> 
Just to confirm. Please send a v4.
SoB have legal meaning so best to have a clean record on list.

Jonathan