From nobody Fri Apr 3 10:56:16 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC3FD327C18 for ; Thu, 19 Feb 2026 21:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771536995; cv=none; b=gEXSzVWi5O97IOeqja6spXyTuN3hIckyThBgt4jj3jFYkwawcz/uTECqsZ3Kw5XQ4W8yD7HxpRCXzaEdmpMFWX0xLtQnMAD4o/sCE0qo6kXj6IAGf4f35H7r/mZ1wggJkcZCbE3aFEJPxViKtVUng0Vaa7hWI/aDLS4qWWnRhk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771536995; c=relaxed/simple; bh=FA4WOPgvDycyyHB2/mEGb4o0SEvbAYbqtnEqBnxYnHs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YQR11nrGT+cMA3Mnb2g5P5N4mb5C6cMz5muPI3Sy0BdTBXy+eaJCIWssveuVVFnXn7olOq4KCZiFauDrrU2jDYiSDWj2L1MRcf8RihZd1dG3KmlJC7bTdJHgnY9yDMJ3PvapSsoYpkk09JSFGgJrbL+nXhDN2H6Kg3Iz4UNz6jU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SyB5sL30; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SyB5sL30" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c626bd75628so500840a12.3 for ; Thu, 19 Feb 2026 13:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771536994; x=1772141794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=snfBJanBL4Z/KaYXmLO1nWQ2apjpeu56D3VSCWFakAo=; b=SyB5sL30vcLonMVB9mNLy0NWoeKac1OVFYfW+mlzeq3Kikh3qFuOkMUbHG29LIkm5D xveuy3dWAtY4JyVBnt/LwluX0sOWqEYBYlb+xwmnEuSbYmgl5tnP9VahNlgASMW81oJ0 kZ+uRiHWJh73T7gqIjd2xdozQIsZZWAbpTM1JOGpVTqeB3VOkvj9AZJgfNHJTJLdrJcT 1uBPtru3TZwDjCA5hGAKqY0eSbwTI1+x8Hhj5OcfQ5RNBDqMvu06NOA8ihGZNyhiGMKJ pm8damdJSNxTcC38qbeO38ryNK8QwQC3mpNd/NHLScglC8nqoDU1CBT4cgu1N9fyx7Hl t9vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771536994; x=1772141794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=snfBJanBL4Z/KaYXmLO1nWQ2apjpeu56D3VSCWFakAo=; b=trc6jtMwqnF7lFCuZggIH6EDvMkKakDrcd9PdoUbWC3BStEGFUXOBFWkn6RkuU56ek MtIyQH+JXrqS88Lyp1ziqdAnuZd3FuirNf/Zl28FwgvF1MHeKxnQpIYp6CH0uO/mdvHR POoI2aw2DYziJKNvpJdz1TP0TDIDwJ4WNaTfd/zijClG6eaE76W9pQkC6dVAD4KnQ3Ex 9lFwmRtTMKUpdguy4HVlNBnOpXL2LMC3fbljtkE+iFfF5NU3MhmGuKSmnt7rXu5LbTtZ I1RwgaDdfDtXJDDNFzYjlmOPsyzRMTWEtSeolRc0AC9vdpKpWLjnjud76y18Bvt162X7 rS/Q== X-Forwarded-Encrypted: i=1; AJvYcCWXo3unHD2cT2QkSyqKSYNq43Zdmkrl3d6jhbstr9vI212PsWIb/D3DXzIeB+ryuT4CDyWWnqdnT4HZQ+k=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh2LwYzmBU3rwLeygEIQ42DJhsnrOd/0ab/R8wDJM80piR7RVu AQTWQObckqamyJS59bcA02NujvRQv5Go2PCwJ1VPBDUV4jMiumdJYaTqM1VIcQ== X-Gm-Gg: AZuq6aLrsNFheeeWl3UzlhK1sF0sytiwmdFa3iKsaAHhGMrcbzEVT00OO2ch6NcBnGM vdHKaQUt+jdWwZQh/kDxWNMpOUjCUpJZv58fLXO7/FCADJ5al3uARQ3svzz6ZkMFbDHC1H8kfPo PDWI9hskBBN9jEOSvzva4F5S0eHvyycay+C5zpd4edeCoHyxVYH2n0K74yp4JyWjW15C+IEHr1Y Da/yvFy8kc5tYNcxmnhs0beJ5Yzf/WZA/6vniqmsqIGJeOQeDwaRdFI6RVxLLMiBQl4gT4JY/BX u6qgKz+kwX5UwGaI12J7U89tkHdE5i7cYqzZsAnZ49cS3snzP3matR4nUSD5h6ar3n1CqhrNz5W nA2MzzrvYNCd62NpdfJXjVNYr/DlIP6aLcGJidqnpIddZ9VPCu3wjqnQJFaaiPz0ueDEzn0E+AT 5sT/TLbnHPeXlwQbNZuYlwODFq X-Received: by 2002:a17:902:f651:b0:2a7:d5c0:c661 with SMTP id d9443c01a7336-2ad50e9dd43mr67541685ad.15.1771536994270; Thu, 19 Feb 2026 13:36:34 -0800 (PST) Received: from arch ([2409:40c2:5415:8e16:49a5:aac1:3b74:3ed7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a7145cbsm238938475ad.30.2026.02.19.13.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 13:36:33 -0800 (PST) From: bhargav To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com Subject: [PATCH v3 1/3] iio: frequency: ad9523: fix implicit variable usage in macros Date: Fri, 20 Feb 2026 03:05:47 +0530 Message-ID: <20260219213549.59645-2-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260219213549.59645-1-rougueprince47@gmail.com> References: <20260219213549.59645-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and AD9523_CLK_DIST_DIV_REV(x) implicitly relied on variable named 'ret' instead of using passed argument '(x)'. Update the macros to explicitly use the argument '(x)' for their operations. This also resolves the following checkpatch.pl warning: WARNING: Argument '(x)' is not used in function-like macro Signed-off-by: bhargav Reviewed-by: Andy Shevchenko --- Changes in v3: -replaced 'x' with '(x)' in AD9523_CLK_DIST_DIV_PHASE_REV(x) and AD9523_CLK_DIST_DIV_REV(x) drivers/iio/frequency/ad9523.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 63c485e9e44c..5725ab62e0fd 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -167,9 +167,9 @@ =20 /* AD9523_CHANNEL_CLOCK_DIST */ #define AD9523_CLK_DIST_DIV_PHASE(x) (((x) & 0x3F) << 18) -#define AD9523_CLK_DIST_DIV_PHASE_REV(x) ((ret >> 18) & 0x3F) +#define AD9523_CLK_DIST_DIV_PHASE_REV(x) (((x) >> 18) & 0x3F) #define AD9523_CLK_DIST_DIV(x) ((((x) - 1) & 0x3FF) << 8) -#define AD9523_CLK_DIST_DIV_REV(x) (((ret >> 8) & 0x3FF) + 1) +#define AD9523_CLK_DIST_DIV_REV(x) ((((x) >> 8) & 0x3FF) + 1) #define AD9523_CLK_DIST_INV_DIV_OUTPUT_EN (1 << 7) #define AD9523_CLK_DIST_IGNORE_SYNC_EN (1 << 6) #define AD9523_CLK_DIST_PWR_DOWN_EN (1 << 5) --=20 2.53.0 From nobody Fri Apr 3 10:56:16 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03C6A329E5A for ; Thu, 19 Feb 2026 21:36:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771537006; cv=none; b=N2VKze8dLjczb0EHyPm+aY/Ody1Aob07+LTRev46Zg92Ys3IyiAgfHonFLmMJKFEhfbLWXTUy3RrGbhshK0YrLYmzyQKa5s75A4TmOb6XESnsA6TooXAVAU5wDgNtLsplSXL3LVbeRZwxEzbAZGWYYWR2b7duDppGl5nXc7OIQ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771537006; c=relaxed/simple; bh=i42XsvsRKtXY5Ms1pYkF7Kk9twF4AYiXPGCpkIeUt4o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hNOg+v7vdzDcJVP4AAicFtZHhKBa744RAAHhg6juS8Jf5Ot2f5k0VO7E/l2qMEdvBqixaqtSkslC+IClkKfXJB/jXjwhtY1QbRHlMBBQCNmDoDdwT7lLjZcdWf6BtjnwSPLKWn7iBkieqCvDFoHXiPw+1gwfvM+X2ltPTOKajHE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QWYBKumB; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QWYBKumB" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2a929245b6aso13551055ad.0 for ; Thu, 19 Feb 2026 13:36:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771537004; x=1772141804; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VrKO3/k5oDaHRjx6Mg3pvGaxTLwHymALHGO1vCKBisg=; b=QWYBKumBxi0WeK0svfl7Ad02tJTBFt+Zo9of2LKliRyX3+K6FRiC877lGqS23VjNRD il19OolD21uvf9giNeGUSFqF2R2w9bqAWjc+N2lMREgs+YuoJySkeUvyyI4b74y50q2v slZ6Bg2tqLJf2I6R9lFjQ+Qdehn1o6LMbfzkXVUP2LMFf066hBtNo0ujNxQR4r1v2Bxs xBihaWQ5ozccJZ3XvamUitLGyd3jw4DcOyTLf7Zxgm6PrcPbst/l/uN1lkvmf/6Z82Pk T/nSl0TW1TzfQhJwiYjc8S8WMrhzki5KNhtO0il3vnFM8mplQ51+uEWWvBFwnEq0nGYh gBaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771537004; x=1772141804; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VrKO3/k5oDaHRjx6Mg3pvGaxTLwHymALHGO1vCKBisg=; b=KBc//TSfSdm2hGTsAlPDNpxA7gtqNWzFVfow7FCCTWz+CgpKhs2Ty3kZSmruKxl85Q gy/kficRalwVp0TC7bCVCuj61ktv2R1QmRreG722EAD0ZbLCCTU8SKwaPGBbHFL1JExH ZOZL5y6o8nY3XYSNZviCAgOn+no7mHTRMM6yJw/6lpwZUhZkGW4V+fvmuKqHUlD6ZgRV IN9faXy0zwGpxnZkOb0ATwZwCZ+HmeGv33JKD9SnvH76uTXp+RJsiepDOc0Sf1mZjm6J w/nIR6Qsh4dpAVIWb8tmcz7ZsuXkP2N0fo1AOvqdovmmXWjyPyQ1j+rUKArM/dmAts/2 J7gA== X-Forwarded-Encrypted: i=1; AJvYcCXg478wSb2e0rYLsm6qR4gNs1o9wdchRZowfYGwuyfxVitTAfHt3T04TzCLaBurpSRPPkTVSaIClVEvtXc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3rJDUiHe3pam8DAuIjL56n/YeH0HObKjsJQjitEDb+CC5X17/ Gp3YVOVKkQTrYl7bLl7yOk8L1UmBoA+EUbLL/r7V82v8b7gxIJVRFu2T X-Gm-Gg: AZuq6aILE9GIHbLgt+6d/0rbcuoCrrKCHJJCL8u/Cxr5Ar6Uhu65pkXLBWmH8TqcTLq LPCV4qW8ll9Y333cCKfljchzWgtIim/5MSJV1Zx5o50TvllHoF9JGHL4Pzj7DakohNqCLaJcjUL k6Ee2Lq3QTLZ7oom8hAdPiQH8B1g6MGDqYiYYKIkCLRD/i2e17mL6bDPn84Z1fM6hfbmoGJzi44 vrnuqqacRTc8Pytd0kYX5u48djCdiaSfTtv5oMFyCF73T50807gO7gAlKSQyCSLdfsZPVX98dq5 G2Loyz2ZcR0oH/qEEm26cNfIR77on1rFX2Ptdg23k5zz3NfZEsbkfRuihFgg+qvQqFHqHmDwOat DulI83rKuTCM3dDcmZnJFJTOF7iKMblquDFDNE1eJ+SDRz9INJXVnThNZj2Tdw7vIAwulJg8chx 6ezRhhnfCKswHyHbfv3aLXMQmkyERVjCToyNA= X-Received: by 2002:a17:903:3bad:b0:2a7:9592:210a with SMTP id d9443c01a7336-2ad175019cfmr167804435ad.33.1771537004295; Thu, 19 Feb 2026 13:36:44 -0800 (PST) Received: from arch ([2409:40c2:5415:8e16:49a5:aac1:3b74:3ed7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a7145cbsm238938475ad.30.2026.02.19.13.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 13:36:44 -0800 (PST) From: bhargav To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com, Andy Shevchenko Subject: [PATCH v3 2/3] iio: frequency: ad9523: avoid multiple line dereferences for pdata Date: Fri, 20 Feb 2026 03:05:48 +0530 Message-ID: <20260219213549.59645-3-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260219213549.59645-1-rougueprince47@gmail.com> References: <20260219213549.59645-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Platform data pointer dereferences for pll1_charge_pump_current_nA and pll2_charge_pump_current_nA were split across multiple lines. Bring the dereference chains onto a single line. This resolves the following checkpatch.pl warnings: WARNING: Avoid multiple line dereference - prefer 'pdata->pll1_charge_pump_= current_nA' WARNING: Avoid multiple line dereference - prefer 'pdata->pll2_charge_pump_= current_nA' Signed-off-by: bhargav Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/ad9523.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 5725ab62e0fd..6daa2ea354a8 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -797,8 +797,7 @@ static int ad9523_setup(struct iio_dev *indio_dev) return ret; =20 ret =3D ad9523_write(indio_dev, AD9523_PLL1_CHARGE_PUMP_CTRL, - AD9523_PLL1_CHARGE_PUMP_CURRENT_nA(pdata-> - pll1_charge_pump_current_nA) | + AD9523_PLL1_CHARGE_PUMP_CURRENT_nA(pdata->pll1_charge_pump_current_nA) | AD9523_PLL1_CHARGE_PUMP_MODE_NORMAL | AD9523_PLL1_BACKLASH_PW_MIN); if (ret < 0) @@ -842,8 +841,7 @@ static int ad9523_setup(struct iio_dev *indio_dev) */ =20 ret =3D ad9523_write(indio_dev, AD9523_PLL2_CHARGE_PUMP, - AD9523_PLL2_CHARGE_PUMP_CURRENT_nA(pdata-> - pll2_charge_pump_current_nA)); + AD9523_PLL2_CHARGE_PUMP_CURRENT_nA(pdata->pll2_charge_pump_current_nA)); if (ret < 0) return ret; =20 --=20 2.53.0 From nobody Fri Apr 3 10:56:16 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95F5F32AAB8 for ; Thu, 19 Feb 2026 21:36:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771537015; cv=none; b=ggEJffCLx3Du7zL27dU4PHNF9O5moTR5OEKrA9wtyiV77zE1mL0QkJs7bZwwdnhNbeIQ2Hs9+T2M2yus7zVAz5bhd44gOkPOHcNkd39+k/3K/LgQjxAPWZEUwZSyFfnZWVuPcdGRPAjxpsTob9KbHskkV7dbM6mVElF+OC8BSHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771537015; c=relaxed/simple; bh=6M+XGC7yqyyv+3XDNyCsRg+HgWbHFVYQ0w+W77xeb18=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hk1kdwiIgP0JRuBNkB/5UZxYzCVkNPa2jlZEgxjtveLa5Ab03S94e5kPigF9GW94RAftCnDU5YGsx+fNKKx3m6Ecibq9UVX0Fhel7l6KCi5Yliw4M9FYkNAORRgrpBNmNqbPwPDuAjn4+EnL747S0FKC/fcYfe37L7454Fue4nc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KjCEaX8N; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KjCEaX8N" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2a962230847so11991035ad.3 for ; Thu, 19 Feb 2026 13:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771537014; x=1772141814; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zc96RPM8zuz0aUXS6dx1Rqoun9U6kSuSBbcKRBldkQs=; b=KjCEaX8NJn1VH/eoC6ecxtpZQh7rkcOfu9V3W0F19xRCDKUBKKEPq1OhYkN34yG2a4 ersmOj0iYTkeQRWkCyTkndhOrDkKJb4xNjYQHUJDA95JGNOFAELUfN9VxWXPA4cm5JbY 9kSiri+D7HLVd9q6Wz9Xb2PUgkhkenHVFmtWGm1vKuU8QHv+pHzvr5xsbvGasE1Y3Gto pAlq+JG/T0g+DyJIK2+zv3/3PA+w/BO2/C6bvYD7ZidYvP63EH4q8EeviIwVG6yRiB1B yn+9e1f8UdPG4kI4nBQ7eq3w5IZznausobEVIgBkcG8F/wYvotu7W95Htdim2mG8ZjDM 6RFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771537014; x=1772141814; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Zc96RPM8zuz0aUXS6dx1Rqoun9U6kSuSBbcKRBldkQs=; b=AVc+NYGZCZJvoy4NSk5VUGNTCF9pPLQgklUMizpeZDZVx2IdU2u+iKGzOeZ6OPHZsz SHsoLcGk5kfZ2DxxuGUHd4oXTHEYGxQjr4A5AP5IxDvhO/4PrCRAEJA3Tdhl7GHQiCIj ztLJQL8xoB6KFHrZu5UsllDl+49AihacmM2IVFF0yM4WYGc8d1G4FpJA9U5vNYIPEKiS Ogfvsaf59KzHKzdfapF7gg7wQNvuArl7a7xsdsTBdsrOQS0Gp12vKuZAjYcJ2y2EDR2Z 7TkrdZj//+JLGZ5i1KqarqNFIqGVyYQe5L4wueEXfVVl0MYFhNfkGsjSFiGmBiH7mA+R d4Hg== X-Forwarded-Encrypted: i=1; AJvYcCWf4wxjRimdLADF+4vjGUXbGn47GnOf/r3YFJfSMe1+eASyaT1xuCtnUiz4wdPMSt8mB5k9F710MkTpVyI=@vger.kernel.org X-Gm-Message-State: AOJu0YwQxD294YcXjpa5xO4p8mmcrNqby6bNg47D1GwX+3Zc2A+v8X1m ihVAMKuV46kuftUSnAvDUYmNOAQVfkTMT07M8uq1dnDc2SdTcfedN4ST X-Gm-Gg: AZuq6aKz4FCQZG9yvyMWzBZxYjE7wzUdZ/HeItXU8LpykaNQKPWsRud8VZkyH/KCurQ koN2foUdenaFkPoWirZbXGN7lxrhQix3dg9t0iKdOpIeDGbfb2e3c/ZBUzp5QG0AVb7wFxDXPbW B7X2mAB+HSnGUFwRwd+LiOoFl2+RjK3Dry975Zv+GKpxivb9ccN+b6R0LSE43/54ukiLab6Dn6X 2GhxSZBLmFThpAHD4AKX2XjIi1MVd+FoLKx6i5G5/gEXO8Qn9BAUe2NH+mx3YtmpePhjkemj4MQ lf1o9iSPu1bf90hPzUUa434/bz7qqOl7JTrxZdPyYqscjr0+55PnaYqf6P5G5wnRpVxcffwCLyZ rRiiBSyNs45tXnl7Y4r+j9/icj7fUGlZN0eEYkCRXXppUyUovB4eUIA19NZNFn1CMBxIVESg2he AMyq3/FoCkKgrZdqlmxkUCagko X-Received: by 2002:a17:902:ce09:b0:2ab:1dad:e500 with SMTP id d9443c01a7336-2ad50e8dd66mr66367645ad.18.1771537014082; Thu, 19 Feb 2026 13:36:54 -0800 (PST) Received: from arch ([2409:40c2:5415:8e16:49a5:aac1:3b74:3ed7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a7145cbsm238938475ad.30.2026.02.19.13.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 13:36:53 -0800 (PST) From: bhargav To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com Subject: [PATCH v3 3/3] iio: frequency: ad9523: fix checkpatch warnings for symbolic permissions Date: Fri, 20 Feb 2026 03:05:49 +0530 Message-ID: <20260219213549.59645-4-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260219213549.59645-1-rougueprince47@gmail.com> References: <20260219213549.59645-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver currently defines device attributes using symbolic permission flags (S_IRUGO and S_IWUSR). Update these to use octal permissions (0444 and 0200) to resolve checkpatch warnings. Signed-off-by: bhargav Reviewed-by: Andy Shevchenko --- Changes in v3: -reduced unwanted vertical spacing=20 -fixed broken indentation drivers/iio/frequency/ad9523.c | 78 +++++++++++++--------------------- 1 file changed, 29 insertions(+), 49 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 6daa2ea354a8..ad32eb66edca 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -558,55 +558,35 @@ static ssize_t ad9523_show(struct device *dev, return ret; } =20 -static IIO_DEVICE_ATTR(pll1_locked, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL1_LD); - -static IIO_DEVICE_ATTR(pll2_locked, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_LD); - -static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REFA); - -static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REFB); - -static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REF_TEST); - -static IIO_DEVICE_ATTR(vcxo_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_VCXO); - -static IIO_DEVICE_ATTR(pll2_feedback_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_FB_CLK); - -static IIO_DEVICE_ATTR(pll2_reference_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_REF_CLK); - -static IIO_DEVICE_ATTR(sync_dividers, S_IWUSR, - NULL, - ad9523_store, - AD9523_SYNC); - -static IIO_DEVICE_ATTR(store_eeprom, S_IWUSR, - NULL, - ad9523_store, - AD9523_EEPROM); +static IIO_DEVICE_ATTR(pll1_locked, 0444, ad9523_show, NULL, + AD9523_STAT_PLL1_LD); + +static IIO_DEVICE_ATTR(pll2_locked, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_LD); + +static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, 0444, ad9523_show, NU= LL, + AD9523_STAT_REFA); + +static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, 0444, ad9523_show, NU= LL, + AD9523_STAT_REFB); + +static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, 0444, ad9523_show,= NULL, + AD9523_STAT_REF_TEST); + +static IIO_DEVICE_ATTR(vcxo_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_VCXO); + +static IIO_DEVICE_ATTR(pll2_feedback_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_FB_CLK); + +static IIO_DEVICE_ATTR(pll2_reference_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_REF_CLK); + +static IIO_DEVICE_ATTR(sync_dividers, 0200, NULL, ad9523_store, + AD9523_SYNC); + +static IIO_DEVICE_ATTR(store_eeprom, 0200, NULL, ad9523_store, + AD9523_EEPROM); =20 static struct attribute *ad9523_attributes[] =3D { &iio_dev_attr_sync_dividers.dev_attr.attr, --=20 2.53.0