[PATCH 1/5] accel/rocket: Fix error path in BO creation

Ross Cawston posted 5 patches 1 month, 2 weeks ago
[PATCH 1/5] accel/rocket: Fix error path in BO creation
Posted by Ross Cawston 1 month, 2 weeks ago
Check the return value of iommu_map_sgtable() after releasing the
mm_lock. Previously an error would be silently ignored.

Signed-off-by: Ross Cawston <ross@r-sc.ca>
---
 drivers/accel/rocket/rocket_gem.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/accel/rocket/rocket_gem.c b/drivers/accel/rocket/rocket_gem.c
index 624c4ecf5a34..db1ff3544af2 100644
--- a/drivers/accel/rocket/rocket_gem.c
+++ b/drivers/accel/rocket/rocket_gem.c
@@ -95,6 +95,8 @@ int rocket_ioctl_create_bo(struct drm_device *dev, void *data, struct drm_file *
 					 rkt_obj->size, PAGE_SIZE,
 					 0, 0);
 	mutex_unlock(&rocket_priv->mm_lock);
+	if (ret)
+		goto err;
 
 	ret = iommu_map_sgtable(rocket_priv->domain->domain,
 				rkt_obj->mm.start,

-- 
2.52.0