From nobody Fri Apr 3 06:25:03 2026 Received: from out-03.smtp.spacemail.com (out-03.smtp.spacemail.com [63.250.43.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E91AE2F5491 for ; Tue, 17 Feb 2026 21:50:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.250.43.88 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771365002; cv=none; b=s1lwNNPSJeMEeZuTUq/ubibTs+LnEtn7nLb9RdsodLdSG90HTeQau5gvmAJ15oaq7XCmQxfM7z3nPy0RQpgBSSWU5ctH0axnbznv7TKLOFmYXEOY2NZSqraHCXZXsk243UDTK00f+YVt4vHkp2oWWsbuvNljQlxhEWt1UweJnuQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771365002; c=relaxed/simple; bh=ZmP9RgOUTYIiHlUT4V9Yl0L96rep3kPBiWGlpC11Vy8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nBadACxNzrAwMMhcQYSrSe6NbJxLAUvXzOD7KUPYVN9VKpFqoyKTqaZ309DFFxbDLs9jv7bcDvmh581KfX4HhHG3CC9vSdE6fQW1cCojNI00yHssd5Bu7HWHnJBl4V/lFhNzwQ+EsYvGhi3PH67jumUiWRoH1TepSMqQPIHa58E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=r-sc.ca; spf=pass smtp.mailfrom=r-sc.ca; dkim=pass (2048-bit key) header.d=r-sc.ca header.i=@r-sc.ca header.b=B+61kZd7; arc=none smtp.client-ip=63.250.43.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=r-sc.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=r-sc.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=r-sc.ca header.i=@r-sc.ca header.b="B+61kZd7" Received: from mac.pk.shawcable.net (S0106dceb699ec90f.pk.shawcable.net [24.69.43.232]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.spacemail.com (Postfix) with ESMTPSA id 4fFtNM04RYz6tkM; Tue, 17 Feb 2026 21:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=r-sc.ca; s=spacemail; t=1771364420; bh=C1++cyFjnAcOq78eiBHr2N5hpkpKmBO2ac0BHicm6JM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=B+61kZd7qjgKiLtwV+4zd3QlnWvt3hd1n0P3ywMf8a4MJV5Kyf33RzqoYt6uxrN+k +amNd0sCWYYVeA9u0MS1eMw5pLKWi4KwLFBWsIQtrLFU4efVeVRZA+7jf7C5yxL2bJ 6g8mydI9EOL8SLskM5KcSLFMBqAdoufZxLj8ZNKPQC8qT9rEcpB41vLJokOsmkHhJ9 dTXRqejYGEFNDBHvw71EO0e44XkuH0XeYpCveyRgFEoxLos1LnImYrcsxEdKA06n5E O/aw12cMU4hjnY6lwfZq7ZE9lkL5l5HGl9E/7fb1rJktue1Mm4CoTbUekeryN4tSac mpaXZNurgyTLg== From: Ross Cawston Date: Tue, 17 Feb 2026 13:39:49 -0800 Subject: [PATCH 1/5] accel/rocket: Fix error path in BO creation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260217-accel-rocket-clean-base-v1-1-d72354325a25@r-sc.ca> References: <20260217-accel-rocket-clean-base-v1-0-d72354325a25@r-sc.ca> In-Reply-To: <20260217-accel-rocket-clean-base-v1-0-d72354325a25@r-sc.ca> To: Tomeu Vizoso , Oded Gabbay , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ross Cawston X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771364416; l=775; i=ross@r-sc.ca; s=20260217; h=from:subject:message-id; bh=ZmP9RgOUTYIiHlUT4V9Yl0L96rep3kPBiWGlpC11Vy8=; b=WmmfmKgGcn/cs693cF97YX5MbBU4smuQH1A1q2cPLJS3Du86Iokg3YWAKoLwrBsMrUC9t5B3d sh5apspTYygBrv4oVuS+qJe1//CFkW1qZLHRtPoPABbb4etJXetb/fR X-Developer-Key: i=ross@r-sc.ca; a=ed25519; pk=c50mfTDLKsgS2tlqXEZEvb/VGiLvxjsLOw5M50DxhtM= X-Envelope-From: ross@r-sc.ca Check the return value of iommu_map_sgtable() after releasing the mm_lock. Previously an error would be silently ignored. Signed-off-by: Ross Cawston --- drivers/accel/rocket/rocket_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/accel/rocket/rocket_gem.c b/drivers/accel/rocket/rocke= t_gem.c index 624c4ecf5a34..db1ff3544af2 100644 --- a/drivers/accel/rocket/rocket_gem.c +++ b/drivers/accel/rocket/rocket_gem.c @@ -95,6 +95,8 @@ int rocket_ioctl_create_bo(struct drm_device *dev, void *= data, struct drm_file * rkt_obj->size, PAGE_SIZE, 0, 0); mutex_unlock(&rocket_priv->mm_lock); + if (ret) + goto err; =20 ret =3D iommu_map_sgtable(rocket_priv->domain->domain, rkt_obj->mm.start, --=20 2.52.0