[v1] riscv: fix minor typos and style issues in XIP code

[PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code

Posted by Kunwu Chan 1 month, 2 weeks ago

Fix a few minor issues found in riscv XIP-related code:

- xip_fixup.h: comment typo (_start vs _sdata) and spaces-vs-tab
- head.S: spelling typo and wrong #endif comment

Kunwu Chan (2):
  riscv: xip_fixup.h: fix comment typo and whitespace issue
  riscv: head.S: fix typo and wrong #endif comment

 arch/riscv/include/asm/xip_fixup.h | 4 ++--
 arch/riscv/kernel/head.S           | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.25.1

Re: [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code

Posted by Paul Walmsley 2 weeks ago

Hi,

On Sat, 14 Feb 2026, Kunwu Chan wrote:

> Fix a few minor issues found in riscv XIP-related code:
> 
> - xip_fixup.h: comment typo (_start vs _sdata) and spaces-vs-tab
> - head.S: spelling typo and wrong #endif comment
> 
> Kunwu Chan (2):
>   riscv: xip_fixup.h: fix comment typo and whitespace issue
>   riscv: head.S: fix typo and wrong #endif comment
> 
>  arch/riscv/include/asm/xip_fixup.h | 4 ++--
>  arch/riscv/kernel/head.S           | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Please see:

  https://lore.kernel.org/linux-riscv/609b889a-8bb1-d2b5-8de6-ddeec27cac04@kernel.org/


- Paul

Re: [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code

Posted by Jisheng Zhang 1 month, 1 week ago

On Sat, Feb 14, 2026 at 10:38:02AM +0800, Kunwu Chan wrote:
> Fix a few minor issues found in riscv XIP-related code:

'RESEND' isn't expected to be used as you did in this series.
You sent the v1 series on Feb 14, only 4 days ago, the series doesn't
miss any dev window.
https://lore.kernel.org/linux-riscv/8ee1b065-b021-411b-b5ee-22c4a108cbce@linux.dev/T/#t

> 
> - xip_fixup.h: comment typo (_start vs _sdata) and spaces-vs-tab
> - head.S: spelling typo and wrong #endif comment

I'm sorry, but how important is fixing comment/spelling typo or #endif
comment among maintainship? The riscv XIP code doesn't stand on itself,
but heavily affects and is affected by other riscv arch common code.

> 
> Kunwu Chan (2):
>   riscv: xip_fixup.h: fix comment typo and whitespace issue
>   riscv: head.S: fix typo and wrong #endif comment
> 
>  arch/riscv/include/asm/xip_fixup.h | 4 ++--
>  arch/riscv/kernel/head.S           | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code

Posted by Conor Dooley 1 month, 1 week ago

On Fri, Feb 20, 2026 at 11:38:03PM +0800, Jisheng Zhang wrote:
> On Sat, Feb 14, 2026 at 10:38:02AM +0800, Kunwu Chan wrote:
> > Fix a few minor issues found in riscv XIP-related code:
> 
> 'RESEND' isn't expected to be used as you did in this series.
> You sent the v1 series on Feb 14, only 4 days ago, the series doesn't
> miss any dev window.
> https://lore.kernel.org/linux-riscv/8ee1b065-b021-411b-b5ee-22c4a108cbce@linux.dev/T/#t

v1 wasn't threaded correctly, so I think a resend is fine as the content
didn't change.

> > - xip_fixup.h: comment typo (_start vs _sdata) and spaces-vs-tab
> > - head.S: spelling typo and wrong #endif comment
> 
> I'm sorry, but how important is fixing comment/spelling typo or #endif
> comment among maintainship?

It's not, but I think we've made this point already!

> The riscv XIP code doesn't stand on itself,
> but heavily affects and is affected by other riscv arch common code.

Re: [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code

Posted by Paul Walmsley 1 month, 1 week ago

On Sat, 14 Feb 2026, Kunwu Chan wrote:

> Fix a few minor issues found in riscv XIP-related code:
> 
> - xip_fixup.h: comment typo (_start vs _sdata) and spaces-vs-tab
> - head.S: spelling typo and wrong #endif comment

Thanks for fixing the threading, but, Conor's message:

  https://lore.kernel.org/linux-riscv/20260213-canteen-diffuser-5ecc80f264b4@spud/   

was exactly right.  Folks who care about XIP support for RISC-V first need 
to send patches to fix it in mainline.  These typo fixes should be rolled 
in to that series.  Until that happens, I plan to keep the XIP removal 
patches queued.

I also want to see the XIP folks participating in testing and reviewing 
upstream patches going forward to confirm that they don't break XIP 
support.  Otherwise, the burden is just getting pushed to patch submitters 
and maintainers, most of whom probably don't care much about XIP.  And 
there's a good chance that we'll just go through this cycle again in 
another few months.

- Paul

Re: [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code

Posted by Nam Cao 1 month, 1 week ago

Paul Walmsley <pjw@kernel.org> writes:
> Thanks for fixing the threading, but, Conor's message:
>
>   https://lore.kernel.org/linux-riscv/20260213-canteen-diffuser-5ecc80f264b4@spud/   
>
> was exactly right.  Folks who care about XIP support for RISC-V first need 
> to send patches to fix it in mainline.  These typo fixes should be rolled 
> in to that series.  Until that happens, I plan to keep the XIP removal 
> patches queued.
>
> I also want to see the XIP folks participating in testing and reviewing 
> upstream patches going forward to confirm that they don't break XIP 
> support.  Otherwise, the burden is just getting pushed to patch submitters 
> and maintainers, most of whom probably don't care much about XIP.  And 
> there's a good chance that we'll just go through this cycle again in 
> another few months.

I would be happy to take that responsibility, if there are users. But
that does not seem to be the case.

Nam