From nobody Thu Apr 2 20:28:05 2026 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA412283FDB for ; Sat, 14 Feb 2026 02:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771036714; cv=none; b=MVKuYN5hURzqQNAhzcIM+Td1xOq6X+4PY6rauhD9YbLMLgl+MCQ24O9hUZcnFsEakbNjx3Cn8AcFJQXANxSnm00NEbEQfh5g4Fmz2leaFxX9Bn3xbtp0IPwYaFZfERawu2ZdyZCc1CAgpoz613PdmumTKrcjQp9+nV+y9e9XAvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771036714; c=relaxed/simple; bh=LX+jgVLAJJI+bgvDumhNI5og1UdPfr3cpthR3+NZTuI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ul3H7QPIEADuvjtMP4pSQRV8T8hf+GAdlwFzjXwqELLafQ2Z19r3F3Lnj9OABpnvavAv1EXko/OB94yHntmaJqwe8P1gk1MwYIwhgH65tFAk0bAhORTEtoQm0mFJlEpMybldp4ZT1o9wKf8g/1zeg0Ky/QHkVgQyceQF6UMhi8Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=aWH/rgDN; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="aWH/rgDN" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771036711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SRA0PW/CLHVVDqNCVWQE4q8KgPW8Hb1oRAscCsU9AWY=; b=aWH/rgDNCvqRtisIRzbd/1S2iXyOyQSnDvXQJBqhVHjiOhYybL4735aq2SZjekhcl3tIwY upwXPDaRX22no2M5bkvjtGYoEfqKB0p0+vPfAnCTtr28ENFODPTvTp/Zpexs46KClSDEg6 bkL5H65bOUYZ5vMBUJ3xQ4rFakRxGOU= From: Kunwu Chan To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: Conor Dooley , Alexandre Ghiti , Anup Patel , Atish Patra , Zong Li , Deepak Gupta , Zhouyi Zhou , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Kunwu Chan Subject: [PATCH RESEND 1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue Date: Sat, 14 Feb 2026 10:38:03 +0800 Message-Id: <20260214023804.677127-2-kunwu.chan@linux.dev> In-Reply-To: <20260214023804.677127-1-kunwu.chan@linux.dev> References: <20260214023804.677127-1-kunwu.chan@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Fix two minor issues in XIP_FIXUP_OFFSET macro: - The comment describes the fixup formula as "reg +=3D CONFIG_PHYS_RAM_BASE - _start", but the actual assembly code subtracts _sdata, not _start. Fix the comment to match. - Replace spaces with a tab for the "add" instruction to keep consistent indentation with surrounding lines. Reviewed-by: Zhouyi Zhou Signed-off-by: Kunwu Chan --- arch/riscv/include/asm/xip_fixup.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/riscv/include/asm/xip_fixup.h b/arch/riscv/include/asm/xi= p_fixup.h index f3d56299bc22..56db595b0e14 100644 --- a/arch/riscv/include/asm/xip_fixup.h +++ b/arch/riscv/include/asm/xip_fixup.h @@ -16,10 +16,10 @@ * * The start of data in Flash is _sdata and the start of data in RAM is * CONFIG_PHYS_RAM_BASE. So this fix-up essentially does this: - * reg +=3D CONFIG_PHYS_RAM_BASE - _start + * reg +=3D CONFIG_PHYS_RAM_BASE - _sdata */ li t0, CONFIG_PHYS_RAM_BASE - add \reg, \reg, t0 + add \reg, \reg, t0 la t0, _sdata sub \reg, \reg, t0 .endm --=20 2.25.1 From nobody Thu Apr 2 20:28:05 2026 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6027E26E6F2 for ; Sat, 14 Feb 2026 02:38:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771036716; cv=none; b=eZevtOk+5uwWnnpQ6o4/9lSIh9u5JVDVKR1b5QxyW1ZXZQ4shbXBntSbY+XK2vrBtDriRCHP/nzwM1nQwvt9c4vEIAuwThrTDripwEoexgpP9O7Rk2cs3cKXcoZF52z8NRA/i1EVYE7wEXMeQx3AKRAU7gvM/WDfS9FXhQZdDZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771036716; c=relaxed/simple; bh=KRTeUVIJox3O8eGhL1JH0eUl/Y9Ahn7rtvuZSvfFSa0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ArZZeYGF94UbZ1OkINWBMJpKv8jfpvCJZiIm1LrQKc/s8JbROJZL5ro+rHeRGtXv2fG06sKXGLUnk+0Op3R2TFXBKptG58sMRSTZw1Yr2de/Emp/4HXJuhdc2ZgPde2S5ER3DfBLTxHz4f2uU9MQ5+GuxN2yF+EzYFPwpjeOWdM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ub8fza77; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ub8fza77" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771036713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i6QACbWSNDKCXmWcy6tkfOeR6o72/bnitArXUWOcfcM=; b=ub8fza77ZsQlVxe72Mbjhr0xr6gsj52Ancru3QFdOgH3m1kf2VBrIU1l3K2wD/4bameWZ5 S/KuJevXIGb9lTKhf4O66Pc2y8vspVXbtCiZtkY56w3RVcCq6PWcgXWiuBGdh/V1oVQmFx l/pBUsU7C35y8RIMKXzO3HIdfDTwXKQ= From: Kunwu Chan To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: Conor Dooley , Alexandre Ghiti , Anup Patel , Atish Patra , Zong Li , Deepak Gupta , Zhouyi Zhou , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Kunwu Chan Subject: [PATCH RESEND 2/2] riscv: head.S: fix typo and wrong #endif comment Date: Sat, 14 Feb 2026 10:38:04 +0800 Message-Id: <20260214023804.677127-3-kunwu.chan@linux.dev> In-Reply-To: <20260214023804.677127-1-kunwu.chan@linux.dev> References: <20260214023804.677127-1-kunwu.chan@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" - Fix spelling: "intruction" -> "instruction". - Fix #endif comment: the matching #ifdef is CONFIG_XIP_KERNEL, not CONFIG_XIP. Reviewed-by: Zhouyi Zhou Signed-off-by: Kunwu Chan --- arch/riscv/kernel/head.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/riscv/kernel/head.S b/arch/riscv/kernel/head.S index 9c99c5ad6fe8..1618d2cb91b3 100644 --- a/arch/riscv/kernel/head.S +++ b/arch/riscv/kernel/head.S @@ -81,7 +81,7 @@ relocate_enable_mmu: sub a1, a1, a2 add ra, ra, a1 =20 - /* Point stvec to virtual address of intruction after satp write */ + /* Point stvec to virtual address of instruction after satp write */ la a2, 1f add a2, a2, a1 csrw CSR_TVEC, a2 @@ -287,7 +287,7 @@ SYM_CODE_START(_start_kernel) /* first time here if hart_lottery in RAM is not set */ beq t0, t1, .Lsecondary_start =20 -#endif /* CONFIG_XIP */ +#endif /* CONFIG_XIP_KERNEL */ #endif /* CONFIG_RISCV_BOOT_SPINWAIT */ =20 #ifdef CONFIG_XIP_KERNEL --=20 2.25.1