powercap: intel_rapl_tpmi: Remove FW_BUG from invalid version check

[PATCH v1] powercap: intel_rapl_tpmi: Remove FW_BUG from invalid version check

Posted by Kuppuswamy Sathyanarayanan 1 month, 2 weeks ago

On partitioned systems, multiple TPMI instances may exist per package,
but RAPL registers are only valid on one instance since RAPL has
package-scope control. Other instances return invalid versions during
domain parsing, which is expected behavior on such systems.

Currently this generates a firmware bug warning:
  intel_rapl_tpmi: [Firmware Bug]: Invalid version

Remove the FW_BUG tag, downgrade to pr_debug(), and update the message
to clarify that invalid versions are expected on partitioned systems
where only one instance can be valid.

Fixes: 9eef7f9da928 ("powercap: intel_rapl: Introduce RAPL TPMI interface driver")
Reported-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
 drivers/powercap/intel_rapl_tpmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/powercap/intel_rapl_tpmi.c b/drivers/powercap/intel_rapl_tpmi.c
index 0a0b85f4528b..0f8abdc592bc 100644
--- a/drivers/powercap/intel_rapl_tpmi.c
+++ b/drivers/powercap/intel_rapl_tpmi.c
@@ -157,7 +157,7 @@ static int parse_one_domain(struct tpmi_rapl_package *trp, u32 offset)
 	tpmi_domain_flags = tpmi_domain_header >> 32 & 0xffff;
 
 	if (tpmi_domain_version == TPMI_VERSION_INVALID) {
-		pr_warn(FW_BUG "Invalid version\n");
+		pr_debug("Invalid version, other instances may be valid\n");
 		return -ENODEV;
 	}
 
-- 
2.43.0

Re: [PATCH v1] powercap: intel_rapl_tpmi: Remove FW_BUG from invalid version check

Posted by srinivas pandruvada 1 month, 2 weeks ago

On Wed, 2026-02-11 at 14:34 -0800, Kuppuswamy Sathyanarayanan wrote:
> On partitioned systems, multiple TPMI instances may exist per
> package,
> but RAPL registers are only valid on one instance since RAPL has
> package-scope control. Other instances return invalid versions during
> domain parsing, which is expected behavior on such systems.
> 
> Currently this generates a firmware bug warning:
>   intel_rapl_tpmi: [Firmware Bug]: Invalid version
> 
> Remove the FW_BUG tag, downgrade to pr_debug(), and update the
> message
> to clarify that invalid versions are expected on partitioned systems
> where only one instance can be valid.
> 
> Fixes: 9eef7f9da928 ("powercap: intel_rapl: Introduce RAPL TPMI
> interface driver")
> Reported-by: Zhang Rui <rui.zhang@intel.com>
> Signed-off-by: Kuppuswamy Sathyanarayanan
> <sathyanarayanan.kuppuswamy@linux.intel.com>

 Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---
>  drivers/powercap/intel_rapl_tpmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/powercap/intel_rapl_tpmi.c
> b/drivers/powercap/intel_rapl_tpmi.c
> index 0a0b85f4528b..0f8abdc592bc 100644
> --- a/drivers/powercap/intel_rapl_tpmi.c
> +++ b/drivers/powercap/intel_rapl_tpmi.c
> @@ -157,7 +157,7 @@ static int parse_one_domain(struct
> tpmi_rapl_package *trp, u32 offset)
>  	tpmi_domain_flags = tpmi_domain_header >> 32 & 0xffff;
>  
>  	if (tpmi_domain_version == TPMI_VERSION_INVALID) {
> -		pr_warn(FW_BUG "Invalid version\n");
> +		pr_debug("Invalid version, other instances may be
> valid\n");
>  		return -ENODEV;
>  	}
>