The introduced helper allows to check for the non-cacheable configurations
earlier during initialisation.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/base/regmap/regcache.c | 30 +++++++++++++++++++-----------
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 1d55f43ff081..0a78ab0dc9fb 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -42,13 +42,10 @@ void regcache_sort_defaults(struct reg_default *defaults, unsigned int ndefaults
}
EXPORT_SYMBOL_GPL(regcache_sort_defaults);
-static int regcache_hw_init(struct regmap *map)
+static int regcache_count_cacheable_registers(struct regmap *map)
{
- int i, j;
- int ret;
int count;
- unsigned int reg, val;
- void *tmp_buf;
+ int i;
/* calculate the size of reg_defaults */
for (count = 0, i = 0; i < map->num_reg_defaults_raw; i++)
@@ -57,10 +54,18 @@ static int regcache_hw_init(struct regmap *map)
count++;
/* all registers are unreadable or volatile, so just bypass */
- if (!count) {
+ if (!count)
map->cache_bypass = true;
- return 0;
- }
+
+ return count;
+}
+
+static int regcache_hw_init(struct regmap *map, int count)
+{
+ int i, j;
+ int ret;
+ unsigned int reg, val;
+ void *tmp_buf;
map->num_reg_defaults = count;
map->reg_defaults = kmalloc_array(count, sizeof(struct reg_default),
@@ -130,6 +135,7 @@ static int regcache_hw_init(struct regmap *map)
int regcache_init(struct regmap *map, const struct regmap_config *config)
{
+ int count = 0;
int ret;
int i;
void *tmp_buf;
@@ -194,15 +200,17 @@ int regcache_init(struct regmap *map, const struct regmap_config *config)
return -ENOMEM;
map->reg_defaults = tmp_buf;
} else if (map->num_reg_defaults_raw) {
+ count = regcache_count_cacheable_registers(map);
+ if (map->cache_bypass)
+ return 0;
+
/* Some devices such as PMICs don't have cache defaults,
* we cope with this by reading back the HW registers and
* crafting the cache defaults by hand.
*/
- ret = regcache_hw_init(map);
+ ret = regcache_hw_init(map, count);
if (ret < 0)
return ret;
- if (map->cache_bypass)
- return 0;
}
if (!map->max_register_is_set && map->num_reg_defaults_raw) {
--
2.50.1