As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce
mbox_ring_doorbell()"), we want to switch all users of NULL mailbox
messages to use mbox_ring_doorbell().
This client only ever sent NULL messages, so the transition is
straightforward. We can remove the call to mbox_client_txdone(). The
call didn't do anything for NULL messages and it's now officially
documented not to be called for doorbells.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
(no changes since v1)
drivers/soc/qcom/smsm.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/soc/qcom/smsm.c b/drivers/soc/qcom/smsm.c
index 021e9d1f61dc..1e127678fd9c 100644
--- a/drivers/soc/qcom/smsm.c
+++ b/drivers/soc/qcom/smsm.c
@@ -182,14 +182,12 @@ static int smsm_update_bits(void *data, u32 mask, u32 value)
if (!(val & changes))
continue;
- if (hostp->mbox_chan) {
- mbox_send_message(hostp->mbox_chan, NULL);
- mbox_client_txdone(hostp->mbox_chan, 0);
- } else if (hostp->ipc_regmap) {
+ if (hostp->mbox_chan)
+ mbox_ring_doorbell(hostp->mbox_chan);
+ else if (hostp->ipc_regmap)
regmap_write(hostp->ipc_regmap,
hostp->ipc_offset,
BIT(hostp->ipc_bit));
- }
}
done:
--
2.53.0.rc2.204.g2597b5adb4-goog