From nobody Mon Feb 9 23:39:44 2026 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE7622C21F6 for ; Sun, 8 Feb 2026 04:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523487; cv=none; b=IyDtHEY0UoXPAK29npHYpeZZsBrHHmiDP5NcKALvmaLscIfUCRr4CFfSyJac1vFgchhVUDQXnH7oYs9fZ971A2406XfgHl47wQtKgmPSR2dVYixgENSRrkU8C/AuX7dO8Rv2i5Erek16AeivLjXxDZbdPbUjm0OanE4LmBSQk8s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523487; c=relaxed/simple; bh=G1nudZutYj6d9MNzox0nHfR1iYoPe3imRgM6voCKXqE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hkjZq5xJwxkbolOeLx4v3D46DRwDjVBTW96J0Xfy+ZLA4JvqlaYCDOMGHg7snLk5tJuNpnlelm21jGTRuECLdJbqVuxsvALh1AQupRjcg+jQFYe5U6RGep6GZ9F7S+x7FD0GqTYKRGowSPPwXraQPgFQFUeUyJo0kBiQut7K8cQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=SrsrWVWE; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SrsrWVWE" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-12336c0a8b6so967667c88.1 for ; Sat, 07 Feb 2026 20:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523486; x=1771128286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZDSoxJmUAFCsFOozdtCEnUcIaNdh6KfxLjvN8lzvaUE=; b=SrsrWVWEQ4GV9FKiXWl0C6wpWS+xgTlrd77iq5c+tvlRIM9yQ/Qfd5F+wIB12vSUKC hSFyrqZxuQPjb+BmU0k5rky7expVU48+o9v5Bp79TlfaTZjgR7/BvyLRWyRu2dPwNHog hp3pu8HDPQhLdeOUgxkFcR4Xv8FRRkako++YE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523486; x=1771128286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZDSoxJmUAFCsFOozdtCEnUcIaNdh6KfxLjvN8lzvaUE=; b=E2K+gyFGZ+JeIh3kFPpeObC5RpT/QaKw8C0erTPzUU8qZmKGXtwEklKo97aCDGMfAz xN/EOZo+Tp1Zpr6LHMPfcn2BK+tTgstdsWGWsWZMnTAKd/EkoSykRc8qu3TfoG5E5tqi Exj69zhUPy/wWAuTk//fgb95hQOKyiU0aHudJFYno74aupxgKg+/XVrIGCKvWwVIaM8D hYdvwF17L88WwgELH9hDF684cTMqIqaI9vvpEVc3YlBq0rU4TeLrW9hqsJgj/iV02r/i vaXG91iiCJg2Z8YZgR5Ox+RhpNN7GKvmC6AqGSqU3+wxB9x5MmIeP4RTWvmy+gMWpWl2 jfDA== X-Forwarded-Encrypted: i=1; AJvYcCXoz5tcOJIMjaP0c5EP4qW9j89WlBPwxHQaSWFb+nJMvyJsRbjbnmd3nbLLOSp/IZrLTItx+k3E12Zv59w=@vger.kernel.org X-Gm-Message-State: AOJu0YxH05hg8v9oEWftfXEnw8YdG/8zywJqEW8gL+pLfqNUm+H4N97W oHJC3Sm8UsQUc47iGZfLHM8VzQOLvAhAE6uXyUyUEsvwY/4hr5j00MkjJ97sroOZzlLNCqU8Yet +oXg= X-Gm-Gg: AZuq6aIfq/hp6EwKlYelqcZkrC2aka9TBiml8VQnF3k88JBPfLohu4cgskdLnJji8un /pfNzIpU6GfYij54qhW3QU8vqfjrKTg+nsLNQct34hc6LY/2w6qQQwu9CMUT7saZUOgu1k7t5ec 5bFKcBZanfS+z2HdYs02+xqWiEoOkMzClXLvuXLdp3zXDxjCh1gp3FHIxSwCgGOUrsydkcjTT65 TfmQnZp1xgafZrRGoRDJiy/1YXHeZ96ivRyDxokCUkG6ufnwEAzJyIMD+pnvgPIhgF3rxYA06QE Wv1OnJ6Dw3SHhMeSfQP6gEiAvVDS2IYcweCEaCv55vywjAgzmfvvittl7paV++vdB0o5SHcHcog 9PkK+wgX50uqmz9NxzLPQ0XY9ylXP3HmFUJMkx90/E52kDGnMO9dY5HChrRUsvz9qsrDnmPZpYd MwquFf8EXqeivCZjEpZ3VF/+zN5DgNDwiTkBwd2yQ5I2N6JSKyMsyQgROFu89qsDzQW1lDiv4= X-Received: by 2002:a05:7022:301:b0:122:345:a948 with SMTP id a92af1059eb24-1270419f523mr4166171c88.46.1770523486146; Sat, 07 Feb 2026 20:04:46 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:44 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 13/15] soc: qcom: smsm: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:35 -0800 Message-ID: <20260207200128.v2.13.I18ba5837ac5c89cdd3531b6b09a2ab24a95912fa@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/soc/qcom/smsm.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/qcom/smsm.c b/drivers/soc/qcom/smsm.c index 021e9d1f61dc..1e127678fd9c 100644 --- a/drivers/soc/qcom/smsm.c +++ b/drivers/soc/qcom/smsm.c @@ -182,14 +182,12 @@ static int smsm_update_bits(void *data, u32 mask, u32= value) if (!(val & changes)) continue; =20 - if (hostp->mbox_chan) { - mbox_send_message(hostp->mbox_chan, NULL); - mbox_client_txdone(hostp->mbox_chan, 0); - } else if (hostp->ipc_regmap) { + if (hostp->mbox_chan) + mbox_ring_doorbell(hostp->mbox_chan); + else if (hostp->ipc_regmap) regmap_write(hostp->ipc_regmap, hostp->ipc_offset, BIT(hostp->ipc_bit)); - } } =20 done: --=20 2.53.0.rc2.204.g2597b5adb4-goog