[PATCH v5 0/5] staging: rtl8723bs: fix OOB read and perform

Luka Gejak posted 5 patches 1 week ago
drivers/staging/rtl8723bs/core/rtw_mlme.c     | 10 +++---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  9 ------
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 32 +++++++++----------
drivers/staging/rtl8723bs/hal/sdio_halinit.c  | 32 +++++++++----------
4 files changed, 38 insertions(+), 45 deletions(-)
[PATCH v5 0/5] staging: rtl8723bs: fix OOB read and perform
Posted by Luka Gejak 1 week ago
Changes in v5:
- Corrected commit message line wrapping to 72 characters.
- Removed blank lines between tags in the Signed-off-by block.
- Removed "Security:" prefix from subject lines.
Changes in v4:
- IMPORTANT: Fixed a build regression in rtw_mlme.c found after 
submitting v3. v3 will not compile; please use this version instead.
- Fixed build regression in rtw_mlme.c found in v3.
- Removed unused variable 'i' from previous iteration.
Changes in v3:
- Reordered the series so the bugfix is Patch 1/5.
- Patch 1: Dropped memcmp change, kept original byte comparison style 
for clarity (requested by Greg KH).
- Patch 1: Added Cc: stable tag.
- Patch 1: Updated commit message to explain the OOB read logic.
Changes in v2:
- Split u1bTmp rename and spacing fixes into two separate patches.
- Split hex modernization and the WMM bugfix into two separate patches.
- Added a Fixes: tag to the WMM bugfix.
- Removed an unused variable and dead debugging code.


Luka Gejak (5):
  staging: rtl8723bs: fix potential out-of-bounds read in
    rtw_restruct_wmm_ie
  staging: rtl8723bs: rename u1bTmp to val
  staging: rtl8723bs: fix spacing around operators
  staging: rtl8723bs: modernize hex output in rtw_report_sec_ie
  staging: rtl8723bs: remove dead debugging code in rtw_mlme_ext.c

 drivers/staging/rtl8723bs/core/rtw_mlme.c     | 10 +++---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  9 ------
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 32 +++++++++----------
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  | 32 +++++++++----------
 4 files changed, 38 insertions(+), 45 deletions(-)

-- 
2.52.0
Re: [PATCH v5 0/5] staging: rtl8723bs: fix OOB read and perform
Posted by Dan Carpenter 6 days, 22 hours ago
On Fri, Jan 30, 2026 at 07:16:15PM +0100, Luka Gejak wrote:
> Changes in v5:
> - Corrected commit message line wrapping to 72 characters.
> - Removed blank lines between tags in the Signed-off-by block.
> - Removed "Security:" prefix from subject lines.

Looks okay.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter
Re: [PATCH v5 0/5] staging: rtl8723bs: fix OOB read and perform
Posted by Dan Carpenter 6 days, 21 hours ago
On Sat, Jan 31, 2026 at 04:09:11PM +0300, Dan Carpenter wrote:
> On Fri, Jan 30, 2026 at 07:16:15PM +0100, Luka Gejak wrote:
> > Changes in v5:
> > - Corrected commit message line wrapping to 72 characters.
> > - Removed blank lines between tags in the Signed-off-by block.
> > - Removed "Security:" prefix from subject lines.
> 
> Looks okay.
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
> 

Or we could apply v6 with the tweaked subjects.

regards,
dan carpenter
Re: [PATCH v5 0/5] staging: rtl8723bs: fix OOB read and perform
Posted by Luka Gejak 6 days, 21 hours ago
Hi Dan,
Thank you for the review and for recommending the v6 series to Greg.
I really appreciate the guidance!

Best regards,
Luka

On Sat, Jan 31, 2026 at 2:57 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> On Sat, Jan 31, 2026 at 04:09:11PM +0300, Dan Carpenter wrote:
> > On Fri, Jan 30, 2026 at 07:16:15PM +0100, Luka Gejak wrote:
> > > Changes in v5:
> > > - Corrected commit message line wrapping to 72 characters.
> > > - Removed blank lines between tags in the Signed-off-by block.
> > > - Removed "Security:" prefix from subject lines.
> >
> > Looks okay.
> >
> > Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
> >
>
> Or we could apply v6 with the tweaked subjects.
>
> regards,
> dan carpenter
Re: [PATCH v5 0/5] staging: rtl8723bs: fix OOB read and perform
Posted by Luka Gejak 1 week ago
Hi Greg and Dan,

Please ignore this v5 series. I realized after sending, that my local
git configuration truncated the subject lines in the patches.
I will send a corrected v6 shortly with the full subject lines.
Apologies for the noise.

Best regards, Luka


On Fri, Jan 30, 2026 at 7:16 PM Luka Gejak <lukagejak5@gmail.com> wrote:
>
> Changes in v5:
> - Corrected commit message line wrapping to 72 characters.
> - Removed blank lines between tags in the Signed-off-by block.
> - Removed "Security:" prefix from subject lines.
> Changes in v4:
> - IMPORTANT: Fixed a build regression in rtw_mlme.c found after
> submitting v3. v3 will not compile; please use this version instead.
> - Fixed build regression in rtw_mlme.c found in v3.
> - Removed unused variable 'i' from previous iteration.
> Changes in v3:
> - Reordered the series so the bugfix is Patch 1/5.
> - Patch 1: Dropped memcmp change, kept original byte comparison style
> for clarity (requested by Greg KH).
> - Patch 1: Added Cc: stable tag.
> - Patch 1: Updated commit message to explain the OOB read logic.
> Changes in v2:
> - Split u1bTmp rename and spacing fixes into two separate patches.
> - Split hex modernization and the WMM bugfix into two separate patches.
> - Added a Fixes: tag to the WMM bugfix.
> - Removed an unused variable and dead debugging code.
>
>
> Luka Gejak (5):
>   staging: rtl8723bs: fix potential out-of-bounds read in
>     rtw_restruct_wmm_ie
>   staging: rtl8723bs: rename u1bTmp to val
>   staging: rtl8723bs: fix spacing around operators
>   staging: rtl8723bs: modernize hex output in rtw_report_sec_ie
>   staging: rtl8723bs: remove dead debugging code in rtw_mlme_ext.c
>
>  drivers/staging/rtl8723bs/core/rtw_mlme.c     | 10 +++---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  9 ------
>  .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 32 +++++++++----------
>  drivers/staging/rtl8723bs/hal/sdio_halinit.c  | 32 +++++++++----------
>  4 files changed, 38 insertions(+), 45 deletions(-)
>
> --
> 2.52.0
>