From nobody Sun Feb 8 04:30:12 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C2F233C18B for ; Fri, 30 Jan 2026 18:16:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797005; cv=none; b=gO5XMJHK1cd1wjpmJA0WIy4F4Id4FhMrORcO0K8bRDdcz4I932XFoyUo2sdSIuJNG1k4pLfcDm+1rKbhI253/IHgrnDC4cUsgjvo+w97TBIWjqlAJ7WDOUN+HJgKBspyBCwjH0rFAmXsnRSY4q8UNgNq2YrDTsbAN8pHRJHdjrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797005; c=relaxed/simple; bh=54jF80axLN2UJAh0SY0zu8J2BqHK+0mKcS7a+qODr54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JWgSXwYYButSy1zAbA+wmCyt74CfNnRdpnpfV01HMx6BUiUVCV0vJX/QZTXfc0EZGp1k9ypjK+4SvhVUplqVi6gvS4FQ5IVAO7Kr89UjsjX4MYRKhWi3c8rMcoTUSWkBIOLpvQeuJta+nJvz2OpI8kBcvKC/Ggv5y6m996YqS6I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h/B+PItv; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h/B+PItv" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4801c2fae63so18414235e9.2 for ; Fri, 30 Jan 2026 10:16:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769797003; x=1770401803; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=h/B+PItvtCLrF0JiS1yXe9+U3x5Rio87GZyET+2RaQ83/LGjt6/RoEsU3jFV3LWK2I /RZ68vT8OulcHOrpx3qeYEBdvwUx2XzMSmnFFxXLrngFKsPBdswyuNSsVIAktkTINXPV ha6+sqzr2TAtHh3Bamk9VcMUVqZJBM+l/3Od3HFyIBhqsOHdySwFVVA+XPS+Btr5PUPr Ghz2Ix2vnnX2yLd7q06b0v9ajr2fBnaDU2n79qs+09EjMQH9uco8euOGksMVy83ptabI Zu+nH9dfb34g82c1Iq9Lrx2U5R6IDZrD8OsXMN67/KuKe/8PWp2n0wGpuY8lFk+tjPFZ DXgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769797003; x=1770401803; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=r87zfktC1jWfhTOg4cfOX0OmGI6bmBaGusAoBGgddhSxTu9yzM28zQRqi+DYm4vLou l+eqhcyvO5qIJLPVn708gBfNUAzxicJlaM6U37ATx6Dyva8Z+pO7y/XnnLTlqVLXpI2f a9jJmIO5bnpk74mFxhNs7oJ2iqKoAHl7ZJYuEgJgCGlrzKtCD2wv/twnZkf6JLD0bfaY 207sC/dNCEDnO3YfUdTScxSyz0hLN5T98/pfCzNNJjx6h61gZ5T7ydRQqR+7rMYSbAai L8d6JeT/P7bUMfmbJm9jovXixfs1R6aZZqeJI84e8Mjyg//gx/bh3CrHBaNIeABwFT/A dieA== X-Forwarded-Encrypted: i=1; AJvYcCW5KWuCHrV2a3fnYDToOR+PCbmETYSnusdIg6tplTe2eCAQV8RmpjAaDs6RxO20Z5XOjvNXvmO2W97pGcU=@vger.kernel.org X-Gm-Message-State: AOJu0YyeKaB47V6ASyZE+4Mvgw3tp0pkHtD8Uc+yVLrZ+pUIShJeGgyF wrBCjnS0bv94faAPqjDfKgh/tOXnNIXWwlMRFc9ttMCTOjtoz0agtCU= X-Gm-Gg: AZuq6aId34V5cN7qXQmtPq8Jts4MndmfkoCXtYEgbimtUXfActodqXXRz4hvu3CL85b saa+kiYILDcQKcd1kpeUTqRn4LgVMJmd0ptp12YE674QtRNDxG8sK2p37grh5YXh0MnGq+WzlnA 1scLSPOJdXsGNWKCD3uky3B1yy6h3BxAuws4eInFn3ugtI0Tq+dpwF4qA4IeSyb0EHxU2ufOlCo psEi1QHyf1lb2wWqNTw5Oh+IjZSZ6Kcnxb69CVq6xD+pniYzizHY0G5Z0g58CiXLu842Qs2HFgp Z/VbCCzu/Kgdk2IX2andursbzg3w1SYI86GUD52+hWTZB2S1ypsJMpjJ1Jotg1I+8eWHNKtXLMs /iAN2055nC8ZG3CsY/9wGc7nUnkyA41VEKMlYenC1Uyitjc8EVwZyf4JWXhA85WZt3V9vhyt/AU anJZKPufWhQZwNAPBlKUuIlUkjr1ipVWx3bbRxkDEqCJ333UBDR5fd8UnknomjFqWeaRZ2sKbO X-Received: by 2002:a05:600c:3e1b:b0:477:7af8:c88b with SMTP id 5b1f17b1804b1-482db45129bmr44705235e9.11.1769797002303; Fri, 30 Jan 2026 10:16:42 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c40e04sm280571025e9.13.2026.01.30.10.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:16:41 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak , stable@vger.kernel.org Subject: [PATCH v5 1/5] staging: rtl8723bs: fix potential out-of-bounds Date: Fri, 30 Jan 2026 19:16:16 +0100 Message-ID: <20260130181620.199152-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130181620.199152-1-lukagejak5@gmail.com> References: <20260130181620.199152-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current code checks 'i + 5 < in_len' at the end of the if statement. However, it accesses 'in_ie[i + 5]' before that check, which can lead to an out-of-bounds read. Move the length check to the beginning of the conditional to ensure the index is within bounds before accessing the array. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..7dfc2678924e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,10 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 = *in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength =3D initial_out_len; =20 - if (in_ie[i] =3D=3D 0xDD && in_ie[i+2] =3D=3D 0x00 && in_ie[i+3] =3D=3D = 0x50 && in_ie[i+4] =3D=3D 0xF2 && in_ie[i+5] =3D=3D 0x02 && i+5 < in_len) = { /* WMM element ID and OUI */ + if (i + 5 < in_len && + in_ie[i] =3D=3D 0xDD && in_ie[i + 2] =3D=3D 0x00 && + in_ie[i + 3] =3D=3D 0x50 && in_ie[i + 4] =3D=3D 0xF2 && + in_ie[i + 5] =3D=3D 0x02) { for (j =3D i; j < i + 9; j++) { out_ie[ielength] =3D in_ie[j]; ielength++; --=20 2.52.0 From nobody Sun Feb 8 04:30:12 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646E037F10D for ; Fri, 30 Jan 2026 18:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797008; cv=none; b=lyaQCK4gGErnnxG3tLX47LjENJJ6ICyaszfvxxD+CmUERG7LXVa5U7jHXDq8AfX2nMfYkqwjNZ0suo8wOrJlXhQvwnz0WYehf/Y5k8lvV4tw5FiSepArdmHP5CCWBeox9ONMsbDaBH9S1xrbAsp35rlgOjFqseG1IZ4T8gLxnFE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797008; c=relaxed/simple; bh=BTGD8PKhmsfkb+4Q1sKuryoutQRF30cIq9URLzQ0h4I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gAiWlk3UQaeLKqKgMgU+78Jgv894AODls1VYzkND8oBc7xu4HKUHq9WqsSba19jwG8Y2Me+6urfB4ojomfyrOwVIbeM3KO7buqAi5/wBGFf6uvy2NJ5tUb/smVBDm4cICsi4L1cQ/y+chtWC5eptmJVz6pOqQjG4I+tY9J3W41U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bgSi2OZ0; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bgSi2OZ0" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4807068eacbso20519765e9.2 for ; Fri, 30 Jan 2026 10:16:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769797005; x=1770401805; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HRDtc7+pH6qw1+quaRjh9oBVjXVe884KC2sSKvso1A4=; b=bgSi2OZ0l9WsEW1NYP+pVq8AQB4r8vVT01P8G5PztBqTv8G9WMMN702gbOv98CaPfE 6EcOZ41aDMGZlWFnfRvDVhFFZHcItaJhQSj5uAKvoi6XpvNzvVptm6TKPj/pt/16YD2g NKerTaoy22ys1LGYw+w9AZhasC6giNVed/iYJygPJG/11NkGcW8Rrt03GXXGnDgi22Mt rSgUBNP0GK9SD3d4uOzqnljHG4swT1/cIaTqSIOrG2ireWBSpccFs48tVT7wYLPq2YKC bSvZNvp60B4R5EuACUPPODGT2L6X8iTT+KvFNE3bSR7NiX6UhPKhAkRyTNX3mmmwaSyA gkdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769797005; x=1770401805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HRDtc7+pH6qw1+quaRjh9oBVjXVe884KC2sSKvso1A4=; b=OGGjev8l/6z8tiez1DTf4dSdWyVaOQlvi2GrmhS3rNAVjuvkXboBEmw3TuBpNbxCWo UqvldykqjIMxIkTolHox/968n4ikn5iRlF4qDZfcmidQGwKLs3aVpxLENsFBEeLU1Zwe F1OpYrSiXi4Na7g/lnQhIzxCCXSudN7T0Apae7oipTad8Cqic48YoaYOlQd5a0+zdnvx 6rs0odzgvz9029WSLRjaKBk3NPrvU8nWG7sSIcMVlJM3fo9/ogJl8z6ku5uOjFCEjeEr dncEkaeCnQEKB2hij4rneFpDrB10kHENh6sTXyus9F3d5Ip4E33REvZIbTgLelNJhvvO q4FA== X-Forwarded-Encrypted: i=1; AJvYcCXRL27VZQ6jFohZrVA2mNZb1rEKNClK68yoWZLgmvfWpPzOEHZLCEOukSlHKM83g3OIvH6x9juP6BkfJOc=@vger.kernel.org X-Gm-Message-State: AOJu0YwmDP8SeDasYme/3SbkGmqJPQxNhysfwiIpsl0DAliLrbMH6gLx fOz7/Y/tN0uAZfJ9gQ++VvBrS0Xk1rsvKbnL5rxCnYVJ+7hYdWYQevo= X-Gm-Gg: AZuq6aLIqG9H4nJbkpslQVe0OUr9SqRSy9c3D4rR/8HbvpGKl5QPhCBd1ymX4qAG38x TfGOEF42BJumaHbW+BYGKu7CoowT09r8pwlMgmr9iaptcTvipm/o29WWaBTOgMXHDUJqYYWG4QD 6CXIrn7Dq/q5+/cyB5bq5nWqz8eTYmp61SU6O97Zg3up5qkI4cNwz5/y+H8XLsvm/6UaKPpxBKj epTMU8iBgGReiNw23YS61fEPkA4C3jzzJymVnMTUDNYmjSkMZMA+blELZR8cGegWbLam4fmgKcT G1g0VPOjWT346N6pUq5RypwbuddkKK6SH+CZIAWJjFsrQvcl43vHbj/sz2wD/xTWPnJzgF32HxV Gh/xAf0kC/1VYUkFg24yptlm6J+Bwe0DapYbyg+yScqrNLD8MIGAR/acAjzzEyqWDvvsw/vM682 NvOHOavtAp0hkGCyyYikvytsvs/2OILAJ9CVI+et2/4pwK4UdBWNB8sWHB63LYpw== X-Received: by 2002:a05:600c:b99:b0:479:3a86:dc1c with SMTP id 5b1f17b1804b1-482db49a407mr47035185e9.36.1769797004485; Fri, 30 Jan 2026 10:16:44 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c40e04sm280571025e9.13.2026.01.30.10.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:16:44 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v5 2/5] staging: rtl8723bs: rename u1bTmp to val Date: Fri, 30 Jan 2026 19:16:17 +0100 Message-ID: <20260130181620.199152-3-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130181620.199152-1-lukagejak5@gmail.com> References: <20260130181620.199152-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak Reviewed-by: Dan Carpenter --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 +++---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..d75a63fd8a6b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) void rtl8723b_FirmwareSelfReset(struct adapter *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - u8 u1bTmp; + u8 val; u8 Delay =3D 100; =20 if ( @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - while (u1bTmp & BIT2) { + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..c774a9009e95 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) struct hal_com_data *pHalData; struct pwrctrl_priv *pwrctrlpriv; u32 NavUpper =3D WiFiNavUpperUs; - u8 u1bTmp; + u8 val; =20 pHalData =3D GET_HAL_DATA(padapter); pwrctrlpriv =3D adapter_to_pwrctl(padapter); @@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->SdioTxOQTMaxFreeSpace =3D pHalData->SdioTxOQTFreeSpace; =20 /* Enable MACTXEN/MACRXEN block */ - u1bTmp =3D rtw_read8(padapter, REG_CR); - u1bTmp |=3D (MACTXEN | MACRXEN); - rtw_write8(padapter, REG_CR, u1bTmp); + val =3D rtw_read8(padapter, REG_CR); + val |=3D (MACTXEN | MACRXEN); + rtw_write8(padapter, REG_CR, val); =20 rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper); =20 @@ -848,7 +848,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* */ static void CardDisableRTL8723BSdio(struct adapter *padapter) { - u8 u1bTmp; + u8 val; u8 bMacPwrCtrlOn; =20 /* Run LPS WL RFOFF flow */ @@ -856,26 +856,26 @@ static void CardDisableRTL8723BSdio(struct adapter *p= adapter) =20 /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 - u1bTmp =3D rtw_read8(padapter, REG_MCUFWDL); - if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ + val =3D rtw_read8(padapter, REG_MCUFWDL); + if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ rtl8723b_FirmwareSelfReset(padapter); =20 /* Reset MCU 0x2[10]=3D 0. Suggested by Filen. 2011.01.26. by tynli. */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - u1bTmp &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + val &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val); =20 /* MCUFWDL 0x80[1:0]=3D 0 */ /* reset MCU ready status */ rtw_write8(padapter, REG_MCUFWDL, 0); =20 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */ - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp); - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val &=3D ~BIT(0); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val |=3D BIT(0); + rtw_write8(padapter, REG_RSV_CTRL+1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0 From nobody Sun Feb 8 04:30:12 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5293F37F728 for ; Fri, 30 Jan 2026 18:16:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797008; cv=none; b=Ryinxfz86NXxK7zUPEzkyGEbzt6vl+N0CLyQibsl/SF2UrAlLrns5f8zzqS2wUhH7hEnwjIH7f4lz4LARbz/GKrbc9wr+9YJplFD3tQ3wbNXUYlD6BXGxcyNvlRS12X6QhPt9YOFT212Fi0Z4KY1TenmeikDr8uZ3ovx2fsozNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797008; c=relaxed/simple; bh=rydnYZqJ+NFeWlELYNoZjjVmnW/PmZZQ4nMY0FQMv2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uFqMYvpe4iGFzcVbDpCRH9W6lZnDhk0ZnPAeTYooaRv08ZMkMNFrUJ5FtcYDLrAgCNlf5BfROqZeInR8AKk2vjUPp1bgrwiqCJ1usTyGMn4nA8LDdOPy4/2gZdAo3j/7XTGFXPzdJiFzze23efXrRRr9rXEAgh3vrJD3YBOS7Dw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gRs/mivO; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gRs/mivO" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4801eb2c0a5so23058855e9.3 for ; Fri, 30 Jan 2026 10:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769797006; x=1770401806; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=itsgzrCz2Yf6Uryqzwzu2QWjHF5Dbr5bnBZ816xY3xM=; b=gRs/mivO02Q82yHrdIHv25YzIqrx62/DpJH/F8JWfgzN3c3dLQy0urYFttOJ3dk0JF ByPy0al8jkWxrdGbJg+Hdssmr2OH94YBQYDu0/kJm+rimvCa/IIFVW9x54iPfBLf68kX 3Zvsd0rJSdwBNl6R/OIWNIqDfGYOwljy9zcABuLAKBFPW5ITnG8ghY036LTUw9vtfxeG hWEUtdfpEe03h9+g8UWzPvongpECj7m2yxLuzaB9k3+gv07QhvAaM9ucK1/6A7Wi3j4P R/wXXpISgOktU46TEai6noOM46Cpex7fl0RkGTBpmhLIafKPknK9ZJK1ztvXg8/IES0w +RIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769797006; x=1770401806; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=itsgzrCz2Yf6Uryqzwzu2QWjHF5Dbr5bnBZ816xY3xM=; b=NYNb3eohzP97fBBWzaiAlbsxMqPpLmQT35GcfFtRU+DO5NDvzbE4mR20Dgo0qidTvo 5KhjTiL+DQYijuel3d+PshGxAZHawkWICom9nXreFjxhdjIbKdZ/vsIAw70tepSpHnVz 38+vzIvRNPTf/QClIHqDqlun2x+I8lPquEadhnWfMkA2VA8tSgg2jCtitin1dJQsQ7zl 6eVK5uPnM3F/YnH665eekau6MdpWvaE6QkmxQb9SN2mvO1d//n3Cj5uEWIkX+CrSVaIH CQHSYVPOJnjj74ngsEaEtCLhVvQihK63RuvtGEPSQviMOullX6ovVmddzmsYUZRTLZIE MJ7Q== X-Forwarded-Encrypted: i=1; AJvYcCWVodKSqISkHv5v265GH+jUXyKxK6nJArJT1bT8cVqKmnAyYREbA4KNjjk2gzBEY3rjx+NvG63LyVS1ro0=@vger.kernel.org X-Gm-Message-State: AOJu0YxySqmgBwDpIB0cybXU4DwPWz+1LB5njCCqtk6bBTlnwMNAQLSa KP+gYGcct1yJKba3wgUn7YgXMbLDfNMLjvpUae6ssPRd2dE07fM6iPs= X-Gm-Gg: AZuq6aIbp8PjGxMNjs2Y3I51XA7tYJ7O6IjWQ0qM4hg+OAeQaLEQ0YmKbWpo6xNFgDT V00lItTXiArvZ1vtSKAihaxw8pIFdxhThYH9VTRXNumZa0CZJXCHkbaLxJuAR3R7ik9XJbsEhib JQY7Jp4Dj6Zg+UNEkish7AIjdVFri8wgSf7HKOoJmWY6/57qO6p/hgEmznzItM5WKMzGAEC5Chr SAKDYzSNx+gPAnTZOrZatjPnbVF+Lim/7M1Gkk4VS24EL7cDy7HHGyrOdvjmKosyRbh2NpmbF5Y f5LXG5/i3+6GBo+ERXW2+fNSee1xsRWCbWocMKMjlg/R8gVezvADry5bKbx2tNc8TJo9kAT+/uF RX0LfsLHJRNfwZZOjIKbaP8qO4UooB0bBAQIcxe10lbIZZKGtApAWqW29MoxC7Ac396dskQqfb8 ddlbombIrNOgMXfxbWoc2BhWqw4og6px06Iy7qZ9JtGjms7mIiq+jXcQmefGScHQ== X-Received: by 2002:a05:600c:628b:b0:480:4b59:932e with SMTP id 5b1f17b1804b1-482db45bce2mr46184425e9.11.1769797005701; Fri, 30 Jan 2026 10:16:45 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c40e04sm280571025e9.13.2026.01.30.10.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:16:45 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v5 3/5] staging: rtl8723bs: fix spacing around operators Date: Fri, 30 Jan 2026 19:16:18 +0100 Message-ID: <20260130181620.199152-4-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130181620.199152-1-lukagejak5@gmail.com> References: <20260130181620.199152-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix coding style issues by adding missing spaces around operators. Signed-off-by: Luka Gejak Reviewed-by: Dan Carpenter --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 28 +++++++++---------- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index d75a63fd8a6b..ae5e4980ed06 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -17,8 +17,8 @@ static void _FWDownloadEnable(struct adapter *padapter, b= ool enable) =20 if (enable) { /* 8051 enable */ - tmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, tmp|0x04); + tmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, tmp | 0x04); =20 tmp =3D rtw_read8(padapter, REG_MCUFWDL); rtw_write8(padapter, REG_MCUFWDL, tmp|0x01); @@ -158,23 +158,23 @@ void _8051Reset8723(struct adapter *padapter) /* Reset 8051(WLMCU) IO wrapper */ /* 0x1c[8] =3D 0 */ /* Suggested by Isaac@SD1 and Gimmy@SD1, coding by Lucas@20130624 */ - io_rst =3D rtw_read8(padapter, REG_RSV_CTRL+1); + io_rst =3D rtw_read8(padapter, REG_RSV_CTRL + 1); io_rst &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, io_rst); + rtw_write8(padapter, REG_RSV_CTRL + 1, io_rst); =20 - cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); cpu_rst &=3D ~BIT(2); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, cpu_rst); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, cpu_rst); =20 /* Enable 8051 IO wrapper */ /* 0x1c[8] =3D 1 */ - io_rst =3D rtw_read8(padapter, REG_RSV_CTRL+1); + io_rst =3D rtw_read8(padapter, REG_RSV_CTRL + 1); io_rst |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, io_rst); + rtw_write8(padapter, REG_RSV_CTRL + 1, io_rst); =20 - cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); cpu_rst |=3D BIT(2); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, cpu_rst); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, cpu_rst); } =20 u8 g_fwdl_chksum_fail; @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val & (~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index c774a9009e95..668616efa68a 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -875,7 +875,7 @@ static void CardDisableRTL8723BSdio(struct adapter *pad= apter) rtw_write8(padapter, REG_RSV_CTRL + 1, val); val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); val |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, val); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0 From nobody Sun Feb 8 04:30:12 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2DA437F738 for ; Fri, 30 Jan 2026 18:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797010; cv=none; b=XYML0C0SCfgqIZcLLR75SrnFmjdrazZcp4z6Gn1AjJldXx66mUfphyU3M8Nk2SZVskmv6TwcfN7elDhhMXr+cyLtj8EpqtlKZJMWQ0fvstT669eBAUqBW9uP70B2nulF50NZLWEI27j5fpT7vSD6vCqj0UEwmf8E5MY7wwc1hz8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797010; c=relaxed/simple; bh=uMjtgTE2oQaSlXZ2RpWzD0PdmDQs8ivpMUqvhD1eH6k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k6lS1gFIaDX5woMzoAnmp+qYkIN4JQCTEvFzha+Q6elhQGSGTkJr5YukzkyT4ksS02ysCW+mYx8pAJknfHTA9/KzJG7FvYGdq2UYrorEh/gO6VOpwKRQvTo2KCUUBI0prvvpFlIvGl0YpQbYuvyc37Sb3y7nuo+DYfhu9Nk3O+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g/+JZBTw; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g/+JZBTw" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48068127f00so20507335e9.3 for ; Fri, 30 Jan 2026 10:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769797007; x=1770401807; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qVrBPCMwxLFaPKXm7iV49koCmmnJv5JcMuWXxCdjyKc=; b=g/+JZBTwLCMT7Q55DKPVTWsrhMhISkIDlI28S94cQd+EOxU8/tOfs5eaRBHSYw/Ow5 BvuDW3+iK5PL18eEw3/NFXMtljiSFDvErT0+97ZFbJklg/1iwE42+LKb+PhOEdhvykeY y2IDEmSOiUr9lmvtwfUvesqQxXkjgatdK+7KmhokraKUco4rTzMVbHmqJlZhNNL8FyqU 9LNJUT3oGKZOCPsnVwke1WM9rvajYOcaQgIwqVC3e9KkZYb+yvnPRdTYlZXvqHu8BevQ WbSDBfVutvNg8G3tpIgYMqdnsW7AH0pUaivHfo3UFLeWsrH1sjWsIOtrTtUY4lrDyVDd ZkkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769797007; x=1770401807; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qVrBPCMwxLFaPKXm7iV49koCmmnJv5JcMuWXxCdjyKc=; b=UEcIdXX8wo63B8uIxdVunvHhP75ljoM6HuVSzQrhhCWM/lMeklsotUXYMCJlEbTI/h 6y/xcLy+0zhypxXNUCEpw7leoxfyqj/t4ctZSKMGqVUvIdLeJ5Zqx5MWTY8HeWg4iHxm lEN34aDychu4UMhlMIZ4h8AkX9YZPaPWD5UAqfa21iryIV+M4rVcId6ZQT8axoMdJO7W IgKwzOEC7lNqw/6OudjWIeW1UMgWQ2ylBfdwFyDZJwLdYDz2nmRHqHZpNSWT1N186bHA S27Rt/ORyKd380wdtf4DZVSB6u/AQfskAMUBhR8ljkS5kCaFLQ80GazoK7I4rH8nGvU+ auaA== X-Forwarded-Encrypted: i=1; AJvYcCWkY3XakN8Ml0GBgMWHPOZoIVVD8x9CAToHsQ3gzuIX/QCAFkIlgdh2NDzQy0vywtY5HYwevxJ504RNxh8=@vger.kernel.org X-Gm-Message-State: AOJu0YyRKzTMbUbcVpmENGjgJGSeobUP/j5OBhcl3lok8Fwty55vBab7 RYDgX9n+EhtUQYF0WcmhGGNbNwOt4QDcoPhzJK9Onq2wnE6CK/+x+1q0xhfA+mo= X-Gm-Gg: AZuq6aITYWRIdh8lB/vvYY/vhMpyqPmQxqwlpMx0Lkd5TQSg6G3oUS2PCko/Bcy2V9k 1d335Eh/vxR56XS0lO5rKEN88wzmpTSAaQC5M/hgv5e2apaLJv73WT0JAVPfHGAtYyo4ek0u3tY El7G1iaaYQFGDRv8jJbexPv0qCo3n7MrbUspny+iKulkWJevSR8Nzr3CMVmJPoAqVUqjsBRZGyc hvXx7BObbDC9AKbLLdj+qgW9o94VYo41WQTEyoiKxTbxXt3Arclo/UnIKM4NpnRQyVKsxa11xOE 0XtiUcDRVF9C5STcAyAFtmX5mhGQgDG6L3NV7zz+8nt7qnFM147bVFZKqX28l1xGuR3e8ukH5b3 pDIMthQG0h+cswik7etP9oDB+g51FycnCFPtRR79iODdllGaAIaCDcpzhksd3EFgCrfU2rNTcxa wUQKUqKVNaTBfQFu3jfdrD/0XltyR1NGnOXHsPHQWe99IkmRJ6I3mnmzEl0PT9Gw== X-Received: by 2002:a05:600c:b99:b0:480:19ed:7efa with SMTP id 5b1f17b1804b1-482db4a8ba1mr47028925e9.36.1769797006785; Fri, 30 Jan 2026 10:16:46 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c40e04sm280571025e9.13.2026.01.30.10.16.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:16:46 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v5 4/5] staging: rtl8723bs: modernize hex output in Date: Fri, 30 Jan 2026 19:16:19 +0100 Message-ID: <20260130181620.199152-5-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130181620.199152-1-lukagejak5@gmail.com> References: <20260130181620.199152-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the manual hex-printing loop with the standard kernel '%*ph' format string. This simplifies the code and uses modern logging practices. Signed-off-by: Luka Gejak Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 7dfc2678924e..5e79a720710f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2071,7 +2071,7 @@ static int rtw_append_pmkid(struct adapter *Adapter, = int iEntry, u8 *ie, uint ie static void rtw_report_sec_ie(struct adapter *adapter, u8 authmode, u8 *se= c_ie) { uint len; - u8 *buff, *p, i; + u8 *buff, *p; union iwreq_data wrqu; =20 buff =3D NULL; @@ -2087,8 +2087,7 @@ static void rtw_report_sec_ie(struct adapter *adapter= , u8 authmode, u8 *sec_ie) len =3D sec_ie[1] + 2; len =3D (len < IW_CUSTOM_MAX) ? len : IW_CUSTOM_MAX; =20 - for (i =3D 0; i < len; i++) - p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), "%02x", sec_ie[i]); + p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), " %*ph", len, sec_ie); =20 p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), ")"); =20 --=20 2.52.0 From nobody Sun Feb 8 04:30:12 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E374037F8A8 for ; Fri, 30 Jan 2026 18:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797012; cv=none; b=DNQbTRUnvRcSwPdJLz3npxW4svZFCRQlPB80HtD4lNd5UclTaQpn28RThshzKPxrCXSCFT9wdGd/MfCgwNjfN/+KjwQL7rja+6+yhXB77UMpp/4FHqUL6fUskOFSGdX2qSjuWyNK/pda+7qUOXHHPkFO3+FoNAp5901tnSqCddE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797012; c=relaxed/simple; bh=FZZvYnP51QX0dNB1MW147bXp1WMORAQQSIU33mEW2yU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AdawvTGqzZ3Pr2CajS09ZUQOAXh+f3KE2z6tSqjJG4MOcRN585X7xoKO8cL3egPE3GB9igAjC8sz1deGQ4jc4+I8JutJ46bVc/dV2sAhbpnqSBf4CNz7ZXajy+/AxKECb7I5o0x6JY15GifAY1HzTt7O4hiZarS5Hkz9ipk1G88= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q4NSNlSo; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q4NSNlSo" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47ee3a63300so25205595e9.2 for ; Fri, 30 Jan 2026 10:16:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769797009; x=1770401809; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7q66IcrlcJI8pRbK+Fca3eWQA2yovR85OACWrbeMFzM=; b=Q4NSNlSoj1H/+iB/phoF/u6o8YLEB1QkBjGnjCqgyNYvsnwpERboXfpgHvN33qQaVa d+/+V0V+t+vRxAnb7iyfYeZFUFZ7QW0hIEkho5q1KfDdEAzD72Cw6ua2zYKPCtfst3Z0 lwlpT4Vrl8RH6rhPHMWV/iELBaW+14jM1Z7TP1ryifTdJb7TUFJu2fPs2mMPMz8GoQ5t gK03uco14HokFKFE4L9By2J1b3/HZuv4r5dcWAGCqyxJImYqQ3rCoYSDtIBq0tiOSAOv XURt3c/GB8MpnhNQszsBGpJRCvBYbbOvIfeYV/uUUivtk1+YNrr+/2R0vBD9CszFQJCF IlAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769797009; x=1770401809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7q66IcrlcJI8pRbK+Fca3eWQA2yovR85OACWrbeMFzM=; b=Zxd6AYkrslnr1y5tKAoU9i5k2mWqcJc860nx4TKGxBJPOj2w/JzRkIzitNv5yLNN3M Z948ZiSt0v0KQVM3vWaNQyEQgJI3kMnGLCsMjuwXTjB9Homn7SiJiu0c+EgPE+y5zrRO L1trP520cZISdG02aaKJXrEN385hLVf9VboEsvaS159AGGNqI3plVfnPfV37wEexSHkm i5QzwwnA3EEoRdQ9cMMkMeksk8ceMLozeUuJSAqCxtyaB+C7bC7V+w7VZOtkMifK6M5h PYtRFY56RK2chK3riopanC5yeLChi8FidZffDhVU1pE52pmwC2gRn+XwENq97cHNgTXS TbQw== X-Forwarded-Encrypted: i=1; AJvYcCXWvIrGEekIyA4T5QEG92qIPP8cgL+1Ivdf5UffJhSERuI1BAoTS5gSFWwzIsrlt5G4o9/uf7P5hQEPBvc=@vger.kernel.org X-Gm-Message-State: AOJu0YwdRBbn4Tjrbt1tuafIgWzEnSr3OA6Ndr+nPvtxZjyG6zSFXwZP fx9AzMRsLAFKH8saChHQRVohoD+nSFBjMOtmI0nYPVZCHZzejWtYDik= X-Gm-Gg: AZuq6aJRBmUY6WIyF2y19tzaj3TE+qf+dPPvGfNX1H2rcH+d/+dx3fl6xY3tDW5/dmU uQMZ/zYXRYlFWunGqMUuUno+F9s3Zc93Q8H9rVzuQltkNOqNXd2s2so8QY1S11I/zuH8VEokVIX p2LqPZ6M+hBymdb3oKr7o5yzNC0zZdK4IuJPICOfIIs0lcaOyjwra0EXvQgvlGjXKlzwtlsaQKt 3ZZc1A0g2G90UAVoojD8huDhIGuq7UOWpyok5lGSaG9CCTMDBKhFTiW7XtHFES2wnK+PoVrq7C4 UXkpCjhmlmV9x9k9IKmpfaBFhIIG1uhjLBFOtIphe9EW441jSPaTld2tkc0058cpOSok6PwDpOU ThKsQgZQajgabChuIfJ/21tx/JtbE+FbIXZmmTecahpqhPBPgAHLhM6R8g7W3X58phOfMiVBH3G 0Okp72jt0Ez9Bu8xP0n7eqqDCi3A8+6Kgm6+g5qYf6qOuH9S+5GjeYVEeSoK08ng== X-Received: by 2002:a05:600c:4443:b0:477:7c7d:d9b2 with SMTP id 5b1f17b1804b1-482db4a1030mr46133745e9.32.1769797009036; Fri, 30 Jan 2026 10:16:49 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c40e04sm280571025e9.13.2026.01.30.10.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:16:47 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v5 5/5] staging: rtl8723bs: remove dead debugging code Date: Fri, 30 Jan 2026 19:16:20 +0100 Message-ID: <20260130181620.199152-6-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130181620.199152-1-lukagejak5@gmail.com> References: <20260130181620.199152-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the unused local variable 'pattrib' and the unreachable 'if (0)' debug block in OnAction_sa_query to clean up the driver code. Signed-off-by: Luka Gejak Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index ac49bfbaa5bb..b61841bf16a5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1849,7 +1849,6 @@ unsigned int OnAction_ht(struct adapter *padapter, un= ion recv_frame *precv_frame unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame = *precv_frame) { u8 *pframe =3D precv_frame->u.hdr.rx_data; - struct rx_pkt_attrib *pattrib =3D &precv_frame->u.hdr.attrib; struct mlme_ext_priv *pmlmeext =3D &(padapter->mlmeextpriv); unsigned short tid; =20 @@ -1865,14 +1864,6 @@ unsigned int OnAction_sa_query(struct adapter *padap= ter, union recv_frame *precv default: break; } - if (0) { - int pp; - - netdev_dbg(padapter->pnetdev, "pattrib->pktlen =3D %d =3D>", pattrib->pk= t_len); - for (pp =3D 0; pp < pattrib->pkt_len; pp++) - pr_cont(" %02x ", pframe[pp]); - pr_cont("\n"); - } =20 return _SUCCESS; } --=20 2.52.0