This series performs a driver-wide audit and cleanup of dead diagnostic 
code within the rtl8723bs staging driver.

The vendor-originated code included a variety of diagnostic counters 
housed within 'struct debug_priv'. These counters were updated 
throughout the driver's hot paths—including MLME, receive, power 
control, and SDIO allocation—but were never read, exposed via 
debugfs, or utilized for any internal logic.

This series removes the write-only counters, the skeletal functions 
used to update them, and cleans up the resulting unused pointers 
and logic blocks.

Changes in v2:
- Expanded the series to include the removal of RX FIFO overflow 
  logic in hal_com.c.

Ethan Tidmore (4):
  staging: rtl8723bs: remove dead RX info reset logic
  staging: rtl8723bs: remove dead RX FIFO overflow logic
  staging: rtl8723bs: remove dead RX sequence logic
  staging: rtl8723bs: remove unused struct debug_priv and all counters

 drivers/staging/rtl8723bs/core/rtw_mlme.c     | 12 -----
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  3 --
 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c  |  6 +--
 drivers/staging/rtl8723bs/core/rtw_recv.c     | 23 +--------
 drivers/staging/rtl8723bs/hal/hal_com.c       | 19 --------
 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c   |  7 ---
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c |  4 --
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  8 +---
 drivers/staging/rtl8723bs/include/drv_types.h | 41 ----------------
 drivers/staging/rtl8723bs/include/hal_com.h   |  1 -
 drivers/staging/rtl8723bs/os_dep/os_intfs.c   | 14 ++----
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c  | 48 +++++--------------
 12 files changed, 17 insertions(+), 169 deletions(-)

-- 
2.52.0

On Tue, Jan 27, 2026 at 06:40:04PM -0600, Ethan Tidmore wrote:
> This series performs a driver-wide audit and cleanup of dead diagnostic 
> code within the rtl8723bs staging driver.
> 
> The vendor-originated code included a variety of diagnostic counters 
> housed within 'struct debug_priv'. These counters were updated 
> throughout the driver's hot paths—including MLME, receive, power 
> control, and SDIO allocation—but were never read, exposed via 
> debugfs, or utilized for any internal logic.
> 
> This series removes the write-only counters, the skeletal functions 
> used to update them, and cleans up the resulting unused pointers 
> and logic blocks.
> 
> Changes in v2:
> - Expanded the series to include the removal of RX FIFO overflow 
>   logic in hal_com.c.
> 

Please don't send multiple versions of a patch on the same day.

Anyway, kbuild bot complained so at least I don't have to review this
now.

regards,
dan carpenter

On Tue, Jan 27, 2026 at 06:40:04PM -0600, Ethan Tidmore wrote:
> This series performs a driver-wide audit and cleanup of dead diagnostic 
> code within the rtl8723bs staging driver.
> 
> The vendor-originated code included a variety of diagnostic counters 
> housed within 'struct debug_priv'. These counters were updated 
> throughout the driver's hot paths—including MLME, receive, power 
> control, and SDIO allocation—but were never read, exposed via 
> debugfs, or utilized for any internal logic.
> 
> This series removes the write-only counters, the skeletal functions 
> used to update them, and cleans up the resulting unused pointers 
> and logic blocks.
> 
> Changes in v2:
> - Expanded the series to include the removal of RX FIFO overflow 
>   logic in hal_com.c.

Please slow down and give people, and tools, a chance to review previous
versions before sending new versions.

Take the time and review changes sent in by others as well while you
wait.  There is no rush here.

thanks,

greg k-h