From nobody Sat Feb 7 16:00:13 2026 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96DB220C490 for ; Wed, 28 Jan 2026 00:40:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769560827; cv=none; b=tYBc+0Uq9WhvvzOslG0pSU+Yv/TCrIgw3qU4E0mEJ8gLWUIkxeP363DTEw3Sla7d7jnJhifFZWv4lKRsKhPUnJfPFCEQmBKI9kToDbCxy5RjP1lPCYxiHDJZCpuvEv9rpN/WrSGiUESx/nt/Gh/Eo6znCPGvj406UGKvcFnOpG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769560827; c=relaxed/simple; bh=pg10IFD9xW4anBBGevy8oZPn/7DCCR1KJZFtMDvNYt4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TqxPtWrdfwMzFfXqWR1vXPBP1fLUP0WJoq9OO6pk9je8lEgx6/rIyqmEpjbshZ5eBvzHR3vvxfzzIce8mbBTICoO7V1G+t/tpTCxkMmRMV9EGpdCNyW/fwpXPKPHcsZ5F4qiDzZxb/ltjcav18smKkuvHjjSB9+dW+Myh34iuv8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y5lDv/Fv; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y5lDv/Fv" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-78fba1a1b1eso6527667b3.1 for ; Tue, 27 Jan 2026 16:40:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769560824; x=1770165624; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rrjnifs8RsgxO4B9HiFkAzePPs7gTMNCcLwx6At5eJ8=; b=Y5lDv/FvWG+F7AE0tAZVy+qeF8MZxQ5NVnpJStXClQHTXLsPKCS80qda5Fac1YQPnw oy2q8MA2yvry/jmMtvCGGGdMlZYfDqwLGBTnc4rCve1AQypFwk4yWzivyOYQAr4DYpdl BaGs8USPnjl/Vvu++JNfSir10u/zZ24gI466AjO7lTOF1tXbpz0hXR23NQWrmDjEBprF GLxAlbERGE61jT/7bxrPzT03QqwO2jQWykcErsLn+vBBEOmKkiaNCOBJ16s41t9zM+dB 2v8Ef6qKFGlBsd9aowEfUqmITHNyklsOzNlTnWvZp4a2sjqYhIqqRbT5VnqUG52gyyHM efUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769560825; x=1770165625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rrjnifs8RsgxO4B9HiFkAzePPs7gTMNCcLwx6At5eJ8=; b=cE4GmMeMvPLbL7yyrv1J818g2XFf7IOmE8o0caKiRuKCRrA1cWWP9beIB/FEUD04eJ 4YMUJVm6LPcOPmaiDoFttGVZzxYf3qYu0w999+IDFAfKBTDIJvo8TpG/HNGbHIN1dcwj m4v7DifOygfd9qN35sBNVk6Uc1vnK5SjFHVxON2SP3cZGCetHR225SD9MOZEVgRSgKPb XOLB5njYPrm8zqDg0co1mLfdfkr7QRSjq1Gkpr7XcwxSSqaq1eaUCrjNem13GerplSAE 4k9vE4Gkj6Oqph971W6ag3SrWBfvPL6mbtb2ftbfC9f5HPsswLqHi9+LbNFS8MCkUCXB XVRA== X-Forwarded-Encrypted: i=1; AJvYcCX9OWzUlPhjz3lG1WWTCBetkmeQ78gB3u+Z3x9KHhqhXd/X7f2YHhvzqO4XiCLvoGxEPYJHRTm961ZSfwg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1hlSp6OzdSmpOWbVEu3WrhFRr+CO+ZYaw89sS+vScibfpnZ/P YGlsqMFbu1cRZwfiP9M+CI+HPR24tXflHL9udtIHO3HZ+SjL90jCWYME X-Gm-Gg: AZuq6aJhDq33K6spe6AbP4/w+bfD2fcbREud407zCtHIbZiEuIxkISdlk1jYAKfyE3R LZ4OAnJRtSMAaHjPhqsSDFGt1uwTJ5t68phJugDfFNr9gMbQKT/S6jvdMefASLuVNP54Vugk2Jz R4w31AGwZ7YZ/xAPBj1OodA9CTEK4T5ocebs+saUdeFYfiV1/CcoFkN79SGbET8Mmhq+RrD5jnp x4xaVbxoRleBAULOIdB8GbPhgO8ibWXxJ6ncYgCNzWKrn9GKiLykonmcVTts+OQ1TLemVEnQZfO k5FEOCCbkk8lR//nlJAnSMnVT8YwNzcrsrXPN4HIjMK94VSJrUdd9MauardNXJU3hXvMjcCtGOU hNLq8euFaUNOZzmIyBYN1qHgADevvFqbZmHZ1oFzaXcYJiZsLsIoMtSIwEKEI+NeV68PKCtFiFz xn+Q== X-Received: by 2002:a05:690c:7308:b0:78c:2c2a:fc53 with SMTP id 00721157ae682-7947ac18466mr29150807b3.15.1769560824588; Tue, 27 Jan 2026 16:40:24 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-794827625d3sm4791867b3.11.2026.01.27.16.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 16:40:24 -0800 (PST) From: Ethan Tidmore To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 1/4] staging: rtl8723bs: remove dead RX info reset logic Date: Tue, 27 Jan 2026 18:40:05 -0600 Message-ID: <20260128004009.51095-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260128004009.51095-1-ethantidmore06@gmail.com> References: <20260128004009.51095-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function rtw_reset_rx_info() and its associated counters in struct debug_priv are used to track AMPDU and management frame statistics that are never read by the driver. Remove the unused function, the write-only struct members, and the now-unused pdbgpriv/psdpriv pointers in rtw_free_assoc_resources() to clean up the MLME code Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index f81a29cd6a78..411339ebab7e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -819,15 +819,6 @@ static void free_scanqueue(struct mlme_priv *pmlmepriv) spin_unlock_bh(&scan_queue->lock); } =20 -static void rtw_reset_rx_info(struct debug_priv *pdbgpriv) -{ - pdbgpriv->dbg_rx_ampdu_drop_count =3D 0; - pdbgpriv->dbg_rx_ampdu_forced_indicate_count =3D 0; - pdbgpriv->dbg_rx_ampdu_loss_count =3D 0; - pdbgpriv->dbg_rx_dup_mgt_frame_drop_count =3D 0; - pdbgpriv->dbg_rx_ampdu_window_shift_cnt =3D 0; -} - static void find_network(struct adapter *adapter) { struct wlan_network *pwlan =3D NULL; @@ -848,8 +839,6 @@ void rtw_free_assoc_resources(struct adapter *adapter, = int lock_scanned_queue) { struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; struct wlan_network *tgt_network =3D &pmlmepriv->cur_network; - struct dvobj_priv *psdpriv =3D adapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; =20 if (check_fwstate(pmlmepriv, WIFI_STATION_STATE | WIFI_AP_STATE)) { struct sta_info *psta; @@ -874,7 +863,6 @@ void rtw_free_assoc_resources(struct adapter *adapter, = int lock_scanned_queue) if (lock_scanned_queue) adapter->securitypriv.key_mask =3D 0; =20 - rtw_reset_rx_info(pdbgpriv); } =20 /* rtw_indicate_connect: the caller has to lock pmlmepriv->lock */ --=20 2.52.0 From nobody Sat Feb 7 16:00:13 2026 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E82E21019E for ; Wed, 28 Jan 2026 00:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769560827; cv=none; b=mrSdT59fl+7slPrYsnchRjmKn/wxs9HAn1F3Ey8zeU4pTPYVr73rNMXqtivwX+4T5Yyv4yF7191eSjrQBzGT7k1pajtgYiSNaUckrYawQFhkUf1IO5XkMqgYVbNtdOIR4VV8BKsTWTUgUMoDPD2Q3GahSBBRawMz9DiWj3FMVqI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769560827; c=relaxed/simple; bh=MP9dXB0QtlVz5EFY8zq0rqzCjlp6FtqlHmoyAcHdpOk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NrKKxsNLhDadDkfC85462aPdI4pKPFhK9k9nYeaNrzYgpqcyDIlnll81OuTvnK9ZbpH0XMpUWP4GN7AkilZ3ZLBqCy9moSmLAh1pN+zuHrV2uOiTdjWNigOXunkFmvn8B8y+4rUTRbNelXv+QuZih7imldaP0rEJlMaJOhTxpUE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TdKX1K32; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TdKX1K32" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-7947072d0f6so20155837b3.1 for ; Tue, 27 Jan 2026 16:40:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769560825; x=1770165625; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2li4MWATGVuQb49gIaL2/wEm7/uj/Idq/ACN32Jca5M=; b=TdKX1K32Ewf0GYZOqowAmoJERJDNx2HIs2q2cZ2a+ldcxrYNZtPNl9vjmaBt61FZlI Zhpui/ae/MFBl3ryXLIg5WvPBvBOPPEtSojvuB4hU7a+8wgoLoPHg5AKGJjnyudPa44z feZHr3SzfAOk4k4i+L/lNImte01vVz9VqRpfbim/cgBkk+jnHRqCOx73dViT7eZrhKs6 EovKwO4ebJ54kSKCeDl+21dgdtmuxFoGUprph6Tr4KuxeO9z9DqawxUEGiAtlm+dHyQT Dt5+JkjC/852xn+cmnS9k5slQmbS6IXfBt7EN9N/ij/+yzi+4V4EAXtgldDAWVIfVghh AZgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769560825; x=1770165625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2li4MWATGVuQb49gIaL2/wEm7/uj/Idq/ACN32Jca5M=; b=qZebysb/5GuPbmM1wlPHMMeMqQIgUL6QfMT53e9y4lnOk5lze7tPncrmYLFKgzk4nz SsKZWIJBRCDb4LMngDHu9xkk+RbXFKueSRKrCEEcYdptAipbX92kkjqeW/1WVKZm8WNj lWfyJDSCfO9DpzkCb73OL6MM5iFOfHcM4uPo2uqoZ6aYdvk6Ypfk0WRIigSACWcAPZ5L MiAZcCc3TgUjQTl1XQQ0MYuRX4iNVH6FAc95DrzvnWoni2X0XGP/2EkV4Gj5A+BfzHBc HAZ33U0KelnXjzEoIeLWPlBBun72Xkh88in8lrLh34bpsSbPYhvzNRoEcSHraMJeh8mb Ttug== X-Forwarded-Encrypted: i=1; AJvYcCXYvGS0sj/H3KRun/sao4bBRxFdDK65uFLEEJMTzNvKH0t2H2YNcmWpPkQ6SRj7Y8xV9+N8kKBH/n78W4A=@vger.kernel.org X-Gm-Message-State: AOJu0YwRTVxMXndG3Qw/4B7aPvZdKn36uReioBVMB9k74l8/VeCVKUHI ELleo0WL29VFFfTUOjXbkUF98qvvtFFvoOmmk+3vOjS+bkNFilZ9DtFbWATcqg== X-Gm-Gg: AZuq6aIxf9RS8nnAy06lIfed3RB226ra4SBcyRnT9TDgLSlj9jhcRJAqpz4Ec/CEZ+1 7jzw+dHAGn/otPNRAq5xTr0Qb3Edb9xoN6qif5FJNaPyjkYm2rgybl73AIDkvYo4cagV/lRiEFM F9uUgyXwOnj9qhsZhwvwvZU5KzotSulTb6gG1kNd5hYAit5453QC0NLNoW8v3aCHOP4m/23s7IZ S3+D/iKz/7jOqIuTxSIk/5DWcpHIR9JP2pRBTyRoqVe94z37cysAEnfVrh0GXbmwnnQOS7NU9x/ rrB8UisyVnAWfbGrfr7V1lVH6cFHSeKKmQz8MOA6TNR/s26dJX++fNoZ1JmnJUiRODevc4vvf3/ E+GvzK7VulL695dzPNP8XnOR43MufMbKgxYRdS/FaVmn6JB7fwIoTi1zCy4+BP2XPlPM= X-Received: by 2002:a05:690c:dc9:b0:794:2c3d:7947 with SMTP id 00721157ae682-7947ac1857amr33107487b3.38.1769560825272; Tue, 27 Jan 2026 16:40:25 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-794827625d3sm4791867b3.11.2026.01.27.16.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 16:40:24 -0800 (PST) From: Ethan Tidmore To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 2/4] staging: rtl8723bs: remove dead RX FIFO overflow logic Date: Tue, 27 Jan 2026 18:40:06 -0600 Message-ID: <20260128004009.51095-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260128004009.51095-1-ethantidmore06@gmail.com> References: <20260128004009.51095-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function rtw_hal_check_rxfifo_full() populates debug variables in struct debug_priv that are never read. These variables (dbg_rx_fifo_*) are write-only and the function itself is a skeletal implementation. Additionally, remove a redundant hw_init_completed check in the caller rtl8723b_HalDmWatchDog(), as it is already covered by a guard clause. Removing this dead code saves unnecessary I/O cycles and cleans up the driver's internal debug structures. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/hal/hal_com.c | 19 ------------------- drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 7 ------- drivers/staging/rtl8723bs/include/hal_com.h | 1 - 3 files changed, 27 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 70b5b289f9cb..fae251c332d3 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -780,25 +780,6 @@ bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8= *pInt) return true; } =20 -void rtw_hal_check_rxfifo_full(struct adapter *adapter) -{ - struct dvobj_priv *psdpriv =3D adapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; - int save_cnt =3D false; - - /* switch counter to RX fifo */ - rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT+3)|= 0xf0); - save_cnt =3D true; - /* todo: other chips */ - - if (save_cnt) { - /* rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT= +3)|0xa0); */ - pdbgpriv->dbg_rx_fifo_last_overflow =3D pdbgpriv->dbg_rx_fifo_curr_overf= low; - pdbgpriv->dbg_rx_fifo_curr_overflow =3D rtw_read16(adapter, REG_RXERR_RP= T); - pdbgpriv->dbg_rx_fifo_diff_overflow =3D pdbgpriv->dbg_rx_fifo_curr_overf= low-pdbgpriv->dbg_rx_fifo_last_overflow; - } -} - static u32 Array_kfreemap[] =3D { 0xf8, 0xe, 0xf6, 0xc, diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/= rtl8723bs/hal/rtl8723b_dm.c index 928226679ab4..3e1ec33fe829 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c @@ -137,13 +137,6 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter) fw_current_in_ps_mode =3D adapter_to_pwrctl(Adapter)->fw_current_in_ps_mo= de; rtw_hal_get_hwreg(Adapter, HW_VAR_FWLPS_RF_ON, (u8 *)(&bFwPSAwake)); =20 - if ( - (hw_init_completed =3D=3D true) && - ((!fw_current_in_ps_mode) && bFwPSAwake) - ) { - rtw_hal_check_rxfifo_full(Adapter); - } - /* ODM */ if (hw_init_completed =3D=3D true) { u8 bLinked =3D false; diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/= rtl8723bs/include/hal_com.h index 74d6c892c401..24e7fd8ee4dc 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -136,7 +136,6 @@ void rtw_hal_update_sta_rate_mask(struct adapter *padap= ter, struct sta_info *pst =20 void SetHwReg(struct adapter *padapter, u8 variable, u8 *val); void GetHwReg(struct adapter *padapter, u8 variable, u8 *val); -void rtw_hal_check_rxfifo_full(struct adapter *adapter); =20 u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable, void *value); --=20 2.52.0 From nobody Sat Feb 7 16:00:13 2026 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 161D921423C for ; Wed, 28 Jan 2026 00:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769560828; cv=none; b=EW9QRjYdODeQvNtcl9EEhyGquEdaegbmIJKnGeMpwJzZgwe1qzDGfs+O4OeOJ5vkzJ/V/cl7PkZjm8hncuE0DUz31UCLhNRBfTEg7jgVWxswBcOsI5xlauYZn8wVgYLcOxnwugVgN5SmiRaMe1YqmKiVS42dfJ3V9epnUVpRxxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769560828; c=relaxed/simple; bh=tL/wQ3w50xZUcCVSNUiUlEs+YdKe8EgtJihMrXX7ylQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ssANUurL850LFGRh3E6fbX4FqbvpTpn4WkwgPtkMDAIV2duVbBY+vAqaNcmp+VGnMWc8l6MZI7klAwRRH2LrXf2hAShQ+YPCW86vTLKmc4OOloB5zIRZ0oB53WSJgm/ySB4nugEs6/fujKErH4hbbRAocNNRogbVmDNmDL01CAs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l1uL/vui; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l1uL/vui" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-79472374371so13367007b3.0 for ; Tue, 27 Jan 2026 16:40:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769560826; x=1770165626; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MCz5fhHGNzoQjNWokMKF0CEanvAxqViLRBCIm5sjxKU=; b=l1uL/vuivS4Fa0fCVa67CwOJ4eanmNifgCGDZRgLWvasX7monGeDmfd7p+2JhLbF3a z5ye1B4QPj1wpPZw4OMNvYXdsvZ4FpmLAKz7y/0yVNCiwIubE2ErMQnIsC/uS6IFjsP3 40tNDa0bv7SItcB90YZnTWElUtEd84ocyPB9TvCNt6I3l1yk9HIGYB+4INxmtC9/NyJL B7Lb0Q3mtNMuOm6toeJPYtTD6T5DanhDLnkHqIgAjp8J6alHM93s4yQfT7E1/O+KFfmP TcQfk1LOfhtklTaNscLU+xdG85FC46dn6jeI4sUvQzqIJg4a7uBRaI/w+pqQxaDmkO+j Ktkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769560826; x=1770165626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MCz5fhHGNzoQjNWokMKF0CEanvAxqViLRBCIm5sjxKU=; b=k1qINQY4PH9doM+QnBOkB5GKAqmHZehKelwokAWyQPXhHaKEEKRX8DpaSD50vo/VyS /BMC4SfryWr+exeOHKMRT7XtFrSNUPAFBWx7OlcH6TwRx7Zm5JEZoFrWrooSFVXgFIz/ kaugHZ3S0DmHt5iEmv7DvWGuB3HCeSHmOw6LlD1s9/9Lum+yQmWAZEKLUdSlDx1EnILV YVeeMu+KbrD1H/NwFyv5y1b6/hCbr5MciZtfx+Ls1GaocFnH0aUzQoMIac+nZb3X7h6D 7i07aSo5I06Hcy9bHVtX2Mnjd1w/p510Nyj2ad2KmpKLG1NlhmQ8Jftfr+O6vgSMljak sZrg== X-Forwarded-Encrypted: i=1; AJvYcCV3ySR5nBZwo69c6ZWu6rAiPDYdIYECTYYf9MAHdlsoJegF6tWP0szYhikGhfa2dR9zowMGj9hiIjQ/8Qw=@vger.kernel.org X-Gm-Message-State: AOJu0YydiEJIwdB7XV6hEix3d6dycTmyG1pmdoX3iwn6Zw2ONXrAP/9b bmmbkwjlyf6qdH/J9TNn3LBQh7oJjFmeXZrbWPQ02CRTQXJa5fCgszNo X-Gm-Gg: AZuq6aI1VIXGWkHMo5DrplHBCOUlTFasYsrmSEcRqTg7ghfib9sK4HtBruC67qv5557 vp3gyZyWRBp4yvR3Wfxglcy4y7MmMTwJBpPHdidF8SFQOA8ErFtLfIv3DIp8NGu7w09BhF/uGMa TfXrQjC3PVflY0uwYkySv5A2T12OocFJmtz1CKmy/bZ4MZel8qcc2NG6/ViAF83fG2+g18+YRWr rddVoaOPcGW9D6znz2atyviPdH4IfdPKb+wUkPL6hHbCoFI1iyGibT2RryDh+H3rtkY3VtF0Aq3 WleOBfW5wakjxGvLbjwOXXBpVIQK6c/ONHAbF+OQ21ZKXr0XdzgG4xLbQWmT/fkA9eXeZDJxeSK LT7QdmCRXXdhK1b2UISXCibf5/z4BEECU2347dudcPLsYnt/t/FTCB70IT/bgoaoQdJk= X-Received: by 2002:a05:690c:e3c7:b0:794:1ab3:3e6f with SMTP id 00721157ae682-7947ab71beamr27954627b3.31.1769560826001; Tue, 27 Jan 2026 16:40:26 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-794827625d3sm4791867b3.11.2026.01.27.16.40.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 16:40:25 -0800 (PST) From: Ethan Tidmore To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 3/4] staging: rtl8723bs: remove dead RX sequence logic Date: Tue, 27 Jan 2026 18:40:07 -0600 Message-ID: <20260128004009.51095-4-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260128004009.51095-1-ethantidmore06@gmail.com> References: <20260128004009.51095-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function recv_indicatepkts_pkt_loss_cnt() is used to calculate values for dbg_rx_ampdu_loss_count, but this variable is never used anywhere in the driver. Remove the function and its call site. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/core/rtw_recv.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index 24cc4a9e0445..cc824427f9a8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -1861,15 +1861,6 @@ static int enqueue_reorder_recvframe(struct recv_reo= rder_ctrl *preorder_ctrl, un =20 } =20 -static void recv_indicatepkts_pkt_loss_cnt(struct debug_priv *pdbgpriv, u6= 4 prev_seq, u64 current_seq) -{ - if (current_seq < prev_seq) - pdbgpriv->dbg_rx_ampdu_loss_count +=3D (4096 + current_seq - prev_seq); - else - pdbgpriv->dbg_rx_ampdu_loss_count +=3D (current_seq - prev_seq); - -} - static int rtw_recv_indicatepkt(struct adapter *padapter, union recv_frame= *precv_frame) { struct recv_priv *precvpriv; @@ -1937,7 +1928,6 @@ static int recv_indicatepkts_in_order(struct adapter = *padapter, struct recv_reor prframe =3D (union recv_frame *)plist; pattrib =3D &prframe->u.hdr.attrib; =20 - recv_indicatepkts_pkt_loss_cnt(pdbgpriv, preorder_ctrl->indicate_seq, pa= ttrib->seq_num); preorder_ctrl->indicate_seq =3D pattrib->seq_num; =20 } --=20 2.52.0 From nobody Sat Feb 7 16:00:13 2026 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0042192EE for ; Wed, 28 Jan 2026 00:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769560829; cv=none; b=lrtwe/Czrkv2tOb4eYjNMiqf72eSi8BX/4tYphKdx9oYsHQSMQ0FlC7+PRc0rDGrx0ylgHMrjedb7nkaPmTXfTLQNhWZtyrCJbWi0QOZg1jcUHKJ0JtqPAhsaCklyryU4KwjG6CJCOeO63qMvrhXOrcdL0xBsQoQKszb9UFYNoY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769560829; c=relaxed/simple; bh=EDN0QGTFDvm8ggC9Q6gvIRT036y5U8fQ0O9YIfrFmi8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tTnPv39j9SVnAyMHbCWa7Ob2DdKxxRwy+g9xv2gg7PeCjBIDopTzbsUvXVkYPDlWIliyv0/UXcFJi6dE+tJJxVqDjQtrj1RxhZh2toYYK41tDvFrYJjk9l0tgQZkoNu67t/ZmrM93/tjY2JQMtdvB/g+8Z7eEJMQXQG8buoAppI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H1E/t3Z7; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H1E/t3Z7" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-7927b1620ddso7061167b3.0 for ; Tue, 27 Jan 2026 16:40:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769560827; x=1770165627; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HCQDQqxS7QhTVFDcAi3eDL0L7CLRtmR3GtbKlv50k3U=; b=H1E/t3Z7U8pcJa6OcBwCLXkdZFr0q8J0l3/E9bXRKXAp2ePZ/g5Upxq1gPgcZ1FO9g x82mA0j6XfIzOLRVjU7FS3SaacUpvmlLhcQzl4v71EISloKWh1avDafzDzbw+LzLO1HB yjb2J1sz5BS+wCztoaow83IORxp+f9qvnIXKeTofETL8AcoViXxRRZGzaM/RksoiEodi tG8OXMk8R+gc532MOEbzW9VvYj9kReHhIiTqOFntiyMGAinHTQoH3O6W2QB1R0OaEGoa J6wIeYAzfJNK0gRAKcr+CADED7aOMkHJ6ICy0CntrleSwmk9C5T/Wv8E7gqg0Hr6Vih/ Bn4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769560827; x=1770165627; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HCQDQqxS7QhTVFDcAi3eDL0L7CLRtmR3GtbKlv50k3U=; b=wJGGeeQZHciJz2VVF3NEfGJrXQiVeOYtKCxAK1wfXg2405jP08yserEWPJXGRJU0dk RnTHYYxDgICiEhC6jMYlm0+PaFaQu3QZ3RIxEO4Fp3MOmYE6d75VADSE2oE+3RtWvZH7 bFcmuNNhMVOkU6Vq6rmAkJGQIqibJQgJOUCoJhDr2JwaGc2jRtC3Sk87hb3GCcs+NE+o mrlYPgRyx62xr70twEmW/QJDHoqhUcmWt61XiQnYDZBsRzkpRLhaqApYivJG2wa0n3ok 4W+jmgajEO8QDyCReuKuFAZYBJ0f2tJWE+9m36qnLKxVS5QEBXiMerykqI2wY335fOcZ o/5w== X-Forwarded-Encrypted: i=1; AJvYcCX5plrd2ZXNdFtbQva3IJIBItr+r8POnqcS0RnVj3NITpzN34MhxoBI54nmzFmlFcIqWaCaxBlcKAeEQ/I=@vger.kernel.org X-Gm-Message-State: AOJu0YxDBl8YUUj5GpHVBwkFW3VnKPdV4E7ZnI295DXaMGwOb+nxA8ly yqZp0jAf9tOqlFHdnWlyYxFl/WnpMxWi6q/yrWyzz5/BNCX3xtlwzLD4 X-Gm-Gg: AZuq6aL3AYbcIC1JgWUJPxKax5mTcgAMaRdf1QwGDDI9EG3WxyZVliMDNgS+gVVhB5y Og+yBdjEs192sXo4bVDup9uWtfODkN37gnXgGOt3FNDyV5V+raQOK+3ieVJ/QN8ZmMD4dncRpuc +VcPLJ9ATn0lk48Yzq9CmheTz5QyRBNYPoAMyNYSiGwREo9Fm/9JKUjz8KcUebq69ibDxUs+ZeO LVREhfuM0mKR5rRf5k5sVo5H7CWMZkEGYSuvJv6MpWJmWAVkLbQqxSGeUicvX1ibopFZ6vem/hh ZTOrJKPnFRegbTOXWI//Omllrtjt+G1/nziM7ulFV7aUS9Y91KPlCBeSFgnWtsAw0+8EBL7JKQB Ks9i0K8R/yV5hMwDkxg2qsrfqgW7rIH7Cribag/iMK+445jBmlVF1/4pXxVdVruolfZk= X-Received: by 2002:a05:690c:6607:b0:794:1b2f:cc90 with SMTP id 00721157ae682-7947abd2f37mr30076637b3.2.1769560826763; Tue, 27 Jan 2026 16:40:26 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-794827625d3sm4791867b3.11.2026.01.27.16.40.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 16:40:26 -0800 (PST) From: Ethan Tidmore To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 4/4] staging: rtl8723bs: remove unused struct debug_priv and all counters Date: Tue, 27 Jan 2026 18:40:08 -0600 Message-ID: <20260128004009.51095-5-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260128004009.51095-1-ethantidmore06@gmail.com> References: <20260128004009.51095-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The struct debug_priv is a collection of diagnostic counters that are updated throughout the driver's hot paths (RX/TX, MLME, Power Control, and SDIO) but are never read, exposed via debugfs, or used for logic. This cleanup removes: - The entire struct debug_priv definition and its instance in dvobj_priv. - All write-only counter increments across the core, hal, and os_dep. - Unused local pointers (psdpriv, pdbgpriv) that were only serving the dead diagnostic logic. - Redundant logic blocks that only existed to update these counters. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 -- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 6 +-- drivers/staging/rtl8723bs/core/rtw_recv.c | 13 +---- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 -- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 8 +--- drivers/staging/rtl8723bs/include/drv_types.h | 41 ---------------- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 14 ++---- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 48 +++++-------------- 8 files changed, 17 insertions(+), 120 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index fa1e3ad59254..f4b50bfdb9d5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -438,8 +438,6 @@ void mgt_dispatcher(struct adapter *padapter, union rec= v_frame *precv_frame) struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; u8 *pframe =3D precv_frame->u.hdr.rx_data; struct sta_info *psta =3D rtw_get_stainfo(&padapter->stapriv, GetAddr2Ptr= (pframe)); - struct dvobj_priv *psdpriv =3D padapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; =20 if (GetFrameType(pframe) !=3D WIFI_MGT_TYPE) return; @@ -463,7 +461,6 @@ void mgt_dispatcher(struct adapter *padapter, union rec= v_frame *precv_frame) if (GetRetry(pframe)) { if (precv_frame->u.hdr.attrib.seq_num =3D=3D psta->RxMgmtFrameSeqNum) { /* drop the duplicate management frame */ - pdbgpriv->dbg_rx_dup_mgt_frame_drop_count++; return; } } diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging= /rtl8723bs/core/rtw_pwrctrl.c index 0ef788abf403..f06d8bc6dac5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -139,8 +139,6 @@ static bool rtw_pwr_unassociated_idle(struct adapter *a= dapter) void rtw_ps_processor(struct adapter *padapter) { struct pwrctrl_priv *pwrpriv =3D adapter_to_pwrctl(padapter); - struct dvobj_priv *psdpriv =3D padapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; u32 ps_deny =3D 0; =20 mutex_lock(&adapter_to_pwrctl(padapter)->lock); @@ -149,10 +147,8 @@ void rtw_ps_processor(struct adapter *padapter) if (ps_deny !=3D 0) goto exit; =20 - if (pwrpriv->bInSuspend) {/* system suspend or autosuspend */ - pdbgpriv->dbg_ps_insuspend_cnt++; + if (pwrpriv->bInSuspend) return; - } =20 pwrpriv->ps_processing =3D true; =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index cc824427f9a8..409dab008a1d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -1782,9 +1782,6 @@ static int amsdu_to_msdu(struct adapter *padapter, un= ion recv_frame *prframe) =20 static int check_indicate_seq(struct recv_reorder_ctrl *preorder_ctrl, u16= seq_num) { - struct adapter *padapter =3D preorder_ctrl->padapter; - struct dvobj_priv *psdpriv =3D padapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; u8 wsize =3D preorder_ctrl->wsize_b; u16 wend =3D (preorder_ctrl->indicate_seq + wsize - 1) % 4096u; =20 @@ -1810,7 +1807,6 @@ static int check_indicate_seq(struct recv_reorder_ctr= l *preorder_ctrl, u16 seq_n preorder_ctrl->indicate_seq =3D seq_num + 1 - wsize; else preorder_ctrl->indicate_seq =3D 0xFFF - (wsize - (seq_num + 1)) + 1; - pdbgpriv->dbg_rx_ampdu_window_shift_cnt++; } =20 return true; @@ -1907,8 +1903,6 @@ static int recv_indicatepkts_in_order(struct adapter = *padapter, struct recv_reor int bPktInBuf =3D false; struct recv_priv *precvpriv =3D &padapter->recvpriv; struct __queue *ppending_recvframe_queue =3D &preorder_ctrl->pending_recv= frame_queue; - struct dvobj_priv *psdpriv =3D padapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; =20 /* spin_lock_irqsave(&ppending_recvframe_queue->lock, irql); */ /* spin_lock(&ppending_recvframe_queue->lock); */ @@ -1918,7 +1912,6 @@ static int recv_indicatepkts_in_order(struct adapter = *padapter, struct recv_reor =20 /* Handling some condition for forced indicate case. */ if (bforced =3D=3D true) { - pdbgpriv->dbg_rx_ampdu_forced_indicate_count++; if (list_empty(phead)) { /* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */ /* spin_unlock(&ppending_recvframe_queue->lock); */ @@ -1988,8 +1981,6 @@ static int recv_indicatepkt_reorder(struct adapter *p= adapter, union recv_frame * struct rx_pkt_attrib *pattrib =3D &prframe->u.hdr.attrib; struct recv_reorder_ctrl *preorder_ctrl =3D prframe->u.hdr.preorder_ctrl; struct __queue *ppending_recvframe_queue =3D &preorder_ctrl->pending_recv= frame_queue; - struct dvobj_priv *psdpriv =3D padapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; =20 if (!pattrib->amsdu) { /* s1. */ @@ -2032,10 +2023,8 @@ static int recv_indicatepkt_reorder(struct adapter *= padapter, union recv_frame * spin_lock_bh(&ppending_recvframe_queue->lock); =20 /* s2. check if winstart_b(indicate_seq) needs to been updated */ - if (!check_indicate_seq(preorder_ctrl, pattrib->seq_num)) { - pdbgpriv->dbg_rx_ampdu_drop_count++; + if (!check_indicate_seq(preorder_ctrl, pattrib->seq_num)) goto _err_exit; - } =20 =20 /* s3. Insert all packet into Reorder Queue to maintain its ordering. */ diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 054e2c2eab02..0527f36c6bfa 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -304,8 +304,6 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter,= bool bUsedWoWLANFw) const struct firmware *fw; struct device *device =3D dvobj_to_dev(padapter->dvobj); u8 *fwfilepath; - struct dvobj_priv *psdpriv =3D padapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; u8 tmp_ps; =20 pFirmware =3D kzalloc(sizeof(struct rt_firmware), GFP_KERNEL); @@ -324,8 +322,6 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter,= bool bUsedWoWLANFw) /* 2. read power_state =3D 0xA0[1:0] */ tmp_ps =3D rtw_read8(padapter, 0xa0); tmp_ps &=3D 0x03; - if (tmp_ps !=3D 0x01) - pdbgpriv->dbg_downloadfw_pwr_state_cnt++; =20 fwfilepath =3D "rtlwifi/rtl8723bs_nic.bin"; =20 diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..a3940b61e177 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -886,9 +886,6 @@ static void CardDisableRTL8723BSdio(struct adapter *pad= apter) =20 u32 rtl8723bs_hal_deinit(struct adapter *padapter) { - struct dvobj_priv *psdpriv =3D padapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; - if (padapter->hw_init_completed) { if (adapter_to_pwrctl(padapter)->bips_processing) { if (padapter->netif_up) { @@ -921,18 +918,15 @@ u32 rtl8723bs_hal_deinit(struct adapter *padapter) adapter_to_pwrctl(padapter)->pre_ips_type =3D 0; =20 } else { - pdbgpriv->dbg_carddisable_cnt++; CardDisableRTL8723BSdio(padapter); =20 adapter_to_pwrctl(padapter)->pre_ips_type =3D 1; } =20 } else { - pdbgpriv->dbg_carddisable_cnt++; CardDisableRTL8723BSdio(padapter); } - } else - pdbgpriv->dbg_deinit_fail_cnt++; + } =20 return _SUCCESS; } diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index f86180dc350c..d07f04d51e55 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -177,45 +177,6 @@ struct registry_priv { #define GET_IFACE_NUMS(padapter) (((struct adapter *)padapter)->dvobj->ifa= ce_nums) #define GET_ADAPTER(padapter, iface_id) (((struct adapter *)padapter)->dvo= bj->padapters[iface_id]) =20 -struct debug_priv { - u32 dbg_sdio_free_irq_error_cnt; - u32 dbg_sdio_alloc_irq_error_cnt; - u32 dbg_sdio_free_irq_cnt; - u32 dbg_sdio_alloc_irq_cnt; - u32 dbg_sdio_deinit_error_cnt; - u32 dbg_sdio_init_error_cnt; - u32 dbg_suspend_error_cnt; - u32 dbg_suspend_cnt; - u32 dbg_resume_cnt; - u32 dbg_resume_error_cnt; - u32 dbg_deinit_fail_cnt; - u32 dbg_carddisable_cnt; - u32 dbg_carddisable_error_cnt; - u32 dbg_ps_insuspend_cnt; - u32 dbg_dev_unload_inIPS_cnt; - u32 dbg_wow_leave_ps_fail_cnt; - u32 dbg_scan_pwr_state_cnt; - u32 dbg_downloadfw_pwr_state_cnt; - u32 dbg_fw_read_ps_state_fail_cnt; - u32 dbg_leave_ips_fail_cnt; - u32 dbg_leave_lps_fail_cnt; - u32 dbg_h2c_leave32k_fail_cnt; - u32 dbg_diswow_dload_fw_fail_cnt; - u32 dbg_enwow_dload_fw_fail_cnt; - u32 dbg_ips_drvopen_fail_cnt; - u32 dbg_poll_fail_cnt; - u32 dbg_rpwm_toggle_cnt; - u32 dbg_rpwm_timeout_fail_cnt; - u64 dbg_rx_fifo_last_overflow; - u64 dbg_rx_fifo_curr_overflow; - u64 dbg_rx_fifo_diff_overflow; - u64 dbg_rx_ampdu_drop_count; - u64 dbg_rx_ampdu_forced_indicate_count; - u64 dbg_rx_ampdu_loss_count; - u64 dbg_rx_dup_mgt_frame_drop_count; - u64 dbg_rx_ampdu_window_shift_cnt; -}; - struct rtw_traffic_statistics { /* tx statistics */ u64 tx_bytes; @@ -251,8 +212,6 @@ struct dvobj_priv { =20 s32 processing_dev_remove; =20 - struct debug_priv drv_dbg; - /* for local/global synchronization */ /* */ spinlock_t lock; diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index bc02db13781c..fd47f324a8bc 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -964,8 +964,6 @@ void rtw_ndev_destructor(struct net_device *ndev) void rtw_dev_unload(struct adapter *padapter) { struct pwrctrl_priv *pwrctl =3D adapter_to_pwrctl(padapter); - struct dvobj_priv *pobjpriv =3D padapter->dvobj; - struct debug_priv *pdbgpriv =3D &pobjpriv->drv_dbg; struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; u8 cnt =3D 0; =20 @@ -994,7 +992,6 @@ void rtw_dev_unload(struct adapter *padapter) /* check HW status and SW state */ netdev_dbg(padapter->pnetdev, "%s: driver in IPS-FWLPS\n", __func__); - pdbgpriv->dbg_dev_unload_inIPS_cnt++; LeaveAllPowerSaveMode(padapter); } else { netdev_dbg(padapter->pnetdev, @@ -1077,24 +1074,21 @@ static void rtw_suspend_normal(struct adapter *pada= pter) void rtw_suspend_common(struct adapter *padapter) { struct dvobj_priv *psdpriv =3D padapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; struct pwrctrl_priv *pwrpriv =3D dvobj_to_pwrctl(psdpriv); struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 unsigned long start_time =3D jiffies; =20 netdev_dbg(padapter->pnetdev, " suspend start\n"); - pdbgpriv->dbg_suspend_cnt++; =20 pwrpriv->bInSuspend =3D true; =20 while (pwrpriv->bips_processing) msleep(1); =20 - if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpris= eRemoved)) { - pdbgpriv->dbg_suspend_error_cnt++; + if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpris= eRemoved)) return; - } + rtw_ps_deny(padapter, PS_DENY_SUSPEND); =20 rtw_cancel_all_timer(padapter); @@ -1123,7 +1117,6 @@ static int rtw_resume_process_normal(struct adapter *= padapter) struct pwrctrl_priv *pwrpriv; struct mlme_priv *pmlmepriv; struct dvobj_priv *psdpriv; - struct debug_priv *pdbgpriv; =20 int ret =3D _SUCCESS; =20 @@ -1136,7 +1129,7 @@ static int rtw_resume_process_normal(struct adapter *= padapter) pwrpriv =3D adapter_to_pwrctl(padapter); pmlmepriv =3D &padapter->mlmepriv; psdpriv =3D padapter->dvobj; - pdbgpriv =3D &psdpriv->drv_dbg; + /* interface init */ /* if (sdio_init(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) { @@ -1155,7 +1148,6 @@ static int rtw_resume_process_normal(struct adapter *= padapter) =20 if (pm_netdev_open(pnetdev, true) !=3D 0) { ret =3D -1; - pdbgpriv->dbg_resume_error_cnt++; goto exit; } =20 diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index dc787954126f..a86252ccac76 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -70,13 +70,10 @@ static int sdio_alloc_irq(struct dvobj_priv *dvobj) sdio_claim_host(func); =20 err =3D sdio_claim_irq(func, &sd_sync_int_hdl); - if (err) { - dvobj->drv_dbg.dbg_sdio_alloc_irq_error_cnt++; + if (err) netdev_crit(dvobj->if1->pnetdev, "%s: sdio_claim_irq FAIL(%d)!\n", __fun= c__, err); - } else { - dvobj->drv_dbg.dbg_sdio_alloc_irq_cnt++; + else dvobj->irq_alloc =3D 1; - } =20 sdio_release_host(func); =20 @@ -97,12 +94,10 @@ static void sdio_free_irq(struct dvobj_priv *dvobj) sdio_claim_host(func); err =3D sdio_release_irq(func); if (err) { - dvobj->drv_dbg.dbg_sdio_free_irq_error_cnt++; netdev_err(dvobj->if1->pnetdev, "%s: sdio_release_irq FAIL(%d)!\n", __func__, err); - } else - dvobj->drv_dbg.dbg_sdio_free_irq_cnt++; + } sdio_release_host(func); } dvobj->irq_alloc =3D 0; @@ -122,16 +117,13 @@ static u32 sdio_init(struct dvobj_priv *dvobj) sdio_claim_host(func); =20 err =3D sdio_enable_func(func); - if (err) { - dvobj->drv_dbg.dbg_sdio_init_error_cnt++; + if (err) goto release; - } =20 err =3D sdio_set_block_size(func, 512); - if (err) { - dvobj->drv_dbg.dbg_sdio_init_error_cnt++; + if (err) goto release; - } + psdio_data->block_transfer_len =3D 512; psdio_data->tx_block_mode =3D 1; psdio_data->rx_block_mode =3D 1; @@ -147,23 +139,15 @@ static u32 sdio_init(struct dvobj_priv *dvobj) static void sdio_deinit(struct dvobj_priv *dvobj) { struct sdio_func *func; - int err; =20 func =3D dvobj->intf_data.func; =20 if (func) { sdio_claim_host(func); - err =3D sdio_disable_func(func); - if (err) - dvobj->drv_dbg.dbg_sdio_deinit_error_cnt++; + sdio_disable_func(func); =20 - if (dvobj->irq_alloc) { - err =3D sdio_release_irq(func); - if (err) - dvobj->drv_dbg.dbg_sdio_free_irq_error_cnt++; - else - dvobj->drv_dbg.dbg_sdio_free_irq_cnt++; - } + if (dvobj->irq_alloc) + sdio_release_irq(func); =20 sdio_release_host(func); } @@ -434,15 +418,12 @@ static int rtw_sdio_suspend(struct device *dev) struct dvobj_priv *psdpriv =3D sdio_get_drvdata(func); struct pwrctrl_priv *pwrpriv =3D dvobj_to_pwrctl(psdpriv); struct adapter *padapter =3D psdpriv->if1; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; =20 if (padapter->bDriverStopped) return 0; =20 - if (pwrpriv->bInSuspend) { - pdbgpriv->dbg_suspend_error_cnt++; + if (pwrpriv->bInSuspend) return 0; - } =20 rtw_suspend_common(padapter); =20 @@ -452,13 +433,9 @@ static int rtw_sdio_suspend(struct device *dev) static int rtw_resume_process(struct adapter *padapter) { struct pwrctrl_priv *pwrpriv =3D adapter_to_pwrctl(padapter); - struct dvobj_priv *psdpriv =3D padapter->dvobj; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; =20 - if (!pwrpriv->bInSuspend) { - pdbgpriv->dbg_resume_error_cnt++; + if (!pwrpriv->bInSuspend) return -1; - } =20 return rtw_resume_common(padapter); } @@ -470,9 +447,6 @@ static int rtw_sdio_resume(struct device *dev) struct adapter *padapter =3D psdpriv->if1; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; int ret =3D 0; - struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; - - pdbgpriv->dbg_resume_cnt++; =20 ret =3D rtw_resume_process(padapter); =20 --=20 2.52.0