pinctrl: meson: amlogic-a4: Fix device node reference leak in bank helpers

[PATCH] pinctrl: meson: amlogic-a4: Fix device node reference leak in bank helpers

Posted by Felix Gu 1 week, 3 days ago

of_parse_phandle_with_fixed_args() increments the reference count of the
returned device node, so it must be explicitly released using
of_node_put() after use.

Fix the reference leak in aml_bank_pins() and aml_bank_number() by
adding the missing of_node_put() calls.

Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
 drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
index ded7b218e2ec..40542edd557e 100644
--- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
+++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
@@ -725,8 +725,9 @@ static u32 aml_bank_pins(struct device_node *np)
 	if (of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3,
 					     0, &of_args))
 		return 0;
-	else
-		return of_args.args[2];
+
+	of_node_put(of_args.np);
+	return of_args.args[2];
 }
 
 static int aml_bank_number(struct device_node *np)
@@ -736,8 +737,9 @@ static int aml_bank_number(struct device_node *np)
 	if (of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3,
 					     0, &of_args))
 		return -EINVAL;
-	else
-		return of_args.args[1] >> 8;
+
+	of_node_put(of_args.np);
+	return of_args.args[1] >> 8;
 }
 
 static unsigned int aml_count_pins(struct device_node *np)

---
base-commit: 615aad0f61e0c7a898184a394dc895c610100d4f
change-id: 20260128-amlogic-0d08ef086c8b

Best regards,
-- 
Felix Gu <ustc.gu@gmail.com>

Re: [PATCH] pinctrl: meson: amlogic-a4: Fix device node reference leak in bank helpers

Posted by Linus Walleij 4 days, 15 hours ago

On Tue, Jan 27, 2026 at 7:23 PM Felix Gu <ustc.gu@gmail.com> wrote:

> of_parse_phandle_with_fixed_args() increments the reference count of the
> returned device node, so it must be explicitly released using
> of_node_put() after use.
>
> Fix the reference leak in aml_bank_pins() and aml_bank_number() by
> adding the missing of_node_put() calls.
>
> Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>

Patch applied!

Yours,
Linus Walleij

Re: [PATCH] pinctrl: meson: amlogic-a4: Fix device node reference leak in bank helpers

Posted by Xianwei Zhao 1 week, 3 days ago

Reviewed-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
On 2026/1/28 02:23, Felix Gu wrote:
> [You don't often get email from ustc.gu@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> [ EXTERNAL EMAIL ]
> 
> of_parse_phandle_with_fixed_args() increments the reference count of the
> returned device node, so it must be explicitly released using
> of_node_put() after use.
> 
> Fix the reference leak in aml_bank_pins() and aml_bank_number() by
> adding the missing of_node_put() calls.
> 
> Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
>   drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> index ded7b218e2ec..40542edd557e 100644
> --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> @@ -725,8 +725,9 @@ static u32 aml_bank_pins(struct device_node *np)
>          if (of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3,
>                                               0, &of_args))
>                  return 0;
> -       else
> -               return of_args.args[2];
> +
> +       of_node_put(of_args.np);
> +       return of_args.args[2];
>   }
> 
>   static int aml_bank_number(struct device_node *np)
> @@ -736,8 +737,9 @@ static int aml_bank_number(struct device_node *np)
>          if (of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3,
>                                               0, &of_args))
>                  return -EINVAL;
> -       else
> -               return of_args.args[1] >> 8;
> +
> +       of_node_put(of_args.np);
> +       return of_args.args[1] >> 8;
>   }
> 
>   static unsigned int aml_count_pins(struct device_node *np)
> 
> ---
> base-commit: 615aad0f61e0c7a898184a394dc895c610100d4f
> change-id: 20260128-amlogic-0d08ef086c8b
> 
> Best regards,
> --
> Felix Gu <ustc.gu@gmail.com>
>