From nobody Sat Feb 7 20:41:07 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 543DF325726 for ; Tue, 27 Jan 2026 18:23:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769538222; cv=none; b=nSbYHhkJLfU9YKrrq3lntDzuH3r/ZKoglXnHDrVcxTEC5X4PhiKeQU/SD7ef2uP5EF4ob8VC5knxRIdj1tf0HGfyc2I3Vot+CLWSHJKx1WCrPrFTxyOjoo9vbO85bALrFrqm6/662z7OH2p2R6PbvzkOMKtk0+N54ZRGWt3of1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769538222; c=relaxed/simple; bh=gzYCg7eQFUgU4V294MJ/J3tLEbmiBq4eX3ZoJFJXYAI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=JMSImsoaQrFzdC30on3l24LcAlLidyWhvKyPvWAPgKmLehBFPOIUh7V1Rbd8H38QoxA1Cw5CDIAf6t/Rcq5Xq2qQMSt56cGQGRne36maOjsOLbZYGYRbZfqeHKL3GQPIm+Szg8+wwXlkIIHZYptYCGaDgMMlKvsVDRhaMfGq12Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Oz1UvdCy; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Oz1UvdCy" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a871c8b171so6219425ad.3 for ; Tue, 27 Jan 2026 10:23:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769538220; x=1770143020; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=cHYljc7F+EOphZrYZwqqhzIU0oWBEMS1jqV+v13KuA4=; b=Oz1UvdCyF3EenR5KV0RfVHjYheo5zba2iRMFf7zEp1rUOymh4uPu5YPVZa6innLSZ3 wlq335W5mR2E3G8z73eqNfLY+IFzdHvpcAc48CtMLy/lEG1NQ2r1kqv49DCH8/w5FIUB CKb+EKTldhx5LOVcSSfLMv+ZOlJ8KNRdo3qiLW7vyRs0iM0jJGpBEQw38xJeKkJizDt/ MMTzEXHIKhk2U8Ti1nXDDWDfjQ+6lyEj5d5LqX9w4CUZU5UakemqEmHoOdgD4ZcriRWX NEvJT5hn6dTCxYMoLE4tGnDxda3FWsLUyKrr4K4XOCzqAzmuiBDPE9emA2p76qxoW7ao /5jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769538220; x=1770143020; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cHYljc7F+EOphZrYZwqqhzIU0oWBEMS1jqV+v13KuA4=; b=CvGKQ4eCrEzxm2ANaq8DGux2m3iZaeVjz8ud907+zrtrKGqp1MCyXR7czE7zalIf5e EAp7feT5570Ki3+VW2LUb5QlHRAJTttJpZu5+dCRhAeRTnXLaOgqUIW1OzqzD7FVTFCj hxb5eriDpH2/dtQ3lXjfCt1WSSAQxMHbTZ2MVYbGJubAZzBHypM0OqA5KKplL3iPQ+ac Gh963YV066Aiw5kkWEO9hibmP0ugiY5NnIPuT99UwY0hc+E0yPjAM90lBTC8lT+cuG0H w1QZwUdj30+ZrLpAdOwpi0nS4FkIlZJcmz4CeFD1/1Aw4bXPVAtupTUiuMkSLk1YguQb l5sw== X-Forwarded-Encrypted: i=1; AJvYcCWal1c9pbYwLxFAVaUAtNL1uYNl9wYgrZTx61Kvl3ETzAODFOGMV6v6bN29GLXWEOAFuGXOjQqNxu2UHU4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1lmdRb8xwP3ZYGUD+Q1GB8/Xf/wkFthL4Uv2CPk7PvWJW9J5R Y5BtP5H+mnKxw4xfVtfHifQ7SFa91byoMEhTM1Si0WfsvVpV/Mae2IDA X-Gm-Gg: AZuq6aKP2Ftnlerpumz5di27DttqaNKoKQYmssd8S8/xhQnOoULFYoqDoT0tLm89GEw 4tI44HB55kAYXxlTEVzasNPIjZhUBXJdOWC/roEwDF3ZRKkRMnIyNoX4bO7yA9JohT4XuSgqDdG +NcYTn0w7BfmQX5fGx1RGcWvoavuYPA95jK9HVpGQCtV1MqUK8y6bHSi7RdehA1A9KrVibTExon 62wwyMyZOmK8tnFExM53WJPaqJO9TjDkJiuSS9nWH2UNMxCW/aQHqQM8hjGBxYM8Sm65nAoI6tX mS9n/pStHSXJYQTncCsvmJhjqa3ITqBHrlpW9vtUG9rIh5Lfu/Fu5veaeDTc0hKD1q3A9Cs30O0 OtQsVgzR0ChDt6kdvw3aa7MiO/tV6Tiv9eoPlxgKUoIMn6bnKbe5gxA1SWceHeXTYc9C4KPfUAN qhYmK6qq+xbQeXr6WO5qdCAxru X-Received: by 2002:a17:903:350d:b0:2a0:34ee:3725 with SMTP id d9443c01a7336-2a870d5a11emr26284835ad.14.1769538220491; Tue, 27 Jan 2026 10:23:40 -0800 (PST) Received: from junjungu-PC.localdomain ([188.253.124.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b413d16sm610135ad.25.2026.01.27.10.23.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 10:23:39 -0800 (PST) From: Felix Gu Date: Wed, 28 Jan 2026 02:23:12 +0800 Subject: [PATCH] pinctrl: meson: amlogic-a4: Fix device node reference leak in bank helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260128-amlogic-v1-1-c8aeb2953dcf@gmail.com> X-B4-Tracking: v=1; b=H4sIAI8CeWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDQyML3cTcnPz0zGRdgxQDi9Q0AwuzZIskJaDqgqLUtMwKsEnRsbW1AJ7 T6qZZAAAA X-Change-ID: 20260128-amlogic-0d08ef086c8b To: Xianwei Zhao , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769538215; l=1586; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=gzYCg7eQFUgU4V294MJ/J3tLEbmiBq4eX3ZoJFJXYAI=; b=Q4t4AtxghLx54Bs7JL9WDYzt2BKTvug6RGwBm9/o2ji5s18HIKqk+SLQR+Uf5ULhZr/nMxqAW rfdWaFvBwCODzsk8RoeQjtM7lb5ct9ZqvdGk9SaGcFLGksgu179QNIQ X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= of_parse_phandle_with_fixed_args() increments the reference count of the returned device node, so it must be explicitly released using of_node_put() after use. Fix the reference leak in aml_bank_pins() and aml_bank_number() by adding the missing of_node_put() calls. Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs") Signed-off-by: Felix Gu Reviewed-by: Xianwei Zhao --- drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/m= eson/pinctrl-amlogic-a4.c index ded7b218e2ec..40542edd557e 100644 --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c @@ -725,8 +725,9 @@ static u32 aml_bank_pins(struct device_node *np) if (of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3, 0, &of_args)) return 0; - else - return of_args.args[2]; + + of_node_put(of_args.np); + return of_args.args[2]; } =20 static int aml_bank_number(struct device_node *np) @@ -736,8 +737,9 @@ static int aml_bank_number(struct device_node *np) if (of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3, 0, &of_args)) return -EINVAL; - else - return of_args.args[1] >> 8; + + of_node_put(of_args.np); + return of_args.args[1] >> 8; } =20 static unsigned int aml_count_pins(struct device_node *np) --- base-commit: 615aad0f61e0c7a898184a394dc895c610100d4f change-id: 20260128-amlogic-0d08ef086c8b Best regards, --=20 Felix Gu