[PATCH] crypto: rng - Use unregister_rngs in register_rngs

Thorsten Blum posted 1 patch 3 hours ago
crypto/rng.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
[PATCH] crypto: rng - Use unregister_rngs in register_rngs
Posted by Thorsten Blum 3 hours ago
Replace the for loop with a call to crypto_unregister_rngs(). Return
'ret' immediately and remove the goto statement to simplify the error
handling code.  No functional changes.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 crypto/rng.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/crypto/rng.c b/crypto/rng.c
index ee1768c5a400..475b6a42d826 100644
--- a/crypto/rng.c
+++ b/crypto/rng.c
@@ -203,17 +203,13 @@ int crypto_register_rngs(struct rng_alg *algs, int count)
 
 	for (i = 0; i < count; i++) {
 		ret = crypto_register_rng(algs + i);
-		if (ret)
-			goto err;
+		if (ret) {
+			crypto_unregister_rngs(algs, i);
+			return ret;
+		}
 	}
 
 	return 0;
-
-err:
-	for (--i; i >= 0; --i)
-		crypto_unregister_rng(algs + i);
-
-	return ret;
 }
 EXPORT_SYMBOL_GPL(crypto_register_rngs);
 
-- 
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4