From nobody Mon Jan 26 22:44:36 2026 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F408C2356D9 for ; Mon, 26 Jan 2026 17:50:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769449850; cv=none; b=UIbKl7wK6nuxGDAlMUINl7ynqEAkPw4xBL8J2o+qdSdIrHfg/uAQuorMbuRFJyWstPiyF2mfyUr10f/fvdaXl0fTyv2f7jjPjAbsjvs3QtB1dAr9Q9fNlGgM6oxQnrtQIAmvXikXzFyU8LAto2ZpMsFzlERIi6QOn0yW1PQlFUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769449850; c=relaxed/simple; bh=SL7/KNDA0aF6p0CwNfieUoCsvRdgyHD+yR8VTxGpO4o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oLJpl6Pu9klVme7fB8NFVHNtuytrK2UyK0kHuHEITnvU1kFshH0qyxx0hJTlr7BtB2UaudCgz0BU6ca+boS2bdQU2PNm9OOh5O3YUDEtLrkL69XoX02vNOWv5pYPq6q9Iqy21rKkxPf08pgnvI07LjugBdSW4iKv43j0OYufbz0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=sH0JvFOW; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="sH0JvFOW" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1769449847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HGQxOYCusMSp/ky1aE6Sp7zrl/h/nHZNCBtArDjwvUA=; b=sH0JvFOWqHxH5X9ZIdDN+yxw8DGmVyy/ZUkP9O4QXl67tVQUDh0MiHXXmkCjXNVmiZcjuP tvB4qZukY1jQNwPQLCFTAiGPCUAaplJjhHSWgqCdfBUmcv+SMNb5FI5ZT5sbus3cvDf6b/ q7uuBc1hF6nrg19qbpjmDgZmNDrXgbk= From: Thorsten Blum To: Neil Horman , Herbert Xu , "David S. Miller" Cc: Thorsten Blum , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: rng - Use unregister_rngs in register_rngs Date: Mon, 26 Jan 2026 18:50:18 +0100 Message-ID: <20260126175018.237812-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Replace the for loop with a call to crypto_unregister_rngs(). Return 'ret' immediately and remove the goto statement to simplify the error handling code. No functional changes. Signed-off-by: Thorsten Blum --- crypto/rng.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/crypto/rng.c b/crypto/rng.c index ee1768c5a400..475b6a42d826 100644 --- a/crypto/rng.c +++ b/crypto/rng.c @@ -203,17 +203,13 @@ int crypto_register_rngs(struct rng_alg *algs, int co= unt) =20 for (i =3D 0; i < count; i++) { ret =3D crypto_register_rng(algs + i); - if (ret) - goto err; + if (ret) { + crypto_unregister_rngs(algs, i); + return ret; + } } =20 return 0; - -err: - for (--i; i >=3D 0; --i) - crypto_unregister_rng(algs + i); - - return ret; } EXPORT_SYMBOL_GPL(crypto_register_rngs); =20 --=20 Thorsten Blum GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4