PCI: dwc: Code clean up and formatting improvements

[PATCH 0/2] PCI: dwc: Code clean up and formatting improvements

Posted by Qiang Yu 2 weeks, 3 days ago

This series contains two cleanup patches for the PCI DWC subsystem that
improve code readability and maintainability without any functional
changes.

The first patch addresses a naming issue where the "has_msi_ctrl" flag
name was misleading. The flag specifically indicates when a platform uses
the iMSI-RX module for MSI handling, rather than having any generic MSI
controller. Renaming it to "uses_imsi_rx" makes the code's intent much
clearer.

The second patch fixes a grammatical error and improves code formatting.

Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
---
Qiang Yu (2):
      PCI: dwc: Fix grammar and formatting in dw_pcie_remove_ext_capability()
      PCI: dwc: Rename has_msi_ctrl to uses_imsi_rx for clarity

 drivers/pci/controller/dwc/pcie-designware-host.c | 16 ++++++++--------
 drivers/pci/controller/dwc/pcie-designware.c      |  3 ++-
 drivers/pci/controller/dwc/pcie-designware.h      |  2 +-
 drivers/pci/controller/dwc/pcie-qcom.c            |  4 ++--
 4 files changed, 13 insertions(+), 12 deletions(-)
---
base-commit: 86291f774fe8524178446cb2c792939640b4970c
change-id: 20260121-remove_cap_clean_up-970b60cf595a

Best regards,
-- 
Qiang Yu <qiang.yu@oss.qualcomm.com>

Re: [PATCH 0/2] PCI: dwc: Code clean up and formatting improvements

Posted by Manivannan Sadhasivam 2 weeks, 2 days ago

On Wed, 21 Jan 2026 23:45:17 -0800, Qiang Yu wrote:
> This series contains two cleanup patches for the PCI DWC subsystem that
> improve code readability and maintainability without any functional
> changes.
> 
> The first patch addresses a naming issue where the "has_msi_ctrl" flag
> name was misleading. The flag specifically indicates when a platform uses
> the iMSI-RX module for MSI handling, rather than having any generic MSI
> controller. Renaming it to "uses_imsi_rx" makes the code's intent much
> clearer.
> 
> [...]

Applied, thanks!

[1/2] PCI: dwc: Fix grammar and formatting in dw_pcie_remove_ext_capability()
      commit: 8a214f64554ce4da91f35e7d3b8eaa9674f5154d
[2/2] PCI: dwc: Rename has_msi_ctrl to uses_imsi_rx for clarity
      commit: 0ecd890e3cf54a0586247b9a384702703277e4fd

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>