From nobody Sun Feb 8 22:00:26 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E749243C042 for ; Thu, 22 Jan 2026 07:45:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769067935; cv=none; b=MLJlsCF2tLoY+CBeS0V1PM6afFevAuc8VPYh/0P5qVV3t19Xv71WOhnABYnXTY2yhLiY12jiLm6ttkvFgU/eu8a4d7267rEz/sdQo1PT5jBAukX6+mhQOybvd9L+KPxRWeWq9bKG0+B64FhL85njPDJCp6BwSKxbwvCV98t3X44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769067935; c=relaxed/simple; bh=OnfAu/AW9rFZ1vLKruBd8Y9wj7Qrr1ILxPEU3yiKVY4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M4Ifr8c9vkAg+pTqJYTXlTcbI5z8MzZeoBKSEZFWQJBgvKBb5dJEA5cWJZG+Ceu1pCKPQeallVnuL6Q3eL97aWRu/SOLnYScuF/8UILbxmr5jxdrIDlbJkf86exeNHuYn8RSGnYUyt4VZySDVQN0UNW8plnGShFyJbaHlpMrnCc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DuIpSdqj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D4U2opxr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DuIpSdqj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D4U2opxr" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60M7OOTS484185 for ; Thu, 22 Jan 2026 07:45:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ARswkDbA8yhSD/2cJfqadeY4khX9O1yiyy3zywvZkvE=; b=DuIpSdqjVU2byTXs 5r0IZFXss3DXWyVz/9fBDkGrXL1paD7SCX55031gumeSIPA4CtxQejve1Yx2s4gR k1r//MClzRZqmdBtIT7/DNRG4KyW69nYGgIU00o2O2plRlJUUgqMXtN6IALhbEva d8LeC6odoWF9Gk7c99gVMj7r8goWMhKNAxw9eVl/fXwtcmRrXyiNoPTmnkaI61nz LlV1MSuTjLgYQ3ONx9uUacd8zIiitu2QSSbHcJRg1c56E/h/JFkCSb8OdYGAIbTE as/LOJBKMIC2dSfT+SuJeBTKsD2WpfA7kS9bwn00xYCCn/pE2rOuT4zRSE+95Np7 htFCCQ== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bu6pj1hrk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 22 Jan 2026 07:45:27 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2b6b9c1249fso1309002eec.1 for ; Wed, 21 Jan 2026 23:45:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769067927; x=1769672727; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ARswkDbA8yhSD/2cJfqadeY4khX9O1yiyy3zywvZkvE=; b=D4U2opxrIeuotygx7wh/5RYm4G/aQbdyxCPsSoBbF/lklGTCEHhMJE77X+UkyIRaE4 5++7Sndu4uisi1GPkqOqWYeLiVoBwuUa5RRp77EzP7SERrpccjiaOo4aUN/Ht6tATRsb CeqWVgVEAjX5PJHbFVmM63Tu4oIbS/tymQR4804IlBmzNuFYJrflyVZdiHQGgfZr4CPK Cojl6ShUy8Y6Q0I0egOPDy1zzH7HEyQ5L+s+nbnZb/6TOdhzpHU8CfXN4S/Nibt6S+ld ppffkbcsa1pEcHGJ8zUmTWHGhm865b55y/DhfeQHLT2VEG+MqG2Mv0Or2IB8OTdsxuXA xbWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769067927; x=1769672727; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ARswkDbA8yhSD/2cJfqadeY4khX9O1yiyy3zywvZkvE=; b=CRUPdH0yq7HzbsymeVvxFEHBD123TkwLQxXAD/ylW5Ekx/mC5J8VNlvm+Qh5EJ46vJ 7UDms1CKx/6v+UHFgFwXMjfZ5JcTc9T19kEeqm5e3JgjWacgN4BDo+WZtVr3K1hz/7Bj ptWUTXeFATjZW+5ZxfaUTP/eYRj4/XB4fQVcykbSM5A9GIOi7ehM4lq4+7rxmLZ3fERk llKNX/7tmVN/fU2vFrsEf4jGr5vo9x6Gx8C5x/oWZ2m+o7ZT1WgvKr+E4BuK9BHIwe88 VW5gq5D7m1cPSOaVMioXExRBg7RlaTDMKiqgmdBlVPrBERgF6ec6aNMlNgcITcKnxMY3 v9zw== X-Forwarded-Encrypted: i=1; AJvYcCV3Fm3iQnkC3+GiWfVfA2fhJ5KnwLPjPLu5eGw5tHDinn/84rbkr+gjdix+SH2ss5nWGQ00TLJO41bQwgc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw56uOUPXFhkKn01Rz09Ay4q7OhPptNib5adMZWuQhJNWpEe6TY Y0Wr+/+J25acqzVSX9jCAKFH9wCrnBDy7qqWlqGRX3E8DdIY1h6UZr+EWazyeYbMYyt/NIqTzWG 8P6FULF9iwD4JYbXMhuQPg6IT+HkERWOdED6CgCA2vpsiwMWhySzE5243E4VsDvJZ8MY= X-Gm-Gg: AZuq6aIog3h3vTWPlKkCB2GiWGM6x4RYYelPfcJ2CbfGyPRmklgJ6XyPRWpSKdXCQo3 Im4gzRtakbtgJaYG82Y7CGbbo8d8CorjVr+dxouWBfxMeasBA65SFdcPYjXz7P3vNozdY+LpKFE uOY9LhNysXkDT7sFoD+gNyWD2QkEhAQnpbfI4RBS/HiAhcNYSBWvphFpSjO/P6DlvX3a27bFoOq jJdImF6kOX27O6BEG7bU9YQu9xHvqEYkZsTB4v1DYcQGGGS5k8vYzC0/H5KgkVn5tNSODjQLqNU XMLH8eMaoF/PfOvWBC6fhFCNYFY2T6u25/hvJCNULzB4iH0tYRpW98bqlbaU/LXdOFRlVSGgwGD 2lG8jcV7uB29zcaa2VJd/uMJ0B0GIbwe4YDFqUYbt+WknXaT27HEQlN1Q X-Received: by 2002:a05:7300:8c14:b0:2a4:3593:c7d9 with SMTP id 5a478bee46e88-2b6b4e8b390mr16756454eec.25.1769067926831; Wed, 21 Jan 2026 23:45:26 -0800 (PST) X-Received: by 2002:a05:7300:8c14:b0:2a4:3593:c7d9 with SMTP id 5a478bee46e88-2b6b4e8b390mr16756440eec.25.1769067926309; Wed, 21 Jan 2026 23:45:26 -0800 (PST) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b36550dfsm24875278eec.25.2026.01.21.23.45.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 23:45:25 -0800 (PST) From: Qiang Yu Date: Wed, 21 Jan 2026 23:45:18 -0800 Subject: [PATCH 1/2] PCI: dwc: Fix grammar and formatting in dw_pcie_remove_ext_capability() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260121-remove_cap_clean_up-v1-1-e78115e5d467@oss.qualcomm.com> References: <20260121-remove_cap_clean_up-v1-0-e78115e5d467@oss.qualcomm.com> In-Reply-To: <20260121-remove_cap_clean_up-v1-0-e78115e5d467@oss.qualcomm.com> To: Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Qiang Yu X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769067924; l=1054; i=qiang.yu@oss.qualcomm.com; s=20250513; h=from:subject:message-id; bh=OnfAu/AW9rFZ1vLKruBd8Y9wj7Qrr1ILxPEU3yiKVY4=; b=0nnXFTMwwb1y/kpr9YhIAJCE29sACTdjKWTFgqjAFquvlCS39T2fxlPSl30koTv/vmjenIIPL AYK+cFs+eRpApnkgviugDQJ1dpL84lPlutCWGk2lGQbMyMbPRF2IOeA X-Developer-Key: i=qiang.yu@oss.qualcomm.com; a=ed25519; pk=Rr94t+fykoieF1ngg/bXxEfr5KoQxeXPtYxM8fBQTAI= X-Authority-Analysis: v=2.4 cv=D8pK6/Rj c=1 sm=1 tr=0 ts=6971d597 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=m7LhmkQuZJo2DZ2u2bkA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIyMDA0OSBTYWx0ZWRfX3zSTDSaVuMWK e38zW6k0afRICML9g0TaLP8ltsUJ2ZTKVnZdAMuxOOfhZPjn+hTP9hFR/CQbi9cJqsimAsZBra3 p8N+0ivJyqB5Y/bwPYDfA4xMaR6WKQ4L7UVb+d6AvRb3Gqmx6xpEsBSNPNi61jW63eX4ChbM7pI zbY5TSMo3UW75OeEyqbVbiv2Dv9DOhnSxkL/AC71b+Cz2oPaWjF7V+cqvbtYo+lFyTojXXWFvZ1 mszKbeELFRGbz/I8CDjUVtzgCp83njsUNNfF85axUE5gVF/ddeVD3Vlvm0sRhVa8VBBv1bYUvtN A2m2V+hdDqXuEEcMJHNgtI96wvZYWhOP7eEuJxMnBzwGKQ5oDw8MCvyJmmHN8fW8xSUWW2YKqrK dCW5xcjpMSUx2aG/B5tXRck0zVbY0e3kT+tCcRewI3FJwQEK+AxkjR1XJ32l9aaMyiFX+yRn6pH Jwglwxb16QgL5w/HqRg== X-Proofpoint-ORIG-GUID: Ks1dUnm4hnGEWA1STRz3ikZJwEMIYGkR X-Proofpoint-GUID: Ks1dUnm4hnGEWA1STRz3ikZJwEMIYGkR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-21_04,2026-01-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 spamscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601220049 Fix a grammatical error in the comment by changing "it's" to "its". Also add a blank line after the variable declaration for better code formatting. Signed-off-by: Qiang Yu Reviewed-by: Shawn Lin --- drivers/pci/controller/dwc/pcie-designware.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/con= troller/dwc/pcie-designware.c index 2fa9f6ee149ed76ee84e8129a47f4bde2fa4d513..18331d9e85be30462277532afa7= 1b5850438f32e 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -268,9 +268,10 @@ void dw_pcie_remove_ext_capability(struct dw_pcie *pci= , u8 cap) return; =20 header =3D dw_pcie_readl_dbi(pci, cap_pos); + /* * If the first cap at offset PCI_CFG_SPACE_SIZE is removed, - * only set it's capid to zero as it cannot be skipped. + * only set its capid to zero as it cannot be skipped. */ if (cap_pos =3D=3D PCI_CFG_SPACE_SIZE) { dw_pcie_dbi_ro_wr_en(pci); --=20 2.34.1 From nobody Sun Feb 8 22:00:26 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F9C5322B7D for ; Thu, 22 Jan 2026 07:45:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769067937; cv=none; b=ENaDRcNCffHQe/rjcw85ehEN5HvXU11nvvkodEXQSCdq2IrXCXIub5AC6jFmzvUHgGUUKisyxkkIUp8Oe3AXHZZOCSopaY8q+DZ4rFCQcLUaeB49pm6wyhcrtFpZD5aeNMOtaRZlHF9PjXqomomzUKtt2UolAD9fiAEnBSXgeuQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769067937; c=relaxed/simple; bh=n2nGPFjnScHpzXJ+RD7+63IUXth3XpnixQPXv9q9I18=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RGVQ7aTDKCoWRfJj3ACzY3B3CrXqveorAHJOFR3zAO6454t0eqq3I0wtEUdeh67avTAiQjgOe0n4YJ8YleE0lv2F4Tkf4DMYNc+HAmA9A8jgFmMf9Akymr/lAhq+F2G5eph9rJR6P9cK+5iq7Eir5LZ5MWB/OixJ8f9NaqTAqbw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o2ZPIGdW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RNoCa10s; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o2ZPIGdW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RNoCa10s" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60LNW7DN646151 for ; Thu, 22 Jan 2026 07:45:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VUN1OBp4kIEhPf3pIRjZb2ZW1SGz8nbeNf69mcSi52o=; b=o2ZPIGdWWOh5dRLv 7f3Mk6xp1LYfwSU/Bzx1MHjmmFC7741Dk0/FETdjVI1fAwaTqFgPweAAzYL9kV3z MwDgJHgGlTfW6pbIqfl66XEL4HrSijkKE+bi8IgaHxxYZqw1rzhjLZaP3tmqtX8N vHyr92xGI/3PZI4A8hIf9fBN7AvoEqetMdlJ/qIWCwPcGDHDu38KTjhqeeFFV7uV Vt4CElpITYXSjquK0V9bf2gokCllI2vKN8BzzbVGj0L0lBUZ+BZjdfDRDlfBaU+x 9MV0Hd4WZtvb09foz/wPRb+A2MOTcXXGNYwO+nKI7QkFJtoPuE/ipR8uTbOHVkgX H7nRXQ== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bu8j9s738-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 22 Jan 2026 07:45:28 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2b6f0b345e3so3885507eec.0 for ; Wed, 21 Jan 2026 23:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769067928; x=1769672728; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VUN1OBp4kIEhPf3pIRjZb2ZW1SGz8nbeNf69mcSi52o=; b=RNoCa10sCZPFZKGa5yH5hkvIKiQ7AxQeEqY0m508rx/82NdJFr/Q+il2kc/S6PWK0s TaZqXOIB1aUoWb7VA0ieW4Jv7diKosw0wgU9hLkYxFk2UCQ08WC/lTi1nkH9rBqdyq0l h5mSa7EtfHjcnkHHe1mAuQQWLD5Dv4Z2ZNR8QASRzybMrml9fJrHfIPqjn5EVJwdryy4 dC0NiS6+xt6urW/vVQrVmbwdVPGgvdLc815iU85mMP9lydCmJmo+x9+UIje9lzN0fHeF etVid4ut7MeSfAO5IorLFKNg5YKB/troIjY8dhYp6kYvWz17CwmuLVGFHIpxIxPUwXKT Gmtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769067928; x=1769672728; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VUN1OBp4kIEhPf3pIRjZb2ZW1SGz8nbeNf69mcSi52o=; b=pXsS6Ya4FxsVa9Uehjh0xEs+/x4zYDM9zEuqM/q7Nghu5ASi8sYPZTjZOophbGxuH1 gv7+mvejTdhcUrO51UC+61Vj/Ch5otuU8wyCjttHtQWC2uzPn7uhKqIL52fpD5cyKx9N puQ5YtBnAw4C62H6HeH+S+kQaQmzAidk4tasa25YYrCfqY1WmArEKQ5CI6s/X2ZrOPMg 5G72FK3i5wm71CX+SZoa7n5CwYxArtFoqi8lqiRAHNqwCQqCPXi3DYYrBHlXSZIa6C3D h51QbC9TnDlARVKJn1DLHe28G0ZARzYdLmbVHzORZUhldsCst20xH7iMOsDnthVSrNV9 60kA== X-Forwarded-Encrypted: i=1; AJvYcCWBIbY8g/m5e3CRdQUsinya/Gg2uWBijl7Fpro7/KYgO/xiadf1guJBgm2wsbMUXAMON/S2uhZrKk/G8Kw=@vger.kernel.org X-Gm-Message-State: AOJu0YzLxey55YHh66nwjMs9kGnETH8V+cIpGmgKd7Qw7F4/4t9wqkXW Yg57VD+NAJWVySbfdmy2KuVvzV4kSxeprg5E0CoiJtIJAahWU1sntIzGOTIqlIlxENm7xJgCqjL 5tH8Y2boqjkIvv1XaQUUDNtI/2Gn4wkNgb1mLzo9SAFHueeKEcmPIViEo8AmklQr3aC4= X-Gm-Gg: AZuq6aIOI3g14n6KcybnHMbWLf1BJYO5pf+NI1uj4LZCKehnlI8Oa/6Q+luhmpdMH8U 8OgCuz4zh/sUKU2Iio+NSOQwqdb+1Ir8I94ES9hrwAmdlkwkjGyjxcDWe6jb8RBr9BkY9nn/Zad 8H1o3tENDtk1GNpmTZgFrfujjHENTR85+i4uIFVlQTjV4ZysUAdDYbweLXzPFTtj4i8u/uT39XE IibrnI06GNCx2azOQsfxSb5KfDV05mNFVpHlo9dBzZnsnCI83PKCS9vjwpCg+WLtEsuDOQ+hM6w RjauLkThAMCvnpg3yI864YVo3Ko9pbJFwmryhsrXg+x4Jek/3Xk/8H0Ft8/gojye9SCo3yP7xtz SF5KderO3Qi3CJRFM819US7HZfydSU2oo01P3oyc6VIsTohUxcOclMyvh X-Received: by 2002:a05:7301:5795:b0:2b7:f7f:69c with SMTP id 5a478bee46e88-2b70f7f0a85mr3659435eec.32.1769067927844; Wed, 21 Jan 2026 23:45:27 -0800 (PST) X-Received: by 2002:a05:7301:5795:b0:2b7:f7f:69c with SMTP id 5a478bee46e88-2b70f7f0a85mr3659410eec.32.1769067927293; Wed, 21 Jan 2026 23:45:27 -0800 (PST) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b36550dfsm24875278eec.25.2026.01.21.23.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 23:45:26 -0800 (PST) From: Qiang Yu Date: Wed, 21 Jan 2026 23:45:19 -0800 Subject: [PATCH 2/2] PCI: dwc: Rename has_msi_ctrl to uses_imsi_rx for clarity Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260121-remove_cap_clean_up-v1-2-e78115e5d467@oss.qualcomm.com> References: <20260121-remove_cap_clean_up-v1-0-e78115e5d467@oss.qualcomm.com> In-Reply-To: <20260121-remove_cap_clean_up-v1-0-e78115e5d467@oss.qualcomm.com> To: Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Qiang Yu X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769067924; l=4649; i=qiang.yu@oss.qualcomm.com; s=20250513; h=from:subject:message-id; bh=n2nGPFjnScHpzXJ+RD7+63IUXth3XpnixQPXv9q9I18=; b=W47RVrStErji2+Pfj0C5yxNiqm9lGH5m0TJCGp0mn1J4BrepbOLorRyhye0BZHdHhc9Ye+mBA a7Twsi/BjaOBqhIeQ3eeNceJHMkN3yw+Z9nid6bpnHI0cXVYioQCQy5 X-Developer-Key: i=qiang.yu@oss.qualcomm.com; a=ed25519; pk=Rr94t+fykoieF1ngg/bXxEfr5KoQxeXPtYxM8fBQTAI= X-Proofpoint-ORIG-GUID: SbvPkAZUAEzuKy8Oj9RIxjkzHuoBfStW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIyMDA1MCBTYWx0ZWRfX8bwgN/PeJAdy S7ia6K/zC5a9n9w/LzditLUs7sxFxSCtqrdLddQj+f2IQC32Gy2TqvD9OcXgCXcUt+qE46F2FSz Jzb2wsbcLis4ndynctYUphQFhSk540Gu6ZWELlyvKy/myIvm1TLFxNzbcfPAyBeD5mTpoLMF0Lm LrIfYy3Gew2tuRYnXn6w1sMMJguMwwgdtx13Efk2bU3lQpiX2uunNARl0tBIdleBaQ6ywzJd9yL dvuAJncRYS+jC5pYYCDrOHxbtGSgcZgGNa6EyJL+Ti9IwXxyfGYZnIVu0ToNxY5E0Ee2t2wq2gQ vVFsa4Sb5CQAuKuNj1D+CK/QnT/39QSgqAMgIFV1tBuqzHqNa9eFmovb2R2Kk9ihZCNvHoMnTvf PveQ9esCZMvHqMbRZPzZQm1w88/GgLVA1lp1nMWqWtTOXDNRcGEKCWp93vuuqK9HFXyyjR14mR9 XDvciLK1/4qigDaKWfg== X-Authority-Analysis: v=2.4 cv=U4CfzOru c=1 sm=1 tr=0 ts=6971d598 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=udIbi99VXrYGKsD6_S4A:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-GUID: SbvPkAZUAEzuKy8Oj9RIxjkzHuoBfStW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-21_04,2026-01-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601220050 The current "has_msi_ctrl" flag name is misleading because it suggests the presence of any MSI controller, while it is specifically set for platforms that lack .msi_init() callback and don't have "msi-parent" or "msi-map" device tree properties, indicating they rely on the iMSI-RX module for MSI functionality. Rename it to "uses_imsi_rx" to make the intent clear: - When true: Platform uses the iMSI-RX module for MSI handling - When false: Platform has other MSI controller support (ITS/MBI, custom handlers) No functional changes, only improves code readability and eliminates naming confusion. Signed-off-by: Qiang Yu Reviewed-by: Shawn Lin --- drivers/pci/controller/dwc/pcie-designware-host.c | 16 ++++++++-------- drivers/pci/controller/dwc/pcie-designware.h | 2 +- drivers/pci/controller/dwc/pcie-qcom.c | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index a17833dd6f9d4b4aa06dc1fe09ffed5e2c28a82f..e7dbdf3670b426783e778be5064= def10d2b209b1 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -255,7 +255,7 @@ void dw_pcie_msi_init(struct dw_pcie_rp *pp) u64 msi_target =3D (u64)pp->msi_data; u32 ctrl, num_ctrls; =20 - if (!pci_msi_enabled() || !pp->has_msi_ctrl) + if (!pci_msi_enabled() || !pp->uses_imsi_rx) return; =20 num_ctrls =3D pp->num_vectors / MAX_MSI_IRQS_PER_CTRL; @@ -603,15 +603,15 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) } =20 if (pci_msi_enabled()) { - pp->has_msi_ctrl =3D !(pp->ops->msi_init || + pp->uses_imsi_rx =3D !(pp->ops->msi_init || of_property_present(np, "msi-parent") || of_property_present(np, "msi-map")); =20 /* - * For the has_msi_ctrl case the default assignment is handled + * For the uses_imsi_rx case the default assignment is handled * in the dw_pcie_msi_host_init(). */ - if (!pp->has_msi_ctrl && !pp->num_vectors) { + if (!pp->uses_imsi_rx && !pp->num_vectors) { pp->num_vectors =3D MSI_DEF_NUM_VECTORS; } else if (pp->num_vectors > MAX_MSI_IRQS) { dev_err(dev, "Invalid number of vectors\n"); @@ -623,7 +623,7 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) ret =3D pp->ops->msi_init(pp); if (ret < 0) goto err_deinit_host; - } else if (pp->has_msi_ctrl) { + } else if (pp->uses_imsi_rx) { ret =3D dw_pcie_msi_host_init(pp); if (ret < 0) goto err_deinit_host; @@ -701,7 +701,7 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) dw_pcie_edma_remove(pci); =20 err_free_msi: - if (pp->has_msi_ctrl) + if (pp->uses_imsi_rx) dw_pcie_free_msi(pp); =20 err_deinit_host: @@ -729,7 +729,7 @@ void dw_pcie_host_deinit(struct dw_pcie_rp *pp) =20 dw_pcie_edma_remove(pci); =20 - if (pp->has_msi_ctrl) + if (pp->uses_imsi_rx) dw_pcie_free_msi(pp); =20 if (pp->ops->deinit) @@ -1130,7 +1130,7 @@ int dw_pcie_setup_rc(struct dw_pcie_rp *pp) * the MSI and MSI-X capabilities of the Root Port to allow the drivers * to fall back to INTx instead. */ - if (pp->has_msi_ctrl) { + if (pp->uses_imsi_rx) { dw_pcie_remove_capability(pci, PCI_CAP_ID_MSI); dw_pcie_remove_capability(pci, PCI_CAP_ID_MSIX); } diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/con= troller/dwc/pcie-designware.h index 53b65428fadb3d905b02bdcc06667065574f4f9d..33154bc89dd3b7d7fbe0ea749ca= 22bdc8292489c 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -416,7 +416,7 @@ struct dw_pcie_host_ops { }; =20 struct dw_pcie_rp { - bool has_msi_ctrl:1; + bool uses_imsi_rx:1; bool cfg0_io_shared:1; u64 cfg0_base; void __iomem *va_cfg0_base; diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controlle= r/dwc/pcie-qcom.c index 13e6c334e10d21b9ebfe5f82de0aff3bce6191e3..999f5e083cef4e78b85a0111d2a= 90c3de65c83b5 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1633,7 +1633,7 @@ static void qcom_pci_free_msi(void *ptr) { struct dw_pcie_rp *pp =3D (struct dw_pcie_rp *)ptr; =20 - if (pp && pp->has_msi_ctrl) + if (pp && pp->uses_imsi_rx) dw_pcie_free_msi(pp); } =20 @@ -1657,7 +1657,7 @@ static int qcom_pcie_ecam_host_init(struct pci_config= _window *cfg) if (ret) return ret; =20 - pp->has_msi_ctrl =3D true; + pp->uses_imsi_rx =3D true; dw_pcie_msi_init(pp); =20 return devm_add_action_or_reset(dev, qcom_pci_free_msi, pp); --=20 2.34.1