[PATCH v3 0/4] i2c: designware: Enable mode swapping

Heikki Krogerus posted 4 patches 2 weeks, 3 days ago
drivers/i2c/busses/i2c-designware-amdisp.c |   4 +-
drivers/i2c/busses/i2c-designware-common.c | 211 +++++++++++++++++++--
drivers/i2c/busses/i2c-designware-core.h   |  23 +--
drivers/i2c/busses/i2c-designware-master.c | 173 ++---------------
drivers/i2c/busses/i2c-designware-slave.c  | 126 ++----------
5 files changed, 250 insertions(+), 287 deletions(-)
[PATCH v3 0/4] i2c: designware: Enable mode swapping
Posted by Heikki Krogerus 2 weeks, 3 days ago
Hi,

Changed since v2:
- Explaining the removal of the "target only" description in the commit message
- Added Acks and Reviewed-by tags from Mika and Andy

Changed since v1:
- The init cb is replaced with i2c_dw_init() also in i2c-designware-amdisp.c
- Checking I2C_FUNC_SLAVE in i2c_dw_reg_slave()

The original cover letter:

It's currently not possible to support MCTP or any other protocol that
requires support for both modes with the DesignWare I2C because the
driver can only be used in one mode. I'm assuming that the driver was
designed this way because the DesignWare I2C can not be operated as
I2C master and I2C slave simultaneously, however, that does not
actually mean both modes could not be supported at the same time. See
the patch 5/6 for more detailed explanation.

This series will enable support for both modes in the driver by
utilising a simple mode swap method, and that way make it possible to
support MCTP, IPMI, SMBus Host Notification Protocol, and any other
protocol requires the support for both modes with the DesignWare I2C.

thanks,

Heikki Krogerus (4):
  i2c: designware: Combine some of the common functions
  i2c: designware: Combine the init functions
  i2c: designware: Enable mode swapping
  i2c: designware: Remove an unnecessary condition

 drivers/i2c/busses/i2c-designware-amdisp.c |   4 +-
 drivers/i2c/busses/i2c-designware-common.c | 211 +++++++++++++++++++--
 drivers/i2c/busses/i2c-designware-core.h   |  23 +--
 drivers/i2c/busses/i2c-designware-master.c | 173 ++---------------
 drivers/i2c/busses/i2c-designware-slave.c  | 126 ++----------
 5 files changed, 250 insertions(+), 287 deletions(-)

-- 
2.50.1
Re: [PATCH v3 0/4] i2c: designware: Enable mode swapping
Posted by Andi Shyti 2 weeks, 1 day ago
Hi Heikki,

> Heikki Krogerus (4):
>   i2c: designware: Combine some of the common functions
>   i2c: designware: Combine the init functions
>   i2c: designware: Enable mode swapping
>   i2c: designware: Remove an unnecessary condition

merged to i2c/i2c-host.

Thanks,
Andi