[PATCH v3 07/27] gpib: cec: Unify *allocate_private usage

Dominik Karol Piątkowski posted 27 patches 3 weeks, 3 days ago
[PATCH v3 07/27] gpib: cec: Unify *allocate_private usage
Posted by Dominik Karol Piątkowski 3 weeks, 3 days ago
Use the return value of cec_allocate_private in calling code as early
return value in case of error.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
---

v3:
- Split commit into smaller pieces
- Improve changelog
- Change `(retval < 0)` to `(retval)`

 drivers/gpib/cec/cec_gpib.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpib/cec/cec_gpib.c b/drivers/gpib/cec/cec_gpib.c
index c2129ba3a902..7e57d65d6c32 100644
--- a/drivers/gpib/cec/cec_gpib.c
+++ b/drivers/gpib/cec/cec_gpib.c
@@ -238,11 +238,13 @@ static int cec_generic_attach(struct gpib_board *board)
 {
 	struct cec_priv *cec_priv;
 	struct nec7210_priv *nec_priv;
+	int retval;
 
 	board->status = 0;
 
-	if (cec_allocate_private(board))
-		return -ENOMEM;
+	retval = cec_allocate_private(board);
+	if (retval)
+		return retval;
 	cec_priv = board->private_data;
 	nec_priv = &cec_priv->nec7210_priv;
 	nec_priv->read_byte = nec7210_ioport_read_byte;
-- 
2.43.0