From nobody Tue Feb 10 05:44:47 2026 Received: from mail-43100.protonmail.ch (mail-43100.protonmail.ch [185.70.43.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7D66340DB0 for ; Fri, 16 Jan 2026 17:48:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585692; cv=none; b=Iwjh/iuPL46WSiA6xmEcvRt9vjd0ONYWsWNYZnOAYB+Dx+07efj3bFmjSwhsQL5NDXBBKDe3He3Cq/nR29fYzy7fXoBHmHkUFvSFmKoSXe9XxkRXTDrXmdIUMDxq+dnWnB7a4WOu25r62QzGShqVdGejHUllQhpybSH4PYPjdYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585692; c=relaxed/simple; bh=BI9q4c3VIjnW4K69NbM7rKCj/7hPYaNMMfQt34TDksc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tUgApfNjYtG+j57A3Rwv3AJHwvDeoTkydSq/dnpDVG9J6iBd32A1j4IgU588KzpHRWXBERjIyV0TeB9mSvXkkD6EtrMVGfvmA9XYgTYd8ZHJKOdKJvCzfEn/zmMaLuscIfw0Tf0yVvxaHffk6kaCTMh00etZ3mfsPWlIQFUvzyk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=L1/5uhSv; arc=none smtp.client-ip=185.70.43.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="L1/5uhSv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768585683; x=1768844883; bh=BI9q4c3VIjnW4K69NbM7rKCj/7hPYaNMMfQt34TDksc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=L1/5uhSvpHjRFR6dZ4ollJ0JKJz9nSqeWGQtltcV9AFSoNUYGykd+t6VRjTtT/MES r4xCDdst3eaprBD+Wd2P7SJkKdpTqEbd4SCxWYhs33XQvUqJpW3ky72cq0tWvtWQuq neS8JYhKJ87kzVxAADGS37wvPJVQGdtRVdPc6e4aosHw24q7y3EsvIjtgFHgHRorFw xrlidXWL8lZo+JAruAMXmOSWlZO60ZrCS9RkkjW5tx1R07yT9ewc6trYJ8I9elL33O EU9/T4l4U11WzCB4oTH6hinsGRrjeKco8/ulAh7Kg5HfgaZEFdL0yyqNh5akOfU2rk jiA9sP61TTsVg== Date: Fri, 16 Jan 2026 17:48:00 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v3 07/27] gpib: cec: Unify *allocate_private usage Message-ID: <20260116174647.317256-8-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> References: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: f710090146656b0fd8af5b0a8c683cd42fd0cdc0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the return value of cec_allocate_private in calling code as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v3: - Split commit into smaller pieces - Improve changelog - Change `(retval < 0)` to `(retval)` drivers/gpib/cec/cec_gpib.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/cec/cec_gpib.c b/drivers/gpib/cec/cec_gpib.c index c2129ba3a902..7e57d65d6c32 100644 --- a/drivers/gpib/cec/cec_gpib.c +++ b/drivers/gpib/cec/cec_gpib.c @@ -238,11 +238,13 @@ static int cec_generic_attach(struct gpib_board *boar= d) { struct cec_priv *cec_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; =20 - if (cec_allocate_private(board)) - return -ENOMEM; + retval =3D cec_allocate_private(board); + if (retval) + return retval; cec_priv =3D board->private_data; nec_priv =3D &cec_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_ioport_read_byte; --=20 2.43.0