Use the return value of allocate_private in calling code as early return
value in case of error.
Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
---
v3:
- Split commit into smaller pieces
- Improve changelog
- Change `(retval < 0)` to `(retval)`
drivers/gpib/pc2/pc2_gpib.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpib/pc2/pc2_gpib.c b/drivers/gpib/pc2/pc2_gpib.c
index e850a781c836..1664861d360d 100644
--- a/drivers/gpib/pc2/pc2_gpib.c
+++ b/drivers/gpib/pc2/pc2_gpib.c
@@ -256,10 +256,12 @@ static int pc2_generic_attach(struct gpib_board *board, const struct gpib_board_
{
struct pc2_priv *pc2_priv;
struct nec7210_priv *nec_priv;
+ int retval;
board->status = 0;
- if (allocate_private(board))
- return -ENOMEM;
+ retval = allocate_private(board);
+ if (retval)
+ return retval;
pc2_priv = board->private_data;
nec_priv = &pc2_priv->nec7210_priv;
nec_priv->read_byte = nec7210_ioport_read_byte;
--
2.43.0