From nobody Tue Feb 10 05:09:52 2026 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4A3739A81D for ; Fri, 16 Jan 2026 17:49:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585760; cv=none; b=shAmg60c5k8I6oex0J+Sf0zU0uHrtyccge/11y8FN0oVo2G2wnUrsFFTZaM5kQSR9+Yl5yJJR5C81f9vo5ClG43KeNw3+Gnv1vPtsEOUYKhEdFA7yftx/eQmzyfFHcZbw423qT7tEUaPOJvWx2GaX9S324HNA9zZPfyGnlBmJc0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585760; c=relaxed/simple; bh=DMJm1o9oWLCmGk0KqRKfmvA2QXR150Lep4c29Q8sA/U=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G5o10FQyJ8IS2XHb+N+eJ3gV1HKbP02NbyXgJPnb849gbixS9HxS4bCw5IPCUdOgkDR5NnTbffR38eW9nIAqBC407dnmA1vV+ZxYosbEdB9zMDC72JY5Y+18OjHyWwg+KXUKxZU6UZ6GrchQ+d3Le0J6fGNnb2J+vGYNDtYtHp8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=flBc73ab; arc=none smtp.client-ip=185.70.43.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="flBc73ab" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768585756; x=1768844956; bh=DMJm1o9oWLCmGk0KqRKfmvA2QXR150Lep4c29Q8sA/U=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=flBc73aby4HulpgAfGPkGrFkejED1Z9oiiC+Srllnt8zhN1FSq8R6G89MtmxA20Cj lP26MVJkj2wguDZvzcZHU1xsngxG4xzCOb//PPFd0lRkjOJBudG8RWFaZ7hq9f2MCC PIgEHj8FNgvCo954EnyPQAj9e3NasArjQcjvXp5aHxQyoShkZaOaRX2P8TIokFoNhm Lu+5SEqA+F/pajd5cWtmharW9wAI/ZTjDak5PQie3WpyuYtjQhO7haMJ1F9jzjrYNT b8C+n2zC99pXu0T9Nbq1sRl/wOWX1vzACCEno0+PbGEbLW2CzzeTnaQp0UQ/yuFjgI lePdTF+wTU05w== Date: Fri, 16 Jan 2026 17:49:13 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v3 24/27] gpib: pc2: Unify *allocate_private usage Message-ID: <20260116174647.317256-25-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> References: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: f762a0c0fddfab445c6cca95e00203d2f92f4511 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the return value of allocate_private in calling code as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v3: - Split commit into smaller pieces - Improve changelog - Change `(retval < 0)` to `(retval)` drivers/gpib/pc2/pc2_gpib.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/pc2/pc2_gpib.c b/drivers/gpib/pc2/pc2_gpib.c index e850a781c836..1664861d360d 100644 --- a/drivers/gpib/pc2/pc2_gpib.c +++ b/drivers/gpib/pc2/pc2_gpib.c @@ -256,10 +256,12 @@ static int pc2_generic_attach(struct gpib_board *boar= d, const struct gpib_board_ { struct pc2_priv *pc2_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; - if (allocate_private(board)) - return -ENOMEM; + retval =3D allocate_private(board); + if (retval) + return retval; pc2_priv =3D board->private_data; nec_priv =3D &pc2_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_ioport_read_byte; --=20 2.43.0