[PATCH v2 00/12] gpib: Unify *allocate_private

Dominik Karol Piątkowski posted 12 patches 3 weeks, 2 days ago
There is a newer version of this series
drivers/gpib/agilent_82350b/agilent_82350b.c |  5 +++--
drivers/gpib/cb7210/cb7210.c                 |  9 +++++----
drivers/gpib/cec/cec_gpib.c                  | 11 ++++++-----
drivers/gpib/eastwood/fluke_gpib.c           |  3 +--
drivers/gpib/fmh_gpib/fmh_gpib.c             |  3 +--
drivers/gpib/gpio/gpib_bitbang.c             |  9 +++++----
drivers/gpib/hp_82335/hp82335.c              |  7 ++++---
drivers/gpib/hp_82341/hp_82341.c             |  5 +++--
drivers/gpib/ines/ines_gpib.c                | 11 ++++++-----
drivers/gpib/ni_usb/ni_usb_gpib.c            |  3 +--
drivers/gpib/pc2/pc2_gpib.c                  | 11 ++++++-----
drivers/gpib/tnt4882/tnt4882_gpib.c          | 20 +++++++++++---------
12 files changed, 52 insertions(+), 45 deletions(-)
[PATCH v2 00/12] gpib: Unify *allocate_private
Posted by Dominik Karol Piątkowski 3 weeks, 2 days ago
Recently, gpib driver got out of staging area. There is still a bit of work that
can be done to improve it.

Return values for *allocate_private functions as well as calling code in
gpib driver are all over the place. Unify them by returning -errno if
something fails, zero otherwise. Use the returned value as early return
value in case of error.

Untouched gpib files already use the proposed convention.

v2: Replace kmalloc/memset pairs to kzalloc.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>

Dominik Karol Piątkowski (12):
  gpib: agilent_82350b: Unify *allocate_private
  gpib: cb7210: Unify *allocate_private
  gpib: cec: Unify *allocate_private
  gpib: eastwood: Unify *allocate_private
  gpib: fmh_gpib: Unify *allocate_private
  gpib: gpio: Unify *allocate_private
  gpib: hp_82335: Unify *allocate_private
  gpib: hp_82341: Unify *allocate_private
  gpib: ines: Unify *allocate_private
  gpib: ni_usb: Unify *allocate_private
  gpib: pc2: Unify *allocate_private
  gpib: tnt4882: Unify *allocate_private

 drivers/gpib/agilent_82350b/agilent_82350b.c |  5 +++--
 drivers/gpib/cb7210/cb7210.c                 |  9 +++++----
 drivers/gpib/cec/cec_gpib.c                  | 11 ++++++-----
 drivers/gpib/eastwood/fluke_gpib.c           |  3 +--
 drivers/gpib/fmh_gpib/fmh_gpib.c             |  3 +--
 drivers/gpib/gpio/gpib_bitbang.c             |  9 +++++----
 drivers/gpib/hp_82335/hp82335.c              |  7 ++++---
 drivers/gpib/hp_82341/hp_82341.c             |  5 +++--
 drivers/gpib/ines/ines_gpib.c                | 11 ++++++-----
 drivers/gpib/ni_usb/ni_usb_gpib.c            |  3 +--
 drivers/gpib/pc2/pc2_gpib.c                  | 11 ++++++-----
 drivers/gpib/tnt4882/tnt4882_gpib.c          | 20 +++++++++++---------
 12 files changed, 52 insertions(+), 45 deletions(-)

-- 
2.43.0