From nobody Sun Feb 8 18:43:59 2026 Received: from mail-24416.protonmail.ch (mail-24416.protonmail.ch [109.224.244.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FB212EFD98 for ; Thu, 15 Jan 2026 19:20:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504818; cv=none; b=rjUHIv7z1k9g+Egg3FpF3l5WlUmUXbgCuEjkZGNqIWmouPIN4guvj+f4sDQtIk+vBy6gnP0nQZAIj/w9BIsmSlHvrZp6wVdMBleFySDJmdkDCUM8uANFIFz7LEereciuYHcKLNI1drtPbnVbLFbI0KGE7YAoxAOrwuB10W1WAjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504818; c=relaxed/simple; bh=CGrPecDc1OMI3cvDEDRJdSnArOdRkg9/BZSWOm+xhBY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hZibJsZmFNRujOGGlDFsRRaga3vSXAlMEM5KvvaQAUmcZK+GAa7I+euC5/gflupY5+vziRBEF4RkSFaYp2Owyu1oK7c9xuEF6cYSYp4U7uc+eBK4bsc+vJ473H0m4ZJu7Z1vmC5dQa5Of+YN0sGlS7372+BAt1QYN/MKt3p7kPg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=w/7vkPqB; arc=none smtp.client-ip=109.224.244.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="w/7vkPqB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504808; x=1768764008; bh=CGrPecDc1OMI3cvDEDRJdSnArOdRkg9/BZSWOm+xhBY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=w/7vkPqBj2cZuTMoMmAhSBS/qJf+j+zC+4ZwaUqOuoqTGjWaeI7OrjKT2c4tWvI9l SuMwBycxf2T8oh+xcKVpTonYeRe+/lJ319WXxw8GGFB2RkbCmSONefri3H2uvhp3qs EZ4wRRgPh4qWZeKm+4FZcBJoDMLwSGorxRt/jkpBV0Pq4Jz4dhdezdPiWt5mrlIfib uqHol1E+1zRbTWVAynvdL0Z5BVIzCU2HpLAkehIBhC9bpz0DcI+NKpMEcH6HxTUEb+ f7faWmuK3xYx66g/n7t9CaE8yvppQG9IXHiUrETVDOxPdfl2EM0QJylWZ2gsENhXOD u0I2zZ2fqNnXQ== Date: Thu, 15 Jan 2026 19:20:04 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 01/12] gpib: agilent_82350b: Unify *allocate_private Message-ID: <20260115191925.52268-2-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: d288a8169ee12a461b4ce3b553e7eea66662b25f Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/agilent_82350b/agilent_82350b.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/agilent_82350b/agilent_82350b.c b/drivers/gpib/ag= ilent_82350b/agilent_82350b.c index 01a5bb43cd2d..f5f102863e47 100644 --- a/drivers/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/gpib/agilent_82350b/agilent_82350b.c @@ -599,8 +599,9 @@ static int agilent_82350b_generic_attach(struct gpib_bo= ard *board, =20 board->status =3D 0; =20 - if (agilent_82350b_allocate_private(board)) - return -ENOMEM; + retval =3D agilent_82350b_allocate_private(board); + if (retval < 0) + return retval; a_priv =3D board->private_data; a_priv->using_fifos =3D use_fifos; tms_priv =3D &a_priv->tms9914_priv; --=20 2.43.0 From nobody Sun Feb 8 18:43:59 2026 Received: from mail-24417.protonmail.ch (mail-24417.protonmail.ch [109.224.244.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72AE52EBDDE for ; Thu, 15 Jan 2026 19:20:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504823; cv=none; b=kblT6M4K4ePnddzKUS1Tk8ndsyGWB6RqWwuk/St4Qrm2QcNmuxis+0z0GSF5032TASkvhmohmsS4x5BAh/P4FWbSa11OILf+c+Vk2uw+ac4Ux7oN144zEvmZq0+buHKYO+jDXtzJgImURFbttRwtDJ/N8r3vrXWWaLA3bBPEiEc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504823; c=relaxed/simple; bh=ebsKHasvE/+sve0wlit3BeNi0E8bB7dFuuxOB1wMqVE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PAQ+Rpzedk1Kh1dob2z4h70qHkjnfp7MXr5BxcxgwuIpwrABdEUUgQ+1Ig4TBHfzhZTrOtkyXymynwRI3i2g8cz5MHhfhbU9uWqscSA8ele7imGyKz6GPGwtyC0pB4E2D4n42keP5iC9mFntxe/KvTtCigefohGWMyG1trPb5fo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=JcpnSUSt; arc=none smtp.client-ip=109.224.244.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="JcpnSUSt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504813; x=1768764013; bh=ebsKHasvE/+sve0wlit3BeNi0E8bB7dFuuxOB1wMqVE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=JcpnSUStqX4MBSHyJU1MKNAhN+YGcRhwvjS56pGrV+hxHcyqhvOJxZEdCbWGS+O9s ihDOkw1c9peIDD/Efwb99AUr+adJ9uxpDRrv+bhDkJvSsTJaDZJ5L0nSyHYHimRZCL r6D6vKFNYcnMU2xPCknRs62YLZz8W5IANNLRt3mZZbIPXUMcTvDW++k79fGwGkX3XV /TR8VeHGK/dnTl/PfUaGvBYiG0EwLLFk2ARmIxyRfgcw9C9hXmYb5RT1jeNkP8yAXW Xk/PrvcEJv2XAXNf6z3fpL5KSVR89SJ2zP8ngFctKCKZsyVB9Erag5iupspdYUqWy4 owFfxtehAxCtg== Date: Thu, 15 Jan 2026 19:20:10 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 02/12] gpib: cb7210: Unify *allocate_private Message-ID: <20260115191925.52268-3-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 037642305ac79ee696bd01eb6395fb4d9fe1d1a9 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/cb7210/cb7210.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpib/cb7210/cb7210.c b/drivers/gpib/cb7210/cb7210.c index 24c61b151071..6395f89d0f3c 100644 --- a/drivers/gpib/cb7210/cb7210.c +++ b/drivers/gpib/cb7210/cb7210.c @@ -856,11 +856,10 @@ static int cb7210_allocate_private(struct gpib_board = *board) { struct cb7210_priv *priv; =20 - board->private_data =3D kmalloc(sizeof(struct cb7210_priv), GFP_KERNEL); + board->private_data =3D kzalloc(sizeof(struct cb7210_priv), GFP_KERNEL); if (!board->private_data) return -ENOMEM; priv =3D board->private_data; - memset(priv, 0, sizeof(struct cb7210_priv)); init_nec7210_private(&priv->nec7210_priv); return 0; } @@ -876,11 +875,13 @@ static int cb7210_generic_attach(struct gpib_board *b= oard) { struct cb7210_priv *cb_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; =20 - if (cb7210_allocate_private(board)) - return -ENOMEM; + retval =3D cb7210_allocate_private(board); + if (retval < 0) + return retval; cb_priv =3D board->private_data; nec_priv =3D &cb_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_locking_ioport_read_byte; --=20 2.43.0 From nobody Sun Feb 8 18:43:59 2026 Received: from mail-24418.protonmail.ch (mail-24418.protonmail.ch [109.224.244.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53C5B2F546D for ; Thu, 15 Jan 2026 19:20:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504828; cv=none; b=pWEp2UskeoV8BWS1hVMKQFA+dtf+4d4kcHYLdJCadkYmxmy6lb0L2RkrOLptfLbpGRdg0AjtaHeqF3QK1LBthB96vNMURaoEAosBBNmi7imGLY1Ir9lYfxGVhqw/EzkxNQiEKpArna8iSUySVleQ49EYE3ROONETGC570mPcaiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504828; c=relaxed/simple; bh=69r6oVwYLdTQ/UQiPRGS0UQsYHOMGFBsQj7kHtHEBE0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AqE2F+qDoRBxY4AaLhEERIDnSnugq9x7b8YNI793UQLL/gypFwHNlx3mKJTBQaymYPMACAAaC9Rh0BgxYGN2kzti7wuadYdFzhfi5eEihxl+mPwPoOhXNz1UmQEp8wB1pz8jwiCEreyZTYEJtcVlcV6JLepjAxSXbMxo2EFhPh8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=d1q1sKXR; arc=none smtp.client-ip=109.224.244.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="d1q1sKXR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504820; x=1768764020; bh=69r6oVwYLdTQ/UQiPRGS0UQsYHOMGFBsQj7kHtHEBE0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=d1q1sKXRJQXd4JZIXIF6LQZ5HZtlomKpBGrU0gbmOy5QwyXK6cwdOGNCEWWW4vUNb cLRMWkcknjcYZIReQ+cVBrlVw2h1bMr1DOkNTR/DLDHHS4ljCMmBaZRGjXyV5TKT1y h9suIw+zKwOSdyY568ylpQuLK+y8QpYDEq2ERAp0M+u0AMAWgHAudATGUaZSVh/N1f eRn+lwEisSBUndssNZtUEiRdfv8Q5AQC61cjnjly0PQcedHKTbCkCrzqq+MbPmSBbT V3nGmPF3c+1/5NoRFOMNlzY+g0NxtGkSIGhlyVjjQ54mXK/MkKrLEIvSyQ3m2M3+jv LnUE6tDB4yJUQ== Date: Thu, 15 Jan 2026 19:20:15 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 03/12] gpib: cec: Unify *allocate_private Message-ID: <20260115191925.52268-4-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 13039ba83445e4d11661b5909ffcf7b21cd16d99 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/cec/cec_gpib.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpib/cec/cec_gpib.c b/drivers/gpib/cec/cec_gpib.c index dbf9b95baabc..f2bb57352d31 100644 --- a/drivers/gpib/cec/cec_gpib.c +++ b/drivers/gpib/cec/cec_gpib.c @@ -220,11 +220,10 @@ static int cec_allocate_private(struct gpib_board *bo= ard) { struct cec_priv *priv; =20 - board->private_data =3D kmalloc(sizeof(struct cec_priv), GFP_KERNEL); + board->private_data =3D kzalloc(sizeof(struct cec_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; priv =3D board->private_data; - memset(priv, 0, sizeof(struct cec_priv)); init_nec7210_private(&priv->nec7210_priv); return 0; } @@ -239,11 +238,13 @@ static int cec_generic_attach(struct gpib_board *boar= d) { struct cec_priv *cec_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; =20 - if (cec_allocate_private(board)) - return -ENOMEM; + retval =3D cec_allocate_private(board); + if (retval < 0) + return retval; cec_priv =3D board->private_data; nec_priv =3D &cec_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_ioport_read_byte; --=20 2.43.0 From nobody Sun Feb 8 18:43:59 2026 Received: from mail-43102.protonmail.ch (mail-43102.protonmail.ch [185.70.43.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E3D7285CAD for ; Thu, 15 Jan 2026 19:20:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.102 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504835; cv=none; b=JnFT7rc1iNXWFbxYYm7g2KVIB0B8eH5QNI+ciiye0rAjMRkNZB/9vaQzfd09BTPlyRYkaiBcQXHALlSH4PX66cOX4znm+XjtawV9OO3WNB/KQ6lliQt5K99XZYRIc1PKIFl5SYmURiLucU9m95YI29V4K8PxoGgeqcXFvJFcn9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504835; c=relaxed/simple; bh=u/J7qcGF5yMjT+HR6mzTXEFVnqb3SAITNcLOk4Daj80=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SeGheJewOev3R0Y0o/LT+6wWLPyy+iY+WNSogp1GlZtowO58bBp/umVol7xhdnUY0FJbUvJrynOPJRr/yKVcAeyo2XSmFP1G0qwxnxUvEtmp2NhsqNwekAmTdzvS9yaPGVE0HLvYDjwVitf+s47xTX37fds5LHoMyUX07rCtn+I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=FIvZPeC3; arc=none smtp.client-ip=185.70.43.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="FIvZPeC3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504825; x=1768764025; bh=u/J7qcGF5yMjT+HR6mzTXEFVnqb3SAITNcLOk4Daj80=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=FIvZPeC34DU+c1Hj11mwwNWuK96Dx42JTx80yf6wy23etLR9h7xxCrsvI0IwnN/KP ZMV3lMlpIaMk4OOx+XOwwD+Q4B+pzHA0uK6++K0xqdwq0p21XKN0VqqOenBTP8wqJY JYIq0XtEEUv4KrE3tgGHMm0AkD2PbwzX/rjJZKAX7rhwZZ1g8aiMvbu4oUe0h9W1wm og/Vkx7X1TGhHgkkD0qMAlUKuaPpTQyLuiFIevACj6xio9L16/jhltx7NgflXsjw3u ZoksdTwL52ouv6qVAFDAL86FQp7K0Jr9jASVRMGMeSJ0VnTSq/mzBSWIolUJQzwOTv iY8lxGpH0Hoqg== Date: Thu, 15 Jan 2026 19:20:20 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 04/12] gpib: eastwood: Unify *allocate_private Message-ID: <20260115191925.52268-5-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: fd91804c2e563c11ed96ad71ab31a0326f49d00e Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/eastwood/fluke_gpib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpib/eastwood/fluke_gpib.c b/drivers/gpib/eastwood/flu= ke_gpib.c index 3ae848e3f738..8e315b0e35a2 100644 --- a/drivers/gpib/eastwood/fluke_gpib.c +++ b/drivers/gpib/eastwood/fluke_gpib.c @@ -853,11 +853,10 @@ static int fluke_allocate_private(struct gpib_board *= board) { struct fluke_priv *priv; =20 - board->private_data =3D kmalloc(sizeof(struct fluke_priv), GFP_KERNEL); + board->private_data =3D kzalloc(sizeof(struct fluke_priv), GFP_KERNEL); if (!board->private_data) return -ENOMEM; priv =3D board->private_data; - memset(priv, 0, sizeof(struct fluke_priv)); init_nec7210_private(&priv->nec7210_priv); priv->dma_buffer_size =3D 0x7ff; priv->dma_buffer =3D kmalloc(priv->dma_buffer_size, GFP_KERNEL); --=20 2.43.0 From nobody Sun Feb 8 18:43:59 2026 Received: from mail-24416.protonmail.ch (mail-24416.protonmail.ch [109.224.244.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FF292F1FC2 for ; Thu, 15 Jan 2026 19:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504837; cv=none; b=ers0NR2daE89+BK8qutR6ZWADc3EiWiZmLVAMqGKJKj3tKWsP9xRDcULuFSYAmn7dKheXo6JgvsyjEZmd7MmZzL8jq1B8hiSSoinBFIgWlSBgVH5x5dKWGslns/p0d2L5b6M9OYLMxNrCLNCEYiYsPo5yqNbXcTWOjB0yJm9UFo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504837; c=relaxed/simple; bh=2GaX/RYUd2Xam5+L3ObyujmDGV5ICgDqxOCpbMMdVA8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ci1NREeh9DLijmyhWyOwcKyUmlNwEhzNfWVWKDoBF1TPLQmwXZccw04CHVQhqFlw16BRGJmBJy8G/xtwe9GBsr9SJsm8jcspOVeGYXPkAuQJFAR39AxNcb+v6mIuJriaO1k83vnvIFbUf9moSl7cHGN5FoEWIs+xkjkUZFekrUo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=rpolLF2k; arc=none smtp.client-ip=109.224.244.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="rpolLF2k" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504833; x=1768764033; bh=2GaX/RYUd2Xam5+L3ObyujmDGV5ICgDqxOCpbMMdVA8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=rpolLF2kpjk4VnBDkfy2TibBJMei9drDybnv01gMAESpi7HKbXx2vRxAkRZy9F0RR w38Vifaa6vRDhyPSE4xY93ZFB/mc6tOVPWfKLuDpIPa2nUZhW2bYkt7lt6idqxTfCR RS2+Y7gaPTjPazyO9yC7nvJc4LNDr8/srUjqIMFbhFQqDCrvjSsKkAHZq/1lHJ5Dxd J9/QA06f+xh5Eq1YsiXuEQH3kTF814eSJe8uxKm8zGdlOs4/zeWveYUiv+TEVi+iDn hQDNo1o1c0P/2hHRe5s6RCe0GbCWxw1LzcM66TdnI5kOH3i+/wJOHImsJn4n3SRmkb nquxIdA8wiehQ== Date: Thu, 15 Jan 2026 19:20:27 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 05/12] gpib: fmh_gpib: Unify *allocate_private Message-ID: <20260115191925.52268-6-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: aecf6a60824d70b2f02a7b8bf59043c97b8200e5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/fmh_gpib/fmh_gpib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpib/fmh_gpib/fmh_gpib.c b/drivers/gpib/fmh_gpib/fmh_g= pib.c index f7bfb4a8e553..b8d955f124bd 100644 --- a/drivers/gpib/fmh_gpib/fmh_gpib.c +++ b/drivers/gpib/fmh_gpib/fmh_gpib.c @@ -1250,11 +1250,10 @@ static int fmh_gpib_allocate_private(struct gpib_bo= ard *board) { struct fmh_priv *priv; =20 - board->private_data =3D kmalloc(sizeof(struct fmh_priv), GFP_KERNEL); + board->private_data =3D kzalloc(sizeof(struct fmh_priv), GFP_KERNEL); if (!board->private_data) return -ENOMEM; priv =3D board->private_data; - memset(priv, 0, sizeof(struct fmh_priv)); init_nec7210_private(&priv->nec7210_priv); priv->dma_buffer_size =3D 0x800; priv->dma_buffer =3D kmalloc(priv->dma_buffer_size, GFP_KERNEL); --=20 2.43.0 From nobody Sun Feb 8 18:43:59 2026 Received: from mail-244123.protonmail.ch (mail-244123.protonmail.ch [109.224.244.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCCFC2F1FC2 for ; Thu, 15 Jan 2026 19:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504842; cv=none; b=g+g2Z/Bk3RuMR15t7bSE0aUq4lDWtDbZxWAhDg/JQP8ZhySxuDveKDEuqDQZGrO98F7tNwaMj7SQJbZJRFFsH/QPjMlHoopOBqiNNU0Jkorh3ci1Ygd+eOlQP5mc0LhZ8WNL1Ot+Gajg0byQJhhFBPNMwgKF0N/0+eBetata/GM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504842; c=relaxed/simple; bh=KA9MXKxQIBvly1s3qKWEufqCl2vMdS+ESnCH1cHJ7Ys=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tvPDYFqgHDtTBZY5+/A6scXkEAehwJP9Vk6jwIk7/i4ybaWt9MBtNlAviCQ2LvbUv/S1aENisLxEtIL2TEZvr/e/05niVUqAmJK1+Uxuvj+WY0hYxygImuEjT/FRB5h4Zil4Un/XYF/jPMaSEnQkEbNKhj8/e+PAmLpmVn4M+EA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=TsWJt4p4; arc=none smtp.client-ip=109.224.244.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="TsWJt4p4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504838; x=1768764038; bh=KA9MXKxQIBvly1s3qKWEufqCl2vMdS+ESnCH1cHJ7Ys=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=TsWJt4p4OiO9W7NLo/Ay7O/XQjyBLvBYfGl4ottgfDEr3LReFo0N15cGwqCjx/Hl4 GpCZKZvKhS6KVQFjuDyC3zYESrw+OLTTnfr2CmnY3SWleHelU+ye0RxFRN8lkR2fUw GGOSD2HeLROuDadbOAOwY9FJPkoTETMnrBJSIOX6qPgifuRiP7kTva6R9vElIYxO8t ROSn0x4Bnf/xRlnEkfspa2Hf67mtd3HCJ7TcE+SvPEIvquhhUkCThALvohm+Prg27/ Irw1LS5rSYPsL6bOOqVHBDKVMNR+LikVWCDMrJo10Wf+gqMygpW06cGsEhzJBRCR7H s3nHMs1iI8aNg== Date: Thu, 15 Jan 2026 19:20:34 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 06/12] gpib: gpio: Unify *allocate_private Message-ID: <20260115191925.52268-7-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 024663f86e28416f555e0613959fb3f7d7319208 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/gpio/gpib_bitbang.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpib/gpio/gpib_bitbang.c b/drivers/gpib/gpio/gpib_bitb= ang.c index 374cd61355e9..3b8bd34f2f3d 100644 --- a/drivers/gpib/gpio/gpib_bitbang.c +++ b/drivers/gpib/gpio/gpib_bitbang.c @@ -1068,7 +1068,7 @@ static int allocate_private(struct gpib_board *board) { board->private_data =3D kzalloc(sizeof(struct bb_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; return 0; } =20 @@ -1205,14 +1205,15 @@ static void bb_detach(struct gpib_board *board) static int bb_attach(struct gpib_board *board, const struct gpib_board_con= fig *config) { struct bb_priv *priv; - int retval =3D 0; + int retval; =20 dbg_printk(2, "%s\n", "Enter ..."); =20 board->status =3D 0; =20 - if (allocate_private(board)) - return -ENOMEM; + retval =3D allocate_private(board); + if (retval < 0) + return retval; priv =3D board->private_data; priv->direction =3D -1; priv->t1_delay =3D 2000; --=20 2.43.0 From nobody Sun Feb 8 18:43:59 2026 Received: from mail-24418.protonmail.ch (mail-24418.protonmail.ch [109.224.244.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27E262EBDDE for ; Thu, 15 Jan 2026 19:20:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504849; cv=none; b=i9ZS4Lt1GPGzwScEHxXcmFUO8tyDcy82IE9gJ6L3fzrNOFYrCVJUHu3JAJzv5i7d/fsmfh9N+A3Zt61flXP8ggQgN8V8x8+AC7HX8HYHTnw+Zi7WIXJBTovIPD4RGbfpgdhIFqs50v9yadwUSbkajYpATs0PTgPVWUzsB4NgddY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504849; c=relaxed/simple; bh=iH9cS/xFBtGfTslgJ2Bm5/fCnbKgeaStv67+ULILVZY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aO4wcpFx28wtYH3RKlziO+BseSNnrqpeQRwTPvZGsaePk6kOx9HRQFEX0xgGQbLE1/qtPLLOHe521LbZ6Q7/0G11T7yLe1aKWPsm9G0GdC7RCsF3rqrLW1u9wzSXcetbu1uHwBLwtA47AjcPmx+li1TIcZr/mRnn6H8NwC3faOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=ndTYmZet; arc=none smtp.client-ip=109.224.244.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="ndTYmZet" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504844; x=1768764044; bh=iH9cS/xFBtGfTslgJ2Bm5/fCnbKgeaStv67+ULILVZY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ndTYmZetht6CougKO1Nz8WpdED3G4XLZ9ZT0bWXKteHBlgZfPCktv2lvmFTKze46S Zhmny6yKCxMKkvyaZ5fUT3NQ8zuKwGdqvgsjhtW4rPyR1ZihZmmpkhuLGcOGfrlEYb b6+FsS8jbfHPcN6W2qsNe3Iu9zqDCLseQUmbpftjLDrB3qN9y4bOroyYIdowXZQ+DU u/0FKfusvtMKMxoyMq+w6NROzyFnsB21deNYMRu6dJmOG0CwI01w7pVUlBa2n0PRSH INM2GTmoTKsZnc2ssKjNluDaw8rHF1YoDN4U/INu1BIzdsp1/abK6awBpQHYpV1DDG gkQjNeU3Z/Szw== Date: Thu, 15 Jan 2026 19:20:40 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 07/12] gpib: hp_82335: Unify *allocate_private Message-ID: <20260115191925.52268-8-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: f5bec98bffe5f6b915acb4dca50c90ecdce21dc0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/hp_82335/hp82335.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpib/hp_82335/hp82335.c b/drivers/gpib/hp_82335/hp8233= 5.c index d0e47ef77c87..871079dd1088 100644 --- a/drivers/gpib/hp_82335/hp82335.c +++ b/drivers/gpib/hp_82335/hp82335.c @@ -212,7 +212,7 @@ static int hp82335_allocate_private(struct gpib_board *= board) { board->private_data =3D kzalloc(sizeof(struct hp82335_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; return 0; } =20 @@ -253,8 +253,9 @@ static int hp82335_attach(struct gpib_board *board, con= st struct gpib_board_conf =20 board->status =3D 0; =20 - if (hp82335_allocate_private(board)) - return -ENOMEM; + retval =3D hp82335_allocate_private(board); + if (retval < 0) + return retval; hp_priv =3D board->private_data; tms_priv =3D &hp_priv->tms9914_priv; tms_priv->read_byte =3D hp82335_read_byte; --=20 2.43.0 From nobody Sun Feb 8 18:43:59 2026 Received: from mail-244122.protonmail.ch (mail-244122.protonmail.ch [109.224.244.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A98F0227E83 for ; Thu, 15 Jan 2026 19:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504860; cv=none; b=TwF/MJiPsuvLHbUB8D3w+z/t1kD0YmIAZ4ioxJIdTAIh3UK1pv5H6dFjwyME3gbXHsxvD+4BC2wYWdQTwENlNg2+5ujiTCsn+T2ho/kFZDNr0EbCfZx3sOIqMiiHk48JJHNwBzNEdYUD8t4rV4RSWENF76Oac3cHtE2m0b5SfOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504860; c=relaxed/simple; bh=oZ2/o4CmQ9PfUSbI98laLaE5VcoE4k2Wn5hbFv3qKSA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cXhgeRe2tdH+ebU4ZwK0Re3PIdp75LYooaE/EmQ5GFk2WtBQY1/PJB1bsZ8m1juHOTt8ecyPcO1pIMhc1EnItDlaVscsNY8DkDV4nAPYMk5Yk3WKlWhuPdIltNp6kUYKHzbqPGCdp2qHcHecFcPflo+/55LrDFhDeYrnZqafozw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=BSP4atJM; arc=none smtp.client-ip=109.224.244.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="BSP4atJM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504850; x=1768764050; bh=oZ2/o4CmQ9PfUSbI98laLaE5VcoE4k2Wn5hbFv3qKSA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=BSP4atJMsiDHg1R3uZ5QDuVQFHUv9Ov6SownRztjRzBU/Jy5LUD+5Wi329kbDh1D1 mWUbgeREwr6lZhLDai1VyVLoF3+R/81L44CQJkSRA+g71fQJUZD2pb5xLUR1RU5ZVz MM1Bh0gi88JJObtND82Z3hP03X1vDEa+oTVXLPhwtm8NWIpstoeQOQRfK0dXf0i1Qr XJ4LRoOhoQ1FmVp7qQiXtzLKov6djh64/0cSBj2sGSzRXnnwprUiDWztsZt6bDrVL2 kPzVFcdI/zE6XeYFMKgKA6lEspPaQmCABOCvu+Q4mpEaz9dnl5k25qVHk2rPzQ+J/q CSlL53ca3Mfdg== Date: Thu, 15 Jan 2026 19:20:45 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 08/12] gpib: hp_82341: Unify *allocate_private Message-ID: <20260115191925.52268-9-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: b697956e053b13b3e3e7c3cbf8c2984861d06382 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/hp_82341/hp_82341.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/hp_82341/hp_82341.c b/drivers/gpib/hp_82341/hp_82= 341.c index 1a2ad0560e14..4a2440fe160f 100644 --- a/drivers/gpib/hp_82341/hp_82341.c +++ b/drivers/gpib/hp_82341/hp_82341.c @@ -693,8 +693,9 @@ static int hp_82341_attach(struct gpib_board *board, co= nst struct gpib_board_con int retval; =20 board->status =3D 0; - if (hp_82341_allocate_private(board)) - return -ENOMEM; + retval =3D hp_82341_allocate_private(board); + if (retval < 0) + return retval; hp_priv =3D board->private_data; tms_priv =3D &hp_priv->tms9914_priv; tms_priv->read_byte =3D hp_82341_read_byte; --=20 2.43.0 From nobody Sun Feb 8 18:43:59 2026 Received: from mail-106121.protonmail.ch (mail-106121.protonmail.ch [79.135.106.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32F022EBB8F for ; Thu, 15 Jan 2026 19:21:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.121 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504869; cv=none; b=qcV/1hNkPM7FtlkbwBweWLWIh2l6ekR3liB4YA96PBeRNwK9SlgjG9ZRSn/AnpsZXnXtzyduzFDkDRCmRWGOKkpMXgmbOtpabyHwotpjOZkpLaU20z26y2k0i21K1bJ7ZS4/CmOQD3V9Ggtw1PhIFTceR5UMlMkxhkQApOFltFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504869; c=relaxed/simple; bh=ErfYa5t20LApzoyfyOzE8LGLIBbaj9hN+6E8Q5cAuGM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=u/V1I6nSmWsHxccjiRvX2nD28GPS2EqWZ+4bn38yUHP/dACtNwk7iFvWLTAiKoj53Q1duE1+VC1Z8Gm4nGa1f8mE60yxqlqSo5aExkVMXAzjaaDOyPL2clwR8EUa2mfceHK1M4bAVv1cDyZuvHCx0VSOZduB8Ncsx8T/QteSvSo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=R/BdyaIQ; arc=none smtp.client-ip=79.135.106.121 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="R/BdyaIQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504857; x=1768764057; bh=ErfYa5t20LApzoyfyOzE8LGLIBbaj9hN+6E8Q5cAuGM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=R/BdyaIQK4502IwGKPImm0C45I9E1gdjmwwDacXk4n7B0C4qcMoYzUPzpX2pjRJjf oL4yJoZG1bW7lVb/T4VDVzDPY/RhEbQGA/Q/bJbzUXt1LUTFVNGcIqkaHs1wJqcQbB fngEoousHTDg0TCJjhR3axjURLamk13/YNU34oDUt1jfn4oiIV3y7A2ioqL+NI5hVO 8bSffCua9v6qFCXiVtqTSiX6DU//lAZnzQxqMFH6k81QR8bI3atzVjlnLLfb58MJ5i L4hViAO50hbSxlhhs4wSFeb3LDlq8nJE6XlwZeNtOPA6KFlfO4gdtXHr1qW/Scg8dz twdhhOIGqOThQ== Date: Thu, 15 Jan 2026 19:20:51 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 09/12] gpib: ines: Unify *allocate_private Message-ID: <20260115191925.52268-10-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 5f55473ab325aa6ceeea3c12b6d9edbf6bce56e3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/ines/ines_gpib.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpib/ines/ines_gpib.c b/drivers/gpib/ines/ines_gpib.c index a3cf846fd0f9..4a87c79f218b 100644 --- a/drivers/gpib/ines/ines_gpib.c +++ b/drivers/gpib/ines/ines_gpib.c @@ -657,11 +657,10 @@ static int ines_allocate_private(struct gpib_board *b= oard) { struct ines_priv *priv; =20 - board->private_data =3D kmalloc(sizeof(struct ines_priv), GFP_KERNEL); + board->private_data =3D kzalloc(sizeof(struct ines_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; priv =3D board->private_data; - memset(priv, 0, sizeof(struct ines_priv)); init_nec7210_private(&priv->nec7210_priv); return 0; } @@ -676,11 +675,13 @@ static int ines_generic_attach(struct gpib_board *boa= rd) { struct ines_priv *ines_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; =20 - if (ines_allocate_private(board)) - return -ENOMEM; + retval =3D ines_allocate_private(board); + if (retval < 0) + return retval; ines_priv =3D board->private_data; nec_priv =3D &ines_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_ioport_read_byte; --=20 2.43.0 From nobody Sun Feb 8 18:43:59 2026 Received: from mail-244123.protonmail.ch (mail-244123.protonmail.ch [109.224.244.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC3312F1FF1 for ; Thu, 15 Jan 2026 19:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504870; cv=none; b=maDu7+tIdUl7fftS4pLMKxb88n+JgD3dJ3k+cjdRatdw7JgMwDuO95QWZo78XlWaUDEWlzIP6PxWrQrGfRwWMA9M9euASH+uhfi+hTM1gyp+x1oc4SIJCewFr3jH8UzUokt6n325GwezmasXBZytFhO7ICo+N+K8Z35VsPq3Vco= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504870; c=relaxed/simple; bh=QsZNlHEoZ0o3k+eO4+9uP0dblXpelHfHww6MTTJU1gQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ti0sq/ebsjVyUxE2ZlAOvcIe5UGaXWzsVvUpwT4ZRq7lxBmQwgdOSvZaKXuH0aasUNbR512PmbdC4oG0LjgQ/g9tfBiHJ5oZ0AmIWYnFegfTOA0/m1exJr5YIt5CRG2sTmy7XowWRtaK57frLl8lVDPxnJd8tmj8dZrxiNx+1+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=hGguYdDr; arc=none smtp.client-ip=109.224.244.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="hGguYdDr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504865; x=1768764065; bh=QsZNlHEoZ0o3k+eO4+9uP0dblXpelHfHww6MTTJU1gQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=hGguYdDrVMbrukwS6gXajSolrG/XKNS937R6wDeRa98DDJy6TABAVmjqIDbo1TJu7 AarqVk/UfsqrEocMyzW7ADSB7ipGfDyXL+NUTviZXb6NOiwdIZApVnZKfayr/0G6B+ 63VY+uZwqrd1ukPWcY7E22an1UiZSgFro13R3MHd8xYdIYDrEFn9ML64NR3TgtYVMk tNmi+OldP05Y/29FxoHrNbzauj4GdliUSxbJtv7WmzB7pG17fhV0iExM2PH5quOoXO AQbG3YhY/lv2Asr0U4e2C4NDJhlwFXZ0CZiImZs5B1J86XD02CjrNog4qZXT/iwy/E KheffjCoYu5gg== Date: Thu, 15 Jan 2026 19:20:59 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 10/12] gpib: ni_usb: Unify *allocate_private Message-ID: <20260115191925.52268-11-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: c2740659e0edd693d0c6865a0b2709af4f0c658b Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/ni_usb/ni_usb_gpib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpib/ni_usb/ni_usb_gpib.c b/drivers/gpib/ni_usb/ni_usb= _gpib.c index 1f8412de9fa3..1fc3ccdebff1 100644 --- a/drivers/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/gpib/ni_usb/ni_usb_gpib.c @@ -1659,11 +1659,10 @@ static int ni_usb_allocate_private(struct gpib_boar= d *board) { struct ni_usb_priv *ni_priv; =20 - board->private_data =3D kmalloc(sizeof(struct ni_usb_priv), GFP_KERNEL); + board->private_data =3D kzalloc(sizeof(struct ni_usb_priv), GFP_KERNEL); if (!board->private_data) return -ENOMEM; ni_priv =3D board->private_data; - memset(ni_priv, 0, sizeof(struct ni_usb_priv)); mutex_init(&ni_priv->bulk_transfer_lock); mutex_init(&ni_priv->control_transfer_lock); mutex_init(&ni_priv->interrupt_transfer_lock); --=20 2.43.0 From nobody Sun Feb 8 18:43:59 2026 Received: from mail-106120.protonmail.ch (mail-106120.protonmail.ch [79.135.106.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69F04285CAD for ; Thu, 15 Jan 2026 19:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.120 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504881; cv=none; b=VZ+W6roxQs8FQyKSUH/hlW2+91Mk8AZY4XQtqU4NyR1Ygx4yrhQ1DtM35OVtBbk/LCqxKJZdI6ho0CkKobu5ohcBOy1tvbI6DMzumnnEg5D42Wwp2qqGC2BcK1MIJhnbBwatoZFxNqFs8m6t4Kssus8gTBb+P7n+n+w70DR/t/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504881; c=relaxed/simple; bh=hCfrS+f8pTonIineyB/oYTMYtgCSrYmGS4kWwXF+Ft4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CMk19wLPSNxSp3hrkWd0vrfk46Wxpd0Fuco8lZMRhe0ogZdhgHBUNty80ILy9h7GiJ/lcVCXsGIG4l0YkQN8sVknj2730i/LER2CvusH4FKxS7fn/Zu7WEL43rE2LkQ++EoPByjlq96z+OiCx+4ymQ/3GC1OqdhW2sfarB6xrOI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=ZnLeKlfq; arc=none smtp.client-ip=79.135.106.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="ZnLeKlfq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504873; x=1768764073; bh=hCfrS+f8pTonIineyB/oYTMYtgCSrYmGS4kWwXF+Ft4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ZnLeKlfqPgE3Jhw5N0HWtb505QcmhUY+n2b7ZNVaoQW8NbTLt9Ib7WJNVfkMu9sS2 c0XRA0mTyU1lJDLWIWCrKCTaZAmHoZeBRu0PDPpZoVnBfM3/VIvrUdKz4zsIlSFUYo vE3mGdIla17cAg/hJDb/dmJlj2gxda7QWo3kh6gvZebQhd4Zi5lrgOA4AzEp0S9OjX VIzOE4vOdU5uaCpZcU0U2sByKP5gI7LFkkYDz5h1hlme0uRkq5Prv8fGaYapELN0u4 Jk3lknocdwiTQ0jZwMmsy9XTUASptu0RiT9sTRKMCJtwghm4oz7ZSof0CfIf19SaYE OVreeqmeI7I8g== Date: Thu, 15 Jan 2026 19:21:06 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 11/12] gpib: pc2: Unify *allocate_private Message-ID: <20260115191925.52268-12-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 8e61838ed015b313a1db2669c1d2f45ed714f6bd Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/pc2/pc2_gpib.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpib/pc2/pc2_gpib.c b/drivers/gpib/pc2/pc2_gpib.c index 9f3943d1df66..11ba9ee1b6f8 100644 --- a/drivers/gpib/pc2/pc2_gpib.c +++ b/drivers/gpib/pc2/pc2_gpib.c @@ -237,11 +237,10 @@ static int allocate_private(struct gpib_board *board) { struct pc2_priv *priv; =20 - board->private_data =3D kmalloc(sizeof(struct pc2_priv), GFP_KERNEL); + board->private_data =3D kzalloc(sizeof(struct pc2_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; priv =3D board->private_data; - memset(priv, 0, sizeof(struct pc2_priv)); init_nec7210_private(&priv->nec7210_priv); return 0; } @@ -257,10 +256,12 @@ static int pc2_generic_attach(struct gpib_board *boar= d, const struct gpib_board_ { struct pc2_priv *pc2_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; - if (allocate_private(board)) - return -ENOMEM; + retval =3D allocate_private(board); + if (retval < 0) + return retval; pc2_priv =3D board->private_data; nec_priv =3D &pc2_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_ioport_read_byte; --=20 2.43.0 From nobody Sun Feb 8 18:43:59 2026 Received: from mail-106118.protonmail.ch (mail-106118.protonmail.ch [79.135.106.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85C8B155C82 for ; Thu, 15 Jan 2026 19:21:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.118 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504888; cv=none; b=IA2h448U+EWuFmtJxQQG6z0X0bfwfcR3TGPOE+bLO4LsXBObM+SykRkoo4Rm4nXxvXEqwlGv11j1L60+C4pzB/Cp/qqoNMaB2a1OrBIntk+l1Khhf8F0ZpshW4brCrH17Bp5wPTK5NQM5OZvPYwkcDFXW1L0lcBW97Dk3UDIt1c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504888; c=relaxed/simple; bh=vV/ABPIoxzepgSZiJOq0f/i6AFJ0I/6t+KH4wWyksVM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jKt3tdhXOkfqvKk8qeLCoJesE19/fj5llWR2KVGyEaNP4sjkvXUWJrfa2cZfv2Tl1DQCdaSrR41uMPItqE+U4qtbAx7G6iCjSCIE48RgDb6qfWntT/b4Fz6xAxherzySh3u0bJ+OKBjBlJjJVTqThqzNJnDpG3XVWtxYoUlPpgg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=M3bjR37U; arc=none smtp.client-ip=79.135.106.118 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="M3bjR37U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504879; x=1768764079; bh=vV/ABPIoxzepgSZiJOq0f/i6AFJ0I/6t+KH4wWyksVM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=M3bjR37U2B0dv5sCv6SnAH73NWgwdufOhnTGBHtWYJ5casu+oE8N6sUeblrW7wgGv lfX4roZxCAQZbZrokwUc013wVcXr23oEMlJq0T5HJ6ouoR3hpNGUV7hKhDVjXQ3pD4 DygV+koaqrvHVYwcDVFKpCUE31+QVDkn9i6ZrMwQh7Ui/9YiLh79DEEnpvg53t/n3A yZOOnlrTp/Ip8bx3fMA9F+bHjNdyKUUGw1cD2/W1MiOq7G7fMizDmRJB0X1tqrWd6I 20VER14lAEUzXLifKhJ74OClMvVNdrTIh3ZgPzW+QgGifl0zPfqLjma5b3gFodRafV 598iKmy3td5nw== Date: Thu, 15 Jan 2026 19:21:13 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 12/12] gpib: tnt4882: Unify *allocate_private Message-ID: <20260115191925.52268-13-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: df15034504298cf2995873973f7ce8b04bc2dd67 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/tnt4882/tnt4882_gpib.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/gpib/tnt4882/tnt4882_gpib.c b/drivers/gpib/tnt4882/tnt= 4882_gpib.c index c03a976b7380..e7e91ba17c2d 100644 --- a/drivers/gpib/tnt4882/tnt4882_gpib.c +++ b/drivers/gpib/tnt4882/tnt4882_gpib.c @@ -843,11 +843,10 @@ static int tnt4882_allocate_private(struct gpib_board= *board) { struct tnt4882_priv *tnt_priv; =20 - board->private_data =3D kmalloc(sizeof(struct tnt4882_priv), GFP_KERNEL); + board->private_data =3D kzalloc(sizeof(struct tnt4882_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; tnt_priv =3D board->private_data; - memset(tnt_priv, 0, sizeof(struct tnt4882_priv)); init_nec7210_private(&tnt_priv->nec7210_priv); return 0; } @@ -916,8 +915,9 @@ static int ni_pci_attach(struct gpib_board *board, cons= t struct gpib_board_confi =20 board->status =3D 0; =20 - if (tnt4882_allocate_private(board)) - return -ENOMEM; + retval =3D tnt4882_allocate_private(board); + if (retval < 0) + return retval; tnt_priv =3D board->private_data; nec_priv =3D &tnt_priv->nec7210_priv; nec_priv->type =3D TNT4882; @@ -1039,8 +1039,9 @@ static int ni_isa_attach_common(struct gpib_board *bo= ard, const struct gpib_boar =20 board->status =3D 0; =20 - if (tnt4882_allocate_private(board)) - return -ENOMEM; + retval =3D tnt4882_allocate_private(board); + if (retval < 0) + return retval; tnt_priv =3D board->private_data; nec_priv =3D &tnt_priv->nec7210_priv; nec_priv->type =3D chipset; @@ -1725,8 +1726,9 @@ static int ni_pcmcia_attach(struct gpib_board *board,= const struct gpib_board_co =20 board->status =3D 0; =20 - if (tnt4882_allocate_private(board)) - return -ENOMEM; + retval =3D tnt4882_allocate_private(board); + if (retval < 0) + return retval; =20 tnt_priv =3D board->private_data; nec_priv =3D &tnt_priv->nec7210_priv; --=20 2.43.0