1. Patchew
  2. linux
  3. [PATCH 0/8] Add Tenstorrent Atlantis Clock/Reset Controller
  4. View patch

[PATCH 4/8] dt-bindings: soc: tenstorrent: Add atlantis resets

Anirudh Srinivasan posted 8 patches 3 weeks, 4 days ago
There is a newer version of this series
[PATCH 4/8] dt-bindings: soc: tenstorrent: Add atlantis resets
Posted by Anirudh Srinivasan 3 weeks, 4 days ago 
Document resets from RCPU syscon for atlantis.

Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
---
 .../tenstorrent/tenstorrent,atlantis-syscon.yaml   |  5 ++++
 .../clock/tenstorrent,atlantis-syscon.h            | 34 ++++++++++++++++++++++
 2 files changed, 39 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
index 3915d78dfeda..7e9c8d85ba9e 100644
--- a/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
+++ b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
@@ -31,11 +31,15 @@ properties:
     description:
       See <dt-bindings/clock/tenstorrent,atlantis-syscon.h> for valid indices.
 
+  "#reset-cells":
+    const: 1
+
 required:
   - compatible
   - reg
   - clocks
   - "#clock-cells"
+  - "#reset-cells"
 
 additionalProperties: false
 
@@ -55,4 +59,5 @@ examples:
       reg = <0x0 0xa8000000 0x0 0x10000>;
       clocks = <&osc_24m>;
       #clock-cells = <1>;
+      #reset-cells = <1>;
     };
diff --git a/include/dt-bindings/clock/tenstorrent,atlantis-syscon.h b/include/dt-bindings/clock/tenstorrent,atlantis-syscon.h
index a8518319642a..ac6afc95b224 100644
--- a/include/dt-bindings/clock/tenstorrent,atlantis-syscon.h
+++ b/include/dt-bindings/clock/tenstorrent,atlantis-syscon.h
@@ -64,4 +64,38 @@
 #define CLK_CAN0_TIMER_CLK 52
 #define CLK_CAN1_TIMER_CLK 53
 
+/* RCPU domain reset */
+#define RST_SMNDMA0  0
+#define RST_SMNDMA1  1
+#define RST_WDT0     2
+#define RST_WDT1     3
+#define RST_TMR      4
+#define RST_PVTC     5
+#define RST_PMU      6
+#define RST_MAILBOX  7
+#define RST_SPACC    8
+#define RST_OTP      9
+#define RST_TRNG     10
+#define RST_CRC      11
+#define RST_QSPI     12
+#define RST_I2C0     13
+#define RST_I2C1     14
+#define RST_I2C2     15
+#define RST_I2C3     16
+#define RST_I2C4     17
+#define RST_UART0    18
+#define RST_UART1    19
+#define RST_UART2    20
+#define RST_UART3    21
+#define RST_UART4    22
+#define RST_SPI0     23
+#define RST_SPI1     24
+#define RST_SPI2     25
+#define RST_SPI3     26
+#define RST_GPIO     27
+#define RST_CAN0     28
+#define RST_CAN1     29
+#define RST_I2S0     30
+#define RST_I2S1     31
+
 #endif /* _DT_BINDINGS_ATLANTIS_SYSCON_H */

-- 
2.43.0
Re: [PATCH 4/8] dt-bindings: soc: tenstorrent: Add atlantis resets
Posted by Krzysztof Kozlowski 3 weeks, 3 days ago 
On Thu, Jan 15, 2026 at 05:42:03PM -0600, Anirudh Srinivasan wrote:
> Document resets from RCPU syscon for atlantis.
> 
> Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
> ---
>  .../tenstorrent/tenstorrent,atlantis-syscon.yaml   |  5 ++++
>  .../clock/tenstorrent,atlantis-syscon.h            | 34 ++++++++++++++++++++++
>  2 files changed, 39 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
> index 3915d78dfeda..7e9c8d85ba9e 100644
> --- a/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
> +++ b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml

There is no such file in linux-next.

> @@ -31,11 +31,15 @@ properties:
>      description:
>        See <dt-bindings/clock/tenstorrent,atlantis-syscon.h> for valid indices.
>  
> +  "#reset-cells":
> +    const: 1
> +
>  required:
>    - compatible
>    - reg
>    - clocks
>    - "#clock-cells"
> +  - "#reset-cells"

Why aren't you posting COMPLETE bindings on first posting? This is now
ABI break for no good reasons - you knew your device has resets.

Best regards,
Krzysztof
Re: [PATCH 4/8] dt-bindings: soc: tenstorrent: Add atlantis resets
Posted by Krzysztof Kozlowski 3 weeks, 3 days ago 
On 16/01/2026 10:02, Krzysztof Kozlowski wrote:
> On Thu, Jan 15, 2026 at 05:42:03PM -0600, Anirudh Srinivasan wrote:
>> Document resets from RCPU syscon for atlantis.
>>
>> Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
>> ---
>>  .../tenstorrent/tenstorrent,atlantis-syscon.yaml   |  5 ++++
>>  .../clock/tenstorrent,atlantis-syscon.h            | 34 ++++++++++++++++++++++
>>  2 files changed, 39 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
>> index 3915d78dfeda..7e9c8d85ba9e 100644
>> --- a/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
>> +++ b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
> 
> There is no such file in linux-next.

Ah, because you just added it in other patch. Then obviously this must
be squashed. Why would you post an incomplete patch and fix it up
immediately?

Please read writing bindings document - it covers this case.

Best regards,
Krzysztof
Re: [PATCH 4/8] dt-bindings: soc: tenstorrent: Add atlantis resets
Posted by Anirudh Srinivasan 3 weeks, 3 days ago 
Hi Krzysztof,

On Fri, Jan 16, 2026 at 3:03 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 16/01/2026 10:02, Krzysztof Kozlowski wrote:
> Ah, because you just added it in other patch. Then obviously this must
> be squashed. Why would you post an incomplete patch and fix it up
> immediately?
>
> Please read writing bindings document - it covers this case.
> Why aren't you posting COMPLETE bindings on first posting? This is now
> ABI break for no good reasons - you knew your device has resets.

I will squash down the commits so that there is just one commit with bindings.
Re: [PATCH 4/8] dt-bindings: soc: tenstorrent: Add atlantis resets
Posted by Krzysztof Kozlowski 3 weeks, 2 days ago 
On 16/01/2026 22:25, Anirudh Srinivasan wrote:
> Hi Krzysztof,
> 
> On Fri, Jan 16, 2026 at 3:03 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 16/01/2026 10:02, Krzysztof Kozlowski wrote:
>> Ah, because you just added it in other patch. Then obviously this must
>> be squashed. Why would you post an incomplete patch and fix it up
>> immediately?
>>
>> Please read writing bindings document - it covers this case.
>> Why aren't you posting COMPLETE bindings on first posting? This is now
>> ABI break for no good reasons - you knew your device has resets.
> 
> I will squash down the commits so that there is just one commit with bindings.

I completely miss what is the context here. What did I reply to? With 50
replies per day I am not tracking what is what here. Provide reasonable
amount of context.

Best regards,
Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.