drivers/phy/qualcomm/phy-qcom-edp.c | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-)
Currently, the LeMans/Monaco DP PHY operates in DP mode rather than eDP
mode. Per the PHY HPG, the Swing and Emphasis settings have been corrected
to the appropriate DP-mode values.
Additionally, the HPG specifies that the LDO value should be set to 0 when
in DP mode. These misconfigurations can lead to link training failures on
certain dongles.
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
---
drivers/phy/qualcomm/phy-qcom-edp.c | 27 ++++++++++++++++++++++++---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
index 13feab99feec..5b0d774bd715 100644
--- a/drivers/phy/qualcomm/phy-qcom-edp.c
+++ b/drivers/phy/qualcomm/phy-qcom-edp.c
@@ -122,6 +122,13 @@ static const u8 dp_swing_hbr_rbr[4][4] = {
{ 0x1f, 0xff, 0xff, 0xff }
};
+static const u8 dp_swing_hbr_rbr_v1[4][4] = {
+ { 0x07, 0x0f, 0x16, 0x1f },
+ { 0x11, 0x1e, 0x1f, 0xff },
+ { 0x16, 0x1f, 0xff, 0xff },
+ { 0x1f, 0xff, 0xff, 0xff }
+};
+
static const u8 dp_pre_emp_hbr_rbr[4][4] = {
{ 0x00, 0x0d, 0x14, 0x1a },
{ 0x00, 0x0e, 0x15, 0xff },
@@ -129,6 +136,13 @@ static const u8 dp_pre_emp_hbr_rbr[4][4] = {
{ 0x03, 0xff, 0xff, 0xff }
};
+static const u8 dp_pre_emp_hbr_rbr_v1[4][4] = {
+ { 0x00, 0x0e, 0x15, 0x1a },
+ { 0x00, 0x0e, 0x15, 0xff },
+ { 0x00, 0x0e, 0xff, 0xff },
+ { 0x04, 0xff, 0xff, 0xff }
+};
+
static const u8 dp_swing_hbr2_hbr3[4][4] = {
{ 0x02, 0x12, 0x16, 0x1a },
{ 0x09, 0x19, 0x1f, 0xff },
@@ -150,6 +164,13 @@ static const struct qcom_edp_swing_pre_emph_cfg dp_phy_swing_pre_emph_cfg = {
.pre_emphasis_hbr3_hbr2 = &dp_pre_emp_hbr2_hbr3,
};
+static const struct qcom_edp_swing_pre_emph_cfg dp_phy_swing_pre_emph_cfg_v1 = {
+ .swing_hbr_rbr = &dp_swing_hbr_rbr_v1,
+ .swing_hbr3_hbr2 = &dp_swing_hbr2_hbr3,
+ .pre_emphasis_hbr_rbr = &dp_pre_emp_hbr_rbr_v1,
+ .pre_emphasis_hbr3_hbr2 = &dp_pre_emp_hbr2_hbr3,
+};
+
static const u8 edp_swing_hbr_rbr[4][4] = {
{ 0x07, 0x0f, 0x16, 0x1f },
{ 0x0d, 0x16, 0x1e, 0xff },
@@ -321,7 +342,7 @@ static int qcom_edp_set_voltages(struct qcom_edp *edp, const struct phy_configur
if (swing == 0xff || emph == 0xff)
return -EINVAL;
- ldo_config = edp->is_edp ? 0x0 : 0x1;
+ ldo_config = !edp->is_edp ? 0x0 : 0x1;
writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG);
writel(swing, edp->tx0 + TXn_TX_DRV_LVL);
@@ -564,7 +585,7 @@ static const struct qcom_edp_phy_cfg sa8775p_dp_phy_cfg = {
.is_edp = false,
.aux_cfg = edp_phy_aux_cfg_v5,
.vco_div_cfg = edp_phy_vco_div_cfg_v4,
- .swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg_v5,
+ .swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg_v1,
.ver_ops = &qcom_edp_phy_ops_v4,
};
@@ -962,7 +983,7 @@ static int qcom_edp_phy_power_on(struct phy *phy)
if (ret)
return ret;
- if (edp->cfg->swing_pre_emph_cfg && !edp->is_edp)
+ if (edp->cfg->swing_pre_emph_cfg && edp->is_edp)
ldo_config = 0x1;
writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG);
---
base-commit: fc4e91c639c0af93d63c3d5bc0ee45515dd7504a
change-id: 20260109-klm_dpphy-8b3a95750f78
Best regards,
--
Yongxing Mou <yongxing.mou@oss.qualcomm.com>On Fri, Jan 09, 2026 at 04:30:21PM +0800, Yongxing Mou wrote: > Currently, the LeMans/Monaco DP PHY operates in DP mode rather than eDP > mode. Per the PHY HPG, the Swing and Emphasis settings have been corrected have been corrected... when? > to the appropriate DP-mode values. > > Additionally, the HPG specifies that the LDO value should be set to 0 when > in DP mode. These misconfigurations can lead to link training failures on > certain dongles. Separate commit > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> Missing Fixes, cc:stable > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 27 ++++++++++++++++++++++++--- > 1 file changed, 24 insertions(+), 3 deletions(-) > -- With best wishes Dmitry
On 1/9/2026 11:27 PM, Dmitry Baryshkov wrote: > On Fri, Jan 09, 2026 at 04:30:21PM +0800, Yongxing Mou wrote: >> Currently, the LeMans/Monaco DP PHY operates in DP mode rather than eDP >> mode. Per the PHY HPG, the Swing and Emphasis settings have been corrected > > have been corrected... when? > sorry, will correct it next patch.>> to the appropriate DP-mode values. >> >> Additionally, the HPG specifies that the LDO value should be set to 0 when >> in DP mode. These misconfigurations can lead to link training failures on >> certain dongles. > > Separate commit > Got it. will update next patch>> >> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> > > Missing Fixes, cc:stable > Ack.>> --- >> drivers/phy/qualcomm/phy-qcom-edp.c | 27 ++++++++++++++++++++++++--- >> 1 file changed, 24 insertions(+), 3 deletions(-) >> >
On 1/9/26 9:30 AM, Yongxing Mou wrote:
> Currently, the LeMans/Monaco DP PHY operates in DP mode rather than eDP
> mode. Per the PHY HPG, the Swing and Emphasis settings have been corrected
> to the appropriate DP-mode values.
>
> Additionally, the HPG specifies that the LDO value should be set to 0 when
> in DP mode. These misconfigurations can lead to link training failures on
> certain dongles.
>
> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> ---
> drivers/phy/qualcomm/phy-qcom-edp.c | 27 ++++++++++++++++++++++++---
> 1 file changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
> index 13feab99feec..5b0d774bd715 100644
> --- a/drivers/phy/qualcomm/phy-qcom-edp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
> @@ -122,6 +122,13 @@ static const u8 dp_swing_hbr_rbr[4][4] = {
> { 0x1f, 0xff, 0xff, 0xff }
> };
>
> +static const u8 dp_swing_hbr_rbr_v1[4][4] = {
> + { 0x07, 0x0f, 0x16, 0x1f },
> + { 0x11, 0x1e, 0x1f, 0xff },
> + { 0x16, 0x1f, 0xff, 0xff },
> + { 0x1f, 0xff, 0xff, 0xff }
> +};
For these platforms, I see 4 tables of settings:
(Low/High) Swing/Pre-em for (Low/High) HBR
None of them exactly match your change
[...]
> - ldo_config = edp->is_edp ? 0x0 : 0x1;
> + ldo_config = !edp->is_edp ? 0x0 : 0x1;
You'll notice that this is further wrong, because for eDP, it should be
0x81 at low-swing-high-HBR and 0xc1 at low-swing-low-HBR, and 0 at both
cases of high-swing
Please split the LDO change into a separate commit because it touches
more platforms
Konrad
On 1/9/2026 5:58 PM, Konrad Dybcio wrote:
> On 1/9/26 9:30 AM, Yongxing Mou wrote:
>> Currently, the LeMans/Monaco DP PHY operates in DP mode rather than eDP
>> mode. Per the PHY HPG, the Swing and Emphasis settings have been corrected
>> to the appropriate DP-mode values.
>>
>> Additionally, the HPG specifies that the LDO value should be set to 0 when
>> in DP mode. These misconfigurations can lead to link training failures on
>> certain dongles.
>>
>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>> ---
>> drivers/phy/qualcomm/phy-qcom-edp.c | 27 ++++++++++++++++++++++++---
>> 1 file changed, 24 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
>> index 13feab99feec..5b0d774bd715 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-edp.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
>> @@ -122,6 +122,13 @@ static const u8 dp_swing_hbr_rbr[4][4] = {
>> { 0x1f, 0xff, 0xff, 0xff }
>> };
>>
>> +static const u8 dp_swing_hbr_rbr_v1[4][4] = {
>> + { 0x07, 0x0f, 0x16, 0x1f },
>> + { 0x11, 0x1e, 0x1f, 0xff },
>> + { 0x16, 0x1f, 0xff, 0xff },
>> + { 0x1f, 0xff, 0xff, 0xff }
>> +};
>
> For these platforms, I see 4 tables of settings:
>
> (Low/High) Swing/Pre-em for (Low/High) HBR
>
> None of them exactly match your change
>
Emm, this table is in LeMans eDP HPG, here are 6 tables. 4 of them use
for eDP mode and reset 2 tables used for DP mode. If my understanding is
incorrect, please correct me. Thanks ~~~ > [...]
>
>> - ldo_config = edp->is_edp ? 0x0 : 0x1;
>> + ldo_config = !edp->is_edp ? 0x0 : 0x1;
>
> You'll notice that this is further wrong, because for eDP, it should be
> 0x81 at low-swing-high-HBR and 0xc1 at low-swing-low-HBR, and 0 at both
> cases of high-swing
>
> Please split the LDO change into a separate commit because it touches
> more platforms
>
> Konrad
>
Yes, you are right, here seems something not correct. i will separate
this change into single one.Here are some parts I don't fully understand
here. Could you please point it? How do we know whether it is in
low‑swing or high‑swing. I didn’t see any logic in the current code that
determines this. Also, the value in Hamoa seems not same with LeMans,it
is 0x51 and 0x91.
While going through the Hamoa HPG, I noticed a potential issue.
static struct qcom_edp_phy_cfg x1e80100_phy_cfg = {
.aux_cfg = edp_phy_aux_cfg_v4,
.vco_div_cfg = edp_phy_vco_div_cfg_v4,
.swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg,...It use
dp_phy_swing_pre_emph_cfg not edp_phy_swing_pre_emph_cfg, but Hamoa
really use edp-panel here.. so does this phy cfg correct here?
On Tue, Jan 13, 2026 at 08:04:06PM +0800, Yongxing Mou wrote:
>
>
> On 1/9/2026 5:58 PM, Konrad Dybcio wrote:
> > On 1/9/26 9:30 AM, Yongxing Mou wrote:
> > > Currently, the LeMans/Monaco DP PHY operates in DP mode rather than eDP
> > > mode. Per the PHY HPG, the Swing and Emphasis settings have been corrected
> > > to the appropriate DP-mode values.
> > >
> > > Additionally, the HPG specifies that the LDO value should be set to 0 when
> > > in DP mode. These misconfigurations can lead to link training failures on
> > > certain dongles.
> > >
> > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> > > ---
> > > drivers/phy/qualcomm/phy-qcom-edp.c | 27 ++++++++++++++++++++++++---
> > > 1 file changed, 24 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
> > > index 13feab99feec..5b0d774bd715 100644
> > > --- a/drivers/phy/qualcomm/phy-qcom-edp.c
> > > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
> > > @@ -122,6 +122,13 @@ static const u8 dp_swing_hbr_rbr[4][4] = {
> > > { 0x1f, 0xff, 0xff, 0xff }
> > > };
> > > +static const u8 dp_swing_hbr_rbr_v1[4][4] = {
> > > + { 0x07, 0x0f, 0x16, 0x1f },
> > > + { 0x11, 0x1e, 0x1f, 0xff },
> > > + { 0x16, 0x1f, 0xff, 0xff },
> > > + { 0x1f, 0xff, 0xff, 0xff }
> > > +};
> >
> > For these platforms, I see 4 tables of settings:
> >
> > (Low/High) Swing/Pre-em for (Low/High) HBR
> >
> > None of them exactly match your change
> >
> Emm, this table is in LeMans eDP HPG, here are 6 tables. 4 of them use for
> eDP mode and reset 2 tables used for DP mode. If my understanding is
> incorrect, please correct me. Thanks ~~~ > [...]
> >
> > > - ldo_config = edp->is_edp ? 0x0 : 0x1;
> > > + ldo_config = !edp->is_edp ? 0x0 : 0x1;
> >
> > You'll notice that this is further wrong, because for eDP, it should be
> > 0x81 at low-swing-high-HBR and 0xc1 at low-swing-low-HBR, and 0 at both
> > cases of high-swing
> >
> > Please split the LDO change into a separate commit because it touches
> > more platforms
> >
> > Konrad
> >
>
> Yes, you are right, here seems something not correct. i will separate this
> change into single one.Here are some parts I don't fully understand here.
> Could you please point it? How do we know whether it is in low‑swing or
> high‑swing. I didn’t see any logic in the current code that determines this.
> Also, the value in Hamoa seems not same with LeMans,it is 0x51 and 0x91.
>
> While going through the Hamoa HPG, I noticed a potential issue.
>
> static struct qcom_edp_phy_cfg x1e80100_phy_cfg = {
> .aux_cfg = edp_phy_aux_cfg_v4,
> .vco_div_cfg = edp_phy_vco_div_cfg_v4,
> .swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg,...It use
> dp_phy_swing_pre_emph_cfg not edp_phy_swing_pre_emph_cfg, but Hamoa really
> use edp-panel here.. so does this phy cfg correct here?
All PHYs should support eDP and DP modes, so most of the configuration
tables need to be updated/fixed. I tried going through all the tables,
but I never had time to do it in a sane and complete way. As you started
looking into it, would you please review programming for all chipsets
starting from SC8180X?
--
With best wishes
Dmitry
On 1/14/2026 2:55 AM, Dmitry Baryshkov wrote:
> On Tue, Jan 13, 2026 at 08:04:06PM +0800, Yongxing Mou wrote:
>>
>>
>> On 1/9/2026 5:58 PM, Konrad Dybcio wrote:
>>> On 1/9/26 9:30 AM, Yongxing Mou wrote:
>>>> Currently, the LeMans/Monaco DP PHY operates in DP mode rather than eDP
>>>> mode. Per the PHY HPG, the Swing and Emphasis settings have been corrected
>>>> to the appropriate DP-mode values.
>>>>
>>>> Additionally, the HPG specifies that the LDO value should be set to 0 when
>>>> in DP mode. These misconfigurations can lead to link training failures on
>>>> certain dongles.
>>>>
>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>> ---
>>>> drivers/phy/qualcomm/phy-qcom-edp.c | 27 ++++++++++++++++++++++++---
>>>> 1 file changed, 24 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
>>>> index 13feab99feec..5b0d774bd715 100644
>>>> --- a/drivers/phy/qualcomm/phy-qcom-edp.c
>>>> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
>>>> @@ -122,6 +122,13 @@ static const u8 dp_swing_hbr_rbr[4][4] = {
>>>> { 0x1f, 0xff, 0xff, 0xff }
>>>> };
>>>> +static const u8 dp_swing_hbr_rbr_v1[4][4] = {
>>>> + { 0x07, 0x0f, 0x16, 0x1f },
>>>> + { 0x11, 0x1e, 0x1f, 0xff },
>>>> + { 0x16, 0x1f, 0xff, 0xff },
>>>> + { 0x1f, 0xff, 0xff, 0xff }
>>>> +};
>>>
>>> For these platforms, I see 4 tables of settings:
>>>
>>> (Low/High) Swing/Pre-em for (Low/High) HBR
>>>
>>> None of them exactly match your change
>>>
>> Emm, this table is in LeMans eDP HPG, here are 6 tables. 4 of them use for
>> eDP mode and reset 2 tables used for DP mode. If my understanding is
>> incorrect, please correct me. Thanks ~~~ > [...]
>>>
>>>> - ldo_config = edp->is_edp ? 0x0 : 0x1;
>>>> + ldo_config = !edp->is_edp ? 0x0 : 0x1;
>>>
>>> You'll notice that this is further wrong, because for eDP, it should be
>>> 0x81 at low-swing-high-HBR and 0xc1 at low-swing-low-HBR, and 0 at both
>>> cases of high-swing
>>>
>>> Please split the LDO change into a separate commit because it touches
>>> more platforms
>>>
>>> Konrad
>>>
>>
>> Yes, you are right, here seems something not correct. i will separate this
>> change into single one.Here are some parts I don't fully understand here.
>> Could you please point it? How do we know whether it is in low‑swing or
>> high‑swing. I didn’t see any logic in the current code that determines this.
>> Also, the value in Hamoa seems not same with LeMans,it is 0x51 and 0x91.
>>
>> While going through the Hamoa HPG, I noticed a potential issue.
>>
>> static struct qcom_edp_phy_cfg x1e80100_phy_cfg = {
>> .aux_cfg = edp_phy_aux_cfg_v4,
>> .vco_div_cfg = edp_phy_vco_div_cfg_v4,
>> .swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg,...It use
>> dp_phy_swing_pre_emph_cfg not edp_phy_swing_pre_emph_cfg, but Hamoa really
>> use edp-panel here.. so does this phy cfg correct here?
>
> All PHYs should support eDP and DP modes, so most of the configuration
> tables need to be updated/fixed. I tried going through all the tables,
> but I never had time to do it in a sane and complete way. As you started
> looking into it, would you please review programming for all chipsets
> starting from SC8180X?
>
I don't got the SC8180X PHY HPG permission now. once i got it, will
check it's configuration and see what i can do. But first i want to
correct the LeMans and Hamoa configuration and post the LDO change. Do
you mean switching between the eDP and DP mode tables based on is_edp,
instead of using a fixed table?
On Fri, Jan 16, 2026 at 04:18:43PM +0800, Yongxing Mou wrote:
>
>
> On 1/14/2026 2:55 AM, Dmitry Baryshkov wrote:
> > On Tue, Jan 13, 2026 at 08:04:06PM +0800, Yongxing Mou wrote:
> > >
> > >
> > > On 1/9/2026 5:58 PM, Konrad Dybcio wrote:
> > > > On 1/9/26 9:30 AM, Yongxing Mou wrote:
> > > > > Currently, the LeMans/Monaco DP PHY operates in DP mode rather than eDP
> > > > > mode. Per the PHY HPG, the Swing and Emphasis settings have been corrected
> > > > > to the appropriate DP-mode values.
> > > > >
> > > > > Additionally, the HPG specifies that the LDO value should be set to 0 when
> > > > > in DP mode. These misconfigurations can lead to link training failures on
> > > > > certain dongles.
> > > > >
> > > > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> > > > > ---
> > > > > drivers/phy/qualcomm/phy-qcom-edp.c | 27 ++++++++++++++++++++++++---
> > > > > 1 file changed, 24 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
> > > > > index 13feab99feec..5b0d774bd715 100644
> > > > > --- a/drivers/phy/qualcomm/phy-qcom-edp.c
> > > > > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
> > > > > @@ -122,6 +122,13 @@ static const u8 dp_swing_hbr_rbr[4][4] = {
> > > > > { 0x1f, 0xff, 0xff, 0xff }
> > > > > };
> > > > > +static const u8 dp_swing_hbr_rbr_v1[4][4] = {
> > > > > + { 0x07, 0x0f, 0x16, 0x1f },
> > > > > + { 0x11, 0x1e, 0x1f, 0xff },
> > > > > + { 0x16, 0x1f, 0xff, 0xff },
> > > > > + { 0x1f, 0xff, 0xff, 0xff }
> > > > > +};
> > > >
> > > > For these platforms, I see 4 tables of settings:
> > > >
> > > > (Low/High) Swing/Pre-em for (Low/High) HBR
> > > >
> > > > None of them exactly match your change
> > > >
> > > Emm, this table is in LeMans eDP HPG, here are 6 tables. 4 of them use for
> > > eDP mode and reset 2 tables used for DP mode. If my understanding is
> > > incorrect, please correct me. Thanks ~~~ > [...]
> > > >
> > > > > - ldo_config = edp->is_edp ? 0x0 : 0x1;
> > > > > + ldo_config = !edp->is_edp ? 0x0 : 0x1;
> > > >
> > > > You'll notice that this is further wrong, because for eDP, it should be
> > > > 0x81 at low-swing-high-HBR and 0xc1 at low-swing-low-HBR, and 0 at both
> > > > cases of high-swing
> > > >
> > > > Please split the LDO change into a separate commit because it touches
> > > > more platforms
> > > >
> > > > Konrad
> > > >
> > >
> > > Yes, you are right, here seems something not correct. i will separate this
> > > change into single one.Here are some parts I don't fully understand here.
> > > Could you please point it? How do we know whether it is in low‑swing or
> > > high‑swing. I didn’t see any logic in the current code that determines this.
> > > Also, the value in Hamoa seems not same with LeMans,it is 0x51 and 0x91.
> > >
> > > While going through the Hamoa HPG, I noticed a potential issue.
> > >
> > > static struct qcom_edp_phy_cfg x1e80100_phy_cfg = {
> > > .aux_cfg = edp_phy_aux_cfg_v4,
> > > .vco_div_cfg = edp_phy_vco_div_cfg_v4,
> > > .swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg,...It use
> > > dp_phy_swing_pre_emph_cfg not edp_phy_swing_pre_emph_cfg, but Hamoa really
> > > use edp-panel here.. so does this phy cfg correct here?
> >
> > All PHYs should support eDP and DP modes, so most of the configuration
> > tables need to be updated/fixed. I tried going through all the tables,
> > but I never had time to do it in a sane and complete way. As you started
> > looking into it, would you please review programming for all chipsets
> > starting from SC8180X?
> >
> I don't got the SC8180X PHY HPG permission now. once i got it, will check
> it's configuration and see what i can do. But first i want to correct the
> LeMans and Hamoa configuration and post the LDO change. Do you mean
> switching between the eDP and DP mode tables based on is_edp, instead of
> using a fixed table?
Based on the PHY being used in the eDP or DP modes (it is related but
not equivalent to the is_edp).
--
With best wishes
Dmitry
On 26-01-09 16:30:21, Yongxing Mou wrote: > Currently, the LeMans/Monaco DP PHY operates in DP mode rather than eDP > mode. Per the PHY HPG, the Swing and Emphasis settings have been corrected > to the appropriate DP-mode values. > > Additionally, the HPG specifies that the LDO value should be set to 0 when > in DP mode. These misconfigurations can lead to link training failures on > certain dongles. > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
© 2016 - 2026 Red Hat, Inc.