From nobody Sun Feb 8 19:49:04 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED7E7320A0C for ; Fri, 9 Jan 2026 08:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767947434; cv=none; b=BL3owmjNeTEiMzA3qeqWnLr8dgiK72TIKawiWYAEqlJcEeKenvXFNt/qxk9km/nUcOrZAiImW3wTGOUZ+/+NMSxQY0wmfarLKg5w268pWZfU8Gy8bhrVOj8asK6ipZ4cvo8G1nWvbo4VrijpE7rZqOShXMJrBO2N8Ss1h92kRpI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767947434; c=relaxed/simple; bh=47ICDv/i8JfnrPPrWxcQsA8JfO1i9z1ltS6R54IEzVw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=TTE2HlbwF06tb177+2GytyFNvjSTUK0yviVhqZ6zQTctbA93T72+PYQU95egLeEHd0AcOHXysts0Z7fJusvObme6fFJov2mzePRL0hO2raNJ3DPMC0BVcP/bfxDTc4L8jkViwanPmM/rYUtZRGT7j7ilEK3tYcevF2v0ubiMG3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BwDLoawG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IzZ+8SK9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BwDLoawG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IzZ+8SK9" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60958hje2765479 for ; Fri, 9 Jan 2026 08:30:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=50+/gJ+IsXhBIpPLZMUP5y jPLB3bzvhy9frEyPnkqvY=; b=BwDLoawGDpW3Ret0vQYeleAZmT8Bm1Ra/hr2F6 S6PhC+Zk2a1rd+wa4ZPN4zcfDuNHqxJkeJJQgQW4JdMu+eiIC0dDPw9v4i7x9DkW Wpt0t2wWDFEt0MgK8wkx42ForSzBn6eOAP73ER1TlGFbKeEmWs4Okt0NOdsDb8Yj OsGCFPSME6it8G9KH9CVmg8nBaTEC8jhPRSLniIn7Fcwfsl7oEuNkFJm3JlF//Ak t9FCUfSULZTgJigl5lP3pZP/gkVNBwMxFAX2UjeRNj+8tyyvEecPmzsQMBbvRrxB sFD/u4qB7jr8VWRPhcmNNhDhor5cb3mpjmBm3oBu6VUhwICw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bjfejtm26-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Jan 2026 08:30:28 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-888825e6423so85252946d6.3 for ; Fri, 09 Jan 2026 00:30:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767947428; x=1768552228; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=50+/gJ+IsXhBIpPLZMUP5yjPLB3bzvhy9frEyPnkqvY=; b=IzZ+8SK9NOnfDpWZXQxA0buSODG9J+gjVzHbMgMQYXlR4NpciSEzsUHCWvQZsmD3ax G/nPvYbrMxhVplISL+xZcHfFimBz2wfpiMROTjQP3Uv/58HKztGTvomtwYtvtXkFVVM5 wXKyvwHsNZWgRQ0a9X7E4WjO/n280epYBBJFZJsgI14FxJ4xrS18CCvXJB43qNXyaRpe XrT2bJtq09hJhMb2IwXxo6zc0VJCO+gWt4UAYtOv7svQnojLb3LbNObGawN+ab0p2B2B ItoDph1JKGvu4UjwTY2LGE0k+aZklWOLiCtdk01qs4pGRJjNrUR6tjEpQcqrjeHhGfZ+ w/kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767947428; x=1768552228; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=50+/gJ+IsXhBIpPLZMUP5yjPLB3bzvhy9frEyPnkqvY=; b=oM6xmTIKhlWn1ZjI3iONU3eV37l9gdgAehxDy04y1jIaOqARAH6FABboQ1FgRYaCh4 4IIxpac+1PxzgUW/1hHAqE6P7/lQsjYSyl9jx8j7FfTEco33qR8fD7ssnQMK8Z1ayru4 iGjxN88tCZoe+v+ZtI6mUIAEeBuwpwwenDg6/VXh+P+DwsseVlx7u1kIoiEGR7Tj2jxV W6CUh2jPFu2H6XD/xkbh06cpYiWzzPvSsRuWVEdH/vJcHSG2NTvz5CbgIL1CdrKYfnGS 7YNetH4swk9mow62CDOndAvgeLG9FrHHTkc4OjL+NVuC3oCgInapgWv8K03epDXF6+dR F0mA== X-Forwarded-Encrypted: i=1; AJvYcCWWBynPJHoqRiYv23TNnJT/m3t7/AXuSc7Qi5q2fPJoRk4HoVkgknVbOuvLw8c1PVNYepJW/iK2N9//q0A=@vger.kernel.org X-Gm-Message-State: AOJu0YyHEcIZxhK8uiExvVktEmb8NmMKb8suui2DHo5JSmaVh4/8bclw qC7bGJspssdl2e9pRS8Rv4vAp1qvnYQW0kd/XC3r1ugwR49t3f9pXrememHX7FDwruxe2TwpJcm OQdvKWpSd0oaul+kSQnac0ICgG7Yhnch9scn65LVVuvxzxfTuVFhHBQhfB3GHt8guXs0= X-Gm-Gg: AY/fxX7IK8CK6SPC1OuPGQ/v1sHp7JrNNxcaCdma0VBz6FzYAFyGQdK8YpQVp8EGmCC 8Z28Z6GZ0s3af+LVHzbLWZa9PsKikbd8pVPvbS1lwhaLWDJIktcG7J/R9Mo/tyNQSQhCc8MOda3 jp+eQC4499imJ7+dHeset2LtFNQE/96sWRR7w7drOHMYfpCVkJ9QxuyreVJ3ZpXiTrUNqnVmsdM WFeaCHghXnz8nocB2lYo8wq92ar2wp5ADelJeOIZZpRyK+rnoo1r80D5bLUePeqWv3l6amnJvE8 5tSnynAJ6lrWGU5iosEGR+jwFv3gKstZdPTU/b/V2JVfGyvGiyfD3L7oLphbyONcv6n4qXocO5r buWBOtiU9ihrag7lxn5OZazjDMUxWNG1EYh4t1wLbIe6W49/KDFLZdylfylJ4sD4cmYEKyAk= X-Received: by 2002:a05:6214:3b83:b0:882:6d84:ebc3 with SMTP id 6a1803df08f44-89084271257mr132321736d6.34.1767947428256; Fri, 09 Jan 2026 00:30:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHqUkiOM/ii1556fLzkZFoM3udxFOUEW7nNFOAw+6Mm6KQoc2unZuy3WSVioTa2744hFenJzg== X-Received: by 2002:a05:6214:3b83:b0:882:6d84:ebc3 with SMTP id 6a1803df08f44-89084271257mr132321416d6.34.1767947427725; Fri, 09 Jan 2026 00:30:27 -0800 (PST) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-890770ce298sm70573926d6.8.2026.01.09.00.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jan 2026 00:30:27 -0800 (PST) From: Yongxing Mou Date: Fri, 09 Jan 2026 16:30:21 +0800 Subject: [PATCH] drm/msm/dp: Correct LeMans/Monaco DP phy Swing/Emphasis setting Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260109-klm_dpphy-v1-1-a6b6abe382de@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAJy8YGkC/yXM4QqDIBSG4VuJ83uCZlZ2KxHDjsclW+W0jY3o3 ifr5/vx8eyQKHpK0BU7RHr75Nclh7gUgJNZbsS8zQ0lL2suuGb3x3y1IUxf1o7SaNUo7poW8j9 Ecv7zt/rh7EjPVya3c4TRJGK4zrPfusJhRVpgLTVy47S0tURp1YicqFJKKGuzXRkYjuMHxSbvj acAAAA= X-Change-ID: 20260109-klm_dpphy-8b3a95750f78 To: Vinod Koul , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1767947425; l=3230; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=47ICDv/i8JfnrPPrWxcQsA8JfO1i9z1ltS6R54IEzVw=; b=RYICtqFVglOkYQB/eS59jM7kqnvciulHlc6ribtwEnbWnBHhu4+D9D9NLdIp/Y785NqgdaIXA eGf43a9Plw3AN/9B3ZD0+TPYq8oWbKjaX7ldA93OyspSUZY6fEwYay7 X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-ORIG-GUID: 1yMukNiRSAOy4JgkdsASKH24ytwWJ-yJ X-Proofpoint-GUID: 1yMukNiRSAOy4JgkdsASKH24ytwWJ-yJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA5MDA1OSBTYWx0ZWRfX3A+ZKEuL2Gpx DDUfnytdU0K+MSeenaYkrUjx9EX20V1ryASsc+9pixp/6wtsxF29bF3DU/Bjemhugt7RMnpqiTy mkUyCAk7DIb5GrS+kK1QBkfEdtxQdmI9OLf9DMKegFSfWgd+ZoTQ3BDNK6Sil33X2JbFGWXp53Q dnKHBdI+cuGMpa6GZJeYECfj3gqj34dNnp0gDq6klMDd5AltGTeV/yTLymvQmdH297ON7bTC3e9 3lnaisY83qyKm8viLM+E4vM4tvFMnKcj8S8Mv9vye0Ij7bPiItIXlZLFT6zom4TXEU4Tek3zunc O8LC1seDNttNipKzSx+LX7r4P5c/QP9QOwfnT0FyhQMqVbHomVc6fFOLEOtArzTJl/tqNLiv/OQ aFOEKelKItbKswy/5i/0mUTIZNjE373aonYtedflh+tpqB4cKuMPZqi+sZchydYpetDdSbnTP5/ zh6IqIbWdlih/uzGZ7A== X-Authority-Analysis: v=2.4 cv=ZfAQ98VA c=1 sm=1 tr=0 ts=6960bca4 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=pSICJWmwak5-Gv9eA8IA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-09_02,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601090059 Currently, the LeMans/Monaco DP PHY operates in DP mode rather than eDP mode. Per the PHY HPG, the Swing and Emphasis settings have been corrected to the appropriate DP-mode values. Additionally, the HPG specifies that the LDO value should be set to 0 when in DP mode. These misconfigurations can lead to link training failures on certain dongles. Signed-off-by: Yongxing Mou Reviewed-by: Abel Vesa --- drivers/phy/qualcomm/phy-qcom-edp.c | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy= -qcom-edp.c index 13feab99feec..5b0d774bd715 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -122,6 +122,13 @@ static const u8 dp_swing_hbr_rbr[4][4] =3D { { 0x1f, 0xff, 0xff, 0xff } }; =20 +static const u8 dp_swing_hbr_rbr_v1[4][4] =3D { + { 0x07, 0x0f, 0x16, 0x1f }, + { 0x11, 0x1e, 0x1f, 0xff }, + { 0x16, 0x1f, 0xff, 0xff }, + { 0x1f, 0xff, 0xff, 0xff } +}; + static const u8 dp_pre_emp_hbr_rbr[4][4] =3D { { 0x00, 0x0d, 0x14, 0x1a }, { 0x00, 0x0e, 0x15, 0xff }, @@ -129,6 +136,13 @@ static const u8 dp_pre_emp_hbr_rbr[4][4] =3D { { 0x03, 0xff, 0xff, 0xff } }; =20 +static const u8 dp_pre_emp_hbr_rbr_v1[4][4] =3D { + { 0x00, 0x0e, 0x15, 0x1a }, + { 0x00, 0x0e, 0x15, 0xff }, + { 0x00, 0x0e, 0xff, 0xff }, + { 0x04, 0xff, 0xff, 0xff } +}; + static const u8 dp_swing_hbr2_hbr3[4][4] =3D { { 0x02, 0x12, 0x16, 0x1a }, { 0x09, 0x19, 0x1f, 0xff }, @@ -150,6 +164,13 @@ static const struct qcom_edp_swing_pre_emph_cfg dp_phy= _swing_pre_emph_cfg =3D { .pre_emphasis_hbr3_hbr2 =3D &dp_pre_emp_hbr2_hbr3, }; =20 +static const struct qcom_edp_swing_pre_emph_cfg dp_phy_swing_pre_emph_cfg_= v1 =3D { + .swing_hbr_rbr =3D &dp_swing_hbr_rbr_v1, + .swing_hbr3_hbr2 =3D &dp_swing_hbr2_hbr3, + .pre_emphasis_hbr_rbr =3D &dp_pre_emp_hbr_rbr_v1, + .pre_emphasis_hbr3_hbr2 =3D &dp_pre_emp_hbr2_hbr3, +}; + static const u8 edp_swing_hbr_rbr[4][4] =3D { { 0x07, 0x0f, 0x16, 0x1f }, { 0x0d, 0x16, 0x1e, 0xff }, @@ -321,7 +342,7 @@ static int qcom_edp_set_voltages(struct qcom_edp *edp, = const struct phy_configur if (swing =3D=3D 0xff || emph =3D=3D 0xff) return -EINVAL; =20 - ldo_config =3D edp->is_edp ? 0x0 : 0x1; + ldo_config =3D !edp->is_edp ? 0x0 : 0x1; =20 writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG); writel(swing, edp->tx0 + TXn_TX_DRV_LVL); @@ -564,7 +585,7 @@ static const struct qcom_edp_phy_cfg sa8775p_dp_phy_cfg= =3D { .is_edp =3D false, .aux_cfg =3D edp_phy_aux_cfg_v5, .vco_div_cfg =3D edp_phy_vco_div_cfg_v4, - .swing_pre_emph_cfg =3D &edp_phy_swing_pre_emph_cfg_v5, + .swing_pre_emph_cfg =3D &dp_phy_swing_pre_emph_cfg_v1, .ver_ops =3D &qcom_edp_phy_ops_v4, }; =20 @@ -962,7 +983,7 @@ static int qcom_edp_phy_power_on(struct phy *phy) if (ret) return ret; =20 - if (edp->cfg->swing_pre_emph_cfg && !edp->is_edp) + if (edp->cfg->swing_pre_emph_cfg && edp->is_edp) ldo_config =3D 0x1; =20 writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG); --- base-commit: fc4e91c639c0af93d63c3d5bc0ee45515dd7504a change-id: 20260109-klm_dpphy-8b3a95750f78 Best regards, --=20 Yongxing Mou