[v2] staging: rtl8723bs: fix error handling and memory leaks

[PATCH v2 0/3] staging: rtl8723bs: fix error handling and memory leaks

Samasth Norway Ananda posted 3 patches 1 month ago

Diff against v3
Download series mbox

There is a newer version of this series

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ++++
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 +++-
2 files changed, 7 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH v2 0/3] staging: rtl8723bs: fix error handling and memory leaks

Posted by Samasth Norway Ananda 1 month ago

This series fixes memory leaks and missing error checks in rtl8723bs:

1. Firmware not released on error paths in rtl8723b_FirmwareDownload().
2. Buffer not freed when cfg80211_inform_bss_frame() fails.
3. Missing IS_ERR() check for kthread_run() in rtl8723b_start_thread().

Changes in v2:
-> Patch 1: Call release_firmware() directly in error paths instead of
using intermediate goto label.
-> Dropped patch 4 (rtw_wdev_alloc) to study cleanup chain further.

Samasth Norway Ananda (3):
  staging: rtl8723bs: fix firmware memory leak on error
  staging: rtl8723bs: fix memory leak in rtw_cfg80211_inform_bss()
  staging: rtl8723bs: add IS_ERR() check for kthread_run()

 drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ++++
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)

-- 
2.50.1